Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add persistent storage for the example ACL implementation. (# 12814)" #13200

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

This reverts commit 381fc55 because
that code was never reviewed and clearly wasn't tested either (it's
comparing TLV::Tag values to tag numbers, which can't possibly work).

Problem

See #12814 (comment)

Change overview

Revert #12814

…roject-chip#12814)"

This reverts commit 381fc55 because
that code was never reviewed and clearly wasn't tested either (it's
comparing TLV::Tag values to tag numbers, which can't possibly work).
@github-actions
Copy link

github-actions bot commented Dec 22, 2021

PR #13200: Size comparison from f9ce4be to 2c4689d

Decreases (4 builds for esp32, mbed, p6)
platform target config section f9ce4be 2c4689d change % change
esp32 all-clusters-app c3devkit (read only) 884820 882510 -2310 -0.3
(read/write) 1312466 1312458 -8 -0.0
.flash.rodata 176088 176080 -8 -0.0
.flash.text 884820 882510 -2310 -0.3
m5stack (read only) 945571 942907 -2664 -0.3
(read/write) 441592 441576 -16 -0.0
.flash.rodata 202920 202904 -16 -0.0
.flash.text 940187 937523 -2664 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2341320 2338848 -2472 -0.1
.data 5280 5272 -8 -0.2
.text 1303896 1301424 -2472 -0.2
p6 all-clusters-app default (read/write) 2393848 2390968 -2880 -0.1
.text 1352112 1349232 -2880 -0.2
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f9ce4be 2c4689d change % change
efr32 lighting-app BRD4161A (read only) 829152 829152 0 0.0
(read/write) 127104 127104 0 0.0
.bss 125224 125224 0 0.0
.data 1876 1876 0 0.0
.text 829144 829144 0 0.0
BRD4161A+rpc (read only) 816796 816796 0 0.0
(read/write) 143768 143768 0 0.0
.bss 141792 141792 0 0.0
.data 1976 1976 0 0.0
.text 816788 816788 0 0.0
window-app BRD4161A (read only) 802616 802616 0 0.0
(read/write) 126040 126040 0 0.0
.bss 124208 124208 0 0.0
.data 1832 1832 0 0.0
.text 802608 802608 0 0.0
esp32 all-clusters-app c3devkit (read only) 884820 882510 -2310 -0.3
(read/write) 1312466 1312458 -8 -0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 176088 176080 -8 -0.0
.flash.text 884820 882510 -2310 -0.3
.iram0.text 62254 62254 0 0.0
m5stack (read only) 945571 942907 -2664 -0.3
(read/write) 441592 441576 -16 -0.0
.dram0.bss 73608 73608 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202920 202904 -16 -0.0
.flash.text 940187 937523 -2664 -0.3
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647512 647512 0 0.0
.bss 76232 76232 0 0.0
.data 1904 1904 0 0.0
.text 563576 563576 0 0.0
lock k32w061+release (read/write) 632224 632224 0 0.0
.bss 75944 75944 0 0.0
.data 1860 1860 0 0.0
.text 548620 548620 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6999268 6999268 0 0.0
(read/write) 325953 325953 0 0.0
.bss 54305 54305 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210128 210128 0 0.0
.dynamic 560 560 0 0.0
.got 56728 56728 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384220 384220 0 0.0
.text 5921604 5921604 0 0.0
thermostat-no-ble arm64 (read only) 2013428 2013428 0 0.0
(read/write) 144033 144033 0 0.0
.bss 64065 64065 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72272 72272 0 0.0
.dynamic 560 560 0 0.0
.got 3888 3888 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128820 128820 0 0.0
.text 1672016 1672016 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341320 2338848 -2472 -0.1
.bss 188380 188380 0 0.0
.data 5280 5272 -8 -0.2
.text 1303896 1301424 -2472 -0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329120 2329120 0 0.0
.bss 180656 180656 0 0.0
.data 5552 5552 0 0.0
.text 1291720 1291720 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302152 2302152 0 0.0
.bss 179704 179704 0 0.0
.data 5544 5544 0 0.0
.text 1264752 1264752 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053840 2053840 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016440 1016440 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 934663 934663 0 0.0
bss 118148 118148 0 0.0
rodata 107908 107908 0 0.0
text 631024 631024 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921015 921015 0 0.0
bss 115192 115192 0 0.0
rodata 101324 101324 0 0.0
text 626336 626336 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858394 858394 0 0.0
bss 116432 116432 0 0.0
rodata 102832 102832 0 0.0
text 558468 558468 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 906775 906775 0 0.0
bss 117336 117336 0 0.0
rodata 103212 103212 0 0.0
text 608852 608852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830690 830690 0 0.0
bss 115648 115648 0 0.0
rodata 98176 98176 0 0.0
text 536332 536332 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908071 908071 0 0.0
bss 117096 117096 0 0.0
rodata 103428 103428 0 0.0
text 610088 610088 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 904887 904887 0 0.0
bss 117124 117124 0 0.0
rodata 102684 102684 0 0.0
text 607600 607600 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2393848 2390968 -2880 -0.1
.bss 116580 116580 0 0.0
.data 2552 2552 0 0.0
.text 1352112 1349232 -2880 -0.2
light-app default (read/write) 2323808 2323808 0 0.0
.bss 105904 105904 0 0.0
.data 2384 2384 0 0.0
.text 1282072 1282072 0 0.0
lock-app default (read/write) 2296032 2296032 0 0.0
.bss 104784 104784 0 0.0
.data 2336 2336 0 0.0
.text 1254296 1254296 0 0.0
qpg lighting-app qpg6105+debug (read only) 531120 531120 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86704 86704 0 0.0
.data 1004 1004 0 0.0
.text 525800 525800 0 0.0
lock-app qpg6105+debug (read only) 502812 502812 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85840 85840 0 0.0
.data 952 952 0 0.0
.text 497492 497492 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 830770 830770 0 0.0
bss 86808 86808 0 0.0
noinit 37160 37160 0 0.0
text 579380 579380 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit feb07d5 into project-chip:master Dec 22, 2021
@bzbarsky-apple bzbarsky-apple deleted the revert-acl-storage-bits branch December 22, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants