-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add persistent storage for the example ACL implementation. (# 12814)" #13200
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:revert-acl-storage-bits
Dec 22, 2021
Merged
Revert "Add persistent storage for the example ACL implementation. (# 12814)" #13200
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:revert-acl-storage-bits
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject-chip#12814)" This reverts commit 381fc55 because that code was never reviewed and clearly wasn't tested either (it's comparing TLV::Tag values to tag numbers, which can't possibly work).
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt and
pan-apple
December 22, 2021 03:50
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
December 22, 2021 03:50
PR #13200: Size comparison from f9ce4be to 2c4689d Decreases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
saurabhst
approved these changes
Dec 22, 2021
kpschoedel
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 381fc55 because
that code was never reviewed and clearly wasn't tested either (it's
comparing TLV::Tag values to tag numbers, which can't possibly work).
Problem
See #12814 (comment)
Change overview
Revert #12814