Remove GroupKeyCodec. #13179
Merged
Remove GroupKeyCodec. #13179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed; all that code already exists in Structs::GroupKey. The XML change is to fix a compile issue due to the type being wrong, but pretty much all the XML is wrong there. project-chip#13176 tracks addressing that.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #13179: Size comparison from bf7feea to e2d02e5 Increases (8 builds for esp32, linux, mbed, p6, telink)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
saurabhst
approved these changes
Dec 28, 2021
andy31415
approved these changes
Jan 4, 2022
Resolved conflict in src/app/clusters/group-key-mgmt-server/group-key-mgmt-server.cpp by running zap regen.
|
PR #13179: Size comparison from b006321 to 64efb1a Increases (8 builds for esp32, linux, mbed, p6, telink)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Remove GroupKeyCodec. It's not needed; all that code already exists in Structs::GroupKey. The XML change is to fix a compile issue due to the type being wrong, but pretty much all the XML is wrong there. project-chip#13176 tracks addressing that. * Remove GroupKeyCodec again - apparently the conflict file was not zap generated Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed; all that code already exists in Structs::GroupKey.
The XML change is to fix a compile issue due to the type being wrong,
but pretty much all the XML is wrong there.
#13176 tracks
addressing that.
Problem
Extra code we don't need.
Change overview
Remove it.
Testing
No behavior changes. Just less code.