Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zephyr] Added support for few GeneralDiagnostics attributes #13160

Merged
merged 1 commit into from
Dec 22, 2021
Merged

[zephyr] Added support for few GeneralDiagnostics attributes #13160

merged 1 commit into from
Dec 22, 2021

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Platform doesn't support a few optional attributes and also
mandatory BootReason event.

Change overview

  • Added support for attributes: UpTime, TotalOperationalHours
  • Added support for event: BootReason

Testing

Performed manual testing with nrfconnect lock example and Python CHIP controller

@restyled-io restyled-io bot mentioned this pull request Dec 20, 2021
Closed
@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_optional_features_pr branch from b3c57b8 to 7c69901 Compare December 20, 2021 14:09
@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_optional_features_pr branch from 7c69901 to 3b16dd5 Compare December 20, 2021 14:33
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #13160: Size comparison from 3a28cd7 to 3b16dd5

Increases (10 builds for nrfconnect, telink)
platform target config section 3a28cd7 3b16dd5 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935999 936623 624 0.1
bss 118408 118480 72 0.1
rodata 108124 108236 112 0.1
text 631884 632336 452 0.1
nrf52840dk_nrf52840+rpc (read/write) 922351 923011 660 0.1
bss 115452 115524 72 0.1
rodata 101540 101656 116 0.1
text 627196 627648 452 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859714 860358 644 0.1
bss 116692 116764 72 0.1
rodata 103048 103164 116 0.1
text 559324 559780 456 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908095 908771 676 0.1
bss 117596 117668 72 0.1
rodata 103428 103544 116 0.1
text 609708 610164 456 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832058 832686 628 0.1
bss 115908 115980 72 0.1
rodata 98392 98508 116 0.1
text 537192 537644 452 0.1
pump-app nrf52840dk_nrf52840 (read/write) 909391 910035 644 0.1
bss 117356 117428 72 0.1
rodata 103644 103760 116 0.1
text 610948 611400 452 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906207 906851 644 0.1
bss 117384 117456 72 0.1
rodata 102900 103016 116 0.1
text 608456 608912 456 0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796755 676 0.1
bss 109464 109536 72 0.1
rodata 78096 78212 116 0.1
text 532048 532548 500 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 708710 709386 676 0.1
bss 107352 107424 72 0.1
rodata 72396 72512 116 0.2
text 449544 450044 500 0.1
telink lighting-app tlsr9518adk80d (read/write) 832258 833042 784 0.1
bss 87064 87136 72 0.1
text 580384 580984 600 0.1
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a28cd7 3b16dd5 change % change
efr32 lighting-app BRD4161A (read only) 830408 830408 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830400 830400 0 0.0
BRD4161A+rpc (read only) 818052 818052 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818044 818044 0 0.0
window-app BRD4161A (read only) 803784 803784 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803776 803776 0 0.0
k32w light k32w061+release (read/write) 648740 648740 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633456 633456 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979164 6979164 0 0.0
(read/write) 325633 325633 0 0.0
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 209704 0 0.0
.dynamic 560 560 0 0.0
.got 56536 56536 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 383732 0 0.0
.text 5903540 5903540 0 0.0
thermostat-no-ble arm64 (read only) 2002756 2002756 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1662736 1662736 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337664 2337664 0 0.0
.bss 188580 188580 0 0.0
.data 5264 5264 0 0.0
.text 1300240 1300240 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2330568 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293168 1293168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2303664 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266264 1266264 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935999 936623 624 0.1
bss 118408 118480 72 0.1
rodata 108124 108236 112 0.1
text 631884 632336 452 0.1
nrf52840dk_nrf52840+rpc (read/write) 922351 923011 660 0.1
bss 115452 115524 72 0.1
rodata 101540 101656 116 0.1
text 627196 627648 452 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859714 860358 644 0.1
bss 116692 116764 72 0.1
rodata 103048 103164 116 0.1
text 559324 559780 456 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908095 908771 676 0.1
bss 117596 117668 72 0.1
rodata 103428 103544 116 0.1
text 609708 610164 456 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832058 832686 628 0.1
bss 115908 115980 72 0.1
rodata 98392 98508 116 0.1
text 537192 537644 452 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909391 910035 644 0.1
bss 117356 117428 72 0.1
rodata 103644 103760 116 0.1
text 610948 611400 452 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906207 906851 644 0.1
bss 117384 117456 72 0.1
rodata 102900 103016 116 0.1
text 608456 608912 456 0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796755 676 0.1
bss 109464 109536 72 0.1
rodata 78096 78212 116 0.1
text 532048 532548 500 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 708710 709386 676 0.1
bss 107352 107424 72 0.1
rodata 72396 72512 116 0.2
text 449544 450044 500 0.1
p6 all-clusters-app default (read/write) 2389080 2389080 0 0.0
.bss 116780 116780 0 0.0
.data 2544 2544 0 0.0
.text 1347344 1347344 0 0.0
light-app default (read/write) 2324944 2324944 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283208 1283208 0 0.0
lock-app default (read/write) 2297152 2297152 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255416 1255416 0 0.0
qpg lighting-app qpg6105+debug (read only) 532240 532240 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 526920 526920 0 0.0
lock-app qpg6105+debug (read only) 503904 503904 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498584 498584 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 833042 784 0.1
bss 87064 87136 72 0.1
noinit 37160 37160 0 0.0
text 580384 580984 600 0.1

@kkasperczyk-no
[zephyr] Added support for few GeneralDiagnostics attributes
384faad 
Platform doesn't support a few optional attributes and also
mandatory BootReason event.

* Added support for attributes: UpTime, TotalOperationalHours
* Added support for event: BootReason
@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_optional_features_pr branch from 3b16dd5 to 384faad Compare December 21, 2021 07:09
@github-actions
Copy link

github-actions bot commented Dec 21, 2021 •
edited
Loading

PR #13160: Size comparison from bf7feea to 384faad

Increases (10 builds for nrfconnect, telink)
platform target config section bf7feea 384faad change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 936703 736 0.1
bss 118428 118500 72 0.1
rodata 108124 108236 112 0.1
text 631864 632380 516 0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 923059 692 0.1
bss 115472 115544 72 0.1
rodata 101540 101656 116 0.1
text 627176 627692 516 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 860422 692 0.1
bss 116712 116784 72 0.1
rodata 103048 103164 116 0.1
text 559308 559820 512 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908111 908803 692 0.1
bss 117616 117688 72 0.1
rodata 103428 103544 116 0.1
text 609692 610204 512 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 832734 692 0.1
bss 115928 116000 72 0.1
rodata 98392 98508 116 0.1
text 537172 537688 516 0.1
pump-app nrf52840dk_nrf52840 (read/write) 909375 910099 724 0.1
bss 117376 117448 72 0.1
rodata 103644 103760 116 0.1
text 610928 611444 516 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 906915 724 0.1
bss 117404 117476 72 0.1
rodata 102900 103016 116 0.1
text 608440 608952 512 0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796819 740 0.1
bss 109464 109536 72 0.1
rodata 78096 78212 116 0.1
text 532048 532608 560 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 708710 709450 740 0.1
bss 107352 107424 72 0.1
rodata 72396 72512 116 0.2
text 449544 450104 560 0.1
telink lighting-app tlsr9518adk80d (read/write) 832258 833090 832 0.1
bss 87088 87160 72 0.1
text 580366 581000 634 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bf7feea 384faad change % change
efr32 lighting-app BRD4161A (read only) 830568 830568 0 0.0
(read/write) 127384 127384 0 0.0
.bss 125504 125504 0 0.0
.data 1876 1876 0 0.0
.text 830560 830560 0 0.0
BRD4161A+rpc (read only) 818196 818196 0 0.0
(read/write) 144048 144048 0 0.0
.bss 142072 142072 0 0.0
.data 1976 1976 0 0.0
.text 818188 818188 0 0.0
window-app BRD4161A (read only) 803944 803944 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124488 124488 0 0.0
.data 1832 1832 0 0.0
.text 803936 803936 0 0.0
esp32 all-clusters-app c3devkit (read only) 883166 883166 0 0.0
(read/write) 1312986 1312986 0 0.0
.dram0.bss 69384 69384 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 176320 176320 0 0.0
.flash.text 883166 883166 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943435 943435 0 0.0
(read/write) 442080 442080 0 0.0
.dram0.bss 73888 73888 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 203128 203128 0 0.0
.flash.text 938051 938051 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648764 648764 0 0.0
.bss 76512 76512 0 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633472 633472 0 0.0
.bss 76224 76224 0 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7006076 7006076 0 0.0
(read/write) 326289 326289 0 0.0
.bss 54641 54641 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210144 210144 0 0.0
.dynamic 560 560 0 0.0
.got 56712 56712 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384228 0 0.0
.text 5928548 5928548 0 0.0
thermostat-no-ble arm64 (read only) 2017908 2017908 0 0.0
(read/write) 144497 144497 0 0.0
.bss 64417 64417 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72376 72376 0 0.0
.dynamic 560 560 0 0.0
.got 3888 3888 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128932 128932 0 0.0
.text 1676304 1676304 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340104 2340104 0 0.0
.bss 188660 188660 0 0.0
.data 5272 5272 0 0.0
.text 1302680 1302680 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330576 2330576 0 0.0
.bss 180936 180936 0 0.0
.data 5552 5552 0 0.0
.text 1293176 1293176 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303672 2303672 0 0.0
.bss 179984 179984 0 0.0
.data 5544 5544 0 0.0
.text 1266272 1266272 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 936703 736 0.1
bss 118428 118500 72 0.1
rodata 108124 108236 112 0.1
text 631864 632380 516 0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 923059 692 0.1
bss 115472 115544 72 0.1
rodata 101540 101656 116 0.1
text 627176 627692 516 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 860422 692 0.1
bss 116712 116784 72 0.1
rodata 103048 103164 116 0.1
text 559308 559820 512 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908111 908803 692 0.1
bss 117616 117688 72 0.1
rodata 103428 103544 116 0.1
text 609692 610204 512 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 832734 692 0.1
bss 115928 116000 72 0.1
rodata 98392 98508 116 0.1
text 537172 537688 516 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 910099 724 0.1
bss 117376 117448 72 0.1
rodata 103644 103760 116 0.1
text 610928 611444 516 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 906915 724 0.1
bss 117404 117476 72 0.1
rodata 102900 103016 116 0.1
text 608440 608952 512 0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796819 740 0.1
bss 109464 109536 72 0.1
rodata 78096 78212 116 0.1
text 532048 532608 560 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 708710 709450 740 0.1
bss 107352 107424 72 0.1
rodata 72396 72512 116 0.2
text 449544 450104 560 0.1
p6 all-clusters-app default (read/write) 2392056 2392056 0 0.0
.bss 116860 116860 0 0.0
.data 2552 2552 0 0.0
.text 1350320 1350320 0 0.0
light-app default (read/write) 2325104 2325104 0 0.0
.bss 106184 106184 0 0.0
.data 2384 2384 0 0.0
.text 1283368 1283368 0 0.0
lock-app default (read/write) 2297312 2297312 0 0.0
.bss 105064 105064 0 0.0
.data 2336 2336 0 0.0
.text 1255576 1255576 0 0.0
qpg lighting-app qpg6105+debug (read only) 532232 532232 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86840 86840 0 0.0
.data 1004 1004 0 0.0
.text 526912 526912 0 0.0
lock-app qpg6105+debug (read only) 503912 503912 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85976 85976 0 0.0
.data 952 952 0 0.0
.text 498592 498592 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 833090 832 0.1
bss 87088 87160 72 0.1
noinit 37160 37160 0 0.0
text 580366 581000 634 0.1

@kkasperczyk-no
Copy link
Contributor Author

Adding fast-track label, as change is only about adding support for few attributes for a specific platform. No generic changes done.

@Damian-Nordic Damian-Nordic merged commit 1798b15 into project-chip:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
config fast track platform review - pending zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkasperczyk-no @bzbarsky-apple @Damian-Nordic