-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app:Add missing on-off commands for all-clusters-app #13155
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
wqx6:external-onoff-commands-all-clusters-app
Dec 20, 2021
Merged
app:Add missing on-off commands for all-clusters-app #13155
bzbarsky-apple
merged 1 commit into
project-chip:master
from
wqx6:external-onoff-commands-all-clusters-app
Dec 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
pan-apple
December 20, 2021 11:05
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
December 20, 2021 11:05
wqx6
force-pushed
the
external-onoff-commands-all-clusters-app
branch
from
December 20, 2021 11:06
7f36435
to
5d6b629
Compare
wqx6
changed the title
app:Add external on-off commands for all-clusters-app
app:Add missing on-off commands for all-clusters-app
Dec 20, 2021
gjc13
approved these changes
Dec 20, 2021
dhrishi
approved these changes
Dec 20, 2021
/rebase |
bzbarsky-apple
approved these changes
Dec 20, 2021
woody-apple
force-pushed
the
external-onoff-commands-all-clusters-app
branch
from
December 20, 2021 18:10
5d6b629
to
d4ff535
Compare
PR #13155: Size comparison from 569e7cc to d4ff535 Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some missing on-off commands need to be added for all-clusters-app. It should be tested in Test Events.
Change overview
Add missing on-off commands in all-clusters-app's zap file
Testing
Test with ESP32C3, the commands is supported now.