-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Change LwIP upstream in p6_sdk to a temporary mirror URL, fix cirque bootstrap failure #13154
Merged
kpschoedel
merged 2 commits into
project-chip:master
from
erjiaqing:hotfix-change-lwip-upstream
Dec 20, 2021
Merged
[hotfix] Change LwIP upstream in p6_sdk to a temporary mirror URL, fix cirque bootstrap failure #13154
kpschoedel
merged 2 commits into
project-chip:master
from
erjiaqing:hotfix-change-lwip-upstream
Dec 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
December 20, 2021 10:44
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
December 20, 2021 10:44
PR #13154: Size comparison from 6a08b04 to ed3739d Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
erjiaqing
force-pushed
the
hotfix-change-lwip-upstream
branch
from
December 20, 2021 12:31
515e417
to
cc5fc78
Compare
erjiaqing
changed the title
[hotfix] Change LwIP upstream in p6_sdk to a temporary mirror URL
[hotfix] Change LwIP upstream in p6_sdk to a temporary mirror URL, fix cirque bootstrap failure
Dec 20, 2021
PR #13154: Size comparison from 6a08b04 to cc5fc78 Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LwIP official repo is down for a few hours, temporarily change the url to a non-official mirror to avoid blocking CI.
PLEASE REVERT ed3739d IN THIS PR IF LWIP REPO IS BACK ONLINE
Other thoughts: can we use a symlink to third_party/lwip/repo/lwip instead of git submodule?