[Group] Implement UDPEndPoint for OpenThread (to enable multicast) #13127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
jelderton,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda and
lzgrablic02
jepenven-silabs
force-pushed
the
ot_udpEndpoint
branch
from
ca253e7 to
b21a465
Compare
|
PR #13127: Size comparison from 462dd77 to b21a465 Increases (25 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (28 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jepenven-silabs
force-pushed
the
ot_udpEndpoint
branch
from
b21a465 to
ae78315
Compare
|
PR #13127: Size comparison from 440c0b1 to 675ae5b Increases (26 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for efr32)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jepenven-silabs
force-pushed
the
ot_udpEndpoint
branch
2 times, most recently
from
bd52815 to
5802d32
Compare
|
PR #13127: Size comparison from 939ca0b to 5802d32 Increases (26 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for efr32)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #13127: Size comparison from 939ca0b to c4c8749 Increases (14 builds for efr32, k32w, mbed, p6, qpg)
Full report (16 builds for efr32, k32w, mbed, p6, qpg)
|
|
I still suggest to modify the lwIP netif driver like this: static err_t openthread_netif_multicast_handler(struct netif *netif,
const ip6_addr_t *group, enum netif_mac_filter_action action)
{
otError error = OT_ERROR_NONE;
otIp6Address multicast_addr;
memcpy(multicast_addr.mFields.m8, group->addr, sizeof(group->addr));
esp_openthread_lock_acquire(portMAX_DELAY);
if (action == NETIF_ADD_MAC_FILTER) {
error = otIp6SubscribeMulticastAddress(esp_openthread_get_instance(), &multicast_addr);
} else {
error = otIp6UnsubscribeMulticastAddress(esp_openthread_get_instance(), &multicast_addr);
}
esp_openthread_lock_release();
switch (error) {
case OT_ERROR_NONE:
case OT_ERROR_ALREADY:
return ERR_OK;
case OT_ERROR_NO_BUFS:
return ERR_MEM;
case OT_ERROR_INVALID_ARGS:
return ERR_ARG;
default:
return ERR_IF;
}
}
// In lwIP netif initialization:
netif->mld_mac_filter = openthread_netif_multicast_handler;The code snippet will sychornize all the lwIP multicast groups to OpenThread. Then we just need to use socket interface |
andy31415
reviewed
Jan 10, 2022
@gjc13 This code seems to defeat the purpose of this PR since it still use LwIP on top of Openthread. Feel free to implement it in another PR, but the main goal here was to de-couple LwIP from OpenThread. Not only for Multicast but in general. Your suggestion is relevant since I don't believe that all platform will use this implementation of UDPEndpoint for OpenThread. But it should be in a different PR, just like the modification required for Multicast using the UDPEndpoint socket implementation. |
jepenven-silabs
force-pushed
the
ot_udpEndpoint
branch
from
ee2d590 to
268aaf4
Compare
andy31415
approved these changes
Jan 10, 2022
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread_LwIP.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jan 10, 2022
|
PR #13127: Size comparison from 5053f20 to 268aaf4 Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 10, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…roject-chip#13127) * Add OT UDPEnPointImpl to enable multicast listening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Partial Fix of #12200
Fix #13126
Partial Fix of #13085
Change overview
Ipv6 subscription for group multicast address wasn't available for OpenThread platform.
Implementing it with the current setup wasn't possible since it would have duplicated the whole IPV6 multicast logic. On top of duplicating the logic, it also caused a lot of error and incompatibility between OpenThread and LwIP.
The solution for now is to use an OpenThread implementation of
UDPEndpointwhich can then use directly the OT multicast api as discussed with @kpschoedel.However, since TCP is not yet supported in OT, we still need to have LWIP on top of OT. This results in a weird buffer situation as can be seen inside the
handleUdpReceivefunction in UDPEndPointImplOt.cppTesting
This feature was tested with the EFR32 platform. It was able to do all previous functionality on top of receiving Multicast payload generated with the
TestGroupMessagingyaml test case.