Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application-managed ReadClient objects #13108

Merged
merged 8 commits into from
Dec 22, 2021
Merged

Application-managed ReadClient objects #13108

merged 8 commits into from
Dec 22, 2021

Conversation

mrjerryjohns
Copy link
Contributor

This 2/N PRs to heap-ify key IM pool-based objects.

This commit heap-ifies the ReadClient object. Specifically, it achieves this indirectly by doing away with the pool-allocated scheme entirely and letting applications control the instantiation and lifetime of the
ReadClient object.

Tests:

  • REPL Reads
  • Unit-tests

@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13108: Size comparison from d24eff1 to 688162f

Increases (1 build for linux)
platform target config section d24eff1 688162f change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 6987588 10040 0.1
.got 56504 56512 8 0.0
.text 5902212 5912484 10272 0.2
Decreases (7 builds for k32w, linux, qpg, telink)
platform target config section d24eff1 688162f change % change
k32w light k32w061+release (read/write) 648852 647496 -1356 -0.2
.bss 76488 76208 -280 -0.4
.text 564660 563584 -1076 -0.2
lock k32w061+release (read/write) 633568 632216 -1352 -0.2
.bss 76208 75928 -280 -0.4
.text 549700 548628 -1072 -0.2
linux chip-tool-ipv6only arm64 (read/write) 325601 325185 -416 -0.1
.bss 54593 54241 -352 -0.6
.data.rel.ro 209704 209632 -72 -0.0
.rodata 383540 383404 -136 -0.0
thermostat-no-ble arm64 (read only) 2006052 2000308 -5744 -0.3
(read/write) 144065 143537 -528 -0.4
.bss 64353 64017 -336 -0.5
.data.rel.ro 72088 71912 -176 -0.2
.got 3840 3832 -8 -0.2
.rodata 128356 128148 -208 -0.2
.text 1666032 1660816 -5216 -0.3
qpg lighting-app qpg6105+debug (read only) 532352 531136 -1216 -0.2
.bss 86824 86688 -136 -0.2
.text 527032 525816 -1216 -0.2
lock-app qpg6105+debug (read only) 504016 502812 -1204 -0.2
.bss 85960 85824 -136 -0.2
.text 498696 497492 -1204 -0.2
telink lighting-app tlsr9518adk80d (read/write) 832370 830686 -1684 -0.2
bss 87064 86784 -280 -0.3
text 580500 579352 -1148 -0.2
Full report (8 builds for k32w, linux, qpg, telink)
platform target config section d24eff1 688162f change % change
k32w light k32w061+release (read/write) 648852 647496 -1356 -0.2
.bss 76488 76208 -280 -0.4
.data 1904 1904 0 0.0
.text 564660 563584 -1076 -0.2
lock k32w061+release (read/write) 633568 632216 -1352 -0.2
.bss 76208 75928 -280 -0.4
.data 1860 1860 0 0.0
.text 549700 548628 -1072 -0.2
linux chip-tool-ipv6only arm64 (read only) 6977548 6987588 10040 0.1
(read/write) 325601 325185 -416 -0.1
.bss 54593 54241 -352 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 209704 209632 -72 -0.0
.dynamic 560 560 0 0.0
.got 56504 56512 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 383404 -136 -0.0
.text 5902212 5912484 10272 0.2
thermostat-no-ble arm64 (read only) 2006052 2000308 -5744 -0.3
(read/write) 144065 143537 -528 -0.4
.bss 64353 64017 -336 -0.5
.data 880 880 0 0.0
.data.rel.ro 72088 71912 -176 -0.2
.dynamic 560 560 0 0.0
.got 3840 3832 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128148 -208 -0.2
.text 1666032 1660816 -5216 -0.3
qpg lighting-app qpg6105+debug (read only) 532352 531136 -1216 -0.2
(read/write) 146936 146936 0 0.0
.bss 86824 86688 -136 -0.2
.data 1004 1004 0 0.0
.text 527032 525816 -1216 -0.2
lock-app qpg6105+debug (read only) 504016 502812 -1204 -0.2
(read/write) 146940 146940 0 0.0
.bss 85960 85824 -136 -0.2
.data 952 952 0 0.0
.text 498696 497492 -1204 -0.2
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 830686 -1684 -0.2
bss 87064 86784 -280 -0.3
noinit 37160 37160 0 0.0
text 580500 579352 -1148 -0.2

@mrjerryjohns
Heap-ify ReadClient
6624609 
This 2/N PRs to heap-ify key IM pool-based objects.

This commit heap-ifies the ReadClient object. Specifically, it achieves
this indirectly by doing away with the pool-allocated scheme entirely
and letting applications control the instantiation and lifetime of the
ReadClient object.

Tests:
- REPL Reads
- Unit-tests
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13108: Size comparison from d24eff1 to 6624609

Increases (1 build for linux)
platform target config section d24eff1 6624609 change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 6987588 10040 0.1
.got 56504 56512 8 0.0
.text 5902212 5912484 10272 0.2
Decreases (14 builds for k32w, linux, nrfconnect, qpg, telink)
platform target config section d24eff1 6624609 change % change
k32w light k32w061+release (read/write) 648852 647496 -1356 -0.2
.bss 76488 76208 -280 -0.4
.text 564660 563584 -1076 -0.2
lock k32w061+release (read/write) 633568 632216 -1352 -0.2
.bss 76208 75928 -280 -0.4
.text 549700 548628 -1072 -0.2
linux chip-tool-ipv6only arm64 (read/write) 325601 325185 -416 -0.1
.bss 54593 54241 -352 -0.6
.data.rel.ro 209704 209632 -72 -0.0
.rodata 383540 383404 -136 -0.0
thermostat-no-ble arm64 (read only) 2006052 2000308 -5744 -0.3
(read/write) 144065 143537 -528 -0.4
.bss 64353 64017 -336 -0.5
.data.rel.ro 72088 71912 -176 -0.2
.got 3840 3832 -8 -0.2
.rodata 128356 128148 -208 -0.2
.text 1666032 1660816 -5216 -0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 934635 -1476 -0.2
bss 118408 118128 -280 -0.2
rodata 108124 107880 -244 -0.2
text 632008 631056 -952 -0.2
nrf52840dk_nrf52840+rpc (read/write) 922479 921019 -1460 -0.2
bss 115452 115172 -280 -0.2
rodata 101540 101296 -244 -0.2
text 627320 626368 -952 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 859842 858366 -1476 -0.2
bss 116692 116412 -280 -0.2
rodata 103048 102804 -244 -0.2
text 559452 558500 -952 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908223 906779 -1444 -0.2
bss 117596 117316 -280 -0.2
rodata 103428 103184 -244 -0.2
text 609836 608884 -952 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 832186 830694 -1492 -0.2
bss 115908 115628 -280 -0.2
rodata 98392 98148 -244 -0.2
text 537316 536364 -952 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 909519 908043 -1476 -0.2
bss 117356 117076 -280 -0.2
rodata 103644 103400 -244 -0.2
text 611072 610120 -952 -0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 904859 -1476 -0.2
bss 117384 117104 -280 -0.2
rodata 102900 102656 -244 -0.2
text 608584 607632 -952 -0.2
qpg lighting-app qpg6105+debug (read only) 532352 531136 -1216 -0.2
.bss 86824 86688 -136 -0.2
.text 527032 525816 -1216 -0.2
lock-app qpg6105+debug (read only) 504016 502812 -1204 -0.2
.bss 85960 85824 -136 -0.2
.text 498696 497492 -1204 -0.2
telink lighting-app tlsr9518adk80d (read/write) 832370 830686 -1684 -0.2
bss 87064 86784 -280 -0.3
text 580500 579352 -1148 -0.2
Full report (18 builds for k32w, linux, nrfconnect, qpg, telink)
platform target config section d24eff1 6624609 change % change
k32w light k32w061+release (read/write) 648852 647496 -1356 -0.2
.bss 76488 76208 -280 -0.4
.data 1904 1904 0 0.0
.text 564660 563584 -1076 -0.2
lock k32w061+release (read/write) 633568 632216 -1352 -0.2
.bss 76208 75928 -280 -0.4
.data 1860 1860 0 0.0
.text 549700 548628 -1072 -0.2
linux chip-tool-ipv6only arm64 (read only) 6977548 6987588 10040 0.1
(read/write) 325601 325185 -416 -0.1
.bss 54593 54241 -352 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 209704 209632 -72 -0.0
.dynamic 560 560 0 0.0
.got 56504 56512 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 383404 -136 -0.0
.text 5902212 5912484 10272 0.2
thermostat-no-ble arm64 (read only) 2006052 2000308 -5744 -0.3
(read/write) 144065 143537 -528 -0.4
.bss 64353 64017 -336 -0.5
.data 880 880 0 0.0
.data.rel.ro 72088 71912 -176 -0.2
.dynamic 560 560 0 0.0
.got 3840 3832 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128148 -208 -0.2
.text 1666032 1660816 -5216 -0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 934635 -1476 -0.2
bss 118408 118128 -280 -0.2
rodata 108124 107880 -244 -0.2
text 632008 631056 -952 -0.2
nrf52840dk_nrf52840+rpc (read/write) 922479 921019 -1460 -0.2
bss 115452 115172 -280 -0.2
rodata 101540 101296 -244 -0.2
text 627320 626368 -952 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 859842 858366 -1476 -0.2
bss 116692 116412 -280 -0.2
rodata 103048 102804 -244 -0.2
text 559452 558500 -952 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908223 906779 -1444 -0.2
bss 117596 117316 -280 -0.2
rodata 103428 103184 -244 -0.2
text 609836 608884 -952 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 832186 830694 -1492 -0.2
bss 115908 115628 -280 -0.2
rodata 98392 98148 -244 -0.2
text 537316 536364 -952 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909519 908043 -1476 -0.2
bss 117356 117076 -280 -0.2
rodata 103644 103400 -244 -0.2
text 611072 610120 -952 -0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 904859 -1476 -0.2
bss 117384 117104 -280 -0.2
rodata 102900 102656 -244 -0.2
text 608584 607632 -952 -0.2
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 531136 -1216 -0.2
(read/write) 146936 146936 0 0.0
.bss 86824 86688 -136 -0.2
.data 1004 1004 0 0.0
.text 527032 525816 -1216 -0.2
lock-app qpg6105+debug (read only) 504016 502812 -1204 -0.2
(read/write) 146940 146940 0 0.0
.bss 85960 85824 -136 -0.2
.data 952 952 0 0.0
.text 498696 497492 -1204 -0.2
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 830686 -1684 -0.2
bss 87064 86784 -280 -0.3
noinit 37160 37160 0 0.0
text 580500 579352 -1148 -0.2

bzbarsky-apple
bzbarsky-apple requested changes Dec 18, 2021
View reviewed changes
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
src/app/InteractionModelEngine.h Outdated Show resolved Hide resolved
src/app/ReadClient.cpp Outdated Show resolved Hide resolved
src/app/ReadClient.cpp Show resolved Hide resolved
src/app/ReadClient.cpp Show resolved Hide resolved
src/app/ReadClient.h Outdated Show resolved Hide resolved
src/controller/ReadInteraction.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDevice.mm Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDevice.mm Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google mentioned this pull request Dec 19, 2021
Merged
@restyled-io restyled-io bot mentioned this pull request Dec 20, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #13108: Size comparison from d354008 to 55dd826

Increases (1 build for linux)
platform target config section d354008 55dd826 change % change
linux chip-tool-ipv6only arm64 .got 56696 56704 8 0.0
Decreases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d354008 55dd826 change % change
efr32 lighting-app BRD4161A (read only) 830568 829160 -1408 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.text 830560 829152 -1408 -0.2
BRD4161A+rpc (read only) 818212 816804 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.text 818204 816796 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.text 803936 802528 -1408 -0.2
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7005564 6997524 -8040 -0.1
(read/write) 326241 325857 -384 -0.1
.bss 54609 54257 -352 -0.6
.data.rel.ro 210144 210096 -48 -0.0
.rodata 384228 384188 -40 -0.0
.text 5928084 5920100 -7984 -0.1
thermostat-no-ble arm64 (read only) 2002916 1997764 -5152 -0.3
(read/write) 144081 143569 -512 -0.4
.bss 64369 64033 -336 -0.5
.data.rel.ro 72088 71928 -160 -0.2
.got 3840 3832 -8 -0.2
.rodata 128356 128244 -112 -0.1
.text 1662896 1658128 -4768 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338232 2336704 -1528 -0.1
.bss 188596 188316 -280 -0.1
.text 1300808 1299280 -1528 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330568 2329032 -1536 -0.1
.bss 180936 180656 -280 -0.2
.text 1293168 1291632 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2303664 2302064 -1600 -0.1
.bss 179984 179704 -280 -0.2
.text 1266264 1264664 -1600 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 934663 -1304 -0.1
bss 118428 118148 -280 -0.2
rodata 108124 107908 -216 -0.2
text 631864 631024 -840 -0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 921015 -1352 -0.1
bss 115472 115192 -280 -0.2
rodata 101540 101324 -216 -0.2
text 627176 626336 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 858394 -1336 -0.2
bss 116712 116432 -280 -0.2
rodata 103048 102832 -216 -0.2
text 559308 558468 -840 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908111 906775 -1336 -0.1
bss 117616 117336 -280 -0.2
rodata 103428 103212 -216 -0.2
text 609692 608852 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 830690 -1352 -0.2
bss 115928 115648 -280 -0.2
rodata 98392 98176 -216 -0.2
text 537172 536332 -840 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 909375 908071 -1304 -0.1
bss 117376 117096 -280 -0.2
rodata 103644 103428 -216 -0.2
text 610928 610088 -840 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 904887 -1304 -0.1
bss 117404 117124 -280 -0.2
rodata 102900 102684 -216 -0.2
text 608440 607600 -840 -0.1
p6 all-clusters-app default (read/write) 2390096 2388704 -1392 -0.1
.bss 116804 116524 -280 -0.2
.text 1348360 1346968 -1392 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532248 531136 -1112 -0.2
.bss 86840 86704 -136 -0.2
.text 526928 525816 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
.bss 85976 85840 -136 -0.2
.text 498592 497492 -1100 -0.2
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
text 580366 579380 -986 -0.2
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d354008 55dd826 change % change
efr32 lighting-app BRD4161A (read only) 830568 829160 -1408 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.data 1876 1876 0 0.0
.text 830560 829152 -1408 -0.2
BRD4161A+rpc (read only) 818212 816804 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.data 1976 1976 0 0.0
.text 818204 816796 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.data 1832 1832 0 0.0
.text 803936 802528 -1408 -0.2
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.data 1904 1904 0 0.0
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.data 1860 1860 0 0.0
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7005564 6997524 -8040 -0.1
(read/write) 326241 325857 -384 -0.1
.bss 54609 54257 -352 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 210144 210096 -48 -0.0
.dynamic 560 560 0 0.0
.got 56696 56704 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384188 -40 -0.0
.text 5928084 5920100 -7984 -0.1
thermostat-no-ble arm64 (read only) 2002916 1997764 -5152 -0.3
(read/write) 144081 143569 -512 -0.4
.bss 64369 64033 -336 -0.5
.data 880 880 0 0.0
.data.rel.ro 72088 71928 -160 -0.2
.dynamic 560 560 0 0.0
.got 3840 3832 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128244 -112 -0.1
.text 1662896 1658128 -4768 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338232 2336704 -1528 -0.1
.bss 188596 188316 -280 -0.1
.data 5272 5272 0 0.0
.text 1300808 1299280 -1528 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2329032 -1536 -0.1
.bss 180936 180656 -280 -0.2
.data 5552 5552 0 0.0
.text 1293168 1291632 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2302064 -1600 -0.1
.bss 179984 179704 -280 -0.2
.data 5544 5544 0 0.0
.text 1266264 1264664 -1600 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 934663 -1304 -0.1
bss 118428 118148 -280 -0.2
rodata 108124 107908 -216 -0.2
text 631864 631024 -840 -0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 921015 -1352 -0.1
bss 115472 115192 -280 -0.2
rodata 101540 101324 -216 -0.2
text 627176 626336 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 858394 -1336 -0.2
bss 116712 116432 -280 -0.2
rodata 103048 102832 -216 -0.2
text 559308 558468 -840 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908111 906775 -1336 -0.1
bss 117616 117336 -280 -0.2
rodata 103428 103212 -216 -0.2
text 609692 608852 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 830690 -1352 -0.2
bss 115928 115648 -280 -0.2
rodata 98392 98176 -216 -0.2
text 537172 536332 -840 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 908071 -1304 -0.1
bss 117376 117096 -280 -0.2
rodata 103644 103428 -216 -0.2
text 610928 610088 -840 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 904887 -1304 -0.1
bss 117404 117124 -280 -0.2
rodata 102900 102684 -216 -0.2
text 608440 607600 -840 -0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2390096 2388704 -1392 -0.1
.bss 116804 116524 -280 -0.2
.data 2552 2552 0 0.0
.text 1348360 1346968 -1392 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.data 2384 2384 0 0.0
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.data 2336 2336 0 0.0
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532248 531136 -1112 -0.2
(read/write) 146936 146936 0 0.0
.bss 86840 86704 -136 -0.2
.data 1004 1004 0 0.0
.text 526928 525816 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
(read/write) 146940 146940 0 0.0
.bss 85976 85840 -136 -0.2
.data 952 952 0 0.0
.text 498592 497492 -1100 -0.2
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
noinit 37160 37160 0 0.0
text 580366 579380 -986 -0.2

@mrjerryjohns
Merge branch 'master' into read-client
5894e2e
@mrjerryjohns
Relaxed the lifetime coupling between the ReadClient the
6d33e2d 
InteractionModelEngine to make shutdown a little less brittle.

Also, removed the Python IM test which now uses the defunct,
chip-im-initiator/responder apps.
@github-actions
Copy link

PR #13108: Size comparison from 660a290 to 6d33e2d

Increases (1 build for linux)
platform target config section 660a290 6d33e2d change % change
linux chip-tool-ipv6only arm64 .got 56696 56704 8 0.0
Decreases (7 builds for k32w, linux, mbed)
platform target config section 660a290 6d33e2d change % change
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7005564 6997604 -7960 -0.1
(read/write) 326241 325857 -384 -0.1
.bss 54609 54257 -352 -0.6
.data.rel.ro 210144 210096 -48 -0.0
.rodata 384228 384188 -40 -0.0
.text 5928084 5920180 -7904 -0.1
thermostat-no-ble arm64 (read only) 2002916 1997764 -5152 -0.3
(read/write) 144081 143569 -512 -0.4
.bss 64369 64033 -336 -0.5
.data.rel.ro 72088 71928 -160 -0.2
.got 3840 3832 -8 -0.2
.rodata 128356 128244 -112 -0.1
.text 1662896 1658128 -4768 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2339832 2338304 -1528 -0.1
.bss 188596 188316 -280 -0.1
.text 1302408 1300880 -1528 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330568 2329032 -1536 -0.1
.bss 180936 180656 -280 -0.2
.text 1293168 1291632 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2303664 2302064 -1600 -0.1
.bss 179984 179704 -280 -0.2
.text 1266264 1264664 -1600 -0.1
Full report (9 builds for k32w, linux, mbed)
platform target config section 660a290 6d33e2d change % change
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.data 1904 1904 0 0.0
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.data 1860 1860 0 0.0
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7005564 6997604 -7960 -0.1
(read/write) 326241 325857 -384 -0.1
.bss 54609 54257 -352 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 210144 210096 -48 -0.0
.dynamic 560 560 0 0.0
.got 56696 56704 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384188 -40 -0.0
.text 5928084 5920180 -7904 -0.1
thermostat-no-ble arm64 (read only) 2002916 1997764 -5152 -0.3
(read/write) 144081 143569 -512 -0.4
.bss 64369 64033 -336 -0.5
.data 880 880 0 0.0
.data.rel.ro 72088 71928 -160 -0.2
.dynamic 560 560 0 0.0
.got 3840 3832 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128244 -112 -0.1
.text 1662896 1658128 -4768 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339832 2338304 -1528 -0.1
.bss 188596 188316 -280 -0.1
.data 5272 5272 0 0.0
.text 1302408 1300880 -1528 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2329032 -1536 -0.1
.bss 180936 180656 -280 -0.2
.data 5552 5552 0 0.0
.text 1293168 1291632 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2302064 -1600 -0.1
.bss 179984 179704 -280 -0.2
.data 5544 5544 0 0.0
.text 1266264 1264664 -1600 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 21, 2021 •
edited
Loading

PR #13108: Size comparison from 1d06bb2 to af63c57

Increases (1 build for linux)
platform target config section 1d06bb2 af63c57 change % change
linux chip-tool-ipv6only arm64 .got 56712 56720 8 0.0
Decreases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d06bb2 af63c57 change % change
efr32 lighting-app BRD4161A (read only) 830568 829144 -1424 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.text 830560 829136 -1424 -0.2
BRD4161A+rpc (read only) 818196 816788 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.text 818188 816780 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.text 803936 802528 -1408 -0.2
esp32 all-clusters-app c3devkit (read only) 883166 882166 -1000 -0.1
(read/write) 1312986 1312434 -552 -0.0
.dram0.bss 69384 69104 -280 -0.4
.flash.rodata 176320 176056 -264 -0.1
.flash.text 883166 882166 -1000 -0.1
m5stack (read only) 943435 942555 -880 -0.1
(read/write) 442080 441552 -528 -0.1
.dram0.bss 73888 73608 -280 -0.4
.flash.rodata 203128 202880 -248 -0.1
.flash.text 938051 937171 -880 -0.1
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7006076 6998100 -7976 -0.1
(read/write) 326289 325921 -368 -0.1
.bss 54641 54305 -336 -0.6
.data.rel.ro 210144 210096 -48 -0.0
.rodata 384228 384188 -40 -0.0
.text 5928548 5920628 -7920 -0.1
thermostat-no-ble arm64 (read only) 2017908 2012772 -5136 -0.3
(read/write) 144497 143969 -528 -0.4
.bss 64417 64065 -352 -0.5
.data.rel.ro 72376 72216 -160 -0.2
.got 3888 3880 -8 -0.2
.rodata 128932 128820 -112 -0.1
.text 1676304 1671552 -4752 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2340104 2338512 -1592 -0.1
.bss 188660 188380 -280 -0.1
.text 1302680 1301088 -1592 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330576 2329040 -1536 -0.1
.bss 180936 180656 -280 -0.2
.text 1293176 1291640 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2303672 2302072 -1600 -0.1
.bss 179984 179704 -280 -0.2
.text 1266272 1264672 -1600 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 934663 -1304 -0.1
bss 118428 118148 -280 -0.2
rodata 108124 107908 -216 -0.2
text 631864 631024 -840 -0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 921015 -1352 -0.1
bss 115472 115192 -280 -0.2
rodata 101540 101324 -216 -0.2
text 627176 626336 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 858394 -1336 -0.2
bss 116712 116432 -280 -0.2
rodata 103048 102832 -216 -0.2
text 559308 558468 -840 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908111 906775 -1336 -0.1
bss 117616 117336 -280 -0.2
rodata 103428 103212 -216 -0.2
text 609692 608852 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 830690 -1352 -0.2
bss 115928 115648 -280 -0.2
rodata 98392 98176 -216 -0.2
text 537172 536332 -840 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 909375 908071 -1304 -0.1
bss 117376 117096 -280 -0.2
rodata 103644 103428 -216 -0.2
text 610928 610088 -840 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 904887 -1304 -0.1
bss 117404 117124 -280 -0.2
rodata 102900 102684 -216 -0.2
text 608440 607600 -840 -0.1
p6 all-clusters-app default (read/write) 2392056 2390648 -1408 -0.1
.bss 116860 116580 -280 -0.2
.text 1350320 1348912 -1408 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532232 531120 -1112 -0.2
.bss 86840 86704 -136 -0.2
.text 526912 525800 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
.bss 85976 85840 -136 -0.2
.text 498592 497492 -1100 -0.2
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
text 580366 579380 -986 -0.2
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d06bb2 af63c57 change % change
efr32 lighting-app BRD4161A (read only) 830568 829144 -1424 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.data 1876 1876 0 0.0
.text 830560 829136 -1424 -0.2
BRD4161A+rpc (read only) 818196 816788 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.data 1976 1976 0 0.0
.text 818188 816780 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.data 1832 1832 0 0.0
.text 803936 802528 -1408 -0.2
esp32 all-clusters-app c3devkit (read only) 883166 882166 -1000 -0.1
(read/write) 1312986 1312434 -552 -0.0
.dram0.bss 69384 69104 -280 -0.4
.dram0.data 14220 14220 0 0.0
.flash.rodata 176320 176056 -264 -0.1
.flash.text 883166 882166 -1000 -0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943435 942555 -880 -0.1
(read/write) 442080 441552 -528 -0.1
.dram0.bss 73888 73608 -280 -0.4
.dram0.data 34056 34056 0 0.0
.flash.rodata 203128 202880 -248 -0.1
.flash.text 938051 937171 -880 -0.1
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.data 1904 1904 0 0.0
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.data 1860 1860 0 0.0
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7006076 6998100 -7976 -0.1
(read/write) 326289 325921 -368 -0.1
.bss 54641 54305 -336 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 210144 210096 -48 -0.0
.dynamic 560 560 0 0.0
.got 56712 56720 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384188 -40 -0.0
.text 5928548 5920628 -7920 -0.1
thermostat-no-ble arm64 (read only) 2017908 2012772 -5136 -0.3
(read/write) 144497 143969 -528 -0.4
.bss 64417 64065 -352 -0.5
.data 880 880 0 0.0
.data.rel.ro 72376 72216 -160 -0.2
.dynamic 560 560 0 0.0
.got 3888 3880 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128932 128820 -112 -0.1
.text 1676304 1671552 -4752 -0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340104 2338512 -1592 -0.1
.bss 188660 188380 -280 -0.1
.data 5272 5272 0 0.0
.text 1302680 1301088 -1592 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330576 2329040 -1536 -0.1
.bss 180936 180656 -280 -0.2
.data 5552 5552 0 0.0
.text 1293176 1291640 -1536 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303672 2302072 -1600 -0.1
.bss 179984 179704 -280 -0.2
.data 5544 5544 0 0.0
.text 1266272 1264672 -1600 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935967 934663 -1304 -0.1
bss 118428 118148 -280 -0.2
rodata 108124 107908 -216 -0.2
text 631864 631024 -840 -0.1
nrf52840dk_nrf52840+rpc (read/write) 922367 921015 -1352 -0.1
bss 115472 115192 -280 -0.2
rodata 101540 101324 -216 -0.2
text 627176 626336 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859730 858394 -1336 -0.2
bss 116712 116432 -280 -0.2
rodata 103048 102832 -216 -0.2
text 559308 558468 -840 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 908111 906775 -1336 -0.1
bss 117616 117336 -280 -0.2
rodata 103428 103212 -216 -0.2
text 609692 608852 -840 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832042 830690 -1352 -0.2
bss 115928 115648 -280 -0.2
rodata 98392 98176 -216 -0.2
text 537172 536332 -840 -0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909375 908071 -1304 -0.1
bss 117376 117096 -280 -0.2
rodata 103644 103428 -216 -0.2
text 610928 610088 -840 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906191 904887 -1304 -0.1
bss 117404 117124 -280 -0.2
rodata 102900 102684 -216 -0.2
text 608440 607600 -840 -0.1
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2392056 2390648 -1408 -0.1
.bss 116860 116580 -280 -0.2
.data 2552 2552 0 0.0
.text 1350320 1348912 -1408 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.data 2384 2384 0 0.0
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.data 2336 2336 0 0.0
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532232 531120 -1112 -0.2
(read/write) 146936 146936 0 0.0
.bss 86840 86704 -136 -0.2
.data 1004 1004 0 0.0
.text 526912 525800 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
(read/write) 146940 146940 0 0.0
.bss 85976 85840 -136 -0.2
.data 952 952 0 0.0
.text 498592 497492 -1100 -0.2
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
noinit 37160 37160 0 0.0
text 580366 579380 -986 -0.2

@github-actions
Copy link

github-actions bot commented Dec 21, 2021 •
edited
Loading

PR #13108: Size comparison from 1d06bb2 to 5298455

Increases (1 build for linux)
platform target config section 1d06bb2 5298455 change % change
linux chip-tool-ipv6only arm64 .got 56712 56720 8 0.0
Decreases (13 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1d06bb2 5298455 change % change
efr32 lighting-app BRD4161A (read only) 830568 829144 -1424 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.text 830560 829136 -1424 -0.2
BRD4161A+rpc (read only) 818196 816788 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.text 818188 816780 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.text 803936 802528 -1408 -0.2
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7006076 6998100 -7976 -0.1
(read/write) 326289 325921 -368 -0.1
.bss 54641 54305 -336 -0.6
.data.rel.ro 210144 210096 -48 -0.0
.rodata 384228 384188 -40 -0.0
.text 5928548 5920628 -7920 -0.1
thermostat-no-ble arm64 (read only) 2017908 2012772 -5136 -0.3
(read/write) 144497 143969 -528 -0.4
.bss 64417 64065 -352 -0.5
.data.rel.ro 72376 72216 -160 -0.2
.got 3888 3880 -8 -0.2
.rodata 128932 128820 -112 -0.1
.text 1676304 1671552 -4752 -0.3
p6 all-clusters-app default (read/write) 2392056 2390648 -1408 -0.1
.bss 116860 116580 -280 -0.2
.text 1350320 1348912 -1408 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532232 531120 -1112 -0.2
.bss 86840 86704 -136 -0.2
.text 526912 525800 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
.bss 85976 85840 -136 -0.2
.text 498592 497492 -1100 -0.2
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
text 580366 579380 -986 -0.2
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1d06bb2 5298455 change % change
efr32 lighting-app BRD4161A (read only) 830568 829144 -1424 -0.2
(read/write) 127384 127104 -280 -0.2
.bss 125504 125224 -280 -0.2
.data 1876 1876 0 0.0
.text 830560 829136 -1424 -0.2
BRD4161A+rpc (read only) 818196 816788 -1408 -0.2
(read/write) 144048 143768 -280 -0.2
.bss 142072 141792 -280 -0.2
.data 1976 1976 0 0.0
.text 818188 816780 -1408 -0.2
window-app BRD4161A (read only) 803944 802536 -1408 -0.2
(read/write) 126320 126040 -280 -0.2
.bss 124488 124208 -280 -0.2
.data 1832 1832 0 0.0
.text 803936 802528 -1408 -0.2
k32w light k32w061+release (read/write) 648764 647512 -1252 -0.2
.bss 76512 76232 -280 -0.4
.data 1904 1904 0 0.0
.text 564548 563576 -972 -0.2
lock k32w061+release (read/write) 633472 632224 -1248 -0.2
.bss 76224 75944 -280 -0.4
.data 1860 1860 0 0.0
.text 549588 548620 -968 -0.2
linux chip-tool-ipv6only arm64 (read only) 7006076 6998100 -7976 -0.1
(read/write) 326289 325921 -368 -0.1
.bss 54641 54305 -336 -0.6
.data 1096 1096 0 0.0
.data.rel.ro 210144 210096 -48 -0.0
.dynamic 560 560 0 0.0
.got 56712 56720 8 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384188 -40 -0.0
.text 5928548 5920628 -7920 -0.1
thermostat-no-ble arm64 (read only) 2017908 2012772 -5136 -0.3
(read/write) 144497 143969 -528 -0.4
.bss 64417 64065 -352 -0.5
.data 880 880 0 0.0
.data.rel.ro 72376 72216 -160 -0.2
.dynamic 560 560 0 0.0
.got 3888 3880 -8 -0.2
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128932 128820 -112 -0.1
.text 1676304 1671552 -4752 -0.3
p6 all-clusters-app default (read/write) 2392056 2390648 -1408 -0.1
.bss 116860 116580 -280 -0.2
.data 2552 2552 0 0.0
.text 1350320 1348912 -1408 -0.1
light-app default (read/write) 2325104 2323696 -1408 -0.1
.bss 106184 105904 -280 -0.3
.data 2384 2384 0 0.0
.text 1283368 1281960 -1408 -0.1
lock-app default (read/write) 2297312 2295912 -1400 -0.1
.bss 105064 104784 -280 -0.3
.data 2336 2336 0 0.0
.text 1255576 1254176 -1400 -0.1
qpg lighting-app qpg6105+debug (read only) 532232 531120 -1112 -0.2
(read/write) 146936 146936 0 0.0
.bss 86840 86704 -136 -0.2
.data 1004 1004 0 0.0
.text 526912 525800 -1112 -0.2
lock-app qpg6105+debug (read only) 503912 502812 -1100 -0.2
(read/write) 146940 146940 0 0.0
.bss 85976 85840 -136 -0.2
.data 952 952 0 0.0
.text 498592 497492 -1100 -0.2
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 830770 -1488 -0.2
bss 87088 86808 -280 -0.3
noinit 37160 37160 0 0.0
text 580366 579380 -986 -0.2

yunhanw-google
yunhanw-google requested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this interaction model test in cirque in this PR, currently rob and I still are debugging one event generation stability test.

bzbarsky-apple
bzbarsky-apple reviewed Dec 21, 2021
View reviewed changes
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
src/app/ReadClient.cpp Outdated Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple merged commit 118ab9d into project-chip:master Dec 22, 2021
@yunhanw-google yunhanw-google mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller darwin review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrjerryjohns @yunhanw-google @bzbarsky-apple @Damian-Nordic