Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align OTA Requestor Cluster with spec #13098

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Align OTA Requestor Cluster with spec #13098

merged 1 commit into from
Dec 20, 2021

Conversation

carol-apple
Copy link
Contributor

Problem

The OTA Requestor Cluster spec has changed since it was first added. There are slight differences between spec and zap/xml files.

Change overview

  • Add ProviderLocation struct
  • Add missing server side attributes
  • Update fields in AnnounceOtaProvider
  • Add default values for fields
  • Add constraints for fields

Testing

Manually tested provider/requestor on Linux

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from cbd2887 to ef9c8d2 Compare December 17, 2021 06:41
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13098: Size comparison from a9b9fca to ef9c8d2

Increases above 0.2%:

platform target config section a9b9fca ef9c8d2 change % change
linux chip-tool-ipv6only arm64 (read only) 6951772 6978172 26400 0.4
.got 56456 56616 160 0.3
.text 5879780 5904308 24528 0.4
Increases (5 builds for esp32, linux, mbed, p6)
platform target config section a9b9fca ef9c8d2 change % change
esp32 all-clusters-app c3devkit (read only) 877496 877944 448 0.1
(read/write) 1313042 1313098 56 0.0
.flash.rodata 175976 176032 56 0.0
.flash.text 877496 877944 448 0.1
m5stack (read only) 938355 938759 404 0.0
(read/write) 442144 442196 52 0.0
.flash.rodata 202800 202860 60 0.0
.flash.text 932971 933375 404 0.0
linux chip-tool-ipv6only arm64 (read only) 6951772 6978172 26400 0.4
(read/write) 324401 325009 608 0.2
.data.rel.ro 208576 209016 440 0.2
.got 56456 56616 160 0.3
.rodata 382580 383076 496 0.1
.text 5879780 5904308 24528 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2334424 2334864 440 0.0
.text 1297000 1297440 440 0.0
p6 all-clusters-app default (read/write) 2385072 2385672 600 0.0
.text 1343336 1343936 600 0.0
Decreases (1 build for esp32)
platform target config section a9b9fca ef9c8d2 change % change
esp32 all-clusters-app m5stack .dram0.bss 74280 74272 -8 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a9b9fca ef9c8d2 change % change
efr32 lighting-app BRD4161A (read only) 829904 829904 0 0.0
(read/write) 127352 127352 0 0.0
.bss 125472 125472 0 0.0
.data 1876 1876 0 0.0
.text 829896 829896 0 0.0
BRD4161A+rpc (read only) 817532 817532 0 0.0
(read/write) 144016 144016 0 0.0
.bss 142040 142040 0 0.0
.data 1976 1976 0 0.0
.text 817524 817524 0 0.0
window-app BRD4161A (read only) 803280 803280 0 0.0
(read/write) 126288 126288 0 0.0
.bss 124456 124456 0 0.0
.data 1832 1832 0 0.0
.text 803272 803272 0 0.0
esp32 all-clusters-app c3devkit (read only) 877496 877944 448 0.1
(read/write) 1313042 1313098 56 0.0
.dram0.bss 69784 69784 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175976 176032 56 0.0
.flash.text 877496 877944 448 0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 938355 938759 404 0.0
(read/write) 442144 442196 52 0.0
.dram0.bss 74280 74272 -8 -0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202800 202860 60 0.0
.flash.text 932971 933375 404 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648664 648664 0 0.0
.bss 76480 76480 0 0.0
.data 1904 1904 0 0.0
.text 564480 564480 0 0.0
lock k32w061+release (read/write) 633380 633380 0 0.0
.bss 76200 76200 0 0.0
.data 1860 1860 0 0.0
.text 549520 549520 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6951772 6978172 26400 0.4
(read/write) 324401 325009 608 0.2
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208576 209016 440 0.2
.dynamic 560 560 0 0.0
.got 56456 56616 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 382580 383076 496 0.1
.text 5879780 5904308 24528 0.4
thermostat-no-ble arm64 (read only) 1996756 1996756 0 0.0
(read/write) 143953 143953 0 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72024 72024 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128196 128196 0 0.0
.text 1657072 1657072 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334424 2334864 440 0.0
.bss 189068 189068 0 0.0
.data 5264 5264 0 0.0
.text 1297000 1297440 440 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329000 2329000 0 0.0
.bss 180896 180896 0 0.0
.data 5544 5544 0 0.0
.text 1291600 1291600 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302032 2302032 0 0.0
.bss 179944 179944 0 0.0
.data 5536 5536 0 0.0
.text 1264632 1264632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935915 935915 0 0.0
bss 118400 118400 0 0.0
rodata 108120 108120 0 0.0
text 631844 631844 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922315 922315 0 0.0
bss 115444 115444 0 0.0
rodata 101536 101536 0 0.0
text 627156 627156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859678 859678 0 0.0
bss 116684 116684 0 0.0
rodata 103044 103044 0 0.0
text 559284 559284 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908059 908059 0 0.0
bss 117588 117588 0 0.0
rodata 103424 103424 0 0.0
text 609668 609668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831974 831974 0 0.0
bss 115900 115900 0 0.0
rodata 98388 98388 0 0.0
text 537152 537152 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909355 909355 0 0.0
bss 117348 117348 0 0.0
rodata 103640 103640 0 0.0
text 610908 610908 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906139 906139 0 0.0
bss 117376 117376 0 0.0
rodata 102896 102896 0 0.0
text 608416 608416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2385072 2385672 600 0.0
.bss 117260 117260 0 0.0
.data 2544 2544 0 0.0
.text 1343336 1343936 600 0.0
light-app default (read/write) 2324456 2324456 0 0.0
.bss 106152 106152 0 0.0
.data 2384 2384 0 0.0
.text 1282720 1282720 0 0.0
lock-app default (read/write) 2296648 2296648 0 0.0
.bss 105032 105032 0 0.0
.data 2336 2336 0 0.0
.text 1254912 1254912 0 0.0
qpg lighting-app qpg6105+debug (read only) 532172 532172 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86816 86816 0 0.0
.data 1004 1004 0 0.0
.text 526852 526852 0 0.0
lock-app qpg6105+debug (read only) 503836 503836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85952 85952 0 0.0
.data 952 952 0 0.0
.text 498516 498516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 830638 830638 0 0.0
bss 87040 87040 0 0.0
noinit 37160 37160 0 0.0
text 578832 578832 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from ef9c8d2 to 0b7798b Compare December 17, 2021 19:31
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13098: Size comparison from 7283e3a to 0b7798b

Increases above 0.2%:

platform target config section 7283e3a 0b7798b change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
.got 56504 56664 160 0.3
.text 5902212 5926740 24528 0.4
p6 all-clusters-app default .data 2544 2552 8 0.3
Increases (5 builds for esp32, linux, mbed, p6)
platform target config section 7283e3a 0b7798b change % change
esp32 all-clusters-app c3devkit (read only) 881266 881792 526 0.1
(read/write) 1312402 1312466 64 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881266 881792 526 0.1
m5stack (read only) 941919 942395 476 0.1
(read/write) 441516 441576 60 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937011 476 0.1
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2337920 2338488 568 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
p6 all-clusters-app default (read/write) 2390040 2390768 728 0.0
.data 2544 2552 8 0.3
.text 1348304 1349032 728 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7283e3a 0b7798b change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
esp32 all-clusters-app c3devkit (read only) 881266 881792 526 0.1
(read/write) 1312402 1312466 64 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881266 881792 526 0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 942395 476 0.1
(read/write) 441516 441576 60 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937011 476 0.1
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56504 56664 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2338488 568 0.0
.bss 188580 188580 0 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 936111 0 0.0
bss 118408 118408 0 0.0
rodata 108124 108124 0 0.0
text 632008 632008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922479 922479 0 0.0
bss 115452 115452 0 0.0
rodata 101540 101540 0 0.0
text 627320 627320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859842 859842 0 0.0
bss 116692 116692 0 0.0
rodata 103048 103048 0 0.0
text 559452 559452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908223 908223 0 0.0
bss 117596 117596 0 0.0
rodata 103428 103428 0 0.0
text 609836 609836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832186 832186 0 0.0
bss 115908 115908 0 0.0
rodata 98392 98392 0 0.0
text 537316 537316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909519 909519 0 0.0
bss 117356 117356 0 0.0
rodata 103644 103644 0 0.0
text 611072 611072 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 906335 0 0.0
bss 117384 117384 0 0.0
rodata 102900 102900 0 0.0
text 608584 608584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2390040 2390768 728 0.0
.bss 116780 116780 0 0.0
.data 2544 2552 8 0.3
.text 1348304 1349032 728 0.1
light-app default (read/write) 2325120 2325120 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283384 1283384 0 0.0
lock-app default (read/write) 2297328 2297328 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255592 1255592 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from 0b7798b to a7388f2 Compare December 17, 2021 21:14
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13098: Size comparison from 7283e3a to a7388f2

Increases above 0.2%:

platform target config section 7283e3a a7388f2 change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
.got 56504 56664 160 0.3
.text 5902212 5926740 24528 0.4
p6 all-clusters-app default .data 2544 2552 8 0.3
Increases (2 builds for linux, p6)
platform target config section 7283e3a a7388f2 change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
p6 all-clusters-app default (read/write) 2390040 2390736 696 0.0
.data 2544 2552 8 0.3
.text 1348304 1349000 696 0.1
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 7283e3a a7388f2 change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56504 56664 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
p6 all-clusters-app default (read/write) 2390040 2390736 696 0.0
.bss 116780 116780 0 0.0
.data 2544 2552 8 0.3
.text 1348304 1349000 696 0.1
light-app default (read/write) 2325120 2325120 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283384 1283384 0 0.0
lock-app default (read/write) 2297328 2297328 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255592 1255592 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from a7388f2 to 6cbe69e Compare December 17, 2021 21:54
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13098: Size comparison from 7283e3a to 6cbe69e

Increases above 0.2%:

platform target config section 7283e3a 6cbe69e change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.text 5902212 5926740 24528 0.4
Increases (1 build for linux)
platform target config section 7283e3a 6cbe69e change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
Full report (8 builds for k32w, linux, qpg, telink)
platform target config section 7283e3a 6cbe69e change % change
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56504 56664 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from 6cbe69e to 06c8a6f Compare December 17, 2021 22:32
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

PR #13098: Size comparison from 7283e3a to 06c8a6f

Increases above 0.2%:

platform target config section 7283e3a 06c8a6f change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
.got 56504 56664 160 0.3
.text 5902212 5926740 24528 0.4
Increases (1 build for linux)
platform target config section 7283e3a 06c8a6f change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
Full report (21 builds for efr32, k32w, linux, nrfconnect, qpg, telink)
platform target config section 7283e3a 06c8a6f change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56504 56664 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 936111 0 0.0
bss 118408 118408 0 0.0
rodata 108124 108124 0 0.0
text 632008 632008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922479 922479 0 0.0
bss 115452 115452 0 0.0
rodata 101540 101540 0 0.0
text 627320 627320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859842 859842 0 0.0
bss 116692 116692 0 0.0
rodata 103048 103048 0 0.0
text 559452 559452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908223 908223 0 0.0
bss 117596 117596 0 0.0
rodata 103428 103428 0 0.0
text 609836 609836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832186 832186 0 0.0
bss 115908 115908 0 0.0
rodata 98392 98392 0 0.0
text 537316 537316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909519 909519 0 0.0
bss 117356 117356 0 0.0
rodata 103644 103644 0 0.0
text 611072 611072 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 906335 0 0.0
bss 117384 117384 0 0.0
rodata 102900 102900 0 0.0
text 608584 608584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch 2 times, most recently from c596bbb to fcedec3 Compare December 18, 2021 00:01
@github-actions
Copy link

github-actions bot commented Dec 18, 2021 •
edited
Loading

PR #13098: Size comparison from 7283e3a to fcedec3

Increases above 0.2%:

platform target config section 7283e3a fcedec3 change % change
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
.got 56504 56664 160 0.3
.text 5902212 5926740 24528 0.4
p6 all-clusters-app default .data 2544 2552 8 0.3
Increases (5 builds for esp32, linux, mbed, p6)
platform target config section 7283e3a fcedec3 change % change
esp32 all-clusters-app c3devkit (read only) 881266 881792 526 0.1
(read/write) 1312402 1312466 64 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881266 881792 526 0.1
m5stack (read only) 941919 942395 476 0.1
(read/write) 441516 441576 60 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937011 476 0.1
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56504 56664 160 0.3
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2337920 2338488 568 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
p6 all-clusters-app default (read/write) 2390040 2390768 728 0.0
.data 2544 2552 8 0.3
.text 1348304 1349032 728 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7283e3a fcedec3 change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
esp32 all-clusters-app c3devkit (read only) 881266 881792 526 0.1
(read/write) 1312402 1312466 64 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881266 881792 526 0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 942395 476 0.1
(read/write) 441516 441576 60 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937011 476 0.1
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648852 648852 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564660 564660 0 0.0
lock k32w061+release (read/write) 633568 633568 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549700 549700 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977548 7003932 26384 0.4
(read/write) 325601 326193 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56504 56664 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383540 384036 496 0.1
.text 5902212 5926740 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2338488 568 0.0
.bss 188580 188580 0 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330760 2330760 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293360 1293360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 936111 0 0.0
bss 118408 118408 0 0.0
rodata 108124 108124 0 0.0
text 632008 632008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922479 922479 0 0.0
bss 115452 115452 0 0.0
rodata 101540 101540 0 0.0
text 627320 627320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859842 859842 0 0.0
bss 116692 116692 0 0.0
rodata 103048 103048 0 0.0
text 559452 559452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908223 908223 0 0.0
bss 117596 117596 0 0.0
rodata 103428 103428 0 0.0
text 609836 609836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832186 832186 0 0.0
bss 115908 115908 0 0.0
rodata 98392 98392 0 0.0
text 537316 537316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909519 909519 0 0.0
bss 117356 117356 0 0.0
rodata 103644 103644 0 0.0
text 611072 611072 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 906335 0 0.0
bss 117384 117384 0 0.0
rodata 102900 102900 0 0.0
text 608584 608584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2390040 2390768 728 0.0
.bss 116780 116780 0 0.0
.data 2544 2552 8 0.3
.text 1348304 1349032 728 0.1
light-app default (read/write) 2325120 2325120 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283384 1283384 0 0.0
lock-app default (read/write) 2297328 2297328 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255592 1255592 0 0.0
qpg lighting-app qpg6105+debug (read only) 532352 532352 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527032 527032 0 0.0
lock-app qpg6105+debug (read only) 504016 504016 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498696 498696 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832370 832370 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580500 580500 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from fcedec3 to 423a08d Compare December 19, 2021 04:10
@github-actions
Copy link

PR #13098: Size comparison from 7fb48ab to 423a08d

Increases above 0.2%:

platform target config section 7fb48ab 423a08d change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
.data.rel.ro 209704 210144 440 0.2
.got 56536 56696 160 0.3
.text 5903540 5928068 24528 0.4
Increases (1 build for linux)
platform target config section 7fb48ab 423a08d change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56536 56696 160 0.3
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
Full report (8 builds for k32w, linux, qpg, telink)
platform target config section 7fb48ab 423a08d change % change
k32w light k32w061+release (read/write) 648868 648868 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564676 564676 0 0.0
lock k32w061+release (read/write) 633584 633584 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549716 549716 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56536 56696 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
qpg lighting-app qpg6105+debug (read only) 532368 532368 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527048 527048 0 0.0
lock-app qpg6105+debug (read only) 504032 504032 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498712 498712 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832378 832378 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580502 580502 0 0.0

@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch 3 times, most recently from 7a05791 to 9a26839 Compare December 19, 2021 04:47
@github-actions
Copy link

PR #13098: Size comparison from 7fb48ab to 9a26839

Increases above 0.2%:

platform target config section 7fb48ab 9a26839 change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
.data.rel.ro 209704 210144 440 0.2
.got 56536 56696 160 0.3
.text 5903540 5928068 24528 0.4
Increases (1 build for linux)
platform target config section 7fb48ab 9a26839 change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56536 56696 160 0.3
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
Decreases (2 builds for qpg, telink)
platform target config section 7fb48ab 9a26839 change % change
qpg lighting-app qpg6105+debug (read only) 532368 530928 -1440 -0.3
.bss 86824 86816 -8 -0.0
.text 527048 525608 -1440 -0.3
telink lighting-app tlsr9518adk80d (read/write) 832378 830714 -1664 -0.2
text 580502 579064 -1438 -0.2
Full report (6 builds for linux, qpg, telink)
platform target config section 7fb48ab 9a26839 change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56536 56696 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
qpg lighting-app qpg6105+debug (read only) 532368 530928 -1440 -0.3
(read/write) 146936 146936 0 0.0
.bss 86824 86816 -8 -0.0
.data 1004 1004 0 0.0
.text 527048 525608 -1440 -0.3
lock-app qpg6105+debug (read only) 504032 504032 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498712 498712 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832378 830714 -1664 -0.2
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580502 579064 -1438 -0.2

@carol-apple
Align OTA Requestor Cluster with spec
1b74e19 
- Update DefaultOtaProviders to be a list of ProviderLocation structs
- Add Endpoint field to AnnounceOTAProviders command
- Accessors cannot properly handle lists so provide minimal implementation of AttributeAccessInterface for OTA Requestor
- Rename ClusterInterface.cpp to ota-requestor-server.cpp to better match other clusters
- Add default, isNullable, and contraints to all applicable fields
@carol-apple carol-apple force-pushed the spec_ota_requestor_cluster branch from 9a26839 to 1b74e19 Compare December 19, 2021 05:11
@github-actions
Copy link

github-actions bot commented Dec 19, 2021 •
edited
Loading

PR #13098: Size comparison from 7fb48ab to 1b74e19

Increases above 0.2%:

platform target config section 7fb48ab 1b74e19 change % change
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
.got 56536 56696 160 0.3
.text 5903540 5928068 24528 0.4
p6 all-clusters-app default .data 2544 2552 8 0.3
Increases (5 builds for esp32, linux, mbed, p6)
platform target config section 7fb48ab 1b74e19 change % change
esp32 all-clusters-app c3devkit (read only) 881268 881864 596 0.1
(read/write) 1312402 1312466 64 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881268 881864 596 0.1
m5stack (read only) 941919 942423 504 0.1
(read/write) 441516 441576 60 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937039 504 0.1
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.data.rel.ro 209704 210144 440 0.2
.got 56536 56696 160 0.3
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2337920 2338488 568 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
p6 all-clusters-app default (read/write) 2390040 2390896 856 0.0
.data 2544 2552 8 0.3
.text 1348304 1349160 856 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7fb48ab 1b74e19 change % change
efr32 lighting-app BRD4161A (read only) 830584 830584 0 0.0
(read/write) 127360 127360 0 0.0
.bss 125480 125480 0 0.0
.data 1876 1876 0 0.0
.text 830576 830576 0 0.0
BRD4161A+rpc (read only) 818212 818212 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142048 142048 0 0.0
.data 1976 1976 0 0.0
.text 818204 818204 0 0.0
window-app BRD4161A (read only) 803960 803960 0 0.0
(read/write) 126296 126296 0 0.0
.bss 124464 124464 0 0.0
.data 1832 1832 0 0.0
.text 803952 803952 0 0.0
esp32 all-clusters-app c3devkit (read only) 881268 881864 596 0.1
(read/write) 1312402 1312466 64 0.0
.dram0.bss 69296 69296 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175832 175896 64 0.0
.flash.text 881268 881864 596 0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 941919 942423 504 0.1
(read/write) 441516 441576 60 0.0
.dram0.bss 73792 73792 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202660 202720 60 0.0
.flash.text 936535 937039 504 0.1
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648868 648868 0 0.0
.bss 76488 76488 0 0.0
.data 1904 1904 0 0.0
.text 564676 564676 0 0.0
lock k32w061+release (read/write) 633584 633584 0 0.0
.bss 76208 76208 0 0.0
.data 1860 1860 0 0.0
.text 549716 549716 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979164 7005548 26384 0.4
(read/write) 325633 326225 592 0.2
.bss 54593 54593 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209704 210144 440 0.2
.dynamic 560 560 0 0.0
.got 56536 56696 160 0.3
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383732 384228 496 0.1
.text 5903540 5928068 24528 0.4
thermostat-no-ble arm64 (read only) 2006052 2006052 0 0.0
(read/write) 144065 144065 0 0.0
.bss 64353 64353 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1666032 1666032 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337920 2338488 568 0.0
.bss 188580 188580 0 0.0
.data 5264 5272 8 0.2
.text 1300496 1301064 568 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330696 2330696 0 0.0
.bss 180920 180920 0 0.0
.data 5552 5552 0 0.0
.text 1293296 1293296 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303792 2303792 0 0.0
.bss 179968 179968 0 0.0
.data 5544 5544 0 0.0
.text 1266392 1266392 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936111 936111 0 0.0
bss 118408 118408 0 0.0
rodata 108124 108124 0 0.0
text 632008 632008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 922479 922479 0 0.0
bss 115452 115452 0 0.0
rodata 101540 101540 0 0.0
text 627320 627320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859842 859842 0 0.0
bss 116692 116692 0 0.0
rodata 103048 103048 0 0.0
text 559452 559452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908223 908223 0 0.0
bss 117596 117596 0 0.0
rodata 103428 103428 0 0.0
text 609836 609836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832186 832186 0 0.0
bss 115908 115908 0 0.0
rodata 98392 98392 0 0.0
text 537316 537316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909519 909519 0 0.0
bss 117356 117356 0 0.0
rodata 103644 103644 0 0.0
text 611072 611072 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906335 906335 0 0.0
bss 117384 117384 0 0.0
rodata 102900 102900 0 0.0
text 608584 608584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2390040 2390896 856 0.0
.bss 116780 116780 0 0.0
.data 2544 2552 8 0.3
.text 1348304 1349160 856 0.1
light-app default (read/write) 2325120 2325120 0 0.0
.bss 106160 106160 0 0.0
.data 2384 2384 0 0.0
.text 1283384 1283384 0 0.0
lock-app default (read/write) 2297328 2297328 0 0.0
.bss 105040 105040 0 0.0
.data 2336 2336 0 0.0
.text 1255592 1255592 0 0.0
qpg lighting-app qpg6105+debug (read only) 532368 532368 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86824 0 0.0
.data 1004 1004 0 0.0
.text 527048 527048 0 0.0
lock-app qpg6105+debug (read only) 504032 504032 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85960 0 0.0
.data 952 952 0 0.0
.text 498712 498712 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832378 832378 0 0.0
bss 87064 87064 0 0.0
noinit 37160 37160 0 0.0
text 580502 580502 0 0.0

@selissia selissia merged commit b3f7dd0 into project-chip:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@selissia selissia selissia approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carol-apple @selissia @bzbarsky-apple @jmeg-sfy