-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowCovering: Update xml config to latest specs #13076
Merged
kpschoedel
merged 16 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-zap-update
Dec 21, 2021
Merged
WindowCovering: Update xml config to latest specs #13076
kpschoedel
merged 16 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-zap-update
Dec 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeg-sfy
changed the title
Jmeg sfy/window covering zap update
WindowCovering: Update xml config to latest specs
Dec 16, 2021
PR #13076: Size comparison from 41700bd to 01a7413 Increases (2 builds for efr32, p6)
Decreases (1 build for linux)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
LuDuda
December 16, 2021 11:43
PR #13076: Size comparison from 1a3738f to c4ab080 Full report (6 builds for k32w, qpg, telink)
|
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-zap-update
branch
from
December 17, 2021 14:43
6c8c670
to
931ffee
Compare
PR #13076: Size comparison from d24eff1 to 3a057ca Increases (6 builds for efr32, esp32, linux, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Dec 17, 2021
bzbarsky-apple
approved these changes
Dec 18, 2021
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-zap-update
branch
from
December 20, 2021 15:08
3a057ca
to
631f588
Compare
PR #13076: Size comparison from 3a28cd7 to 631f588 Increases (4 builds for efr32, linux, mbed, p6)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-zap-update
branch
from
December 20, 2021 17:48
631f588
to
d2982a3
Compare
PR #13076: Size comparison from 569e7cc to d2982a3 Increases (4 builds for efr32, linux, mbed, p6)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current attributes pattern is not specs compliant
here current specs https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/WindowCovering.adoc
Some attributes have been deprecated
Some attributes are using the nullable feature
Change overview
Testing
How was this tested? (at least one bullet point required)