Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support write operation of user label list for User Label Cluster #13065

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Support write operation of user label list for User Label Cluster #13065

merged 5 commits into from
Dec 17, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • No write support for User Label cluster

Change overview

Support write operation of user label list for User Label cluster

Testing

How was this tested? (at least one bullet point required)

  • No write list attribute support in chip-tool yet, the test is done by auto generated test case in CHIPClustersTests.m

@yufengwangca yufengwangca changed the title Support write operation of user label list for User Label cluster Support write operation of user label list for User Label Cluster Dec 15, 2021
@github-actions
Copy link

github-actions bot commented Dec 15, 2021

PR #13065: Size comparison from fc5be12 to a2a4d77

Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fc5be12 a2a4d77 change % change
efr32 lighting-app BRD4161A (read only) 835748 836164 416 0.0
.text 835740 836156 416 0.0
BRD4161A+rpc (read only) 823352 823768 416 0.1
.text 823344 823760 416 0.1
window-app BRD4161A (read only) 809108 809556 448 0.1
.text 809100 809548 448 0.1
k32w lighting-app k32w061+se05x+release (read/write) 686412 686764 352 0.1
.text 600680 601032 352 0.1
lock-app k32w061+debug (read/write) 633976 634328 352 0.1
.text 550140 550492 352 0.1
shell k32w061+debug (read/write) 639720 640056 336 0.1
.text 553396 553732 336 0.1
linux thermostat-no-ble arm64 (read only) 1994052 1996532 2480 0.1
(read/write) 143937 143953 16 0.0
.data.rel.ro 72000 72024 24 0.0
.text 1654672 1657136 2464 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2333776 2334160 384 0.0
.text 1296352 1296736 384 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2329344 2329664 320 0.0
.text 1291944 1292264 320 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302376 2302760 384 0.0
.text 1264976 1265360 384 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936579 936915 336 0.0
text 632668 633008 340 0.1
nrf52840dk_nrf52840+rpc (read/write) 918531 918867 336 0.0
text 625804 626144 340 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 860294 860630 336 0.0
text 560100 560440 340 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908675 909011 336 0.0
text 610484 610824 340 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832622 832958 336 0.0
text 537956 538296 340 0.1
pump-app nrf52840dk_nrf52840 (read/write) 913555 913891 336 0.0
text 614036 614376 340 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906787 907123 336 0.0
text 609232 609572 340 0.1
p6 all-clusters-app default (read/write) 2389688 2390120 432 0.0
.text 1347952 1348384 432 0.0
light-app default (read/write) 2330000 2330416 416 0.0
.text 1288264 1288680 416 0.0
lock-app default (read/write) 2302192 2302624 432 0.0
.text 1260456 1260888 432 0.0
qpg lighting-app qpg6105+debug (read only) 532768 533112 344 0.1
.text 527448 527792 344 0.1
lock-app qpg6105+debug (read only) 504456 504784 328 0.1
.text 499136 499464 328 0.1
telink lighting-app tlsr9518adk80d (read/write) 831110 831526 416 0.1
text 579422 579838 416 0.1
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fc5be12 a2a4d77 change % change
efr32 lighting-app BRD4161A (read only) 835748 836164 416 0.0
(read/write) 127324 127324 0 0.0
.bss 125448 125448 0 0.0
.data 1876 1876 0 0.0
.text 835740 836156 416 0.0
BRD4161A+rpc (read only) 823352 823768 416 0.1
(read/write) 143992 143992 0 0.0
.bss 142016 142016 0 0.0
.data 1976 1976 0 0.0
.text 823344 823760 416 0.1
window-app BRD4161A (read only) 809108 809556 448 0.1
(read/write) 126264 126264 0 0.0
.bss 124432 124432 0 0.0
.data 1832 1832 0 0.0
.text 809100 809548 448 0.1
k32w lighting-app k32w061+se05x+release (read/write) 686412 686764 352 0.1
.bss 78024 78024 0 0.0
.data 1908 1908 0 0.0
.text 600680 601032 352 0.1
lock-app k32w061+debug (read/write) 633976 634328 352 0.1
.bss 76176 76176 0 0.0
.data 1860 1860 0 0.0
.text 550140 550492 352 0.1
shell k32w061+debug (read/write) 639720 640056 336 0.1
.bss 78684 78684 0 0.0
.data 1840 1840 0 0.0
.text 553396 553732 336 0.1
linux chip-tool-ipv6only arm64 (read only) 6911556 6911556 0 0.0
(read/write) 322993 322993 0 0.0
.bss 54577 54577 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 207752 207752 0 0.0
.dynamic 560 560 0 0.0
.got 55864 55864 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 377636 377636 0 0.0
.text 5847924 5847924 0 0.0
thermostat-no-ble arm64 (read only) 1994052 1996532 2480 0.1
(read/write) 143937 143953 16 0.0
.bss 64321 64321 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72024 24 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127908 127908 0 0.0
.text 1654672 1657136 2464 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333776 2334160 384 0.0
.bss 189020 189020 0 0.0
.data 5256 5256 0 0.0
.text 1296352 1296736 384 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329344 2329664 320 0.0
.bss 180872 180872 0 0.0
.data 5544 5544 0 0.0
.text 1291944 1292264 320 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302376 2302760 384 0.0
.bss 179920 179920 0 0.0
.data 5536 5536 0 0.0
.text 1264976 1265360 384 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936579 936915 336 0.0
bss 118376 118376 0 0.0
rodata 107952 107952 0 0.0
text 632668 633008 340 0.1
nrf52840dk_nrf52840+rpc (read/write) 918531 918867 336 0.0
bss 114708 114708 0 0.0
rodata 99864 99864 0 0.0
text 625804 626144 340 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 860294 860630 336 0.0
bss 116660 116660 0 0.0
rodata 102876 102876 0 0.0
text 560100 560440 340 0.1
lock-app nrf52840dk_nrf52840 (read/write) 908675 909011 336 0.0
bss 117564 117564 0 0.0
rodata 103256 103256 0 0.0
text 610484 610824 340 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832622 832958 336 0.0
bss 115876 115876 0 0.0
rodata 98220 98220 0 0.0
text 537956 538296 340 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913555 913891 336 0.0
bss 117472 117472 0 0.0
rodata 104600 104600 0 0.0
text 614036 614376 340 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 906787 907123 336 0.0
bss 117352 117352 0 0.0
rodata 102728 102728 0 0.0
text 609232 609572 340 0.1
shell nrf52840dk_nrf52840 (read/write) 796959 796959 0 0.0
bss 109472 109472 0 0.0
rodata 78032 78032 0 0.0
text 532996 532996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709594 709594 0 0.0
bss 107360 107360 0 0.0
rodata 72336 72336 0 0.0
text 450484 450484 0 0.0
p6 all-clusters-app default (read/write) 2389688 2390120 432 0.0
.bss 117212 117212 0 0.0
.data 2536 2536 0 0.0
.text 1347952 1348384 432 0.0
light-app default (read/write) 2330000 2330416 416 0.0
.bss 106128 106128 0 0.0
.data 2384 2384 0 0.0
.text 1288264 1288680 416 0.0
lock-app default (read/write) 2302192 2302624 432 0.0
.bss 105008 105008 0 0.0
.data 2336 2336 0 0.0
.text 1260456 1260888 432 0.0
qpg lighting-app qpg6105+debug (read only) 532768 533112 344 0.1
(read/write) 146936 146936 0 0.0
.bss 86800 86800 0 0.0
.data 1004 1004 0 0.0
.text 527448 527792 344 0.1
lock-app qpg6105+debug (read only) 504456 504784 328 0.1
(read/write) 146940 146940 0 0.0
.bss 85936 85936 0 0.0
.data 952 952 0 0.0
.text 499136 499464 328 0.1
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831110 831526 416 0.1
bss 87016 87016 0 0.0
noinit 37160 37160 0 0.0
text 579422 579838 416 0.1

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2021

CLA assistant check
All committers have signed the CLA.

@bzbarsky-apple bzbarsky-apple merged commit 7eb3574 into project-chip:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants