-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Optional argument parsing does not work after #12732 #13028
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_OptionalArgumentParsingBrokenAfter12732
Dec 15, 2021
Merged
[chip-tool] Optional argument parsing does not work after #12732 #13028
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_OptionalArgumentParsingBrokenAfter12732
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
December 15, 2021 11:55
pullapprove
bot
requested review from
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
December 15, 2021 11:55
PR #13028: Size comparison from c52bc7b to 6d42bef Decreases (1 build for linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 15, 2021
andy31415
added
hotfix
urgent fix needed, can bypass review
fast track
and removed
hotfix
urgent fix needed, can bypass review
labels
Dec 15, 2021
fast track: change by domain owner, critical bug, changes test tool only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Optional arguments parsing is broken in
chip-tool
after #12732.Change overview
chip-tool
custom parsing...Testing
Tried with
./out/debug/standalone/chip-tool pairing onnetwork-long 0x12345 20202021 3840 --trace_file /tmp/foo.log --commissioner-name alpha
locally.Fixes #13016