Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp Docker build - now it will stay fixed #12996

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

andy31415
Copy link
Contributor

Problem

ESP checkouts with depth 1, however for branches this makes checkouts of specific revisions not work (because shallow depth)

Change overview

do not use depth 1
update sha to latest 4.4 branch sha

Testing

Docker image build will validate this.

@andy31415 andy31415 changed the title Fix esp doicker build - now it will stay fixed Fix esp Docker build - now it will stay fixed Dec 14, 2021
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Dec 14, 2021
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review labels Dec 14, 2021
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Dec 14, 2021
@github-actions
Copy link

github-actions bot commented Dec 14, 2021

PR #12996: Size comparison from f40044e to 8917200

Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section f40044e 8917200 change % change
efr32 lighting-app BRD4161A (read only) 833464 833464 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126744 126744 0 0.0
.data 1864 1864 0 0.0
.text 833456 833456 0 0.0
BRD4161A+rpc (read only) 821052 821052 0 0.0
(read/write) 145284 145284 0 0.0
.bss 143320 143320 0 0.0
.data 1964 1964 0 0.0
.text 821044 821044 0 0.0
window-app BRD4161A (read only) 810688 810688 0 0.0
(read/write) 127560 127560 0 0.0
.bss 125728 125728 0 0.0
.data 1828 1828 0 0.0
.text 810680 810680 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 687400 687400 0 0.0
.bss 79328 79328 0 0.0
.data 1896 1896 0 0.0
.text 600376 600376 0 0.0
lock-app k32w061+debug (read/write) 637324 637324 0 0.0
.bss 77480 77480 0 0.0
.data 1856 1856 0 0.0
.text 552188 552188 0 0.0
shell k32w061+debug (read/write) 642728 642728 0 0.0
.bss 79788 79788 0 0.0
.data 1836 1836 0 0.0
.text 555304 555304 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6880588 6880588 0 0.0
(read/write) 323585 323585 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208880 208880 0 0.0
.dynamic 560 560 0 0.0
.got 53776 53776 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366140 366140 0 0.0
.text 5832148 5832148 0 0.0
thermostat-no-ble arm64 (read only) 1998508 1998508 0 0.0
(read/write) 145073 145073 0 0.0
.bss 65601 65601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 127852 127852 0 0.0
.text 1659328 1659328 0 0.0
p6 all-clusters-app default (read/write) 2387432 2387432 0 0.0
.bss 118516 118516 0 0.0
.data 2528 2528 0 0.0
.heap 912296 912296 0 0.0
.text 1345696 1345696 0 0.0
light-app default (read/write) 2327792 2327792 0 0.0
.bss 107432 107432 0 0.0
.data 2368 2368 0 0.0
.heap 923544 923544 0 0.0
.text 1286056 1286056 0 0.0
lock-app default (read/write) 2303856 2303856 0 0.0
.bss 106312 106312 0 0.0
.data 2336 2336 0 0.0
.heap 924696 924696 0 0.0
.text 1262120 1262120 0 0.0
qpg lighting-app qpg6105+debug (read only) 532120 532120 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88080 88080 0 0.0
.data 992 992 0 0.0
.text 526800 526800 0 0.0
lock-app qpg6105+debug (read only) 506464 506464 0 0.0
(read/write) 146936 146936 0 0.0
.bss 87216 87216 0 0.0
.data 948 948 0 0.0
.text 501144 501144 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832126 832126 0 0.0
bss 88320 88320 0 0.0
noinit 37160 37160 0 0.0
text 579914 579914 0 0.0

@andy31415 andy31415 merged commit 2b189f3 into project-chip:master Dec 14, 2021
@andy31415 andy31415 deleted the fix_esp_checkouts branch June 14, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review integrations review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants