Feature/door lock cluster phase 1 #12989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
…ssing attribute setters' retcode. 2. Implemented empty DoorLockServer methods to set appropriate attributes in the same manner.
…n portable ones from inttypes.h (to prevent printf size mismatch on different platforms)
truebiker
force-pushed
the
feature/door-lock-cluster-phase-1
branch
from
b17881e to
1def357
Compare
|
PR #12989: Size comparison from a9b9fca to 1def357 Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #12989: Size comparison from bf7feea to 9fc77bd Full report (9 builds for efr32, k32w, qpg, telink)
|
|
PR #12989: Size comparison from bf7feea to fce3776 Increases (2 builds for mbed, p6)
Full report (29 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
reviewed
Dec 21, 2021
jmeg-sfy
reviewed
Dec 21, 2021
jmeg-sfy
approved these changes
Dec 21, 2021
|
PR #12989: Size comparison from 9a80f75 to 0bf3e1a Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jrhees-cae
reviewed
Dec 22, 2021
|
PR #12989: Size comparison from 3a617aa to 2afbad9 Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #12989: Size comparison from 83b2f46 to fba5f79 Increases (4 builds for esp32, mbed, p6)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jrhees-cae
approved these changes
Dec 28, 2021
selissia
approved these changes
Dec 28, 2021
lmpprk
pushed a commit
to lmpprk/connectedhomeip
that referenced
this pull request
Dec 29, 2021
* Added support for all server-side attributes except those marked as 'nice-to-have'. 1. ZAP generator extended to generate pre attribute change callback for Door Lock cluster. 2. Door Lock cluster defines list of attribute change callbacks to be implemented by user and proxies pre attribute change request to the user app. * Added pre-change trap for all unhandled cluster attributes * Update autogenerated files * Fixed restyled-io notes * Fixed CR note (invalid usage of language attribute string) * Fixed CR notes * Fixed return values for pre-attribute change callbacks to make Darwin tests pass. * 1. Fixed bug in DoorLockServer methods: wrong type was used for processing attribute setters' retcode. 2. Implemented empty DoorLockServer methods to set appropriate attributes in the same manner. * Fixed build issue on Infineon: substituted printf type modificators on portable ones from inttypes.h (to prevent printf size mismatch on different platforms) * Fixed arguments in DoorState and LockState accessors * Used chip::to_underlying instead of static_cast for Door Lock enum parameters * Fix CR note: added size sanity checks for all cluster attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Door Lock cluster implementation phase 1: essential attributes support.
Change overview
Testing
How was this tested? (at least one bullet point required)