Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookup SubjectDescriptor in CommandHandler #12953

Merged
merged 10 commits into from
Jan 14, 2022
Merged

Hookup SubjectDescriptor in CommandHandler #12953

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8d7bcf3
Hookup SubjectDescriptor in CommandHandler
mlepage-google Dec 13, 2021
69a4704
Non-functional syntax change
mlepage-google Dec 13, 2021
fae0387
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Dec 14, 2021
aaf1632
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Jan 4, 2022
74b46bd
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Jan 7, 2022
718acac
Fix merge conflict
mlepage-google Jan 7, 2022
4787bb0
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Jan 12, 2022
29582bd
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Jan 13, 2022
ebf5202
Improve unit tests for command interaction
mlepage-google Jan 13, 2022
a10fa63
Merge branch 'master' into subject-descriptor-in-command-handler
mlepage-google Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/CommandHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ CHIP_ERROR CommandHandler::ProcessCommandDataIB(CommandDataIB::Parser & aCommand
VerifyOrExit(mpCallback->CommandExists(concretePath), err = CHIP_ERROR_INVALID_PROFILE_ID);

{
Access::SubjectDescriptor subjectDescriptor; // TODO: get actual subject descriptor
if (mpExchangeCtx == nullptr || !mpExchangeCtx->HasSessionHandle())
{
// No exchange context or session handle means no subject descriptor so cannot check access control
return AddStatus(concretePath, Protocols::InteractionModel::Status::Failure);
}
Access::SubjectDescriptor subjectDescriptor = mpExchangeCtx->GetSessionHandle()->GetSubjectDescriptor();
Access::RequestPath requestPath{ .cluster = concretePath.mClusterId, .endpoint = concretePath.mEndpointId };
Access::Privilege requestPrivilege = Access::Privilege::kOperate; // TODO: get actual request privilege
err = Access::GetAccessControl().Check(subjectDescriptor, requestPath, requestPrivilege);
Expand Down