Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the SystemStats part of TestInetEndPointLimit #12946

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Fix the SystemStats part of TestInetEndPointLimit #12946

merged 2 commits into from
Dec 13, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

The newly added ‘fake’ platform was the first to actually run with both
a static EndPoint pool and SystemStats enabled, and revealed that the
newly added stats test was incorrect.

Change overview

Fix the stats checks.

Testing

CI (passes in fork)

@kpschoedel
Fix the SystemStats part of TestInetEndPointLimit
ae0cbc2 
#### Problem

The newly added ‘fake’ platform was the first to actually run with both
a static EndPoint pool and SystemStats enabled, and revealed that the
newly added stats test was incorrect.

#### Change overview

Fix the stats checks.

#### Testing

Run locally on fake platform.
@boring-cyborg boring-cyborg bot added the inet label Dec 13, 2021
@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12946: Size comparison from 73776ef to ae0cbc2

Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 73776ef ae0cbc2 change % change
efr32 lighting-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 123152 123152 0 0.0
.bss 121288 121288 0 0.0
.data 1864 1864 0 0.0
.text 815940 815940 0 0.0
BRD4161A+rpc (read only) 803580 803580 0 0.0
(read/write) 139828 139828 0 0.0
.bss 137864 137864 0 0.0
.data 1964 1964 0 0.0
.text 803572 803572 0 0.0
window-app BRD4161A (read only) 793008 793008 0 0.0
(read/write) 122104 122104 0 0.0
.bss 120272 120272 0 0.0
.data 1828 1828 0 0.0
.text 793000 793000 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670408 0 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588840 0 0.0
lock-app k32w061+debug (read/write) 620344 620344 0 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540664 0 0.0
shell k32w061+debug (read/write) 625712 625712 0 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873564 0 0.0
(read/write) 319201 319201 0 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208784 0 0.0
.dynamic 560 560 0 0.0
.got 53576 53576 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 365692 0 0.0
.text 5826788 5826788 0 0.0
thermostat-no-ble arm64 (read only) 1954660 1954660 0 0.0
(read/write) 137537 137537 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70600 70600 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620512 1620512 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314032 2314032 0 0.0
.bss 183964 183964 0 0.0
.data 5240 5240 0 0.0
.heap 847240 847240 0 0.0
.text 1276608 1276608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2309888 0 0.0
.bss 175824 175824 0 0.0
.data 5536 5536 0 0.0
.heap 855088 855088 0 0.0
.text 1272488 1272488 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2283000 0 0.0
.bss 174864 174864 0 0.0
.data 5528 5528 0 0.0
.heap 856056 856056 0 0.0
.text 1245600 1245600 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
p6 all-clusters-app default (read/write) 2360976 2360976 0 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319240 1319240 0 0.0
light-app default (read/write) 2301568 2301568 0 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1259832 0 0.0
lock-app default (read/write) 2277640 2277640 0 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1235904 0 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522160 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516840 0 0.0
lock-app qpg6100+debug (read only) 496532 496532 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491212 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812262 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567218 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12946: Size comparison from 73776ef to 750580e

Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 73776ef 750580e change % change
efr32 lighting-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 123152 123152 0 0.0
.bss 121288 121288 0 0.0
.data 1864 1864 0 0.0
.text 815940 815940 0 0.0
BRD4161A+rpc (read only) 803580 803580 0 0.0
(read/write) 139828 139828 0 0.0
.bss 137864 137864 0 0.0
.data 1964 1964 0 0.0
.text 803572 803572 0 0.0
window-app BRD4161A (read only) 793008 793008 0 0.0
(read/write) 122104 122104 0 0.0
.bss 120272 120272 0 0.0
.data 1828 1828 0 0.0
.text 793000 793000 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670408 0 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588840 0 0.0
lock-app k32w061+debug (read/write) 620344 620344 0 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540664 0 0.0
shell k32w061+debug (read/write) 625712 625712 0 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873564 0 0.0
(read/write) 319201 319201 0 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208784 0 0.0
.dynamic 560 560 0 0.0
.got 53576 53576 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 365692 0 0.0
.text 5826788 5826788 0 0.0
thermostat-no-ble arm64 (read only) 1954660 1954660 0 0.0
(read/write) 137537 137537 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70600 70600 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620512 1620512 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314032 2314032 0 0.0
.bss 183964 183964 0 0.0
.data 5240 5240 0 0.0
.heap 847240 847240 0 0.0
.text 1276608 1276608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2309888 0 0.0
.bss 175824 175824 0 0.0
.data 5536 5536 0 0.0
.heap 855088 855088 0 0.0
.text 1272488 1272488 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2283000 0 0.0
.bss 174864 174864 0 0.0
.data 5528 5528 0 0.0
.heap 856056 856056 0 0.0
.text 1245600 1245600 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
p6 all-clusters-app default (read/write) 2360976 2360976 0 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319240 1319240 0 0.0
light-app default (read/write) 2301568 2301568 0 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1259832 0 0.0
lock-app default (read/write) 2277640 2277640 0 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1235904 0 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522160 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516840 0 0.0
lock-app qpg6100+debug (read only) 496532 496532 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491212 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812262 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567218 0 0.0

@andy31415
Copy link
Contributor

fast track: unit test update

@andy31415 andy31415 merged commit 2141a14 into project-chip:master Dec 13, 2021
@kpschoedel kpschoedel deleted the x7715-test-fake branch December 13, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track inet review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpschoedel @andy31415