-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Data Provider: Listener added. #12936
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_data_provider_listener
Dec 15, 2021
Merged
Group Data Provider: Listener added. #12936
jepenven-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_data_provider_listener
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst and
selissia
December 13, 2021 11:26
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 13, 2021 11:26
PR #12936: Size comparison from c3572d4 to c8aff44 Increases (23 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_data_provider_listener
branch
from
December 13, 2021 13:58
c8aff44
to
abee2b1
Compare
PR #12936: Size comparison from c3572d4 to abee2b1 Increases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Dec 13, 2021
andy31415
reviewed
Dec 13, 2021
woody-apple
approved these changes
Dec 13, 2021
rcasallas-silabs
force-pushed
the
group_data_provider_listener
branch
from
December 13, 2021 16:48
abee2b1
to
e363dfc
Compare
PR #12936: Size comparison from 73776ef to e363dfc Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_data_provider_listener
branch
from
December 14, 2021 09:21
e363dfc
to
f739bac
Compare
PR #12936: Size comparison from c8027a5 to f739bac Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 14, 2021
rcasallas-silabs
force-pushed
the
group_data_provider_listener
branch
from
December 15, 2021 09:31
f739bac
to
c78adca
Compare
PR #12936: Size comparison from c52bc7b to c78adca Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_data_provider_listener
branch
from
December 15, 2021 14:23
c78adca
to
64f1b5f
Compare
PR #12936: Size comparison from 6afd51d to 64f1b5f Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The group data provider is missing a listener to detect new and removed groups.
Change overview
Testing
Unit tests pass successfully.