Ios custom flow #12920
Merged
Ios custom flow #12920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outbound work flow
lijujayakumar
suggested changes
Dec 11, 2021
src/darwin/CHIPTool/CHIPTool/View Controllers/Custom Flow/CustomFlowViewController.m
Outdated
Show resolved
Hide resolved
src/darwin/CHIPTool/CHIPTool/View Controllers/Custom Flow/CustomFlowViewController.m
Outdated
Show resolved
Hide resolved
src/darwin/CHIPTool/CHIPTool/View Controllers/Custom Flow/CustomFlowViewController.m
Outdated
Show resolved
Hide resolved
src/darwin/CHIPTool/CHIPTool/View Controllers/RootViewController.m
Outdated
Show resolved
Hide resolved
Xiole-KKE
commented
Dec 11, 2021
src/darwin/CHIPTool/CHIPTool/View Controllers/QRCode/QRCodeViewController.m
Show resolved
Hide resolved
demo.mp4 |
CommissioningCustomFlowUseMockFlag = 1, use mock respond CommissioningCustomFlowUseMockFlag = 0, use api respond
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple and
Byungjoo-Lee
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
src/darwin/CHIPTool/CHIPTool/View Controllers/QRCode/QRCodeViewController.m
Outdated
Show resolved
Hide resolved
lijujayakumar
approved these changes
Dec 17, 2021
chrisdecenzo
approved these changes
Dec 17, 2021
yunhanw-google
approved these changes
Dec 20, 2021
|
Is there corresponding android custom commissioning flow implemented as well? Thanks |
Yes, #12712 is one of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds Custom Commissioning Flow to iOS CHIP Tool
Change overview
New pages for Custom Commissioning Flow. Adds customflow:// as URL specifier for CHIPTool and corresponding handler.
The specific handling is not implemented yet.
Testing
How was this tested? (at least one bullet point required)
Tested on iPhone X
Demo
demo.mp4