Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ContentLauncher commands from tv-casting-app to tv-app #12913

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Send ContentLauncher commands from tv-casting-app to tv-app #12913

merged 3 commits into from
Dec 20, 2021

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented Dec 10, 2021 •
edited
Loading

Problem

  • tv-casting-app needs to be able to send ContentLaucher commands to the tv-app after commissioning completes.

Change overview

What's in this PR

  • Updates to the tv-casting-app.zap and zzz generated files (Most of this PR is generated code. All the generated code is separated into the first commit: 66fcad3)
  • Updates to tv-casting-app main to actually send LaunchURL commands to the tv-app

Testing

Tested that the tv-casting-app is able to send ContentLauncher.LaunchURL with test data to the tv-app. See tv-casting-app logs below:

[1639166929.632388][94996:94996] CHIP:DMG: ICR moving to [AddingComm]
[1639166929.632402][94996:94996] CHIP:DMG: ICR moving to [AddedComma]
[1639166929.632448][94996:94996] CHIP:IN: Prepared encrypted message 0x55ee2575ebb0 to 0xFFFFFFFEFFFFFFFF (1) of type 0x8 and protocolId (0, 1) on exchange 1129i with MessageCounter:983433.
[1639166929.632481][94996:94996] CHIP:IN: Sending encrypted msg 0x55ee2575ebb0 with MessageCounter:983433 to 0xFFFFFFFEFFFFFFFF (1) at monotonic time: 703187783 msec
[1639166929.632553][94996:94996] CHIP:DMG: ICR moving to [CommandSen]
[1639166929.632751][94996:94996] CHIP:EM: Received message of type 0x10 with protocolId (0, 0) and MessageCounter:13510908 on exchange 6229r
[1639166929.632765][94996:94996] CHIP:EM: Found matching exchange: 6229r, Delegate: (nil)
[1639166929.632791][94996:94996] CHIP:EM: Rxd Ack; Removing MessageCounter:983432 from Retrans Table on exchange 6229r
[1639166929.632803][94996:94996] CHIP:EM: Removed CHIP MessageCounter:983432 from RetransTable on exchange 6229r
[1639166929.698344][94996:94996] CHIP:EM: Received message of type 0x9 with protocolId (0, 1) and MessageCounter:13510909 on exchange 1129i
[1639166929.698481][94996:94996] CHIP:EM: Found matching exchange: 1129i, Delegate: 0x55ee271b1640
[1639166929.698708][94996:94996] CHIP:EM: Rxd Ack; Removing MessageCounter:983433 from Retrans Table on exchange 1129i
[1639166929.698726][94996:94996] CHIP:EM: Removed CHIP MessageCounter:983433 from RetransTable on exchange 1129i
[1639166929.698796][94996:94996] CHIP:DMG: ICR moving to [ResponseRe]
[1639166929.698831][94996:94996] CHIP:DMG: InvokeResponseMessage =
[1639166929.698847][94996:94996] CHIP:DMG: {
[1639166929.698863][94996:94996] CHIP:DMG: suppressResponse = false,
[1639166929.698878][94996:94996] CHIP:DMG: InvokeResponseIBs =
[1639166929.698897][94996:94996] CHIP:DMG: [
[1639166929.698912][94996:94996] CHIP:DMG: InvokeResponseIB =
[1639166929.698931][94996:94996] CHIP:DMG: {
[1639166929.698946][94996:94996] CHIP:DMG: CommandDataIB =
[1639166929.698963][94996:94996] CHIP:DMG: {
[1639166929.698979][94996:94996] CHIP:DMG: CommandPathIB =
[1639166929.698999][94996:94996] CHIP:DMG: {
[1639166929.699017][94996:94996] CHIP:DMG: EndpointId = 0x1,
[1639166929.699034][94996:94996] CHIP:DMG: ClusterId = 0x50a,
[1639166929.699051][94996:94996] CHIP:DMG: CommandId = 0x1,
[1639166929.699109][94996:94996] CHIP:DMG: },
[1639166929.704464][94996:94996] CHIP:DMG:
[1639166929.704482][94996:94996] CHIP:DMG: CommandData =
[1639166929.704495][94996:94996] CHIP:DMG: {
[1639166929.704502][94996:94996] CHIP:DMG: 0x0 = "Example data",
[1639166929.705344][94996:94996] CHIP:DMG: 0x1 = 0,
[1639166929.705409][94996:94996] CHIP:DMG: },
[1639166929.705422][94996:94996] CHIP:DMG: },
[1639166929.705438][94996:94996] CHIP:DMG:
[1639166929.705450][94996:94996] CHIP:DMG: },
[1639166929.705465][94996:94996] CHIP:DMG:
[1639166929.705477][94996:94996] CHIP:DMG: ],
[1639166929.705491][94996:94996] CHIP:DMG:
[1639166929.705502][94996:94996] CHIP:DMG: },
[1639166929.705529][94996:94996] CHIP:DMG: Received Command Response Data, Endpoint=1 Cluster=0x0000_050A Command=0x0000_0001
[1639166929.705547][94996:94996] CHIP:ZCL: LaunchURLResponse:
[1639166929.705559][94996:94996] CHIP:ZCL: data: Example data
[1639166929.705570][94996:94996] CHIP:ZCL: contentLaunchStatus: 0
[1639166929.705583][94996:94996] CHIP:SVR: ContentLauncher: Default Success Response
[1639166929.705600][94996:94996] CHIP:DMG: ICR moving to [AwaitingDe]
[1639166929.705614][94996:94996] CHIP:EM: Sending Standalone Ack for MessageCounter:13510909 on exchange 1129i
[1639166929.705647][94996:94996] CHIP:IN: Prepared encrypted message 0x7fff993d2460 to 0xFFFFFFFEFFFFFFFF (1) of type 0x10 and protocolId (0, 0) on exchange 1129i with MessageCounter:983434.
[1639166929.705682][94996:94996] CHIP:IN: Sending encrypted msg 0x7fff993d2460 with MessageCounter:983434 to 0xFFFFFFFEFFFFFFFF (1) at monotonic time: 703187856 msec
[1639166929.705746][94996:94996] CHIP:EM: Flushed pending ack for MessageCounter:13510909 on exchange 1129i

bzbarsky-apple
bzbarsky-apple requested changes Dec 11, 2021
View reviewed changes
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
examples/tv-casting-app/linux/main.cpp Show resolved Hide resolved
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
src/app/OperationalDeviceProxy.cpp Show resolved Hide resolved
src/app/OperationalDeviceProxy.h Show resolved Hide resolved
@sharadb-amazon sharadb-amazon force-pushed the content-launcher-120721 branch 2 times, most recently from 0d6a8be to 9da1a3a Compare December 14, 2021 00:53
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12913: Size comparison from 5d10320 to 9da1a3a

Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 9da1a3a change % change
efr32 lighting-app BRD4161A (read only) 815676 815836 160 0.0
(read/write) 123208 123224 16 0.0
.bss 121344 121360 16 0.0
.text 815668 815828 160 0.0
BRD4161A+rpc (read only) 803292 803452 160 0.0
(read/write) 139884 139900 16 0.0
.bss 137920 137936 16 0.0
.text 803284 803444 160 0.0
window-app BRD4161A (read only) 792752 792912 160 0.0
(read/write) 122160 122176 16 0.0
.bss 120328 120344 16 0.0
.text 792744 792904 160 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856780 98 0.0
(read/write) 1304650 1304666 16 0.0
.dram0.bss 64752 64768 16 0.0
.flash.text 856682 856780 98 0.0
m5stack (read only) 960783 960863 80 0.0
(read/write) 450468 450484 16 0.0
.dram0.bss 74040 74056 16 0.0
.flash.text 955399 955479 80 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670208 96 0.0
.bss 73928 73944 16 0.0
.text 588488 588568 80 0.0
lock-app k32w061+debug (read/write) 620048 620136 88 0.0
.bss 72080 72088 8 0.0
.text 540312 540392 80 0.0
shell k32w061+debug (read/write) 625416 625504 88 0.0
.bss 74388 74396 8 0.0
.text 543392 543472 80 0.0
linux thermostat-no-ble arm64 (read only) 1952452 1952612 160 0.0
(read/write) 137681 137697 16 0.0
.bss 59537 59553 16 0.0
.text 1618336 1618496 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313720 2313784 64 0.0
.bss 184020 184028 8 0.0
.text 1276296 1276360 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309576 2309640 64 0.0
.bss 175880 175888 8 0.0
.text 1272176 1272240 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282688 2282752 64 0.0
.bss 174920 174928 8 0.0
.text 1245288 1245352 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907531 112 0.0
bss 116352 116368 16 0.0
text 613272 613344 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870575 96 0.0
bss 112700 112716 16 0.0
text 588012 588080 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833534 112 0.0
bss 117728 117740 12 0.0
text 543696 543764 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880147 64 0.0
bss 113616 113628 12 0.0
text 592708 592780 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806386 64 0.0
bss 115024 115040 16 0.0
text 523224 523292 68 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885131 112 0.0
bss 113528 113544 16 0.0
text 596312 596380 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878339 112 0.0
bss 113404 113420 16 0.0
text 591508 591580 72 0.0
p6 all-clusters-app default (read/write) 2360712 2360856 144 0.0
.bss 112220 112236 16 0.0
.text 1318976 1319120 144 0.0
light-app default (read/write) 2301288 2301448 160 0.0
.bss 101136 101152 16 0.0
.text 1259552 1259712 160 0.0
lock-app default (read/write) 2277376 2277536 160 0.0
.bss 100016 100032 16 0.0
.text 1235640 1235800 160 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521904 64 0.0
.bss 82768 82776 8 0.0
.text 516520 516584 64 0.0
lock-app qpg6100+debug (read only) 496204 496268 64 0.0
.bss 81904 81912 8 0.0
.text 490884 490948 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812078 112 0.0
bss 82920 82936 16 0.0
text 566724 566818 94 0.0
Decreases (6 builds for mbed, p6)
platform target config section 5d10320 9da1a3a change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 847184 847176 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855032 855024 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856008 856000 -8 -0.0
p6 all-clusters-app default .heap 918592 918576 -16 -0.0
light-app default .heap 929840 929824 -16 -0.0
lock-app default .heap 931000 930984 -16 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 9da1a3a change % change
efr32 lighting-app BRD4161A (read only) 815676 815836 160 0.0
(read/write) 123208 123224 16 0.0
.bss 121344 121360 16 0.0
.data 1864 1864 0 0.0
.text 815668 815828 160 0.0
BRD4161A+rpc (read only) 803292 803452 160 0.0
(read/write) 139884 139900 16 0.0
.bss 137920 137936 16 0.0
.data 1964 1964 0 0.0
.text 803284 803444 160 0.0
window-app BRD4161A (read only) 792752 792912 160 0.0
(read/write) 122160 122176 16 0.0
.bss 120328 120344 16 0.0
.data 1828 1828 0 0.0
.text 792744 792904 160 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856780 98 0.0
(read/write) 1304650 1304666 16 0.0
.dram0.bss 64752 64768 16 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 856682 856780 98 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960783 960863 80 0.0
(read/write) 450468 450484 16 0.0
.dram0.bss 74040 74056 16 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210592 0 0.0
.flash.text 955399 955479 80 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670208 96 0.0
.bss 73928 73944 16 0.0
.data 1896 1896 0 0.0
.text 588488 588568 80 0.0
lock-app k32w061+debug (read/write) 620048 620136 88 0.0
.bss 72080 72088 8 0.0
.data 1856 1856 0 0.0
.text 540312 540392 80 0.0
shell k32w061+debug (read/write) 625416 625504 88 0.0
.bss 74388 74396 8 0.0
.data 1836 1836 0 0.0
.text 543392 543472 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6876732 0 0.0
(read/write) 319281 319281 0 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208760 0 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366092 0 0.0
.text 5828772 5828772 0 0.0
thermostat-no-ble arm64 (read only) 1952452 1952612 160 0.0
(read/write) 137681 137697 16 0.0
.bss 59537 59553 16 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125764 0 0.0
.text 1618336 1618496 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313720 2313784 64 0.0
.bss 184020 184028 8 0.0
.data 5240 5240 0 0.0
.heap 847184 847176 -8 -0.0
.text 1276296 1276360 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309576 2309640 64 0.0
.bss 175880 175888 8 0.0
.data 5536 5536 0 0.0
.heap 855032 855024 -8 -0.0
.text 1272176 1272240 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282688 2282752 64 0.0
.bss 174920 174928 8 0.0
.data 5520 5520 0 0.0
.heap 856008 856000 -8 -0.0
.text 1245288 1245352 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907531 112 0.0
bss 116352 116368 16 0.0
rodata 102220 102220 0 0.0
text 613272 613344 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870575 96 0.0
bss 112700 112716 16 0.0
rodata 93520 93520 0 0.0
text 588012 588080 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833534 112 0.0
bss 117728 117740 12 0.0
rodata 97480 97480 0 0.0
text 543696 543764 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880147 64 0.0
bss 113616 113628 12 0.0
rodata 98340 98340 0 0.0
text 592708 592780 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806386 64 0.0
bss 115024 115040 16 0.0
rodata 93628 93628 0 0.0
text 523224 523292 68 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885131 112 0.0
bss 113528 113544 16 0.0
rodata 99692 99692 0 0.0
text 596312 596380 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878339 112 0.0
bss 113404 113420 16 0.0
rodata 97828 97828 0 0.0
text 591508 591580 72 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2360712 2360856 144 0.0
.bss 112220 112236 16 0.0
.data 2528 2528 0 0.0
.heap 918592 918576 -16 -0.0
.text 1318976 1319120 144 0.0
light-app default (read/write) 2301288 2301448 160 0.0
.bss 101136 101152 16 0.0
.data 2368 2368 0 0.0
.heap 929840 929824 -16 -0.0
.text 1259552 1259712 160 0.0
lock-app default (read/write) 2277376 2277536 160 0.0
.bss 100016 100032 16 0.0
.data 2328 2328 0 0.0
.heap 931000 930984 -16 -0.0
.text 1235640 1235800 160 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521904 64 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82776 8 0.0
.data 996 996 0 0.0
.text 516520 516584 64 0.0
lock-app qpg6100+debug (read only) 496204 496268 64 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81912 8 0.0
.data 952 952 0 0.0
.text 490884 490948 64 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812078 112 0.0
bss 82920 82936 16 0.0
noinit 37160 37160 0 0.0
text 566724 566818 94 0.0

@sharadb-amazon sharadb-amazon force-pushed the content-launcher-120721 branch 2 times, most recently from 6603846 to 6cd6e79 Compare December 15, 2021 18:33
@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12913: Size comparison from a525e63 to 6cd6e79

Increases (10 builds for k32w, linux, p6, qpg, telink)
platform target config section a525e63b 6cd6e79 change % change
k32w lighting-app k32w061+se05x+release (read/write) 688772 688852 80 0.0
.bss 79344 79360 16 0.0
.text 601728 601792 64 0.0
lock-app k32w061+debug (read/write) 638712 638784 72 0.0
.bss 77496 77504 8 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644188 88 0.0
.bss 79804 79812 8 0.0
.text 556656 556736 80 0.0
linux thermostat-no-ble arm64 (read only) 2008172 2008332 160 0.0
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.text 1668624 1668784 160 0.0
p6 all-clusters-app default (read/write) 2390776 2390936 160 0.0
.bss 118532 118548 16 0.0
.text 1349040 1349200 160 0.0
light-app default (read/write) 2331064 2331208 144 0.0
.bss 107448 107464 16 0.0
.text 1289328 1289472 144 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106344 16 0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 533472 533536 64 0.0
.bss 88096 88104 8 0.0
.text 528152 528216 64 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
.bss 87232 87240 8 0.0
.text 502512 502576 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 833746 833858 112 0.0
bss 88336 88352 16 0.0
text 581440 581534 94 0.0
Decreases (3 builds for p6)
platform target config section a525e63b 6cd6e79 change % change
p6 all-clusters-app default .heap 912272 912256 -16 -0.0
light-app default .heap 923520 923504 -16 -0.0
lock-app default .heap 924680 924664 -16 -0.0
Full report (12 builds for k32w, linux, p6, qpg, telink)
platform target config section a525e63b 6cd6e79 change % change
k32w lighting-app k32w061+se05x+release (read/write) 688772 688852 80 0.0
.bss 79344 79360 16 0.0
.data 1900 1900 0 0.0
.text 601728 601792 64 0.0
lock-app k32w061+debug (read/write) 638712 638784 72 0.0
.bss 77496 77504 8 0.0
.data 1860 1860 0 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644188 88 0.0
.bss 79804 79812 8 0.0
.data 1840 1840 0 0.0
.text 556656 556736 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6979268 6979268 0 0.0
(read/write) 324593 324593 0 0.0
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 55512 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376308 376308 0 0.0
.text 5916916 5916916 0 0.0
thermostat-no-ble arm64 (read only) 2008172 2008332 160 0.0
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1668624 1668784 160 0.0
p6 all-clusters-app default (read/write) 2390776 2390936 160 0.0
.bss 118532 118548 16 0.0
.data 2536 2536 0 0.0
.heap 912272 912256 -16 -0.0
.text 1349040 1349200 160 0.0
light-app default (read/write) 2331064 2331208 144 0.0
.bss 107448 107464 16 0.0
.data 2376 2376 0 0.0
.heap 923520 923504 -16 -0.0
.text 1289328 1289472 144 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106344 16 0.0
.data 2336 2336 0 0.0
.heap 924680 924664 -16 -0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 533472 533536 64 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88104 8 0.0
.data 996 996 0 0.0
.text 528152 528216 64 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87240 8 0.0
.data 952 952 0 0.0
.text 502512 502576 64 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833746 833858 112 0.0
bss 88336 88352 16 0.0
noinit 37160 37160 0 0.0
text 581440 581534 94 0.0

@sharadb-amazon sharadb-amazon force-pushed the content-launcher-120721 branch from 6cd6e79 to d461885 Compare December 15, 2021 19:08
@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12913: Size comparison from a525e63 to d461885

Increases (10 builds for k32w, linux, p6, qpg, telink)
platform target config section a525e63b d461885 change % change
k32w lighting-app k32w061+se05x+release (read/write) 688772 688852 80 0.0
.bss 79344 79360 16 0.0
.text 601728 601792 64 0.0
lock-app k32w061+debug (read/write) 638712 638784 72 0.0
.bss 77496 77504 8 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644188 88 0.0
.bss 79804 79812 8 0.0
.text 556656 556736 80 0.0
linux thermostat-no-ble arm64 (read only) 2008172 2008332 160 0.0
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.text 1668624 1668784 160 0.0
p6 all-clusters-app default (read/write) 2390776 2390936 160 0.0
.bss 118532 118548 16 0.0
.text 1349040 1349200 160 0.0
light-app default (read/write) 2331064 2331208 144 0.0
.bss 107448 107464 16 0.0
.text 1289328 1289472 144 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106344 16 0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 533472 533536 64 0.0
.bss 88096 88104 8 0.0
.text 528152 528216 64 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
.bss 87232 87240 8 0.0
.text 502512 502576 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 833746 833858 112 0.0
bss 88336 88352 16 0.0
text 581440 581534 94 0.0
Decreases (3 builds for p6)
platform target config section a525e63b d461885 change % change
p6 all-clusters-app default .heap 912272 912256 -16 -0.0
light-app default .heap 923520 923504 -16 -0.0
lock-app default .heap 924680 924664 -16 -0.0
Full report (12 builds for k32w, linux, p6, qpg, telink)
platform target config section a525e63b d461885 change % change
k32w lighting-app k32w061+se05x+release (read/write) 688772 688852 80 0.0
.bss 79344 79360 16 0.0
.data 1900 1900 0 0.0
.text 601728 601792 64 0.0
lock-app k32w061+debug (read/write) 638712 638784 72 0.0
.bss 77496 77504 8 0.0
.data 1860 1860 0 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644188 88 0.0
.bss 79804 79812 8 0.0
.data 1840 1840 0 0.0
.text 556656 556736 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6979268 6979268 0 0.0
(read/write) 324593 324593 0 0.0
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 55512 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376308 376308 0 0.0
.text 5916916 5916916 0 0.0
thermostat-no-ble arm64 (read only) 2008172 2008332 160 0.0
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1668624 1668784 160 0.0
p6 all-clusters-app default (read/write) 2390776 2390936 160 0.0
.bss 118532 118548 16 0.0
.data 2536 2536 0 0.0
.heap 912272 912256 -16 -0.0
.text 1349040 1349200 160 0.0
light-app default (read/write) 2331064 2331208 144 0.0
.bss 107448 107464 16 0.0
.data 2376 2376 0 0.0
.heap 923520 923504 -16 -0.0
.text 1289328 1289472 144 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106344 16 0.0
.data 2336 2336 0 0.0
.heap 924680 924664 -16 -0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 533472 533536 64 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88104 8 0.0
.data 996 996 0 0.0
.text 528152 528216 64 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87240 8 0.0
.data 952 952 0 0.0
.text 502512 502576 64 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833746 833858 112 0.0
bss 88336 88352 16 0.0
noinit 37160 37160 0 0.0
text 581440 581534 94 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12913: Size comparison from 89aff25 to 243eec9

Increases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 89aff25 243eec9 change % change
efr32 lighting-app BRD4161A (read only) 840592 840752 160 0.0
(read/write) 128640 128664 24 0.0
.bss 126760 126784 24 0.0
.text 840584 840744 160 0.0
BRD4161A+rpc (read only) 828196 828340 144 0.0
(read/write) 145312 145336 24 0.0
.bss 143336 143360 24 0.0
.text 828188 828332 144 0.0
window-app BRD4161A (read only) 813968 814128 160 0.0
(read/write) 127576 127600 24 0.0
.bss 125744 125768 24 0.0
.text 813960 814120 160 0.0
k32w lighting-app k32w061+se05x+release (read/write) 691148 691236 88 0.0
.bss 79344 79368 24 0.0
.text 604096 604160 64 0.0
lock-app k32w061+debug (read/write) 638712 638792 80 0.0
.bss 77496 77512 16 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644196 96 0.0
.bss 79804 79820 16 0.0
.text 556656 556736 80 0.0
linux chip-tool-ipv6only arm64 (read/write) 324609 324625 16 0.0
.bss 55905 55921 16 0.0
thermostat-no-ble arm64 (read only) 2008724 2008884 160 0.0
(read/write) 145297 145313 16 0.0
.bss 65649 65665 16 0.0
.text 1669120 1669280 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2338816 2338880 64 0.0
.bss 190332 190348 16 0.0
.text 1301392 1301456 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334320 2334448 128 0.0
.bss 182192 182208 16 0.0
.text 1296920 1297048 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307416 2307480 64 0.0
.bss 181232 181248 16 0.0
.text 1270016 1270080 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 927055 927119 64 0.0
bss 119852 119872 20 0.0
text 627160 627232 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 890095 890159 64 0.0
bss 116204 116224 20 0.0
text 601900 601968 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853062 853126 64 0.0
bss 121228 121248 20 0.0
text 557600 557668 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 899107 899203 96 0.0
bss 119032 119052 20 0.0
text 604928 605000 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825366 825462 96 0.0
bss 120440 120460 20 0.0
text 535460 535528 68 0.0
pump-app nrf52840dk_nrf52840 (read/write) 904047 904159 112 0.0
bss 118944 118964 20 0.0
text 608532 608600 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 897287 897367 80 0.0
bss 118824 118844 20 0.0
text 603728 603800 72 0.0
p6 all-clusters-app default (read/write) 2394600 2394744 144 0.0
.bss 118532 118556 24 0.0
.text 1352864 1353008 144 0.0
light-app default (read/write) 2334912 2335072 160 0.0
.bss 107448 107472 24 0.0
.text 1293176 1293336 160 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106352 24 0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 536144 536224 80 0.0
.bss 88096 88112 16 0.0
.text 530824 530904 80 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
.bss 87232 87248 16 0.0
.text 502512 502576 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 836574 836702 128 0.0
bss 88336 88360 24 0.0
text 583428 583522 94 0.0
Decreases (6 builds for mbed, p6)
platform target config section 89aff25 243eec9 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 840856 840840 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 848712 848696 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 849680 849664 -16 -0.0
p6 all-clusters-app default .heap 912272 912248 -24 -0.0
light-app default .heap 923512 923488 -24 -0.0
lock-app default .heap 924680 924656 -24 -0.0
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 89aff25 243eec9 change % change
efr32 lighting-app BRD4161A (read only) 840592 840752 160 0.0
(read/write) 128640 128664 24 0.0
.bss 126760 126784 24 0.0
.data 1876 1876 0 0.0
.text 840584 840744 160 0.0
BRD4161A+rpc (read only) 828196 828340 144 0.0
(read/write) 145312 145336 24 0.0
.bss 143336 143360 24 0.0
.data 1976 1976 0 0.0
.text 828188 828332 144 0.0
window-app BRD4161A (read only) 813968 814128 160 0.0
(read/write) 127576 127600 24 0.0
.bss 125744 125768 24 0.0
.data 1832 1832 0 0.0
.text 813960 814120 160 0.0
k32w lighting-app k32w061+se05x+release (read/write) 691148 691236 88 0.0
.bss 79344 79368 24 0.0
.data 1908 1908 0 0.0
.text 604096 604160 64 0.0
lock-app k32w061+debug (read/write) 638712 638792 80 0.0
.bss 77496 77512 16 0.0
.data 1860 1860 0 0.0
.text 553556 553620 64 0.0
shell k32w061+debug (read/write) 644100 644196 96 0.0
.bss 79804 79820 16 0.0
.data 1840 1840 0 0.0
.text 556656 556736 80 0.0
linux chip-tool-ipv6only arm64 (read only) 6979836 6979836 0 0.0
(read/write) 324609 324625 16 0.0
.bss 55905 55921 16 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55520 55520 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376348 376348 0 0.0
.text 5917428 5917428 0 0.0
thermostat-no-ble arm64 (read only) 2008724 2008884 160 0.0
(read/write) 145297 145313 16 0.0
.bss 65649 65665 16 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128068 128068 0 0.0
.text 1669120 1669280 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338816 2338880 64 0.0
.bss 190332 190348 16 0.0
.data 5256 5256 0 0.0
.heap 840856 840840 -16 -0.0
.text 1301392 1301456 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334320 2334448 128 0.0
.bss 182192 182208 16 0.0
.data 5544 5544 0 0.0
.heap 848712 848696 -16 -0.0
.text 1296920 1297048 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307416 2307480 64 0.0
.bss 181232 181248 16 0.0
.data 5536 5536 0 0.0
.heap 849680 849664 -16 -0.0
.text 1270016 1270080 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 927055 927119 64 0.0
bss 119852 119872 20 0.0
rodata 104424 104424 0 0.0
text 627160 627232 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 890095 890159 64 0.0
bss 116204 116224 20 0.0
rodata 95720 95720 0 0.0
text 601900 601968 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853062 853126 64 0.0
bss 121228 121248 20 0.0
rodata 99680 99680 0 0.0
text 557600 557668 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 899107 899203 96 0.0
bss 119032 119052 20 0.0
rodata 99732 99732 0 0.0
text 604928 605000 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825366 825462 96 0.0
bss 120440 120460 20 0.0
rodata 95024 95024 0 0.0
text 535460 535528 68 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 904047 904159 112 0.0
bss 118944 118964 20 0.0
rodata 101088 101088 0 0.0
text 608532 608600 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 897287 897367 80 0.0
bss 118824 118844 20 0.0
rodata 99224 99224 0 0.0
text 603728 603800 72 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2394600 2394744 144 0.0
.bss 118532 118556 24 0.0
.data 2536 2536 0 0.0
.heap 912272 912248 -24 -0.0
.text 1352864 1353008 144 0.0
light-app default (read/write) 2334912 2335072 160 0.0
.bss 107448 107472 24 0.0
.data 2384 2384 0 0.0
.heap 923512 923488 -24 -0.0
.text 1293176 1293336 160 0.0
lock-app default (read/write) 2307128 2307288 160 0.0
.bss 106328 106352 24 0.0
.data 2336 2336 0 0.0
.heap 924680 924656 -24 -0.0
.text 1265392 1265552 160 0.0
qpg lighting-app qpg6105+debug (read only) 536144 536224 80 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88112 16 0.0
.data 1004 1004 0 0.0
.text 530824 530904 80 0.0
lock-app qpg6105+debug (read only) 507832 507896 64 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87248 16 0.0
.data 952 952 0 0.0
.text 502512 502576 64 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836574 836702 128 0.0
bss 88336 88360 24 0.0
noinit 37160 37160 0 0.0
text 583428 583522 94 0.0

@sharadb-amazon sharadb-amazon force-pushed the content-launcher-120721 branch from 243eec9 to bdea82a Compare December 16, 2021 22:34
@github-actions
Copy link

github-actions bot commented Dec 16, 2021 •
edited
Loading

PR #12913: Size comparison from 2ddefed to bdea82a

Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2ddefed bdea82a change % change
efr32 lighting-app BRD4161A (read only) 829456 829616 160 0.0
(read/write) 127352 127376 24 0.0
.bss 125472 125496 24 0.0
.text 829448 829608 160 0.0
BRD4161A+rpc (read only) 817100 817260 160 0.0
(read/write) 144016 144040 24 0.0
.bss 142040 142064 24 0.0
.text 817092 817252 160 0.0
window-app BRD4161A (read only) 802864 803008 144 0.0
(read/write) 126288 126312 24 0.0
.bss 124456 124480 24 0.0
.text 802856 803000 144 0.0
esp32 all-clusters-app c3devkit (read only) 877066 877070 4 0.0
(read/write) 1313042 1313058 16 0.0
.dram0.bss 69784 69808 24 0.0
.flash.text 877066 877070 4 0.0
m5stack (read/write) 442144 442168 24 0.0
.dram0.bss 74280 74304 24 0.0
k32w light k32w061+release (read/write) 648328 648352 24 0.0
.bss 76480 76504 24 0.0
lock k32w061+release (read/write) 633044 633060 16 0.0
.bss 76200 76216 16 0.0
linux chip-tool-ipv6only arm64 (read/write) 323633 323649 16 0.0
.bss 54577 54593 16 0.0
thermostat-no-ble arm64 (read only) 1994292 1994452 160 0.0
(read/write) 143937 143953 16 0.0
.bss 64321 64337 16 0.0
.text 1654624 1654784 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 189068 189084 16 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 180896 180912 16 0.0
lock-app CY8CPROTO_062_4343W+release .bss 179944 179960 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935579 935595 16 0.0
bss 118400 118420 20 0.0
nrf52840dk_nrf52840+rpc bss 115444 115464 20 0.0
nrf5340dk_nrf5340_cpuapp bss 116684 116704 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907723 907739 16 0.0
bss 117588 117608 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831638 831654 16 0.0
bss 115900 115920 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912603 912619 16 0.0
bss 117496 117516 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905803 905819 16 0.0
bss 117376 117396 20 0.0
p6 all-clusters-app default (read/write) 2384640 2384784 144 0.0
.bss 117260 117284 24 0.0
.text 1342904 1343048 144 0.0
light-app default (read/write) 2324008 2324168 160 0.0
.bss 106152 106176 24 0.0
.text 1282272 1282432 160 0.0
lock-app default (read/write) 2296216 2296376 160 0.0
.bss 105032 105056 24 0.0
.text 1254480 1254640 160 0.0
qpg lighting-app qpg6105+debug .bss 86816 86832 16 0.0
lock-app qpg6105+debug .bss 85952 85968 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 830222 830238 16 0.0
bss 87040 87064 24 0.0
Decreases (12 builds for esp32, mbed, nrfconnect, qpg, telink)
platform target config section 2ddefed bdea82a change % change
esp32 all-clusters-app m5stack (read only) 937963 937943 -20 -0.0
.flash.text 932579 932559 -20 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2334104 2334040 -64 -0.0
.text 1296680 1296616 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 631508 631488 -20 -0.0
nrf52840dk_nrf52840+rpc text 626820 626800 -20 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859342 859326 -16 -0.0
text 558948 558932 -16 -0.0
lock-app nrf52840dk_nrf52840 text 609332 609316 -16 -0.0
nrf5340dk_nrf5340_cpuapp text 536816 536796 -20 -0.0
pump-app nrf52840dk_nrf52840 text 612884 612864 -20 -0.0
pump-controller-app nrf52840dk_nrf52840 text 608080 608064 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 531836 531828 -8 -0.0
.text 526516 526508 -8 -0.0
lock-app qpg6105+debug (read only) 503508 503500 -8 -0.0
.text 498188 498180 -8 -0.0
telink lighting-app tlsr9518adk80d text 578416 578398 -18 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2ddefed bdea82a change % change
efr32 lighting-app BRD4161A (read only) 829456 829616 160 0.0
(read/write) 127352 127376 24 0.0
.bss 125472 125496 24 0.0
.data 1876 1876 0 0.0
.text 829448 829608 160 0.0
BRD4161A+rpc (read only) 817100 817260 160 0.0
(read/write) 144016 144040 24 0.0
.bss 142040 142064 24 0.0
.data 1976 1976 0 0.0
.text 817092 817252 160 0.0
window-app BRD4161A (read only) 802864 803008 144 0.0
(read/write) 126288 126312 24 0.0
.bss 124456 124480 24 0.0
.data 1832 1832 0 0.0
.text 802856 803000 144 0.0
esp32 all-clusters-app c3devkit (read only) 877066 877070 4 0.0
(read/write) 1313042 1313058 16 0.0
.dram0.bss 69784 69808 24 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175976 175976 0 0.0
.flash.text 877066 877070 4 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 937963 937943 -20 -0.0
(read/write) 442144 442168 24 0.0
.dram0.bss 74280 74304 24 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202800 202800 0 0.0
.flash.text 932579 932559 -20 -0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648328 648352 24 0.0
.bss 76480 76504 24 0.0
.data 1904 1904 0 0.0
.text 564144 564144 0 0.0
lock k32w061+release (read/write) 633044 633060 16 0.0
.bss 76200 76216 16 0.0
.data 1860 1860 0 0.0
.text 549184 549184 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6931292 6931292 0 0.0
(read/write) 323633 323649 16 0.0
.bss 54577 54593 16 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208096 208096 0 0.0
.dynamic 560 560 0 0.0
.got 56160 56160 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 379476 379476 0 0.0
.text 5864244 5864244 0 0.0
thermostat-no-ble arm64 (read only) 1994292 1994452 160 0.0
(read/write) 143937 143953 16 0.0
.bss 64321 64337 16 0.0
.data 880 880 0 0.0
.data.rel.ro 72000 72000 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128196 128196 0 0.0
.text 1654624 1654784 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334104 2334040 -64 -0.0
.bss 189068 189084 16 0.0
.data 5264 5264 0 0.0
.text 1296680 1296616 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328616 2328616 0 0.0
.bss 180896 180912 16 0.0
.data 5544 5544 0 0.0
.text 1291216 1291216 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301712 2301712 0 0.0
.bss 179944 179960 16 0.0
.data 5536 5536 0 0.0
.text 1264312 1264312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935579 935595 16 0.0
bss 118400 118420 20 0.0
rodata 108120 108120 0 0.0
text 631508 631488 -20 -0.0
nrf52840dk_nrf52840+rpc (read/write) 921979 921979 0 0.0
bss 115444 115464 20 0.0
rodata 101536 101536 0 0.0
text 626820 626800 -20 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859342 859326 -16 -0.0
bss 116684 116704 20 0.0
rodata 103044 103044 0 0.0
text 558948 558932 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 907723 907739 16 0.0
bss 117588 117608 20 0.0
rodata 103424 103424 0 0.0
text 609332 609316 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831638 831654 16 0.0
bss 115900 115920 20 0.0
rodata 98388 98388 0 0.0
text 536816 536796 -20 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912603 912619 16 0.0
bss 117496 117516 20 0.0
rodata 104768 104768 0 0.0
text 612884 612864 -20 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905803 905819 16 0.0
bss 117376 117396 20 0.0
rodata 102896 102896 0 0.0
text 608080 608064 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2384640 2384784 144 0.0
.bss 117260 117284 24 0.0
.data 2544 2544 0 0.0
.text 1342904 1343048 144 0.0
light-app default (read/write) 2324008 2324168 160 0.0
.bss 106152 106176 24 0.0
.data 2384 2384 0 0.0
.text 1282272 1282432 160 0.0
lock-app default (read/write) 2296216 2296376 160 0.0
.bss 105032 105056 24 0.0
.data 2336 2336 0 0.0
.text 1254480 1254640 160 0.0
qpg lighting-app qpg6105+debug (read only) 531836 531828 -8 -0.0
(read/write) 146936 146936 0 0.0
.bss 86816 86832 16 0.0
.data 1004 1004 0 0.0
.text 526516 526508 -8 -0.0
lock-app qpg6105+debug (read only) 503508 503500 -8 -0.0
(read/write) 146940 146940 0 0.0
.bss 85952 85968 16 0.0
.data 952 952 0 0.0
.text 498188 498180 -8 -0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 830222 830238 16 0.0
bss 87040 87064 24 0.0
noinit 37160 37160 0 0.0
text 578416 578398 -18 -0.0

bzbarsky-apple
bzbarsky-apple approved these changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, if the documentation for SetConnectedSession is fixed to:

  1. Give some idea of when this makes sense to do (only if you just allocated the object)
  2. Say that this function is deprecated and should not be used.

@bzbarsky-apple
Copy link
Contributor

/rebase

@sharadb-amazon @bzbarsky-apple
Switched to client for Media cluster
3ab53c3
@sharadb-amazon @bzbarsky-apple
Send ContentLauncher.LaunchURL command from the tv-casting-app to tv-app
7223c2e 
Merged from master and resolved merge conflicts

Using InvokeCommand instead of the callback api to LaunchURL

Calling GetPeerIdForNode instead of GetPeerID
@sharadb-amazon @bzbarsky-apple
Added usage/deprecation comment for OperationalDeviceProxy.SetConnect…
8c9607c 
…edSession
@woody-apple woody-apple force-pushed the content-launcher-120721 branch from 0d705d7 to 8c9607c Compare December 20, 2021 16:58
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

PR #12913: Size comparison from 569e7cc to 8c9607c

Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 569e7cc 8c9607c change % change
efr32 lighting-app BRD4161A (read only) 830408 830568 160 0.0
(read/write) 127360 127384 24 0.0
.bss 125480 125504 24 0.0
.text 830400 830560 160 0.0
BRD4161A+rpc (read only) 818052 818212 160 0.0
(read/write) 144024 144048 24 0.0
.bss 142048 142072 24 0.0
.text 818044 818204 160 0.0
window-app BRD4161A (read only) 803784 803944 160 0.0
(read/write) 126296 126320 24 0.0
.bss 124464 124488 24 0.0
.text 803776 803936 160 0.0
esp32 all-clusters-app c3devkit (read only) 881716 881720 4 0.0
(read/write) 1312466 1312498 32 0.0
.dram0.bss 69296 69320 24 0.0
.flash.text 881716 881720 4 0.0
m5stack (read/write) 441576 441600 24 0.0
.dram0.bss 73792 73816 24 0.0
k32w light k32w061+release (read/write) 648740 648764 24 0.0
.bss 76488 76512 24 0.0
lock k32w061+release (read/write) 633456 633472 16 0.0
.bss 76208 76224 16 0.0
linux chip-tool-ipv6only arm64 (read/write) 326225 326241 16 0.0
.bss 54593 54609 16 0.0
thermostat-no-ble arm64 (read only) 2002756 2002916 160 0.0
(read/write) 144065 144081 16 0.0
.bss 64353 64369 16 0.0
.text 1662736 1662896 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188580 188596 16 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 180920 180936 16 0.0
lock-app CY8CPROTO_062_4343W+release .bss 179968 179984 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 118408 118428 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 922351 922367 16 0.0
bss 115452 115472 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859714 859730 16 0.0
bss 116692 116712 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 908095 908111 16 0.0
bss 117596 117616 20 0.0
nrf5340dk_nrf5340_cpuapp bss 115908 115928 20 0.0
pump-app nrf52840dk_nrf52840 bss 117356 117376 20 0.0
pump-controller-app nrf52840dk_nrf52840 bss 117384 117404 20 0.0
p6 all-clusters-app default (read/write) 2389936 2390096 160 0.0
.bss 116780 116804 24 0.0
.text 1348200 1348360 160 0.0
light-app default (read/write) 2324944 2325104 160 0.0
.bss 106160 106184 24 0.0
.text 1283208 1283368 160 0.0
lock-app default (read/write) 2297152 2297312 160 0.0
.bss 105040 105064 24 0.0
.text 1255416 1255576 160 0.0
qpg lighting-app qpg6105+debug (read only) 532240 532248 8 0.0
.bss 86824 86840 16 0.0
.text 526920 526928 8 0.0
lock-app qpg6105+debug (read only) 503904 503912 8 0.0
.bss 85960 85976 16 0.0
.text 498584 498592 8 0.0
telink lighting-app tlsr9518adk80d bss 87064 87088 24 0.0
Decreases (9 builds for esp32, nrfconnect, telink)
platform target config section 569e7cc 8c9607c change % change
esp32 all-clusters-app m5stack (read only) 942151 942131 -20 -0.0
.flash.text 936767 936747 -20 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935999 935967 -32 -0.0
text 631884 631864 -20 -0.0
nrf52840dk_nrf52840+rpc text 627196 627176 -20 -0.0
nrf5340dk_nrf5340_cpuapp text 559324 559308 -16 -0.0
lock-app nrf52840dk_nrf52840 text 609708 609692 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832058 832042 -16 -0.0
text 537192 537172 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 909391 909375 -16 -0.0
text 610948 610928 -20 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906207 906191 -16 -0.0
text 608456 608440 -16 -0.0
telink lighting-app tlsr9518adk80d text 580384 580366 -18 -0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 569e7cc 8c9607c change % change
efr32 lighting-app BRD4161A (read only) 830408 830568 160 0.0
(read/write) 127360 127384 24 0.0
.bss 125480 125504 24 0.0
.data 1876 1876 0 0.0
.text 830400 830560 160 0.0
BRD4161A+rpc (read only) 818052 818212 160 0.0
(read/write) 144024 144048 24 0.0
.bss 142048 142072 24 0.0
.data 1976 1976 0 0.0
.text 818044 818204 160 0.0
window-app BRD4161A (read only) 803784 803944 160 0.0
(read/write) 126296 126320 24 0.0
.bss 124464 124488 24 0.0
.data 1832 1832 0 0.0
.text 803776 803936 160 0.0
esp32 all-clusters-app c3devkit (read only) 881716 881720 4 0.0
(read/write) 1312466 1312498 32 0.0
.dram0.bss 69296 69320 24 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175896 175896 0 0.0
.flash.text 881716 881720 4 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 942151 942131 -20 -0.0
(read/write) 441576 441600 24 0.0
.dram0.bss 73792 73816 24 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202720 202720 0 0.0
.flash.text 936767 936747 -20 -0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 648740 648764 24 0.0
.bss 76488 76512 24 0.0
.data 1904 1904 0 0.0
.text 564548 564548 0 0.0
lock k32w061+release (read/write) 633456 633472 16 0.0
.bss 76208 76224 16 0.0
.data 1860 1860 0 0.0
.text 549588 549588 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7005564 7005564 0 0.0
(read/write) 326225 326241 16 0.0
.bss 54593 54609 16 0.0
.data 1096 1096 0 0.0
.data.rel.ro 210144 210144 0 0.0
.dynamic 560 560 0 0.0
.got 56696 56696 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384228 384228 0 0.0
.text 5928084 5928084 0 0.0
thermostat-no-ble arm64 (read only) 2002756 2002916 160 0.0
(read/write) 144065 144081 16 0.0
.bss 64353 64369 16 0.0
.data 880 880 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128356 128356 0 0.0
.text 1662736 1662896 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338232 2338232 0 0.0
.bss 188580 188596 16 0.0
.data 5272 5272 0 0.0
.text 1300808 1300808 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330568 2330568 0 0.0
.bss 180920 180936 16 0.0
.data 5552 5552 0 0.0
.text 1293168 1293168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303664 2303664 0 0.0
.bss 179968 179984 16 0.0
.data 5544 5544 0 0.0
.text 1266264 1266264 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053688 2053688 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016288 1016288 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935999 935967 -32 -0.0
bss 118408 118428 20 0.0
rodata 108124 108124 0 0.0
text 631884 631864 -20 -0.0
nrf52840dk_nrf52840+rpc (read/write) 922351 922367 16 0.0
bss 115452 115472 20 0.0
rodata 101540 101540 0 0.0
text 627196 627176 -20 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859714 859730 16 0.0
bss 116692 116712 20 0.0
rodata 103048 103048 0 0.0
text 559324 559308 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 908095 908111 16 0.0
bss 117596 117616 20 0.0
rodata 103428 103428 0 0.0
text 609708 609692 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832058 832042 -16 -0.0
bss 115908 115928 20 0.0
rodata 98392 98392 0 0.0
text 537192 537172 -20 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 909391 909375 -16 -0.0
bss 117356 117376 20 0.0
rodata 103644 103644 0 0.0
text 610948 610928 -20 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906207 906191 -16 -0.0
bss 117384 117404 20 0.0
rodata 102900 102900 0 0.0
text 608456 608440 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 796079 796079 0 0.0
bss 109464 109464 0 0.0
rodata 78096 78096 0 0.0
text 532048 532048 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 708710 708710 0 0.0
bss 107352 107352 0 0.0
rodata 72396 72396 0 0.0
text 449544 449544 0 0.0
p6 all-clusters-app default (read/write) 2389936 2390096 160 0.0
.bss 116780 116804 24 0.0
.data 2552 2552 0 0.0
.text 1348200 1348360 160 0.0
light-app default (read/write) 2324944 2325104 160 0.0
.bss 106160 106184 24 0.0
.data 2384 2384 0 0.0
.text 1283208 1283368 160 0.0
lock-app default (read/write) 2297152 2297312 160 0.0
.bss 105040 105064 24 0.0
.data 2336 2336 0 0.0
.text 1255416 1255576 160 0.0
qpg lighting-app qpg6105+debug (read only) 532240 532248 8 0.0
(read/write) 146936 146936 0 0.0
.bss 86824 86840 16 0.0
.data 1004 1004 0 0.0
.text 526920 526928 8 0.0
lock-app qpg6105+debug (read only) 503904 503912 8 0.0
(read/write) 146940 146940 0 0.0
.bss 85960 85976 16 0.0
.data 952 952 0 0.0
.text 498584 498592 8 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832258 832258 0 0.0
bss 87064 87088 24 0.0
noinit 37160 37160 0 0.0
text 580384 580366 -18 -0.0

@bzbarsky-apple bzbarsky-apple merged commit d354008 into project-chip:master Dec 20, 2021
@sharadb-amazon sharadb-amazon deleted the content-launcher-120721 branch December 20, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharadb-amazon @bzbarsky-apple @yunhanw-google @chrisdecenzo