Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up args to access control check calls #12893

Merged

Conversation

mlepage-google
Copy link
Contributor

Problem

Calls with args, and plumbing to deliver args, came in different PRs
and require final hookup.

Change overview

  • Hook up wildcard/group expansion flag in IM read attribute
  • Hook up subject descriptor in IM read/write attribute

Testing

How was this tested? (at least one bullet point required)

  • Built, tested in chip-tool.

- Hook up wildcard/group expansion flag in IM read attribute
- Hook up subject descriptor in IM read/write attribute
@github-actions
Copy link

github-actions bot commented Dec 10, 2021

PR #12893: Size comparison from d27ac43 to c9ab42d

Decreases (21 builds for efr32, esp32, k32w, nrfconnect, p6, qpg, telink)
platform target config section d27ac43 c9ab42d change % change
efr32 lighting-app BRD4161A (read only) 815260 815244 -16 -0.0
.text 815252 815236 -16 -0.0
BRD4161A+rpc (read only) 802908 802876 -32 -0.0
.text 802900 802868 -32 -0.0
window-app BRD4161A (read only) 792224 792208 -16 -0.0
.text 792216 792200 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 856528 856490 -38 -0.0
.flash.text 856528 856490 -38 -0.0
m5stack (read only) 960191 960143 -48 -0.0
.flash.text 954807 954759 -48 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 669744 669712 -32 -0.0
.text 588196 588164 -32 -0.0
lock-app k32w061+debug (read/write) 619696 619664 -32 -0.0
.text 540036 540004 -32 -0.0
shell k32w061+debug (read/write) 625016 624984 -32 -0.0
.text 543068 543036 -32 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907035 907003 -32 -0.0
text 613240 613212 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 870099 870067 -32 -0.0
text 587984 587956 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833034 833018 -16 -0.0
text 543668 543640 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 879695 879663 -32 -0.0
text 592684 592656 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805934 805918 -16 -0.0
text 523204 523176 -28 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 884631 884599 -32 -0.0
text 596276 596248 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877843 877811 -32 -0.0
text 591472 591444 -28 -0.0
p6 all-clusters-app default (read/write) 2360584 2360552 -32 -0.0
.text 1318848 1318816 -32 -0.0
light-app default (read/write) 2300800 2300768 -32 -0.0
.text 1259064 1259032 -32 -0.0
lock-app default (read/write) 2276872 2276856 -16 -0.0
.text 1235136 1235120 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 521532 521500 -32 -0.0
.text 516212 516180 -32 -0.0
lock-app qpg6100+debug (read only) 495896 495864 -32 -0.0
.text 490576 490544 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 811522 811482 -40 -0.0
text 566628 566590 -38 -0.0
Full report (27 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section d27ac43 c9ab42d change % change
efr32 lighting-app BRD4161A (read only) 815260 815244 -16 -0.0
(read/write) 123132 123132 0 0.0
.bss 121272 121272 0 0.0
.data 1860 1860 0 0.0
.text 815252 815236 -16 -0.0
BRD4161A+rpc (read only) 802908 802876 -32 -0.0
(read/write) 139808 139808 0 0.0
.bss 137848 137848 0 0.0
.data 1960 1960 0 0.0
.text 802900 802868 -32 -0.0
window-app BRD4161A (read only) 792224 792208 -16 -0.0
(read/write) 121264 121264 0 0.0
.bss 119440 119440 0 0.0
.data 1824 1824 0 0.0
.text 792216 792200 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 856528 856490 -38 -0.0
(read/write) 1304970 1304970 0 0.0
.dram0.bss 65016 65016 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172792 172792 0 0.0
.flash.text 856528 856490 -38 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960191 960143 -48 -0.0
(read/write) 450704 450704 0 0.0
.dram0.bss 74304 74304 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210564 210564 0 0.0
.flash.text 954807 954759 -48 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669744 669712 -32 -0.0
.bss 73856 73856 0 0.0
.data 1892 1892 0 0.0
.text 588196 588164 -32 -0.0
lock-app k32w061+debug (read/write) 619696 619664 -32 -0.0
.bss 72008 72008 0 0.0
.data 1852 1852 0 0.0
.text 540036 540004 -32 -0.0
shell k32w061+debug (read/write) 625016 624984 -32 -0.0
.bss 74316 74316 0 0.0
.data 1832 1832 0 0.0
.text 543068 543036 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 6846220 6846220 0 0.0
(read/write) 318849 318849 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208632 208632 0 0.0
.dynamic 560 560 0 0.0
.got 53408 53408 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364028 364028 0 0.0
.text 5801396 5801396 0 0.0
thermostat-no-ble arm64 (read only) 1947668 1947668 0 0.0
(read/write) 137185 137185 0 0.0
.bss 59505 59505 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70344 70344 0 0.0
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125476 125476 0 0.0
.text 1614416 1614416 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907035 907003 -32 -0.0
bss 116280 116280 0 0.0
rodata 101932 101932 0 0.0
text 613240 613212 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 870099 870067 -32 -0.0
bss 112628 112628 0 0.0
rodata 93228 93228 0 0.0
text 587984 587956 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833034 833018 -16 -0.0
bss 117656 117656 0 0.0
rodata 97188 97188 0 0.0
text 543668 543640 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 879695 879663 -32 -0.0
bss 113544 113544 0 0.0
rodata 98048 98048 0 0.0
text 592684 592656 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805934 805918 -16 -0.0
bss 114952 114952 0 0.0
rodata 93336 93336 0 0.0
text 523204 523176 -28 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884631 884599 -32 -0.0
bss 113456 113456 0 0.0
rodata 99400 99400 0 0.0
text 596276 596248 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877843 877811 -32 -0.0
bss 113332 113332 0 0.0
rodata 97540 97540 0 0.0
text 591472 591444 -28 -0.0
shell nrf52840dk_nrf52840 (read/write) 782267 782267 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523840 523840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697346 697346 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444480 444480 0 0.0
p6 all-clusters-app default (read/write) 2360584 2360552 -32 -0.0
.bss 112484 112484 0 0.0
.data 2520 2520 0 0.0
.heap 918336 918336 0 0.0
.text 1318848 1318816 -32 -0.0
light-app default (read/write) 2300800 2300768 -32 -0.0
.bss 101064 101064 0 0.0
.data 2360 2360 0 0.0
.heap 929920 929920 0 0.0
.text 1259064 1259032 -32 -0.0
lock-app default (read/write) 2276872 2276856 -16 -0.0
.bss 99944 99944 0 0.0
.data 2328 2328 0 0.0
.heap 931072 931072 0 0.0
.text 1235136 1235120 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 521532 521500 -32 -0.0
(read/write) 122336 122336 0 0.0
.bss 82696 82696 0 0.0
.data 992 992 0 0.0
.text 516212 516180 -32 -0.0
lock-app qpg6100+debug (read only) 495896 495864 -32 -0.0
(read/write) 122332 122332 0 0.0
.bss 81832 81832 0 0.0
.data 948 948 0 0.0
.text 490576 490544 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811522 811482 -40 -0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566628 566590 -38 -0.0

@andy31415 andy31415 merged commit a269640 into project-chip:master Dec 10, 2021
@mlepage-google mlepage-google deleted the access-control-arg-hookup branch December 10, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants