Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate string test value to maxLength in Darwin tests #12844

Conversation

Morozov-5F
Copy link
Contributor

Problem

Fix Darwin test case failure in #12639 due to out-of-bounds test value.

Change overview

Now helper.js truncates strings for OCTET_STRING and CHAR_STRING types to their maximum length for Darwin tests.

Testing

How was this tested? (at least one bullet point required)

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12844: Size comparison from b20bf90 to 47dca06

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b20bf90 47dca06 change % change
efr32 lighting-app BRD4161A (read only) 807372 807372 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807364 807364 0 0.0
BRD4161A+rpc (read only) 794992 794992 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 794984 794984 0 0.0
window-app BRD4161A (read only) 784348 784348 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784340 784340 0 0.0
esp32 all-clusters-app c3devkit (read only) 861936 861936 0 0.0
(read/write) 1305602 1305602 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172752 0 0.0
.flash.text 861936 861936 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965067 965067 0 0.0
(read/write) 451296 451296 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210468 0 0.0
.flash.text 959683 959683 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668468 668468 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587044 587044 0 0.0
lock-app k32w061+debug (read/write) 618428 618428 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538884 538884 0 0.0
shell k32w061+debug (read/write) 623520 623520 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541776 541776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792140 6792140 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749316 5749316 0 0.0
thermostat-no-ble arm64 (read only) 1943044 1943044 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610592 1610592 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323312 2323312 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285888 1285888 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307944 2307944 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270544 1270544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281056 2281056 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243656 1243656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905563 905563 0 0.0
bss 116168 116168 0 0.0
rodata 101676 101676 0 0.0
text 612124 612124 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 868603 868603 0 0.0
bss 112516 112516 0 0.0
rodata 92972 92972 0 0.0
text 586852 586852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831554 831554 0 0.0
bss 117544 117544 0 0.0
rodata 96932 96932 0 0.0
text 542552 542552 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878191 878191 0 0.0
bss 113432 113432 0 0.0
rodata 97792 97792 0 0.0
text 591568 591568 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804422 804422 0 0.0
bss 114840 114840 0 0.0
rodata 93080 93080 0 0.0
text 522088 522088 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883119 883119 0 0.0
bss 113344 113344 0 0.0
rodata 99144 99144 0 0.0
text 595156 595156 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876363 876363 0 0.0
bss 113220 113220 0 0.0
rodata 97284 97284 0 0.0
text 590356 590356 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360072 2360072 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318336 1318336 0 0.0
light-app default (read/write) 2292856 2292856 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251120 1251120 0 0.0
lock-app default (read/write) 2268936 2268936 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227200 1227200 0 0.0
qpg lighting-app qpg6100+debug (read only) 520260 520260 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 514940 514940 0 0.0
lock-app qpg6100+debug (read only) 494636 494636 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489316 489316 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809658 809658 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565158 565158 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this is fixing tests

@jmartinez-silabs jmartinez-silabs merged commit d07de2f into project-chip:master Dec 9, 2021
@Morozov-5F Morozov-5F deleted the bugfix/fix-str-test-value-length-in-darwin-test branch December 9, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants