-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate string test value to maxLength in Darwin tests #12844
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
Morozov-5F:bugfix/fix-str-test-value-length-in-darwin-test
Dec 9, 2021
Merged
Truncate string test value to maxLength in Darwin tests #12844
jmartinez-silabs
merged 1 commit into
project-chip:master
from
Morozov-5F:bugfix/fix-str-test-value-length-in-darwin-test
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Dec 9, 2021
PR #12844: Size comparison from b20bf90 to 47dca06 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 9, 2021
bzbarsky-apple
approved these changes
Dec 9, 2021
Fast tracking, given this is fixing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix Darwin test case failure in #12639 due to out-of-bounds test value.
Change overview
Now
helper.js
truncates strings forOCTET_STRING
andCHAR_STRING
types to their maximum length for Darwin tests.Testing
How was this tested? (at least one bullet point required)
master
and Door Lock cluster rework: phase 1 #12639 to make sure there were no unexpected changes.Tes
intoLanguage
attribute in Door Lock Cluster (in Door Lock cluster rework: phase 1 #12639).