Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simulated code gen #12826

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fix simulated code gen #12826

merged 2 commits into from
Dec 10, 2021

Conversation

krypton36
Copy link
Contributor

Problem

Zap code gen was not generating code for the Simulated device tests regardless of changes to YAML files. It appears that it was an issue with the Promise functions added in the chip_tests. The promises were not being fulfilled. New functionality was added to chip-tool tests that identify the controller. This causes issues in the simulated device since it does not need a controller identifier.

Change overview

  • Added ZAP function that will generate CHIPCluster to fulfill promises.
  • Add a condition if the test is a simulated test, do not generate controller identifier code.
  • Added missing required attributes for cluster in ZAP config file for simulated device.
  • Generated code with updates.

Testing

  • Added a new simulated YAML file and generated code.
  • Modified the existing YAML and generated code.
  • Generated chip-tool and compiled.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12826: Size comparison from 38eebd2 to a4c92f4

Full report (1 build for telink)
platform target config section 38eebd2 a4c92f4 change % change
telink lighting-app tlsr9518adk80d (read/write) 808702 808702 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 564470 0 0.0

@krypton36 krypton36 force-pushed the FixSimulatedCodeGen branch from a4c92f4 to fe82340 Compare December 9, 2021 19:19
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12826: Size comparison from 7a99b3d to fe82340

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7a99b3d fe82340 change % change
efr32 lighting-app BRD4161A (read only) 806260 806260 0 0.0
(read/write) 122980 122980 0 0.0
.bss 121160 121160 0 0.0
.data 1820 1820 0 0.0
.text 806252 806252 0 0.0
BRD4161A+rpc (read only) 793896 793896 0 0.0
(read/write) 139664 139664 0 0.0
.bss 137736 137736 0 0.0
.data 1928 1928 0 0.0
.text 793888 793888 0 0.0
window-app BRD4161A (read only) 783004 783004 0 0.0
(read/write) 121112 121112 0 0.0
.bss 119328 119328 0 0.0
.data 1784 1784 0 0.0
.text 782996 782996 0 0.0
esp32 all-clusters-app c3devkit (read only) 861526 861526 0 0.0
(read/write) 1305546 1305546 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 861526 861526 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964515 964515 0 0.0
(read/write) 451248 451248 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210420 210420 0 0.0
.flash.text 959131 959131 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667732 0 0.0
.bss 73744 73744 0 0.0
.data 1852 1852 0 0.0
.text 586336 586336 0 0.0
lock-app k32w061+debug (read/write) 617324 617324 0 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 537808 537808 0 0.0
shell k32w061+debug (read/write) 622400 622400 0 0.0
.bss 74124 74124 0 0.0
.data 1792 1792 0 0.0
.text 540684 540684 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6784316 6784316 0 0.0
(read/write) 317777 317777 0 0.0
.bss 51681 51681 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 208360 208360 0 0.0
.dynamic 560 560 0 0.0
.got 52992 52992 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363596 363596 0 0.0
.text 5743028 5743028 0 0.0
thermostat-no-ble arm64 (read only) 1935204 1935204 0 0.0
(read/write) 136353 136353 0 0.0
.bss 59409 59409 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69800 0 0.0
.dynamic 560 560 0 0.0
.got 3512 3512 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124996 124996 0 0.0
.text 1604304 1604304 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2322936 2322936 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285512 1285512 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307128 2307128 0 0.0
.bss 175688 175688 0 0.0
.data 5488 5488 0 0.0
.heap 855272 855272 0 0.0
.text 1269728 1269728 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279856 2279856 0 0.0
.bss 174728 174728 0 0.0
.data 5488 5488 0 0.0
.heap 856232 856232 0 0.0
.text 1242456 1242456 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904791 0 0.0
bss 116168 116168 0 0.0
rodata 101440 101440 0 0.0
text 611608 611608 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 867819 867819 0 0.0
bss 112516 112516 0 0.0
rodata 92740 92740 0 0.0
text 586336 586336 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830786 0 0.0
bss 117544 117544 0 0.0
rodata 96700 96700 0 0.0
text 542036 542036 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877023 877023 0 0.0
bss 113432 113432 0 0.0
rodata 97560 97560 0 0.0
text 590668 590668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803270 803270 0 0.0
bss 114840 114840 0 0.0
rodata 92848 92848 0 0.0
text 521188 521188 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 881951 0 0.0
bss 113344 113344 0 0.0
rodata 98912 98912 0 0.0
text 594256 594256 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 875159 0 0.0
bss 113220 113220 0 0.0
rodata 97048 97048 0 0.0
text 589420 589420 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2359504 2359504 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1317768 1317768 0 0.0
light-app default (read/write) 2291752 2291752 0 0.0
.bss 100880 100880 0 0.0
.data 2328 2328 0 0.0
.heap 930136 930136 0 0.0
.text 1250016 1250016 0 0.0
lock-app default (read/write) 2267616 2267616 0 0.0
.bss 99760 99760 0 0.0
.data 2288 2288 0 0.0
.heap 931296 931296 0 0.0
.text 1225880 1225880 0 0.0
qpg lighting-app qpg6100+debug (read only) 519472 519472 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 514152 514152 0 0.0
lock-app qpg6100+debug (read only) 493464 493464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 488144 488144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808702 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 564470 0 0.0

@vivien-apple vivien-apple merged commit 572e168 into project-chip:master Dec 10, 2021
@bzbarsky-apple bzbarsky-apple mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krypton36 @andy31415 @bzbarsky-apple @vivien-apple