Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed label cluster]: Implement fixed label cluster server callback #12810

Merged
merged 4 commits into from
Dec 11, 2021
Merged

[Fixed label cluster]: Implement fixed label cluster server callback #12810

merged 4 commits into from
Dec 11, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Missing implementation for fixed label cluster in CHIP sdk

Change overview

Implement fixed label cluster server callback

Testing

How was this tested? (at least one bullet point required)

yufengw@yufengw-SEi:~/connectedhomeip/out/debug/standalone$ ./chip-tool fixedlabel read label-list 12344321 0
....
[1639067914.490591][602487:602492] CHIP:DMG: ReportDataMessage =
[1639067914.490597][602487:602492] CHIP:DMG: {
[1639067914.490601][602487:602492] CHIP:DMG: 	AttributeReportIBs =
[1639067914.490610][602487:602492] CHIP:DMG: 	[
[1639067914.490614][602487:602492] CHIP:DMG: 		AttributeReportIB =
[1639067914.490623][602487:602492] CHIP:DMG: 		{
[1639067914.490629][602487:602492] CHIP:DMG: 			AttributeDataIB =
[1639067914.490637][602487:602492] CHIP:DMG: 			{
[1639067914.490644][602487:602492] CHIP:DMG: 				DataVersion = 0x0,
[1639067914.490651][602487:602492] CHIP:DMG: 				AttributePathIB =
[1639067914.490658][602487:602492] CHIP:DMG: 				{
[1639067914.490666][602487:602492] CHIP:DMG: 					Endpoint = 0x0,
[1639067914.490674][602487:602492] CHIP:DMG: 					Cluster = 0x40,
[1639067914.490681][602487:602492] CHIP:DMG: 					Attribute = 0x0000_0000,
[1639067914.490688][602487:602492] CHIP:DMG: 				}
[1639067914.490696][602487:602492] CHIP:DMG: 					
[1639067914.490704][602487:602492] CHIP:DMG: 					Data = [
[1639067914.490711][602487:602492] CHIP:DMG: 						
[1639067914.490719][602487:602492] CHIP:DMG: 					],
[1639067914.490725][602487:602492] CHIP:DMG: 			},
[1639067914.490733][602487:602492] CHIP:DMG: 			
[1639067914.490738][602487:602492] CHIP:DMG: 		},
[1639067914.490749][602487:602492] CHIP:DMG: 		
[1639067914.490755][602487:602492] CHIP:DMG: 		AttributeReportIB =
[1639067914.490764][602487:602492] CHIP:DMG: 		{
[1639067914.490769][602487:602492] CHIP:DMG: 			AttributeDataIB =
[1639067914.490775][602487:602492] CHIP:DMG: 			{
[1639067914.490782][602487:602492] CHIP:DMG: 				DataVersion = 0x0,
[1639067914.490788][602487:602492] CHIP:DMG: 				AttributePathIB =
[1639067914.490795][602487:602492] CHIP:DMG: 				{
[1639067914.490803][602487:602492] CHIP:DMG: 					Endpoint = 0x0,
[1639067914.490811][602487:602492] CHIP:DMG: 					Cluster = 0x40,
[1639067914.490818][602487:602492] CHIP:DMG: 					Attribute = 0x0000_0000,
[1639067914.490825][602487:602492] CHIP:DMG: 					ListIndex = Null,
[1639067914.490832][602487:602492] CHIP:DMG: 				}
[1639067914.490841][602487:602492] CHIP:DMG: 					
[1639067914.490847][602487:602492] CHIP:DMG: 					Data = 
[1639067914.490855][602487:602492] CHIP:DMG: 					{
[1639067914.490863][602487:602492] CHIP:DMG: 						0x1 = "room", 
[1639067914.490872][602487:602492] CHIP:DMG: 						0x2 = "bedroom 2", 
[1639067914.490880][602487:602492] CHIP:DMG: 					},
[1639067914.490886][602487:602492] CHIP:DMG: 			},
[1639067914.490895][602487:602492] CHIP:DMG: 			
[1639067914.490900][602487:602492] CHIP:DMG: 		},
[1639067914.490912][602487:602492] CHIP:DMG: 		
[1639067914.490917][602487:602492] CHIP:DMG: 		AttributeReportIB =
[1639067914.490926][602487:602492] CHIP:DMG: 		{
[1639067914.490933][602487:602492] CHIP:DMG: 			AttributeDataIB =
[1639067914.490941][602487:602492] CHIP:DMG: 			{
[1639067914.490948][602487:602492] CHIP:DMG: 				DataVersion = 0x0,
[1639067914.490954][602487:602492] CHIP:DMG: 				AttributePathIB =
[1639067914.490960][602487:602492] CHIP:DMG: 				{
[1639067914.490966][602487:602492] CHIP:DMG: 					Endpoint = 0x0,
[1639067914.490973][602487:602492] CHIP:DMG: 					Cluster = 0x40,
[1639067914.490981][602487:602492] CHIP:DMG: 					Attribute = 0x0000_0000,
[1639067914.490988][602487:602492] CHIP:DMG: 					ListIndex = Null,
[1639067914.490996][602487:602492] CHIP:DMG: 				}
[1639067914.491004][602487:602492] CHIP:DMG: 					
[1639067914.491011][602487:602492] CHIP:DMG: 					Data = 
[1639067914.491019][602487:602492] CHIP:DMG: 					{
[1639067914.491026][602487:602492] CHIP:DMG: 						0x1 = "orientation", 
[1639067914.491034][602487:602492] CHIP:DMG: 						0x2 = "North", 
[1639067914.491041][602487:602492] CHIP:DMG: 					},
[1639067914.491048][602487:602492] CHIP:DMG: 			},
[1639067914.491057][602487:602492] CHIP:DMG: 			
[1639067914.491062][602487:602492] CHIP:DMG: 		},
[1639067914.491074][602487:602492] CHIP:DMG: 		
[1639067914.491079][602487:602492] CHIP:DMG: 		AttributeReportIB =
[1639067914.491087][602487:602492] CHIP:DMG: 		{
[1639067914.491093][602487:602492] CHIP:DMG: 			AttributeDataIB =
[1639067914.491099][602487:602492] CHIP:DMG: 			{
[1639067914.491106][602487:602492] CHIP:DMG: 				DataVersion = 0x0,
[1639067914.491113][602487:602492] CHIP:DMG: 				AttributePathIB =
[1639067914.491119][602487:602492] CHIP:DMG: 				{
[1639067914.491126][602487:602492] CHIP:DMG: 					Endpoint = 0x0,
[1639067914.491134][602487:602492] CHIP:DMG: 					Cluster = 0x40,
[1639067914.491142][602487:602492] CHIP:DMG: 					Attribute = 0x0000_0000,
[1639067914.491149][602487:602492] CHIP:DMG: 					ListIndex = Null,
[1639067914.491156][602487:602492] CHIP:DMG: 				}
[1639067914.491163][602487:602492] CHIP:DMG: 					
[1639067914.491170][602487:602492] CHIP:DMG: 					Data = 
[1639067914.491177][602487:602492] CHIP:DMG: 					{
[1639067914.491185][602487:602492] CHIP:DMG: 						0x1 = "floor", 
[1639067914.491193][602487:602492] CHIP:DMG: 						0x2 = "2", 
[1639067914.491201][602487:602492] CHIP:DMG: 					},
[1639067914.491208][602487:602492] CHIP:DMG: 			},
[1639067914.491216][602487:602492] CHIP:DMG: 			
[1639067914.491221][602487:602492] CHIP:DMG: 		},
[1639067914.491233][602487:602492] CHIP:DMG: 		
[1639067914.491238][602487:602492] CHIP:DMG: 		AttributeReportIB =
[1639067914.491247][602487:602492] CHIP:DMG: 		{
[1639067914.491252][602487:602492] CHIP:DMG: 			AttributeDataIB =
[1639067914.491259][602487:602492] CHIP:DMG: 			{
[1639067914.491265][602487:602492] CHIP:DMG: 				DataVersion = 0x0,
[1639067914.491272][602487:602492] CHIP:DMG: 				AttributePathIB =
[1639067914.491278][602487:602492] CHIP:DMG: 				{
[1639067914.491285][602487:602492] CHIP:DMG: 					Endpoint = 0x0,
[1639067914.491293][602487:602492] CHIP:DMG: 					Cluster = 0x40,
[1639067914.491300][602487:602492] CHIP:DMG: 					Attribute = 0x0000_0000,
[1639067914.491308][602487:602492] CHIP:DMG: 					ListIndex = Null,
[1639067914.491315][602487:602492] CHIP:DMG: 				}
[1639067914.491323][602487:602492] CHIP:DMG: 					
[1639067914.491329][602487:602492] CHIP:DMG: 					Data = 
[1639067914.491337][602487:602492] CHIP:DMG: 					{
[1639067914.491344][602487:602492] CHIP:DMG: 						0x1 = "direction", 
[1639067914.491353][602487:602492] CHIP:DMG: 						0x2 = "up", 
[1639067914.491360][602487:602492] CHIP:DMG: 					},
[1639067914.491367][602487:602492] CHIP:DMG: 			},
[1639067914.491375][602487:602492] CHIP:DMG: 			
[1639067914.491380][602487:602492] CHIP:DMG: 		},
[1639067914.491388][602487:602492] CHIP:DMG: 		
[1639067914.491394][602487:602492] CHIP:DMG: 	],
[1639067914.491413][602487:602492] CHIP:DMG: 	
[1639067914.491417][602487:602492] CHIP:DMG: 	SuppressResponse = true, 
[1639067914.491422][602487:602492] CHIP:DMG: }
[1639067914.491581][602487:602492] CHIP:TOO: FixedLabel.LabelList response: 4 entries
[1639067914.491602][602487:602492] CHIP:TOO:   [1]: {
[1639067914.491607][602487:602492] CHIP:TOO:     Label: room
[1639067914.491612][602487:602492] CHIP:TOO:     Value: bedroom 2
[1639067914.491617][602487:602492] CHIP:TOO:   }
[1639067914.491625][602487:602492] CHIP:TOO:   [2]: {
[1639067914.491629][602487:602492] CHIP:TOO:     Label: orientation
[1639067914.491634][602487:602492] CHIP:TOO:     Value: North
[1639067914.491638][602487:602492] CHIP:TOO:   }
[1639067914.491646][602487:602492] CHIP:TOO:   [3]: {
[1639067914.491651][602487:602492] CHIP:TOO:     Label: floor
[1639067914.491655][602487:602492] CHIP:TOO:     Value: 2
[1639067914.491660][602487:602492] CHIP:TOO:   }
[1639067914.491666][602487:602492] CHIP:TOO:   [4]: {
[1639067914.491671][602487:602492] CHIP:TOO:     Label: direction
[1639067914.491676][602487:602492] CHIP:TOO:     Value: up
[1639067914.491681][602487:602492] CHIP:TOO:   }
[1639067914.491701][602487:602492] CHIP:DMG: Client[0] moving to [UNINIT]

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12810: Size comparison from 5bb8377 to 4f97ee6

Increases above 0.2%:

platform target config section 5bb8377 4f97ee6 change % change
k32w lighting-app k32w061+se05x+release .bss 73744 74016 272 0.4
lock-app k32w061+debug .bss 71896 72168 272 0.4
shell k32w061+debug .bss 74124 74396 272 0.4
linux thermostat-no-ble arm64 (read only) 1935204 1940836 5632 0.3
(read/write) 136353 136801 448 0.3
.bss 59409 59697 288 0.5
.init_array 256 264 8 3.1
.rodata 124996 125572 576 0.5
.text 1604304 1609168 4864 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116168 116436 268 0.2
nrf52840dk_nrf52840+rpc bss 112516 112784 268 0.2
nrf5340dk_nrf5340_cpuapp bss 117544 117812 268 0.2
lock-app nrf52840dk_nrf52840 bss 113432 113704 272 0.2
rodata 97560 97888 328 0.3
nrf5340dk_nrf5340_cpuapp bss 114840 115112 272 0.2
rodata 92848 93180 332 0.4
pump-app nrf52840dk_nrf52840 bss 113344 113616 272 0.2
rodata 98912 99244 332 0.3
pump-controller-app nrf52840dk_nrf52840 bss 113220 113492 272 0.2
rodata 97048 97380 332 0.3
p6 light-app default .bss 100880 101144 264 0.3
lock-app default .bss 99760 100032 272 0.3
.data 2288 2296 8 0.3
qpg lighting-app qpg6100+debug .bss 82616 82880 264 0.3
.data 956 960 4 0.4
lock-app qpg6100+debug .bss 81752 82024 272 0.3
.data 912 916 4 0.4
telink lighting-app tlsr9518adk80d bss 82736 83008 272 0.3
Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5bb8377 4f97ee6 change % change
efr32 lighting-app BRD4161A (read/write) 122980 123256 276 0.2
.bss 121160 121432 272 0.2
.data 1820 1824 4 0.2
BRD4161A+rpc (read/write) 139664 139944 280 0.2
.bss 137736 138008 272 0.2
.data 1928 1932 4 0.2
window-app BRD4161A (read only) 783004 784236 1232 0.2
(read/write) 121112 121388 276 0.2
.bss 119328 119600 272 0.2
.data 1784 1788 4 0.2
.text 782996 784228 1232 0.2
k32w lighting-app k32w061+se05x+release .bss 73744 74016 272 0.4
.data 1852 1856 4 0.2
lock-app k32w061+debug (read/write) 617324 618556 1232 0.2
.bss 71896 72168 272 0.4
.data 1820 1824 4 0.2
.text 537808 538764 956 0.2
shell k32w061+debug (read/write) 622400 623648 1248 0.2
.bss 74124 74396 272 0.4
.data 1792 1796 4 0.2
.text 540684 541656 972 0.2
linux thermostat-no-ble arm64 (read only) 1935204 1940836 5632 0.3
(read/write) 136353 136801 448 0.3
.bss 59409 59697 288 0.5
.data.rel.ro 69800 69952 152 0.2
.init_array 256 264 8 3.1
.rodata 124996 125572 576 0.5
.text 1604304 1609168 4864 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2321272 2322240 968 0.0
.bss 186884 187156 272 0.1
.data 5232 5240 8 0.2
.text 1283848 1284816 968 0.1
lighting-app CY8CPROTO_062_4343W+release .bss 175688 175952 264 0.2
.data 5488 5496 8 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2279856 2280824 968 0.0
.bss 174728 175000 272 0.2
.data 5488 5496 8 0.1
.text 1242456 1243424 968 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116168 116436 268 0.2
rodata 101440 101556 116 0.1
nrf52840dk_nrf52840+rpc bss 112516 112784 268 0.2
rodata 92740 92852 112 0.1
nrf5340dk_nrf5340_cpuapp bss 117544 117812 268 0.2
rodata 96700 96812 112 0.1
lock-app nrf52840dk_nrf52840 (read/write) 877023 878279 1256 0.1
bss 113432 113704 272 0.2
rodata 97560 97888 328 0.3
text 590668 591300 632 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 803270 804530 1260 0.2
bss 114840 115112 272 0.2
rodata 92848 93180 332 0.4
text 521188 521820 632 0.1
pump-app nrf52840dk_nrf52840 (read/write) 881951 883227 1276 0.1
bss 113344 113616 272 0.2
rodata 98912 99244 332 0.3
text 594256 594904 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 876387 1228 0.1
bss 113220 113492 272 0.2
rodata 97048 97380 332 0.3
text 589420 590064 644 0.1
p6 all-clusters-app default (read/write) 2357456 2358680 1224 0.1
.bss 113108 113380 272 0.2
.text 1315720 1316944 1224 0.1
light-app default .bss 100880 101144 264 0.3
lock-app default (read/write) 2267616 2268856 1240 0.1
.bss 99760 100032 272 0.3
.data 2288 2296 8 0.3
.text 1225880 1227120 1240 0.1
qpg lighting-app qpg6100+debug (read/write) 122332 122336 4 0.0
.bss 82616 82880 264 0.3
.data 956 960 4 0.4
lock-app qpg6100+debug (read only) 493464 494420 956 0.2
.bss 81752 82024 272 0.3
.data 912 916 4 0.4
.text 488144 489100 956 0.2
telink lighting-app tlsr9518adk80d bss 82736 83008 272 0.3
Decreases (15 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5bb8377 4f97ee6 change % change
efr32 lighting-app BRD4161A (read only) 806260 805180 -1080 -0.1
.text 806252 805172 -1080 -0.1
BRD4161A+rpc (read only) 793896 792816 -1080 -0.1
.text 793888 792808 -1080 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 667732 667260 -472 -0.1
.text 586336 585588 -748 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 844328 844048 -280 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2307128 2306184 -944 -0.0
.heap 855272 855000 -272 -0.0
.text 1269728 1268784 -944 -0.1
lock-app CY8CPROTO_062_4343W+release .heap 856232 855952 -280 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904267 -524 -0.1
text 611608 610720 -888 -0.1
nrf52840dk_nrf52840+rpc (read/write) 867819 867307 -512 -0.1
text 586336 585448 -888 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830258 -528 -0.1
text 542036 541144 -892 -0.2
p6 all-clusters-app default .heap 917720 917448 -272 -0.0
light-app default (read/write) 2291752 2290680 -1072 -0.0
.heap 930136 929872 -264 -0.0
.text 1250016 1248944 -1072 -0.1
lock-app default .heap 931296 931016 -280 -0.0
qpg lighting-app qpg6100+debug (read only) 519472 518696 -776 -0.1
.text 514152 513376 -776 -0.2
lock-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 807954 -748 -0.1
text 564470 563326 -1144 -0.2
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5bb8377 4f97ee6 change % change
efr32 lighting-app BRD4161A (read only) 806260 805180 -1080 -0.1
(read/write) 122980 123256 276 0.2
.bss 121160 121432 272 0.2
.data 1820 1824 4 0.2
.text 806252 805172 -1080 -0.1
BRD4161A+rpc (read only) 793896 792816 -1080 -0.1
(read/write) 139664 139944 280 0.2
.bss 137736 138008 272 0.2
.data 1928 1932 4 0.2
.text 793888 792808 -1080 -0.1
window-app BRD4161A (read only) 783004 784236 1232 0.2
(read/write) 121112 121388 276 0.2
.bss 119328 119600 272 0.2
.data 1784 1788 4 0.2
.text 782996 784228 1232 0.2
k32w lighting-app k32w061+se05x+release (read/write) 667732 667260 -472 -0.1
.bss 73744 74016 272 0.4
.data 1852 1856 4 0.2
.text 586336 585588 -748 -0.1
lock-app k32w061+debug (read/write) 617324 618556 1232 0.2
.bss 71896 72168 272 0.4
.data 1820 1824 4 0.2
.text 537808 538764 956 0.2
shell k32w061+debug (read/write) 622400 623648 1248 0.2
.bss 74124 74396 272 0.4
.data 1792 1796 4 0.2
.text 540684 541656 972 0.2
linux chip-tool-ipv6only arm64 (read only) 6783628 6783628 0 0.0
(read/write) 317777 317777 0 0.0
.bss 51681 51681 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 208360 208360 0 0.0
.dynamic 560 560 0 0.0
.got 52992 52992 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363612 363612 0 0.0
.text 5742324 5742324 0 0.0
thermostat-no-ble arm64 (read only) 1935204 1940836 5632 0.3
(read/write) 136353 136801 448 0.3
.bss 59409 59697 288 0.5
.data 776 776 0 0.0
.data.rel.ro 69800 69952 152 0.2
.dynamic 560 560 0 0.0
.got 3512 3512 0 0.0
.init 24 24 0 0.0
.init_array 256 264 8 3.1
.rodata 124996 125572 576 0.5
.text 1604304 1609168 4864 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321272 2322240 968 0.0
.bss 186884 187156 272 0.1
.data 5232 5240 8 0.2
.heap 844328 844048 -280 -0.0
.text 1283848 1284816 968 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307128 2306184 -944 -0.0
.bss 175688 175952 264 0.2
.data 5488 5496 8 0.1
.heap 855272 855000 -272 -0.0
.text 1269728 1268784 -944 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279856 2280824 968 0.0
.bss 174728 175000 272 0.2
.data 5488 5496 8 0.1
.heap 856232 855952 -280 -0.0
.text 1242456 1243424 968 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904267 -524 -0.1
bss 116168 116436 268 0.2
rodata 101440 101556 116 0.1
text 611608 610720 -888 -0.1
nrf52840dk_nrf52840+rpc (read/write) 867819 867307 -512 -0.1
bss 112516 112784 268 0.2
rodata 92740 92852 112 0.1
text 586336 585448 -888 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830258 -528 -0.1
bss 117544 117812 268 0.2
rodata 96700 96812 112 0.1
text 542036 541144 -892 -0.2
lock-app nrf52840dk_nrf52840 (read/write) 877023 878279 1256 0.1
bss 113432 113704 272 0.2
rodata 97560 97888 328 0.3
text 590668 591300 632 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 803270 804530 1260 0.2
bss 114840 115112 272 0.2
rodata 92848 93180 332 0.4
text 521188 521820 632 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 883227 1276 0.1
bss 113344 113616 272 0.2
rodata 98912 99244 332 0.3
text 594256 594904 648 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 876387 1228 0.1
bss 113220 113492 272 0.2
rodata 97048 97380 332 0.3
text 589420 590064 644 0.1
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2357456 2358680 1224 0.1
.bss 113108 113380 272 0.2
.data 2512 2512 0 0.0
.heap 917720 917448 -272 -0.0
.text 1315720 1316944 1224 0.1
light-app default (read/write) 2291752 2290680 -1072 -0.0
.bss 100880 101144 264 0.3
.data 2328 2328 0 0.0
.heap 930136 929872 -264 -0.0
.text 1250016 1248944 -1072 -0.1
lock-app default (read/write) 2267616 2268856 1240 0.1
.bss 99760 100032 272 0.3
.data 2288 2296 8 0.3
.heap 931296 931016 -280 -0.0
.text 1225880 1227120 1240 0.1
qpg lighting-app qpg6100+debug (read only) 519472 518696 -776 -0.1
(read/write) 122332 122336 4 0.0
.bss 82616 82880 264 0.3
.data 956 960 4 0.4
.text 514152 513376 -776 -0.2
lock-app qpg6100+debug (read only) 493464 494420 956 0.2
(read/write) 122336 122332 -4 -0.0
.bss 81752 82024 272 0.3
.data 912 916 4 0.4
.text 488144 489100 956 0.2
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 807954 -748 -0.1
bss 82736 83008 272 0.3
noinit 37160 37160 0 0.0
text 564470 563326 -1144 -0.2

bzbarsky-apple
bzbarsky-apple requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem is that the basic setup with the configuration manager in this PR does not make sense.

src/app/clusters/fixed-label-server/fixed-label-server.cpp Show resolved Hide resolved
src/app/clusters/fixed-label-server/fixed-label-server.cpp Show resolved Hide resolved
src/app/clusters/fixed-label-server/fixed-label-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/fixed-label-server/fixed-label-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/fixed-label-server/fixed-label-server.cpp Outdated Show resolved Hide resolved
src/include/platform/PlatformManager.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12810: Size comparison from 3042ef8 to a4cfd5f

Increases above 0.2%:

platform target config section 3042ef8 a4cfd5f change % change
efr32 lighting-app BRD4161A .data 1848 1852 4 0.2
BRD4161A+rpc .data 1956 1960 4 0.2
window-app BRD4161A .data 1812 1816 4 0.2
linux thermostat-no-ble arm64 (read only) 1943060 1948324 5264 0.3
.init_array 264 272 8 3.0
.text 1610608 1615408 4800 0.3
p6 light-app default .data 2352 2360 8 0.3
qpg lighting-app qpg6100+debug .data 984 988 4 0.4
lock-app qpg6100+debug .data 940 944 4 0.4
Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 3042ef8 a4cfd5f change % change
efr32 lighting-app BRD4161A (read/write) 123008 123028 20 0.0
.bss 121160 121176 16 0.0
.data 1848 1852 4 0.2
BRD4161A+rpc (read/write) 139696 139712 16 0.0
.bss 137736 137752 16 0.0
.data 1956 1960 4 0.2
window-app BRD4161A (read only) 784348 785252 904 0.1
(read/write) 121140 121160 20 0.0
.bss 119328 119344 16 0.0
.data 1812 1816 4 0.2
.text 784340 785244 904 0.1
k32w lighting-app k32w061+se05x+release .bss 73744 73760 16 0.0
.data 1880 1884 4 0.2
lock-app k32w061+debug (read/write) 618428 619100 672 0.1
.bss 71896 71912 16 0.0
.data 1848 1852 4 0.2
.text 538884 539536 652 0.1
shell k32w061+debug (read/write) 623520 624192 672 0.1
.bss 74124 74140 16 0.0
.data 1820 1824 4 0.2
.text 541776 542428 652 0.1
linux thermostat-no-ble arm64 (read only) 1943060 1948324 5264 0.3
(read/write) 136865 137041 176 0.1
.bss 59441 59457 16 0.0
.data.rel.ro 70160 70312 152 0.2
.init_array 264 272 8 3.0
.rodata 125300 125604 304 0.2
.text 1610608 1615408 4800 0.3
p6 all-clusters-app default (read/write) 2360072 2360984 912 0.0
.bss 113108 113132 24 0.0
.text 1318336 1319248 912 0.1
light-app default .bss 100880 100888 8 0.0
.data 2352 2360 8 0.3
lock-app default (read/write) 2268936 2269848 912 0.0
.bss 99760 99776 16 0.0
.text 1227200 1228112 912 0.1
qpg lighting-app qpg6100+debug .bss 82616 82624 8 0.0
.data 984 988 4 0.4
lock-app qpg6100+debug (read only) 494636 495296 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81752 81768 16 0.0
.data 940 944 4 0.4
.text 489316 489976 660 0.1
telink lighting-app tlsr9518adk80d bss 82736 82752 16 0.0
Decreases (8 builds for efr32, k32w, p6, qpg, telink)
platform target config section 3042ef8 a4cfd5f change % change
efr32 lighting-app BRD4161A (read only) 807372 806556 -816 -0.1
.text 807364 806548 -816 -0.1
BRD4161A+rpc (read only) 795008 794192 -816 -0.1
.text 795000 794184 -816 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 668468 667724 -744 -0.1
.text 587044 586280 -764 -0.1
p6 all-clusters-app default .heap 917720 917696 -24 -0.0
light-app default (read/write) 2292872 2292032 -840 -0.0
.heap 930112 930096 -16 -0.0
.text 1251136 1250296 -840 -0.1
lock-app default .heap 931264 931248 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 520260 519492 -768 -0.1
(read/write) 122336 122332 -4 -0.0
.text 514940 514172 -768 -0.1
telink lighting-app tlsr9518adk80d (read/write) 809658 808702 -956 -0.1
text 565164 564322 -842 -0.1
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 3042ef8 a4cfd5f change % change
efr32 lighting-app BRD4161A (read only) 807372 806556 -816 -0.1
(read/write) 123008 123028 20 0.0
.bss 121160 121176 16 0.0
.data 1848 1852 4 0.2
.text 807364 806548 -816 -0.1
BRD4161A+rpc (read only) 795008 794192 -816 -0.1
(read/write) 139696 139712 16 0.0
.bss 137736 137752 16 0.0
.data 1956 1960 4 0.2
.text 795000 794184 -816 -0.1
window-app BRD4161A (read only) 784348 785252 904 0.1
(read/write) 121140 121160 20 0.0
.bss 119328 119344 16 0.0
.data 1812 1816 4 0.2
.text 784340 785244 904 0.1
k32w lighting-app k32w061+se05x+release (read/write) 668468 667724 -744 -0.1
.bss 73744 73760 16 0.0
.data 1880 1884 4 0.2
.text 587044 586280 -764 -0.1
lock-app k32w061+debug (read/write) 618428 619100 672 0.1
.bss 71896 71912 16 0.0
.data 1848 1852 4 0.2
.text 538884 539536 652 0.1
shell k32w061+debug (read/write) 623520 624192 672 0.1
.bss 74124 74140 16 0.0
.data 1820 1824 4 0.2
.text 541776 542428 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6792492 6792492 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749668 5749668 0 0.0
thermostat-no-ble arm64 (read only) 1943060 1948324 5264 0.3
(read/write) 136865 137041 176 0.1
.bss 59441 59457 16 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70312 152 0.2
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 272 8 3.0
.rodata 125300 125604 304 0.2
.text 1610608 1615408 4800 0.3
p6 all-clusters-app default (read/write) 2360072 2360984 912 0.0
.bss 113108 113132 24 0.0
.data 2512 2512 0 0.0
.heap 917720 917696 -24 -0.0
.text 1318336 1319248 912 0.1
light-app default (read/write) 2292872 2292032 -840 -0.0
.bss 100880 100888 8 0.0
.data 2352 2360 8 0.3
.heap 930112 930096 -16 -0.0
.text 1251136 1250296 -840 -0.1
lock-app default (read/write) 2268936 2269848 912 0.0
.bss 99760 99776 16 0.0
.data 2320 2320 0 0.0
.heap 931264 931248 -16 -0.0
.text 1227200 1228112 912 0.1
qpg lighting-app qpg6100+debug (read only) 520260 519492 -768 -0.1
(read/write) 122336 122332 -4 -0.0
.bss 82616 82624 8 0.0
.data 984 988 4 0.4
.text 514940 514172 -768 -0.1
lock-app qpg6100+debug (read only) 494636 495296 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81752 81768 16 0.0
.data 940 944 4 0.4
.text 489316 489976 660 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809658 808702 -956 -0.1
bss 82736 82752 16 0.0
noinit 37160 37160 0 0.0
text 565164 564322 -842 -0.1

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12810: Size comparison from 0089995 to 30f843f

Increases above 0.2%:

platform target config section 0089995 30f843f change % change
efr32 lighting-app BRD4161A .data 1848 1852 4 0.2
BRD4161A+rpc .data 1956 1960 4 0.2
window-app BRD4161A .data 1812 1816 4 0.2
k32w lighting-app k32w061+se05x+release .data 1880 1884 4 0.2
lock-app k32w061+debug .data 1848 1852 4 0.2
shell k32w061+debug .data 1820 1824 4 0.2
linux thermostat-no-ble arm64 (read only) 1943364 1948628 5264 0.3
.data.rel.ro 70160 70312 152 0.2
.init_array 264 272 8 3.0
.rodata 125300 125604 304 0.2
.text 1610912 1615712 4800 0.3
p6 light-app default .data 2352 2360 8 0.3
qpg lighting-app qpg6100+debug .data 984 988 4 0.4
lock-app qpg6100+debug .data 940 944 4 0.4
Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 0089995 30f843f change % change
efr32 lighting-app BRD4161A (read/write) 123008 123028 20 0.0
.bss 121160 121176 16 0.0
.data 1848 1852 4 0.2
BRD4161A+rpc (read/write) 139696 139712 16 0.0
.bss 137736 137752 16 0.0
.data 1956 1960 4 0.2
window-app BRD4161A (read only) 784460 785364 904 0.1
(read/write) 121140 121160 20 0.0
.bss 119328 119344 16 0.0
.data 1812 1816 4 0.2
.text 784452 785356 904 0.1
k32w lighting-app k32w061+se05x+release .bss 73744 73760 16 0.0
.data 1880 1884 4 0.2
lock-app k32w061+debug (read/write) 618492 619164 672 0.1
.bss 71896 71912 16 0.0
.data 1848 1852 4 0.2
.text 538948 539600 652 0.1
shell k32w061+debug (read/write) 623584 624256 672 0.1
.bss 74124 74140 16 0.0
.data 1820 1824 4 0.2
.text 541840 542492 652 0.1
linux thermostat-no-ble arm64 (read only) 1943364 1948628 5264 0.3
(read/write) 136865 137041 176 0.1
.bss 59441 59457 16 0.0
.data.rel.ro 70160 70312 152 0.2
.init_array 264 272 8 3.0
.rodata 125300 125604 304 0.2
.text 1610912 1615712 4800 0.3
p6 all-clusters-app default (read/write) 2360184 2361096 912 0.0
.bss 113108 113132 24 0.0
.text 1318448 1319360 912 0.1
light-app default .bss 100880 100888 8 0.0
.data 2352 2360 8 0.3
lock-app default (read/write) 2269048 2269960 912 0.0
.bss 99760 99776 16 0.0
.text 1227312 1228224 912 0.1
qpg lighting-app qpg6100+debug .bss 82616 82624 8 0.0
.data 984 988 4 0.4
lock-app qpg6100+debug (read only) 494700 495360 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81752 81768 16 0.0
.data 940 944 4 0.4
.text 489380 490040 660 0.1
telink lighting-app tlsr9518adk80d bss 82736 82752 16 0.0
Decreases (8 builds for efr32, k32w, p6, qpg, telink)
platform target config section 0089995 30f843f change % change
efr32 lighting-app BRD4161A (read only) 807484 806668 -816 -0.1
.text 807476 806660 -816 -0.1
BRD4161A+rpc (read only) 795120 794304 -816 -0.1
.text 795112 794296 -816 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 668532 667788 -744 -0.1
.text 587108 586344 -764 -0.1
p6 all-clusters-app default .heap 917720 917696 -24 -0.0
light-app default (read/write) 2292984 2292144 -840 -0.0
.heap 930112 930096 -16 -0.0
.text 1251248 1250408 -840 -0.1
lock-app default .heap 931264 931248 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 520324 519556 -768 -0.1
(read/write) 122336 122332 -4 -0.0
.text 515004 514236 -768 -0.1
telink lighting-app tlsr9518adk80d (read/write) 809770 808806 -964 -0.1
text 565274 564432 -842 -0.1
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 0089995 30f843f change % change
efr32 lighting-app BRD4161A (read only) 807484 806668 -816 -0.1
(read/write) 123008 123028 20 0.0
.bss 121160 121176 16 0.0
.data 1848 1852 4 0.2
.text 807476 806660 -816 -0.1
BRD4161A+rpc (read only) 795120 794304 -816 -0.1
(read/write) 139696 139712 16 0.0
.bss 137736 137752 16 0.0
.data 1956 1960 4 0.2
.text 795112 794296 -816 -0.1
window-app BRD4161A (read only) 784460 785364 904 0.1
(read/write) 121140 121160 20 0.0
.bss 119328 119344 16 0.0
.data 1812 1816 4 0.2
.text 784452 785356 904 0.1
k32w lighting-app k32w061+se05x+release (read/write) 668532 667788 -744 -0.1
.bss 73744 73760 16 0.0
.data 1880 1884 4 0.2
.text 587108 586344 -764 -0.1
lock-app k32w061+debug (read/write) 618492 619164 672 0.1
.bss 71896 71912 16 0.0
.data 1848 1852 4 0.2
.text 538948 539600 652 0.1
shell k32w061+debug (read/write) 623584 624256 672 0.1
.bss 74124 74140 16 0.0
.data 1820 1824 4 0.2
.text 541840 542492 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6792796 6792796 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749972 5749972 0 0.0
thermostat-no-ble arm64 (read only) 1943364 1948628 5264 0.3
(read/write) 136865 137041 176 0.1
.bss 59441 59457 16 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70312 152 0.2
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 272 8 3.0
.rodata 125300 125604 304 0.2
.text 1610912 1615712 4800 0.3
p6 all-clusters-app default (read/write) 2360184 2361096 912 0.0
.bss 113108 113132 24 0.0
.data 2512 2512 0 0.0
.heap 917720 917696 -24 -0.0
.text 1318448 1319360 912 0.1
light-app default (read/write) 2292984 2292144 -840 -0.0
.bss 100880 100888 8 0.0
.data 2352 2360 8 0.3
.heap 930112 930096 -16 -0.0
.text 1251248 1250408 -840 -0.1
lock-app default (read/write) 2269048 2269960 912 0.0
.bss 99760 99776 16 0.0
.data 2320 2320 0 0.0
.heap 931264 931248 -16 -0.0
.text 1227312 1228224 912 0.1
qpg lighting-app qpg6100+debug (read only) 520324 519556 -768 -0.1
(read/write) 122336 122332 -4 -0.0
.bss 82616 82624 8 0.0
.data 984 988 4 0.4
.text 515004 514236 -768 -0.1
lock-app qpg6100+debug (read only) 494700 495360 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81752 81768 16 0.0
.data 940 944 4 0.4
.text 489380 490040 660 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 808806 -964 -0.1
bss 82736 82752 16 0.0
noinit 37160 37160 0 0.0
text 565274 564432 -842 -0.1

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12810: Size comparison from 83aac59 to 6d58ecf

Increases above 0.2%:

platform target config section 83aac59 6d58ecf change % change
linux thermostat-no-ble arm64 (read only) 1947044 1952324 5280 0.3
.init_array 272 280 8 2.9
.text 1614096 1618896 4800 0.3
p6 all-clusters-app default .data 2520 2528 8 0.3
light-app default .data 2360 2368 8 0.3
qpg lighting-app qpg6100+debug .data 992 996 4 0.4
lock-app qpg6100+debug .data 948 952 4 0.4
Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 6d58ecf change % change
efr32 lighting-app BRD4161A (read/write) 123148 123168 20 0.0
.bss 121288 121304 16 0.0
.data 1860 1864 4 0.2
BRD4161A+rpc (read/write) 139824 139848 24 0.0
.bss 137864 137880 16 0.0
.data 1960 1964 4 0.2
window-app BRD4161A (read only) 786164 787084 920 0.1
(read/write) 121280 121300 20 0.0
.bss 119456 119472 16 0.0
.data 1824 1828 4 0.2
.text 786156 787076 920 0.1
k32w lighting-app k32w061+se05x+release .bss 73872 73888 16 0.0
.data 1892 1896 4 0.2
lock-app k32w061+debug (read/write) 619524 620196 672 0.1
.bss 72024 72040 16 0.0
.data 1852 1856 4 0.2
.text 539848 540500 652 0.1
shell k32w061+debug (read/write) 624624 625296 672 0.1
.bss 74252 74268 16 0.0
.data 1832 1836 4 0.2
.text 542740 543392 652 0.1
linux thermostat-no-ble arm64 (read only) 1947044 1952324 5280 0.3
(read/write) 137201 137377 176 0.1
.bss 59601 59617 16 0.0
.data.rel.ro 70304 70456 152 0.2
.init_array 272 280 8 2.9
.rodata 125444 125748 304 0.2
.text 1614096 1618896 4800 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2324984 656 0.0
.bss 185108 185132 24 0.0
.data 5240 5248 8 0.2
.text 1286904 1287560 656 0.1
lighting-app CY8CPROTO_062_4343W+release .bss 175824 175832 8 0.0
.data 5528 5536 8 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2282712 648 0.0
.bss 174864 174880 16 0.0
.data 5520 5528 8 0.1
.text 1244664 1245312 648 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116296 116312 16 0.0
nrf52840dk_nrf52840+rpc bss 112644 112660 16 0.0
nrf5340dk_nrf5340_cpuapp bss 117672 117684 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 880107 700 0.1
bss 113560 113576 16 0.0
rodata 98096 98172 76 0.1
text 592356 592936 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805666 806350 684 0.1
bss 114968 114988 20 0.0
rodata 93388 93464 76 0.1
text 522876 523456 580 0.1
pump-app nrf52840dk_nrf52840 (read/write) 884347 885047 700 0.1
bss 113472 113488 16 0.0
rodata 99452 99528 76 0.1
text 595948 596536 588 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 878255 668 0.1
bss 113348 113368 20 0.0
rodata 97588 97664 76 0.1
text 591144 591736 592 0.1
p6 all-clusters-app default (read/write) 2361904 2362816 912 0.0
.bss 113244 113268 24 0.0
.data 2520 2528 8 0.3
.text 1320168 1321080 912 0.1
light-app default .bss 101016 101024 8 0.0
.data 2360 2368 8 0.3
lock-app default (read/write) 2270784 2271696 912 0.0
.bss 99896 99912 16 0.0
.text 1229048 1229960 912 0.1
qpg lighting-app qpg6100+debug .bss 82712 82720 8 0.0
.data 992 996 4 0.4
lock-app qpg6100+debug (read only) 495696 496348 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81848 81864 16 0.0
.data 948 952 4 0.4
.text 490376 491028 652 0.1
telink lighting-app tlsr9518adk80d bss 82864 82880 16 0.0
Decreases (14 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 6d58ecf change % change
efr32 lighting-app BRD4161A (read only) 809188 808388 -800 -0.1
.text 809180 808380 -800 -0.1
BRD4161A+rpc (read only) 796824 796008 -816 -0.1
.text 796816 796000 -816 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 669576 668828 -748 -0.1
.text 588012 587244 -768 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846096 846064 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2308000 -944 -0.0
.heap 855096 855080 -16 -0.0
.text 1271544 1270600 -944 -0.1
lock-app CY8CPROTO_062_4343W+release .heap 856064 856040 -24 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906015 -780 -0.1
rodata 101980 101840 -140 -0.1
text 612912 612280 -632 -0.1
nrf52840dk_nrf52840+rpc (read/write) 869827 869063 -764 -0.1
rodata 93276 93136 -140 -0.2
text 587640 587008 -632 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832030 -764 -0.1
rodata 97236 97096 -140 -0.1
text 543340 542708 -632 -0.1
p6 all-clusters-app default .heap 917576 917544 -32 -0.0
light-app default (read/write) 2294720 2293880 -840 -0.0
.heap 929968 929952 -16 -0.0
.text 1252984 1252144 -840 -0.1
lock-app default .heap 931120 931104 -16 -0.0
qpg lighting-app qpg6100+debug (read only) 521328 520556 -772 -0.1
(read/write) 122336 122332 -4 -0.0
.text 516008 515236 -772 -0.1
telink lighting-app tlsr9518adk80d (read/write) 810978 810022 -956 -0.1
text 566032 565190 -842 -0.1
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 6d58ecf change % change
efr32 lighting-app BRD4161A (read only) 809188 808388 -800 -0.1
(read/write) 123148 123168 20 0.0
.bss 121288 121304 16 0.0
.data 1860 1864 4 0.2
.text 809180 808380 -800 -0.1
BRD4161A+rpc (read only) 796824 796008 -816 -0.1
(read/write) 139824 139848 24 0.0
.bss 137864 137880 16 0.0
.data 1960 1964 4 0.2
.text 796816 796000 -816 -0.1
window-app BRD4161A (read only) 786164 787084 920 0.1
(read/write) 121280 121300 20 0.0
.bss 119456 119472 16 0.0
.data 1824 1828 4 0.2
.text 786156 787076 920 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669576 668828 -748 -0.1
.bss 73872 73888 16 0.0
.data 1892 1896 4 0.2
.text 588012 587244 -768 -0.1
lock-app k32w061+debug (read/write) 619524 620196 672 0.1
.bss 72024 72040 16 0.0
.data 1852 1856 4 0.2
.text 539848 540500 652 0.1
shell k32w061+debug (read/write) 624624 625296 672 0.1
.bss 74252 74268 16 0.0
.data 1832 1836 4 0.2
.text 542740 543392 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6864588 6864588 0 0.0
(read/write) 318785 318785 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364700 364700 0 0.0
.text 5820228 5820228 0 0.0
thermostat-no-ble arm64 (read only) 1947044 1952324 5280 0.3
(read/write) 137201 137377 176 0.1
.bss 59601 59617 16 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70456 152 0.2
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 280 8 2.9
.rodata 125444 125748 304 0.2
.text 1614096 1618896 4800 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324984 656 0.0
.bss 185108 185132 24 0.0
.data 5240 5248 8 0.2
.heap 846096 846064 -32 -0.0
.text 1286904 1287560 656 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308000 -944 -0.0
.bss 175824 175832 8 0.0
.data 5528 5536 8 0.1
.heap 855096 855080 -16 -0.0
.text 1271544 1270600 -944 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282712 648 0.0
.bss 174864 174880 16 0.0
.data 5520 5528 8 0.1
.heap 856064 856040 -24 -0.0
.text 1244664 1245312 648 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906015 -780 -0.1
bss 116296 116312 16 0.0
rodata 101980 101840 -140 -0.1
text 612912 612280 -632 -0.1
nrf52840dk_nrf52840+rpc (read/write) 869827 869063 -764 -0.1
bss 112644 112660 16 0.0
rodata 93276 93136 -140 -0.2
text 587640 587008 -632 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832030 -764 -0.1
bss 117672 117684 12 0.0
rodata 97236 97096 -140 -0.1
text 543340 542708 -632 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 879407 880107 700 0.1
bss 113560 113576 16 0.0
rodata 98096 98172 76 0.1
text 592356 592936 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805666 806350 684 0.1
bss 114968 114988 20 0.0
rodata 93388 93464 76 0.1
text 522876 523456 580 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 885047 700 0.1
bss 113472 113488 16 0.0
rodata 99452 99528 76 0.1
text 595948 596536 588 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 878255 668 0.1
bss 113348 113368 20 0.0
rodata 97588 97664 76 0.1
text 591144 591736 592 0.1
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2362816 912 0.0
.bss 113244 113268 24 0.0
.data 2520 2528 8 0.3
.heap 917576 917544 -32 -0.0
.text 1320168 1321080 912 0.1
light-app default (read/write) 2294720 2293880 -840 -0.0
.bss 101016 101024 8 0.0
.data 2360 2368 8 0.3
.heap 929968 929952 -16 -0.0
.text 1252984 1252144 -840 -0.1
lock-app default (read/write) 2270784 2271696 912 0.0
.bss 99896 99912 16 0.0
.data 2328 2328 0 0.0
.heap 931120 931104 -16 -0.0
.text 1229048 1229960 912 0.1
qpg lighting-app qpg6100+debug (read only) 521328 520556 -772 -0.1
(read/write) 122336 122332 -4 -0.0
.bss 82712 82720 8 0.0
.data 992 996 4 0.4
.text 516008 515236 -772 -0.1
lock-app qpg6100+debug (read only) 495696 496348 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81848 81864 16 0.0
.data 948 952 4 0.4
.text 490376 491028 652 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 810022 -956 -0.1
bss 82864 82880 16 0.0
noinit 37160 37160 0 0.0
text 566032 565190 -842 -0.1

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12810: Size comparison from 03cf99c to d9b0702

Increases above 0.2%:

platform target config section 03cf99c d9b0702 change % change
linux thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
.init_array 272 280 8 2.9
.text 1614704 1619488 4784 0.3
p6 all-clusters-app default .data 2520 2528 8 0.3
light-app default .data 2360 2368 8 0.3
qpg lighting-app qpg6100+debug .data 992 996 4 0.4
lock-app qpg6100+debug .data 948 952 4 0.4
Increases (16 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 03cf99c d9b0702 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data.rel.ro 70344 70496 152 0.2
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313616 2314264 648 0.0
.bss 184284 184300 16 0.0
.data 5232 5240 8 0.2
.text 1276192 1276840 648 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2282160 2282808 648 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.text 1244760 1245408 648 0.1
p6 all-clusters-app default (read/write) 2360168 2361056 888 0.0
.bss 112484 112500 16 0.0
.data 2520 2528 8 0.3
.text 1318432 1319320 888 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496452 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491132 652 0.1
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
text 566528 567124 596 0.1
Decreases (7 builds for mbed, p6, qpg)
platform target config section 03cf99c d9b0702 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846928 846904 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855112 855088 -24 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856080 856056 -24 -0.0
p6 all-clusters-app default .heap 918336 918312 -24 -0.0
light-app default .heap 929920 929896 -24 -0.0
lock-app default .heap 931072 931056 -16 -0.0
qpg lighting-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 03cf99c d9b0702 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6847340 6847340 0 0.0
(read/write) 318945 318945 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208712 208712 0 0.0
.dynamic 560 560 0 0.0
.got 53424 53424 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 363964 363964 0 0.0
.text 5802388 5802388 0 0.0
thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data 832 832 0 0.0
.data.rel.ro 70344 70496 152 0.2
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313616 2314264 648 0.0
.bss 184284 184300 16 0.0
.data 5232 5240 8 0.2
.heap 846928 846904 -24 -0.0
.text 1276192 1276840 648 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.heap 855112 855088 -24 -0.0
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282160 2282808 648 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.heap 856080 856056 -24 -0.0
.text 1244760 1245408 648 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
p6 all-clusters-app default (read/write) 2360168 2361056 888 0.0
.bss 112484 112500 16 0.0
.data 2520 2528 8 0.3
.heap 918336 918312 -24 -0.0
.text 1318432 1319320 888 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.heap 929920 929896 -24 -0.0
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.data 2328 2328 0 0.0
.heap 931072 931056 -16 -0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
(read/write) 122336 122332 -4 -0.0
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496452 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491132 652 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
noinit 37160 37160 0 0.0
text 566528 567124 596 0.1

@github-actions
Copy link

PR #12810: Size comparison from 01421b9 to 690f2e2

Increases (1 build for telink)
platform target config section 01421b9 690f2e2 change % change
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
text 566528 567124 596 0.1
Full report (1 build for telink)
platform target config section 01421b9 690f2e2 change % change
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
noinit 37160 37160 0 0.0
text 566528 567124 596 0.1

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12810: Size comparison from f27c939 to 828ec46

Increases above 0.2%:

platform target config section f27c939 828ec46 change % change
linux thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
.init_array 272 280 8 2.9
.text 1614704 1619488 4784 0.3
p6 all-clusters-app default .data 2520 2528 8 0.3
light-app default .data 2360 2368 8 0.3
qpg lighting-app qpg6100+debug .data 992 996 4 0.4
lock-app qpg6100+debug .data 948 952 4 0.4
Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f27c939 828ec46 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data.rel.ro 70344 70496 152 0.2
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313248 2313904 656 0.0
.bss 183948 183964 16 0.0
.data 5232 5240 8 0.2
.text 1275824 1276480 656 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2282160 2282808 648 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.text 1244760 1245408 648 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 907639 700 0.1
bss 116280 116300 20 0.0
rodata 101932 102008 76 0.1
text 613140 613728 588 0.1
nrf52840dk_nrf52840+rpc (read/write) 869987 870687 700 0.1
bss 112628 112648 20 0.0
rodata 93228 93304 76 0.1
text 587884 588468 584 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832938 833638 700 0.1
bss 117656 117672 16 0.0
rodata 97188 97264 76 0.1
text 543568 544152 584 0.1
lock-app nrf52840dk_nrf52840 (read/write) 879599 880251 652 0.1
bss 113544 113560 16 0.0
rodata 98048 98124 76 0.1
text 592584 593164 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805838 806490 652 0.1
bss 114952 114972 20 0.0
rodata 93336 93412 76 0.1
text 523104 523680 576 0.1
pump-app nrf52840dk_nrf52840 (read/write) 884535 885203 668 0.1
bss 113456 113472 16 0.0
rodata 99400 99476 76 0.1
text 596176 596764 588 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 878447 716 0.1
bss 113332 113352 20 0.0
rodata 97540 97616 76 0.1
text 591372 591964 592 0.1
p6 all-clusters-app default (read/write) 2359800 2360696 896 0.0
.bss 112148 112164 16 0.0
.data 2520 2528 8 0.3
.text 1318064 1318960 896 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496452 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491132 652 0.1
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
text 566528 567124 596 0.1
Decreases (7 builds for mbed, p6, qpg)
platform target config section f27c939 828ec46 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 847264 847240 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855112 855088 -24 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856080 856056 -24 -0.0
p6 all-clusters-app default .heap 918672 918648 -24 -0.0
light-app default .heap 929920 929896 -24 -0.0
lock-app default .heap 931072 931056 -16 -0.0
qpg lighting-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f27c939 828ec46 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6861276 6861276 0 0.0
(read/write) 318657 318657 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208384 208384 0 0.0
.dynamic 560 560 0 0.0
.got 53456 53456 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364972 364972 0 0.0
.text 5816212 5816212 0 0.0
thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data 832 832 0 0.0
.data.rel.ro 70344 70496 152 0.2
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313248 2313904 656 0.0
.bss 183948 183964 16 0.0
.data 5232 5240 8 0.2
.heap 847264 847240 -24 -0.0
.text 1275824 1276480 656 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.heap 855112 855088 -24 -0.0
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282160 2282808 648 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.heap 856080 856056 -24 -0.0
.text 1244760 1245408 648 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 907639 700 0.1
bss 116280 116300 20 0.0
rodata 101932 102008 76 0.1
text 613140 613728 588 0.1
nrf52840dk_nrf52840+rpc (read/write) 869987 870687 700 0.1
bss 112628 112648 20 0.0
rodata 93228 93304 76 0.1
text 587884 588468 584 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832938 833638 700 0.1
bss 117656 117672 16 0.0
rodata 97188 97264 76 0.1
text 543568 544152 584 0.1
lock-app nrf52840dk_nrf52840 (read/write) 879599 880251 652 0.1
bss 113544 113560 16 0.0
rodata 98048 98124 76 0.1
text 592584 593164 580 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805838 806490 652 0.1
bss 114952 114972 20 0.0
rodata 93336 93412 76 0.1
text 523104 523680 576 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884535 885203 668 0.1
bss 113456 113472 16 0.0
rodata 99400 99476 76 0.1
text 596176 596764 588 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 878447 716 0.1
bss 113332 113352 20 0.0
rodata 97540 97616 76 0.1
text 591372 591964 592 0.1
shell nrf52840dk_nrf52840 (read/write) 782283 782283 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523852 523852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697362 697362 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444492 444492 0 0.0
p6 all-clusters-app default (read/write) 2359800 2360696 896 0.0
.bss 112148 112164 16 0.0
.data 2520 2528 8 0.3
.heap 918672 918648 -24 -0.0
.text 1318064 1318960 896 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.heap 929920 929896 -24 -0.0
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.data 2328 2328 0 0.0
.heap 931072 931056 -16 -0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
(read/write) 122336 122332 -4 -0.0
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496452 652 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491132 652 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
noinit 37160 37160 0 0.0
text 566528 567124 596 0.1

@boring-cyborg boring-cyborg bot added the darwin label Dec 11, 2021
@github-actions
Copy link

github-actions bot commented Dec 11, 2021 •
edited
Loading

PR #12810: Size comparison from f27c939 to 1d32862

Increases above 0.2%:

platform target config section f27c939 1d32862 change % change
linux thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
.init_array 272 280 8 2.9
.text 1614704 1619488 4784 0.3
p6 all-clusters-app default .data 2520 2528 8 0.3
light-app default .data 2360 2368 8 0.3
qpg lighting-app qpg6100+debug .data 992 996 4 0.4
lock-app qpg6100+debug .data 948 952 4 0.4
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f27c939 1d32862 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
esp32 all-clusters-app c3devkit (read only) 856438 857000 562 0.1
(read/write) 1304266 1304370 104 0.0
.dram0.bss 64680 64696 16 0.0
.flash.rodata 172424 172512 88 0.1
.flash.text 856438 857000 562 0.1
m5stack (read only) 960075 960631 556 0.1
(read/write) 449992 450084 92 0.0
.dram0.bss 73960 73976 16 0.0
.flash.rodata 210196 210272 76 0.0
.flash.text 954691 955247 556 0.1
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6861276 6861404 128 0.0
.rodata 364972 364988 16 0.0
.text 5816212 5816324 112 0.0
thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data.rel.ro 70344 70496 152 0.2
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313248 2313904 656 0.0
.bss 183948 183964 16 0.0
.data 5232 5240 8 0.2
.text 1275824 1276480 656 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2282160 2282872 712 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.text 1244760 1245472 712 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 907639 700 0.1
bss 116280 116300 20 0.0
rodata 101932 102008 76 0.1
text 613140 613732 592 0.1
nrf52840dk_nrf52840+rpc (read/write) 869987 870687 700 0.1
bss 112628 112648 20 0.0
rodata 93228 93304 76 0.1
text 587884 588472 588 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832938 833638 700 0.1
bss 117656 117672 16 0.0
rodata 97188 97264 76 0.1
text 543568 544156 588 0.1
lock-app nrf52840dk_nrf52840 (read/write) 879599 880251 652 0.1
bss 113544 113560 16 0.0
rodata 98048 98124 76 0.1
text 592584 593168 584 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805838 806506 668 0.1
bss 114952 114972 20 0.0
rodata 93336 93412 76 0.1
text 523104 523684 580 0.1
pump-app nrf52840dk_nrf52840 (read/write) 884535 885203 668 0.1
bss 113456 113472 16 0.0
rodata 99400 99476 76 0.1
text 596176 596768 592 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 878447 716 0.1
bss 113332 113352 20 0.0
rodata 97540 97616 76 0.1
text 591372 591968 596 0.1
p6 all-clusters-app default (read/write) 2359800 2360696 896 0.0
.bss 112148 112164 16 0.0
.data 2520 2528 8 0.3
.text 1318064 1318960 896 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496460 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491140 660 0.1
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
text 566528 567124 596 0.1
Decreases (7 builds for mbed, p6, qpg)
platform target config section f27c939 1d32862 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 847264 847240 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855112 855088 -24 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856080 856056 -24 -0.0
p6 all-clusters-app default .heap 918672 918648 -24 -0.0
light-app default .heap 929920 929896 -24 -0.0
lock-app default .heap 931072 931056 -16 -0.0
qpg lighting-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f27c939 1d32862 change % change
efr32 lighting-app BRD4161A (read only) 814844 815748 904 0.1
(read/write) 123132 123152 20 0.0
.bss 121272 121288 16 0.0
.data 1860 1864 4 0.2
.text 814836 815740 904 0.1
BRD4161A+rpc (read only) 802476 803380 904 0.1
(read/write) 139808 139828 20 0.0
.bss 137848 137864 16 0.0
.data 1960 1964 4 0.2
.text 802468 803372 904 0.1
window-app BRD4161A (read only) 791920 792832 912 0.1
(read/write) 122080 122104 24 0.0
.bss 120256 120272 16 0.0
.data 1824 1828 4 0.2
.text 791912 792824 912 0.1
esp32 all-clusters-app c3devkit (read only) 856438 857000 562 0.1
(read/write) 1304266 1304370 104 0.0
.dram0.bss 64680 64696 16 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172424 172512 88 0.1
.flash.text 856438 857000 562 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960075 960631 556 0.1
(read/write) 449992 450084 92 0.0
.dram0.bss 73960 73976 16 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210196 210272 76 0.0
.flash.text 954691 955247 556 0.1
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669632 670320 688 0.1
.bss 73856 73872 16 0.0
.data 1892 1896 4 0.2
.text 588084 588752 668 0.1
lock-app k32w061+debug (read/write) 619584 620256 672 0.1
.bss 72008 72024 16 0.0
.data 1852 1856 4 0.2
.text 539924 540576 652 0.1
shell k32w061+debug (read/write) 624904 625576 672 0.1
.bss 74316 74332 16 0.0
.data 1832 1836 4 0.2
.text 542956 543608 652 0.1
linux chip-tool-ipv6only arm64 (read only) 6861276 6861404 128 0.0
(read/write) 318657 318657 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208384 208384 0 0.0
.dynamic 560 560 0 0.0
.got 53456 53456 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364972 364988 16 0.0
.text 5816212 5816324 112 0.0
thermostat-no-ble arm64 (read only) 1947956 1953204 5248 0.3
(read/write) 137185 137377 192 0.1
.bss 59505 59537 32 0.1
.data 832 832 0 0.0
.data.rel.ro 70344 70496 152 0.2
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 280 8 2.9
.rodata 125476 125780 304 0.2
.text 1614704 1619488 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313248 2313904 656 0.0
.bss 183948 183964 16 0.0
.data 5232 5240 8 0.2
.heap 847264 847240 -24 -0.0
.text 1275824 1276480 656 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309040 2309760 720 0.0
.bss 175808 175824 16 0.0
.data 5528 5536 8 0.1
.heap 855112 855088 -24 -0.0
.text 1271640 1272360 720 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282160 2282872 712 0.0
.bss 174848 174864 16 0.0
.data 5520 5528 8 0.1
.heap 856080 856056 -24 -0.0
.text 1244760 1245472 712 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 907639 700 0.1
bss 116280 116300 20 0.0
rodata 101932 102008 76 0.1
text 613140 613732 592 0.1
nrf52840dk_nrf52840+rpc (read/write) 869987 870687 700 0.1
bss 112628 112648 20 0.0
rodata 93228 93304 76 0.1
text 587884 588472 588 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832938 833638 700 0.1
bss 117656 117672 16 0.0
rodata 97188 97264 76 0.1
text 543568 544156 588 0.1
lock-app nrf52840dk_nrf52840 (read/write) 879599 880251 652 0.1
bss 113544 113560 16 0.0
rodata 98048 98124 76 0.1
text 592584 593168 584 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805838 806506 668 0.1
bss 114952 114972 20 0.0
rodata 93336 93412 76 0.1
text 523104 523684 580 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884535 885203 668 0.1
bss 113456 113472 16 0.0
rodata 99400 99476 76 0.1
text 596176 596768 592 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 878447 716 0.1
bss 113332 113352 20 0.0
rodata 97540 97616 76 0.1
text 591372 591968 596 0.1
shell nrf52840dk_nrf52840 (read/write) 782283 782283 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523852 523852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697362 697362 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444492 444492 0 0.0
p6 all-clusters-app default (read/write) 2359800 2360696 896 0.0
.bss 112148 112164 16 0.0
.data 2520 2528 8 0.3
.heap 918672 918648 -24 -0.0
.text 1318064 1318960 896 0.1
light-app default (read/write) 2300384 2301296 912 0.0
.bss 101064 101080 16 0.0
.data 2360 2368 8 0.3
.heap 929920 929896 -24 -0.0
.text 1258648 1259560 912 0.1
lock-app default (read/write) 2276456 2277360 904 0.0
.bss 99944 99960 16 0.0
.data 2328 2328 0 0.0
.heap 931072 931056 -16 -0.0
.text 1234720 1235624 904 0.1
qpg lighting-app qpg6100+debug (read only) 521412 522080 668 0.1
(read/write) 122336 122332 -4 -0.0
.bss 82696 82712 16 0.0
.data 992 996 4 0.4
.text 516092 516760 668 0.1
lock-app qpg6100+debug (read only) 495800 496460 660 0.1
(read/write) 122332 122336 4 0.0
.bss 81832 81848 16 0.0
.data 948 952 4 0.4
.text 490480 491140 660 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811418 812118 700 0.1
bss 82848 82864 16 0.0
noinit 37160 37160 0 0.0
text 566528 567124 596 0.1

@bzbarsky-apple bzbarsky-apple merged commit ed19251 into project-chip:master Dec 11, 2021
@yufengwangca yufengwangca deleted the pr/cluster/fixlabel branch December 11, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app darwin examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @electrocucaracha @yunhanw-google @bzbarsky-apple