Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle [ota-requestor] Switch shell commands to use the common code #12806

Closed
wants to merge 4 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Dec 9, 2021

A duplicate of #12804 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

Damian-Nordic and others added 4 commits December 9, 2021 15:41
1. Make OTARequestor class able to send ApplyUpdate command.
2. Add Apply() method OTAImageProcessor so that an image can
   be applied on ApplyUpdateResponse.
@restyled-io restyled-io bot added the restyled label Dec 9, 2021
@todo
Copy link

todo bot commented Dec 9, 2021

Call OTARequestorDriver to schedule the image application.

// TODO: Call OTARequestorDriver to schedule the image application.
switch (response.action)
{
case EMBER_ZCL_OTA_APPLY_UPDATE_ACTION_PROCEED: {
VerifyOrReturn(requestorCore->mBdxDownloader != nullptr, ChipLogError(SoftwareUpdate, "Downloader is not set"));
OTAImageProcessorInterface * imageProcessor = requestorCore->mBdxDownloader->GetImageProcessorDelegate();
VerifyOrReturn(imageProcessor != nullptr, ChipLogError(SoftwareUpdate, "Image processor is not set"));
imageProcessor->Apply();
break;
}
default:


This comment was generated by todo based on a TODO comment in 60d0cc0 in #12806. cc @project-chip.

@todo
Copy link

todo bot commented Dec 9, 2021

remove dependency of OTA shell on controller-clusters

# TODO: remove dependency of OTA shell on controller-clusters
include_dirs = [ "${chip_root}/zzz_generated/controller-clusters" ]
}
if (chip_device_platform != "none") {


This comment was generated by todo based on a TODO comment in 60d0cc0 in #12806. cc @project-chip.

@restyled-io restyled-io bot closed this Dec 9, 2021
@restyled-io restyled-io bot deleted the restyled/ota-shell branch December 9, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants