Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app] Move CASESessionManager to server internal storage #12778

Merged
merged 4 commits into from
Dec 14, 2021
Merged

[app] Move CASESessionManager to server internal storage #12778

merged 4 commits into from
Dec 14, 2021

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Dec 9, 2021 •
edited
Loading

Problem

CASESessionManager is now only availabe on linux devices.
For OTA and binding cluster to work, we need to share the CASESessionManager with the OTA requestor on all platforms.

Changes

Move CASESessionManager to the Server class.

Test

Tested with OTA requestor & provider.

@pullapprove pullapprove bot requested a review from xylophone21 December 10, 2021 04:39
@gjc13 gjc13 force-pushed the server-internal-pool branch from 6816b08 to 7335eb8 Compare December 10, 2021 04:39
@boring-cyborg boring-cyborg bot added the lib label Dec 10, 2021
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12778: Size comparison from a37aab5 to 7335eb8

Increases above 0.2%:

platform target config section a37aab5 7335eb8 change % change
efr32 lighting-app BRD4161A (read only) 808964 825704 16740 2.1
(read/write) 123020 129392 6372 5.2
.bss 121160 127528 6368 5.3
.text 808956 825696 16740 2.1
BRD4161A+rpc (read only) 796600 813328 16728 2.1
(read/write) 139696 146064 6368 4.6
.bss 137736 144104 6368 4.6
.text 796592 813320 16728 2.1
window-app BRD4161A (read only) 785940 802660 16720 2.1
(read/write) 121152 127520 6368 5.3
.bss 119328 125696 6368 5.3
.text 785932 802652 16720 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669336 686988 17652 2.6
.bss 73744 80112 6368 8.6
.text 587900 599184 11284 1.9
lock-app k32w061+debug (read/write) 619284 636924 17640 2.8
.bss 71896 78264 6368 8.9
.text 539736 551008 11272 2.1
shell k32w061+debug (read/write) 624384 641892 17508 2.8
.bss 74124 80492 6368 8.6
.text 542628 553768 11140 2.1
linux chip-tool-ipv6only arm64 (read/write) 318225 323793 5568 1.7
.bss 51713 57121 5408 10.5
thermostat-no-ble arm64 (read only) 1947348 1993020 45672 2.3
(read/write) 137041 145713 8672 6.3
.bss 59441 66801 7360 12.4
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125508 127468 1960 1.6
.text 1614336 1655120 40784 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324264 2344456 20192 0.9
.bss 184980 192244 7264 3.9
.text 1286840 1307032 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308880 2329072 20192 0.9
.bss 175696 182960 7264 4.1
.text 1271480 1291672 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2282000 2302192 20192 0.9
.bss 174736 182000 7264 4.2
.text 1244600 1264792 20192 1.6
p6 all-clusters-app default (read/write) 2361664 2386976 25312 1.1
.bss 113116 120380 7264 6.4
.data 2520 2528 8 0.3
.text 1319928 1345240 25312 1.9
light-app default (read/write) 2294480 2319776 25296 1.1
.bss 100888 108152 7264 7.2
.data 2360 2368 8 0.3
.text 1252744 1278040 25296 2.0
lock-app default (read/write) 2270544 2295832 25288 1.1
.bss 99768 107032 7264 7.3
.text 1228808 1254096 25288 2.1
Increases (14 builds for efr32, k32w, linux, mbed, p6)
platform target config section a37aab5 7335eb8 change % change
efr32 lighting-app BRD4161A (read only) 808964 825704 16740 2.1
(read/write) 123020 129392 6372 5.2
.bss 121160 127528 6368 5.3
.text 808956 825696 16740 2.1
BRD4161A+rpc (read only) 796600 813328 16728 2.1
(read/write) 139696 146064 6368 4.6
.bss 137736 144104 6368 4.6
.text 796592 813320 16728 2.1
window-app BRD4161A (read only) 785940 802660 16720 2.1
(read/write) 121152 127520 6368 5.3
.bss 119328 125696 6368 5.3
.text 785932 802652 16720 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669336 686988 17652 2.6
.bss 73744 80112 6368 8.6
.text 587900 599184 11284 1.9
lock-app k32w061+debug (read/write) 619284 636924 17640 2.8
.bss 71896 78264 6368 8.9
.text 539736 551008 11272 2.1
shell k32w061+debug (read/write) 624384 641892 17508 2.8
.bss 74124 80492 6368 8.6
.text 542628 553768 11140 2.1
linux chip-tool-ipv6only arm64 (read only) 6856796 6859628 2832 0.0
(read/write) 318225 323793 5568 1.7
.bss 51713 57121 5408 10.5
.data.rel.ro 208696 208816 120 0.1
.got 53024 53056 32 0.1
.text 5814164 5816644 2480 0.0
thermostat-no-ble arm64 (read only) 1947348 1993020 45672 2.3
(read/write) 137041 145713 8672 6.3
.bss 59441 66801 7360 12.4
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125508 127468 1960 1.6
.text 1614336 1655120 40784 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324264 2344456 20192 0.9
.bss 184980 192244 7264 3.9
.data 5240 5248 8 0.2
.text 1286840 1307032 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308880 2329072 20192 0.9
.bss 175696 182960 7264 4.1
.data 5528 5536 8 0.1
.text 1271480 1291672 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2282000 2302192 20192 0.9
.bss 174736 182000 7264 4.2
.data 5520 5528 8 0.1
.text 1244600 1264792 20192 1.6
p6 all-clusters-app default (read/write) 2361664 2386976 25312 1.1
.bss 113116 120380 7264 6.4
.data 2520 2528 8 0.3
.text 1319928 1345240 25312 1.9
light-app default (read/write) 2294480 2319776 25296 1.1
.bss 100888 108152 7264 7.2
.data 2360 2368 8 0.3
.text 1252744 1278040 25296 2.0
lock-app default (read/write) 2270544 2295832 25288 1.1
.bss 99768 107032 7264 7.3
.text 1228808 1254096 25288 2.1
Decreases (6 builds for mbed, p6)
platform target config section a37aab5 7335eb8 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846224 838952 -7272 -0.9
lighting-app CY8CPROTO_062_4343W+release .heap 855224 847952 -7272 -0.9
lock-app CY8CPROTO_062_4343W+release .heap 856192 848920 -7272 -0.8
p6 all-clusters-app default .heap 917704 910432 -7272 -0.8
light-app default .heap 930096 922824 -7272 -0.8
lock-app default .heap 931248 923984 -7264 -0.8
Full report (16 builds for efr32, k32w, linux, mbed, p6)
platform target config section a37aab5 7335eb8 change % change
efr32 lighting-app BRD4161A (read only) 808964 825704 16740 2.1
(read/write) 123020 129392 6372 5.2
.bss 121160 127528 6368 5.3
.data 1860 1860 0 0.0
.text 808956 825696 16740 2.1
BRD4161A+rpc (read only) 796600 813328 16728 2.1
(read/write) 139696 146064 6368 4.6
.bss 137736 144104 6368 4.6
.data 1960 1960 0 0.0
.text 796592 813320 16728 2.1
window-app BRD4161A (read only) 785940 802660 16720 2.1
(read/write) 121152 127520 6368 5.3
.bss 119328 125696 6368 5.3
.data 1824 1824 0 0.0
.text 785932 802652 16720 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669336 686988 17652 2.6
.bss 73744 80112 6368 8.6
.data 1892 1892 0 0.0
.text 587900 599184 11284 1.9
lock-app k32w061+debug (read/write) 619284 636924 17640 2.8
.bss 71896 78264 6368 8.9
.data 1852 1852 0 0.0
.text 539736 551008 11272 2.1
shell k32w061+debug (read/write) 624384 641892 17508 2.8
.bss 74124 80492 6368 8.6
.data 1832 1832 0 0.0
.text 542628 553768 11140 2.1
linux chip-tool-ipv6only arm64 (read only) 6856796 6859628 2832 0.0
(read/write) 318225 323793 5568 1.7
.bss 51713 57121 5408 10.5
.data 1096 1096 0 0.0
.data.rel.ro 208696 208816 120 0.1
.dynamic 560 560 0 0.0
.got 53024 53056 32 0.1
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363836 363836 0 0.0
.text 5814164 5816644 2480 0.0
thermostat-no-ble arm64 (read only) 1947348 1993020 45672 2.3
(read/write) 137041 145713 8672 6.3
.bss 59441 66801 7360 12.4
.data 832 832 0 0.0
.data.rel.ro 70304 71472 1168 1.7
.dynamic 560 560 0 0.0
.got 3592 3736 144 4.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 127468 1960 1.6
.text 1614336 1655120 40784 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324264 2344456 20192 0.9
.bss 184980 192244 7264 3.9
.data 5240 5248 8 0.2
.heap 846224 838952 -7272 -0.9
.text 1286840 1307032 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308880 2329072 20192 0.9
.bss 175696 182960 7264 4.1
.data 5528 5536 8 0.1
.heap 855224 847952 -7272 -0.9
.text 1271480 1291672 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282000 2302192 20192 0.9
.bss 174736 182000 7264 4.2
.data 5520 5528 8 0.1
.heap 856192 848920 -7272 -0.8
.text 1244600 1264792 20192 1.6
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
p6 all-clusters-app default (read/write) 2361664 2386976 25312 1.1
.bss 113116 120380 7264 6.4
.data 2520 2528 8 0.3
.heap 917704 910432 -7272 -0.8
.text 1319928 1345240 25312 1.9
light-app default (read/write) 2294480 2319776 25296 1.1
.bss 100888 108152 7264 7.2
.data 2360 2368 8 0.3
.heap 930096 922824 -7272 -0.8
.text 1252744 1278040 25296 2.0
lock-app default (read/write) 2270544 2295832 25288 1.1
.bss 99768 107032 7264 7.3
.data 2328 2328 0 0.0
.heap 931248 923984 -7264 -0.8
.text 1228808 1254096 25288 2.1

@bzbarsky-apple
Copy link
Contributor

So why this move? Neither the commits nor the PR description explain why we want to do this....

@gjc13 gjc13 requested a review from bzbarsky-apple December 10, 2021 05:41
@gjc13
Copy link
Contributor Author

gjc13 commented Dec 10, 2021

So why this move? Neither the commits nor the PR description explain why we want to do this....

Updated PR description.

@gjc13 gjc13 force-pushed the server-internal-pool branch from 7335eb8 to a303882 Compare December 10, 2021 05:45
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12778: Size comparison from d6dfe03 to 1cc39c1

Increases above 0.2%:

platform target config section d6dfe03 1cc39c1 change % change
efr32 lighting-app BRD4161A (read only) 809204 825912 16708 2.1
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.text 809196 825904 16708 2.1
BRD4161A+rpc (read only) 796824 813552 16728 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.text 796816 813544 16728 2.1
window-app BRD4161A (read only) 786180 802884 16704 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.text 786172 802876 16704 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669560 686236 16676 2.5
.bss 73872 79248 5376 7.3
.text 587996 599296 11300 1.9
lock-app k32w061+debug (read/write) 619508 636188 16680 2.7
.bss 72024 77400 5376 7.5
.text 539832 551136 11304 2.1
shell k32w061+debug (read/write) 624608 641124 16516 2.6
.bss 74252 79628 5376 7.2
.text 542724 553864 11140 2.1
linux chip-tool-ipv6only arm64 (read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
thermostat-no-ble arm64 (read only) 1947444 1993116 45672 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125508 127468 1960 1.6
.text 1614432 1655216 40784 2.5
p6 all-clusters-app default (read/write) 2361904 2387200 25296 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.text 1320168 1345464 25296 1.9
light-app default (read/write) 2294704 2320000 25296 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.text 1252968 1278264 25296 2.0
lock-app default (read/write) 2270784 2296056 25272 1.1
.bss 99896 106168 6272 6.3
.text 1229048 1254320 25272 2.1
qpg lighting-app qpg6100+debug (read only) 521320 532680 11360 2.2
.bss 82712 88088 5376 6.5
.text 516000 527360 11360 2.2
lock-app qpg6100+debug (read only) 495688 507036 11348 2.3
.bss 81848 87224 5376 6.6
.text 490368 501716 11348 2.3
telink lighting-app tlsr9518adk80d (read/write) 810954 830378 19424 2.4
bss 82864 88240 5376 6.5
text 566006 578590 12584 2.2
Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d6dfe03 1cc39c1 change % change
efr32 lighting-app BRD4161A (read only) 809204 825912 16708 2.1
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.text 809196 825904 16708 2.1
BRD4161A+rpc (read only) 796824 813552 16728 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.text 796816 813544 16728 2.1
window-app BRD4161A (read only) 786180 802884 16704 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.text 786172 802876 16704 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669560 686236 16676 2.5
.bss 73872 79248 5376 7.3
.text 587996 599296 11300 1.9
lock-app k32w061+debug (read/write) 619508 636188 16680 2.7
.bss 72024 77400 5376 7.5
.text 539832 551136 11304 2.1
shell k32w061+debug (read/write) 624608 641124 16516 2.6
.bss 74252 79628 5376 7.2
.text 542724 553864 11140 2.1
linux chip-tool-ipv6only arm64 (read only) 6864988 6867836 2848 0.0
(read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
.data.rel.ro 208776 208896 120 0.1
.got 53096 53128 32 0.1
.text 5820564 5823044 2480 0.0
thermostat-no-ble arm64 (read only) 1947444 1993116 45672 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125508 127468 1960 1.6
.text 1614432 1655216 40784 2.5
p6 all-clusters-app default (read/write) 2361904 2387200 25296 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.text 1320168 1345464 25296 1.9
light-app default (read/write) 2294704 2320000 25296 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.text 1252968 1278264 25296 2.0
lock-app default (read/write) 2270784 2296056 25272 1.1
.bss 99896 106168 6272 6.3
.text 1229048 1254320 25272 2.1
qpg lighting-app qpg6100+debug (read only) 521320 532680 11360 2.2
.bss 82712 88088 5376 6.5
.text 516000 527360 11360 2.2
lock-app qpg6100+debug (read only) 495688 507036 11348 2.3
.bss 81848 87224 5376 6.6
.text 490368 501716 11348 2.3
telink lighting-app tlsr9518adk80d (read/write) 810954 830378 19424 2.4
bss 82864 88240 5376 6.5
text 566006 578590 12584 2.2
Decreases (3 builds for p6)
platform target config section d6dfe03 1cc39c1 change % change
p6 all-clusters-app default .heap 917576 911296 -6280 -0.7
light-app default .heap 929968 923688 -6280 -0.7
lock-app default .heap 931120 924848 -6272 -0.7
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d6dfe03 1cc39c1 change % change
efr32 lighting-app BRD4161A (read only) 809204 825912 16708 2.1
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.data 1860 1860 0 0.0
.text 809196 825904 16708 2.1
BRD4161A+rpc (read only) 796824 813552 16728 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.data 1960 1960 0 0.0
.text 796816 813544 16728 2.1
window-app BRD4161A (read only) 786180 802884 16704 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.data 1824 1824 0 0.0
.text 786172 802876 16704 2.1
k32w lighting-app k32w061+se05x+release (read/write) 669560 686236 16676 2.5
.bss 73872 79248 5376 7.3
.data 1892 1892 0 0.0
.text 587996 599296 11300 1.9
lock-app k32w061+debug (read/write) 619508 636188 16680 2.7
.bss 72024 77400 5376 7.5
.data 1852 1852 0 0.0
.text 539832 551136 11304 2.1
shell k32w061+debug (read/write) 624608 641124 16516 2.6
.bss 74252 79628 5376 7.2
.data 1832 1832 0 0.0
.text 542724 553864 11140 2.1
linux chip-tool-ipv6only arm64 (read only) 6864988 6867836 2848 0.0
(read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
.data 1192 1192 0 0.0
.data.rel.ro 208776 208896 120 0.1
.dynamic 560 560 0 0.0
.got 53096 53128 32 0.1
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364764 0 0.0
.text 5820564 5823044 2480 0.0
thermostat-no-ble arm64 (read only) 1947444 1993116 45672 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data 832 832 0 0.0
.data.rel.ro 70304 71472 1168 1.7
.dynamic 560 560 0 0.0
.got 3592 3736 144 4.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 127468 1960 1.6
.text 1614432 1655216 40784 2.5
p6 all-clusters-app default (read/write) 2361904 2387200 25296 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.heap 917576 911296 -6280 -0.7
.text 1320168 1345464 25296 1.9
light-app default (read/write) 2294704 2320000 25296 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.heap 929968 923688 -6280 -0.7
.text 1252968 1278264 25296 2.0
lock-app default (read/write) 2270784 2296056 25272 1.1
.bss 99896 106168 6272 6.3
.data 2328 2328 0 0.0
.heap 931120 924848 -6272 -0.7
.text 1229048 1254320 25272 2.1
qpg lighting-app qpg6100+debug (read only) 521320 532680 11360 2.2
(read/write) 122336 122336 0 0.0
.bss 82712 88088 5376 6.5
.data 992 992 0 0.0
.text 516000 527360 11360 2.2
lock-app qpg6100+debug (read only) 495688 507036 11348 2.3
(read/write) 122332 122332 0 0.0
.bss 81848 87224 5376 6.6
.data 948 948 0 0.0
.text 490368 501716 11348 2.3
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 830378 19424 2.4
bss 82864 88240 5376 6.5
noinit 37160 37160 0 0.0
text 566006 578590 12584 2.2

@gjc13 gjc13 force-pushed the server-internal-pool branch from 79f05b4 to b6d0022 Compare December 10, 2021 07:31
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12778: Size comparison from 83aac59 to b6d0022

Increases above 0.2%:

platform target config section 83aac59 b6d0022 change % change
efr32 lighting-app BRD4161A (read only) 809188 825672 16484 2.0
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.text 809180 825664 16484 2.0
BRD4161A+rpc (read only) 796824 813312 16488 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.text 796816 813304 16488 2.1
window-app BRD4161A (read only) 786164 802644 16480 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.text 786156 802636 16480 2.1
esp32 all-clusters-app c3devkit (read only) 862812 882092 19280 2.2
(read/write) 1306058 1314666 8608 0.7
.dram0.bss 65832 72120 6288 9.6
.dram0.data 14124 14188 64 0.5
.flash.rodata 173064 175320 2256 1.3
.flash.text 862812 882092 19280 2.2
m5stack (read only) 966007 968799 2792 0.3
(read/write) 451744 455720 3976 0.9
.dram0.bss 75128 78592 3464 4.6
.flash.rodata 210772 211284 512 0.2
.flash.text 960623 963415 2792 0.3
k32w lighting-app k32w061+se05x+release (read/write) 669576 686220 16644 2.5
.bss 73872 79248 5376 7.3
.text 588012 599280 11268 1.9
lock-app k32w061+debug (read/write) 619524 636172 16648 2.7
.bss 72024 77400 5376 7.5
.text 539848 551120 11272 2.1
shell k32w061+debug (read/write) 624624 641108 16484 2.6
.bss 74252 79628 5376 7.2
.text 542740 553848 11108 2.0
linux chip-tool-ipv6only arm64 (read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
thermostat-no-ble arm64 (read only) 1947044 1992588 45544 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125444 127324 1880 1.5
.text 1614096 1654832 40736 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2344456 20128 0.9
.bss 185108 191380 6272 3.4
.text 1286904 1307032 20128 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2329080 20136 0.9
.bss 175824 182096 6272 3.6
.text 1271544 1291680 20136 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2302192 20128 0.9
.bss 174864 181136 6272 3.6
.text 1244664 1264792 20128 1.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 921639 14844 1.6
bss 116296 119752 3456 3.0
rodata 101980 103272 1292 1.3
text 612912 623012 10100 1.6
nrf52840dk_nrf52840+rpc (read/write) 869827 884675 14848 1.7
bss 112644 116100 3456 3.1
rodata 93276 94572 1296 1.4
text 587640 597740 10100 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 832794 847642 14848 1.8
bss 117672 121128 3456 2.9
rodata 97236 98532 1296 1.3
text 543340 553444 10104 1.9
lock-app nrf52840dk_nrf52840 (read/write) 879407 896399 16992 1.9
bss 113560 118932 5372 4.7
rodata 98096 99392 1296 1.3
text 592356 602664 10308 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 805666 822638 16972 2.1
bss 114968 120340 5372 4.7
rodata 93388 94680 1292 1.4
text 522876 533188 10312 2.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 901319 16972 1.9
bss 113472 118844 5372 4.7
rodata 99452 100744 1292 1.3
text 595948 606252 10304 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 894527 16940 1.9
bss 113348 118720 5372 4.7
rodata 97588 98880 1292 1.3
text 591144 601452 10308 1.7
p6 all-clusters-app default (read/write) 2361904 2386976 25072 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.text 1320168 1345240 25072 1.9
light-app default (read/write) 2294720 2319776 25056 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.text 1252984 1278040 25056 2.0
lock-app default (read/write) 2270784 2295832 25048 1.1
.bss 99896 106168 6272 6.3
.text 1229048 1254096 25048 2.0
qpg lighting-app qpg6100+debug (read only) 521328 532664 11336 2.2
.bss 82712 88088 5376 6.5
.text 516008 527344 11336 2.2
lock-app qpg6100+debug (read only) 495696 507020 11324 2.3
.bss 81848 87224 5376 6.6
.text 490376 501700 11324 2.3
telink lighting-app tlsr9518adk80d (read/write) 810978 830386 19408 2.4
bss 82864 88240 5376 6.5
text 566032 578598 12566 2.2
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 b6d0022 change % change
efr32 lighting-app BRD4161A (read only) 809188 825672 16484 2.0
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.text 809180 825664 16484 2.0
BRD4161A+rpc (read only) 796824 813312 16488 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.text 796816 813304 16488 2.1
window-app BRD4161A (read only) 786164 802644 16480 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.text 786156 802636 16480 2.1
esp32 all-clusters-app c3devkit (read only) 862812 882092 19280 2.2
(read/write) 1306058 1314666 8608 0.7
.dram0.bss 65832 72120 6288 9.6
.dram0.data 14124 14188 64 0.5
.flash.rodata 173064 175320 2256 1.3
.flash.text 862812 882092 19280 2.2
m5stack (read only) 966007 968799 2792 0.3
(read/write) 451744 455720 3976 0.9
.dram0.bss 75128 78592 3464 4.6
.flash.rodata 210772 211284 512 0.2
.flash.text 960623 963415 2792 0.3
k32w lighting-app k32w061+se05x+release (read/write) 669576 686220 16644 2.5
.bss 73872 79248 5376 7.3
.text 588012 599280 11268 1.9
lock-app k32w061+debug (read/write) 619524 636172 16648 2.7
.bss 72024 77400 5376 7.5
.text 539848 551120 11272 2.1
shell k32w061+debug (read/write) 624624 641108 16484 2.6
.bss 74252 79628 5376 7.2
.text 542740 553848 11108 2.0
linux chip-tool-ipv6only arm64 (read only) 6864588 6867420 2832 0.0
(read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
.data.rel.ro 208776 208896 120 0.1
.got 53096 53128 32 0.1
.text 5820228 5822772 2544 0.0
thermostat-no-ble arm64 (read only) 1947044 1992588 45544 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data.rel.ro 70304 71472 1168 1.7
.got 3592 3736 144 4.0
.rodata 125444 127324 1880 1.5
.text 1614096 1654832 40736 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2344456 20128 0.9
.bss 185108 191380 6272 3.4
.data 5240 5248 8 0.2
.text 1286904 1307032 20128 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2329080 20136 0.9
.bss 175824 182096 6272 3.6
.data 5528 5536 8 0.1
.text 1271544 1291680 20136 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2302192 20128 0.9
.bss 174864 181136 6272 3.6
.data 5520 5528 8 0.1
.text 1244664 1264792 20128 1.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 921639 14844 1.6
bss 116296 119752 3456 3.0
rodata 101980 103272 1292 1.3
text 612912 623012 10100 1.6
nrf52840dk_nrf52840+rpc (read/write) 869827 884675 14848 1.7
bss 112644 116100 3456 3.1
rodata 93276 94572 1296 1.4
text 587640 597740 10100 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 832794 847642 14848 1.8
bss 117672 121128 3456 2.9
rodata 97236 98532 1296 1.3
text 543340 553444 10104 1.9
lock-app nrf52840dk_nrf52840 (read/write) 879407 896399 16992 1.9
bss 113560 118932 5372 4.7
rodata 98096 99392 1296 1.3
text 592356 602664 10308 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 805666 822638 16972 2.1
bss 114968 120340 5372 4.7
rodata 93388 94680 1292 1.4
text 522876 533188 10312 2.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 901319 16972 1.9
bss 113472 118844 5372 4.7
rodata 99452 100744 1292 1.3
text 595948 606252 10304 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 894527 16940 1.9
bss 113348 118720 5372 4.7
rodata 97588 98880 1292 1.3
text 591144 601452 10308 1.7
p6 all-clusters-app default (read/write) 2361904 2386976 25072 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.text 1320168 1345240 25072 1.9
light-app default (read/write) 2294720 2319776 25056 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.text 1252984 1278040 25056 2.0
lock-app default (read/write) 2270784 2295832 25048 1.1
.bss 99896 106168 6272 6.3
.text 1229048 1254096 25048 2.0
qpg lighting-app qpg6100+debug (read only) 521328 532664 11336 2.2
.bss 82712 88088 5376 6.5
.text 516008 527344 11336 2.2
lock-app qpg6100+debug (read only) 495696 507020 11324 2.3
.bss 81848 87224 5376 6.6
.text 490376 501700 11324 2.3
telink lighting-app tlsr9518adk80d (read/write) 810978 830386 19408 2.4
bss 82864 88240 5376 6.5
text 566032 578598 12566 2.2
Decreases (7 builds for linux, mbed, p6)
platform target config section 83aac59 b6d0022 change % change
linux chip-tool-ipv6only arm64 .rodata 364700 364620 -80 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846096 839816 -6280 -0.7
lighting-app CY8CPROTO_062_4343W+release .heap 855096 848816 -6280 -0.7
lock-app CY8CPROTO_062_4343W+release .heap 856064 849784 -6280 -0.7
p6 all-clusters-app default .heap 917576 911296 -6280 -0.7
light-app default .heap 929968 923688 -6280 -0.7
lock-app default .heap 931120 924848 -6272 -0.7
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 b6d0022 change % change
efr32 lighting-app BRD4161A (read only) 809188 825672 16484 2.0
(read/write) 123148 128528 5380 4.4
.bss 121288 126664 5376 4.4
.data 1860 1860 0 0.0
.text 809180 825664 16484 2.0
BRD4161A+rpc (read only) 796824 813312 16488 2.1
(read/write) 139824 145200 5376 3.8
.bss 137864 143240 5376 3.9
.data 1960 1960 0 0.0
.text 796816 813304 16488 2.1
window-app BRD4161A (read only) 786164 802644 16480 2.1
(read/write) 121280 126656 5376 4.4
.bss 119456 124832 5376 4.5
.data 1824 1824 0 0.0
.text 786156 802636 16480 2.1
esp32 all-clusters-app c3devkit (read only) 862812 882092 19280 2.2
(read/write) 1306058 1314666 8608 0.7
.dram0.bss 65832 72120 6288 9.6
.dram0.data 14124 14188 64 0.5
.flash.rodata 173064 175320 2256 1.3
.flash.text 862812 882092 19280 2.2
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966007 968799 2792 0.3
(read/write) 451744 455720 3976 0.9
.dram0.bss 75128 78592 3464 4.6
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 211284 512 0.2
.flash.text 960623 963415 2792 0.3
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 686220 16644 2.5
.bss 73872 79248 5376 7.3
.data 1892 1892 0 0.0
.text 588012 599280 11268 1.9
lock-app k32w061+debug (read/write) 619524 636172 16648 2.7
.bss 72024 77400 5376 7.5
.data 1852 1852 0 0.0
.text 539848 551120 11272 2.1
shell k32w061+debug (read/write) 624624 641108 16484 2.6
.bss 74252 79628 5376 7.2
.data 1832 1832 0 0.0
.text 542740 553848 11108 2.0
linux chip-tool-ipv6only arm64 (read only) 6864588 6867420 2832 0.0
(read/write) 318785 323025 4240 1.3
.bss 51985 56081 4096 7.9
.data 1192 1192 0 0.0
.data.rel.ro 208776 208896 120 0.1
.dynamic 560 560 0 0.0
.got 53096 53128 32 0.1
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364700 364620 -80 -0.0
.text 5820228 5822772 2544 0.0
thermostat-no-ble arm64 (read only) 1947044 1992588 45544 2.3
(read/write) 137201 144545 7344 5.4
.bss 59601 65633 6032 10.1
.data 832 832 0 0.0
.data.rel.ro 70304 71472 1168 1.7
.dynamic 560 560 0 0.0
.got 3592 3736 144 4.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125444 127324 1880 1.5
.text 1614096 1654832 40736 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2344456 20128 0.9
.bss 185108 191380 6272 3.4
.data 5240 5248 8 0.2
.heap 846096 839816 -6280 -0.7
.text 1286904 1307032 20128 1.6
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2329080 20136 0.9
.bss 175824 182096 6272 3.6
.data 5528 5536 8 0.1
.heap 855096 848816 -6280 -0.7
.text 1271544 1291680 20136 1.6
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2302192 20128 0.9
.bss 174864 181136 6272 3.6
.data 5520 5528 8 0.1
.heap 856064 849784 -6280 -0.7
.text 1244664 1264792 20128 1.6
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 921639 14844 1.6
bss 116296 119752 3456 3.0
rodata 101980 103272 1292 1.3
text 612912 623012 10100 1.6
nrf52840dk_nrf52840+rpc (read/write) 869827 884675 14848 1.7
bss 112644 116100 3456 3.1
rodata 93276 94572 1296 1.4
text 587640 597740 10100 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 832794 847642 14848 1.8
bss 117672 121128 3456 2.9
rodata 97236 98532 1296 1.3
text 543340 553444 10104 1.9
lock-app nrf52840dk_nrf52840 (read/write) 879407 896399 16992 1.9
bss 113560 118932 5372 4.7
rodata 98096 99392 1296 1.3
text 592356 602664 10308 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 805666 822638 16972 2.1
bss 114968 120340 5372 4.7
rodata 93388 94680 1292 1.4
text 522876 533188 10312 2.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 901319 16972 1.9
bss 113472 118844 5372 4.7
rodata 99452 100744 1292 1.3
text 595948 606252 10304 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 894527 16940 1.9
bss 113348 118720 5372 4.7
rodata 97588 98880 1292 1.3
text 591144 601452 10308 1.7
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2386976 25072 1.1
.bss 113244 119516 6272 5.5
.data 2520 2528 8 0.3
.heap 917576 911296 -6280 -0.7
.text 1320168 1345240 25072 1.9
light-app default (read/write) 2294720 2319776 25056 1.1
.bss 101016 107288 6272 6.2
.data 2360 2368 8 0.3
.heap 929968 923688 -6280 -0.7
.text 1252984 1278040 25056 2.0
lock-app default (read/write) 2270784 2295832 25048 1.1
.bss 99896 106168 6272 6.3
.data 2328 2328 0 0.0
.heap 931120 924848 -6272 -0.7
.text 1229048 1254096 25048 2.0
qpg lighting-app qpg6100+debug (read only) 521328 532664 11336 2.2
(read/write) 122336 122336 0 0.0
.bss 82712 88088 5376 6.5
.data 992 992 0 0.0
.text 516008 527344 11336 2.2
lock-app qpg6100+debug (read only) 495696 507020 11324 2.3
(read/write) 122332 122332 0 0.0
.bss 81848 87224 5376 6.6
.data 948 948 0 0.0
.text 490376 501700 11324 2.3
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 830386 19408 2.4
bss 82864 88240 5376 6.5
noinit 37160 37160 0 0.0
text 566032 578598 12566 2.2

@gjc13 gjc13 force-pushed the server-internal-pool branch from b6d0022 to 157de4f Compare December 13, 2021 06:19
@gjc13 gjc13 requested a review from carol-apple December 13, 2021 06:20
@gjc13
Copy link
Contributor Author

gjc13 commented Dec 13, 2021

@carol-apple @andy31415 @bzbarsky-apple PTAL

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12778: Size comparison from f85d6ed to 157de4f

Increases above 0.2%:

platform target config section f85d6ed 157de4f change % change
efr32 lighting-app BRD4161A (read only) 815980 832952 16972 2.1
(read/write) 123152 128552 5400 4.4
.bss 121288 126688 5400 4.5
.text 815972 832944 16972 2.1
BRD4161A+rpc (read only) 803612 820556 16944 2.1
(read/write) 139828 145228 5400 3.9
.bss 137864 143264 5400 3.9
.text 803604 820548 16944 2.1
window-app BRD4161A (read only) 793056 810032 16976 2.1
(read/write) 122104 127504 5400 4.4
.bss 120272 125672 5400 4.5
.text 793048 810024 16976 2.1
esp32 all-clusters-app c3devkit (read only) 857268 876682 19414 2.3
(read/write) 1304378 1312986 8608 0.7
.dram0.bss 64696 71008 6312 9.8
.dram0.data 14124 14188 64 0.5
.flash.rodata 172520 174760 2240 1.3
.flash.text 857268 876682 19414 2.3
m5stack (read only) 960819 964071 3252 0.3
(read/write) 450092 454092 4000 0.9
.dram0.bss 73976 77464 3488 4.7
.flash.text 955435 958687 3252 0.3
k32w lighting-app k32w061+se05x+release (read/write) 670436 687216 16780 2.5
.bss 73872 79272 5400 7.3
.text 588868 600248 11380 1.9
lock-app k32w061+debug (read/write) 620372 637156 16784 2.7
.bss 72024 77424 5400 7.5
.text 540692 552076 11384 2.1
shell k32w061+debug (read/write) 625740 642360 16620 2.7
.bss 74332 79732 5400 7.3
.text 543772 554992 11220 2.1
linux chip-tool-ipv6only arm64 (read/write) 318737 323041 4304 1.4
.bss 51889 56017 4128 8.0
thermostat-no-ble arm64 (read only) 1954356 2000188 45832 2.3
(read/write) 137425 144833 7408 5.4
.bss 59537 65601 6064 10.2
.data.rel.ro 70528 71696 1168 1.7
.got 3648 3816 168 4.6
.rodata 125780 127740 1960 1.6
.text 1620464 1661344 40880 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314104 2334296 20192 0.9
.bss 183964 190260 6296 3.4
.text 1276680 1296872 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309960 2330152 20192 0.9
.bss 175824 182120 6296 3.6
.text 1272560 1292752 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2283072 2303264 20192 0.9
.bss 174864 181160 6296 3.6
.text 1245672 1265864 20192 1.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907735 922727 14992 1.7
bss 116300 119780 3480 3.0
rodata 102008 103304 1296 1.3
text 613828 624040 10212 1.7
nrf52840dk_nrf52840+rpc (read/write) 870803 885759 14956 1.7
bss 112648 116128 3480 3.1
rodata 93308 94600 1292 1.4
text 588572 598784 10212 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 833738 848710 14972 1.8
bss 117672 121152 3480 3.0
rodata 97268 98560 1292 1.3
text 544256 554480 10224 1.9
lock-app nrf52840dk_nrf52840 (read/write) 880351 897483 17132 1.9
bss 113560 118956 5396 4.8
rodata 98128 99420 1292 1.3
text 593264 603684 10420 1.8
nrf5340dk_nrf5340_cpuapp (read/write) 806606 823742 17136 2.1
bss 114972 120368 5396 4.7
rodata 93416 94712 1296 1.4
text 523784 534212 10428 2.0
pump-app nrf52840dk_nrf52840 (read/write) 885303 902423 17120 1.9
bss 113472 118868 5396 4.8
rodata 99480 100776 1296 1.3
text 596868 607284 10416 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 878543 895631 17088 1.9
bss 113352 118748 5396 4.8
rodata 97616 98912 1296 1.3
text 592064 602484 10420 1.8
p6 all-clusters-app default (read/write) 2361000 2386696 25696 1.1
.bss 112164 118460 6296 5.6
.text 1319264 1344960 25696 1.9
light-app default (read/write) 2301600 2327288 25688 1.1
.bss 101080 107376 6296 6.2
.text 1259864 1285552 25688 2.0
lock-app default (read/write) 2277672 2303352 25680 1.1
.bss 99960 106256 6296 6.3
.data 2328 2336 8 0.3
.text 1235936 1261616 25680 2.1
qpg lighting-app qpg6100+debug (read only) 522184 533640 11456 2.2
.bss 82712 88112 5400 6.5
.text 516864 528320 11456 2.2
lock-app qpg6100+debug (read only) 496564 507992 11428 2.3
.bss 81848 87248 5400 6.6
.text 491244 502672 11428 2.3
telink lighting-app tlsr9518adk80d (read/write) 812282 831818 19536 2.4
bss 82864 88264 5400 6.5
text 567284 579950 12666 2.2
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f85d6ed 157de4f change % change
efr32 lighting-app BRD4161A (read only) 815980 832952 16972 2.1
(read/write) 123152 128552 5400 4.4
.bss 121288 126688 5400 4.5
.text 815972 832944 16972 2.1
BRD4161A+rpc (read only) 803612 820556 16944 2.1
(read/write) 139828 145228 5400 3.9
.bss 137864 143264 5400 3.9
.text 803604 820548 16944 2.1
window-app BRD4161A (read only) 793056 810032 16976 2.1
(read/write) 122104 127504 5400 4.4
.bss 120272 125672 5400 4.5
.text 793048 810024 16976 2.1
esp32 all-clusters-app c3devkit (read only) 857268 876682 19414 2.3
(read/write) 1304378 1312986 8608 0.7
.dram0.bss 64696 71008 6312 9.8
.dram0.data 14124 14188 64 0.5
.flash.rodata 172520 174760 2240 1.3
.flash.text 857268 876682 19414 2.3
m5stack (read only) 960819 964071 3252 0.3
(read/write) 450092 454092 4000 0.9
.dram0.bss 73976 77464 3488 4.7
.flash.rodata 210280 210792 512 0.2
.flash.text 955435 958687 3252 0.3
k32w lighting-app k32w061+se05x+release (read/write) 670436 687216 16780 2.5
.bss 73872 79272 5400 7.3
.text 588868 600248 11380 1.9
lock-app k32w061+debug (read/write) 620372 637156 16784 2.7
.bss 72024 77424 5400 7.5
.text 540692 552076 11384 2.1
shell k32w061+debug (read/write) 625740 642360 16620 2.7
.bss 74332 79732 5400 7.3
.text 543772 554992 11220 2.1
linux chip-tool-ipv6only arm64 (read only) 6863180 6866396 3216 0.0
(read/write) 318737 323041 4304 1.4
.bss 51889 56017 4128 8.0
.data.rel.ro 208416 208536 120 0.1
.got 53512 53568 56 0.1
.text 5817828 5820676 2848 0.0
thermostat-no-ble arm64 (read only) 1954356 2000188 45832 2.3
(read/write) 137425 144833 7408 5.4
.bss 59537 65601 6064 10.2
.data.rel.ro 70528 71696 1168 1.7
.got 3648 3816 168 4.6
.rodata 125780 127740 1960 1.6
.text 1620464 1661344 40880 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314104 2334296 20192 0.9
.bss 183964 190260 6296 3.4
.text 1276680 1296872 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309960 2330152 20192 0.9
.bss 175824 182120 6296 3.6
.text 1272560 1292752 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read/write) 2283072 2303264 20192 0.9
.bss 174864 181160 6296 3.6
.text 1245672 1265864 20192 1.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907735 922727 14992 1.7
bss 116300 119780 3480 3.0
rodata 102008 103304 1296 1.3
text 613828 624040 10212 1.7
nrf52840dk_nrf52840+rpc (read/write) 870803 885759 14956 1.7
bss 112648 116128 3480 3.1
rodata 93308 94600 1292 1.4
text 588572 598784 10212 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 833738 848710 14972 1.8
bss 117672 121152 3480 3.0
rodata 97268 98560 1292 1.3
text 544256 554480 10224 1.9
lock-app nrf52840dk_nrf52840 (read/write) 880351 897483 17132 1.9
bss 113560 118956 5396 4.8
rodata 98128 99420 1292 1.3
text 593264 603684 10420 1.8
nrf5340dk_nrf5340_cpuapp (read/write) 806606 823742 17136 2.1
bss 114972 120368 5396 4.7
rodata 93416 94712 1296 1.4
text 523784 534212 10428 2.0
pump-app nrf52840dk_nrf52840 (read/write) 885303 902423 17120 1.9
bss 113472 118868 5396 4.8
rodata 99480 100776 1296 1.3
text 596868 607284 10416 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 878543 895631 17088 1.9
bss 113352 118748 5396 4.8
rodata 97616 98912 1296 1.3
text 592064 602484 10420 1.8
p6 all-clusters-app default (read/write) 2361000 2386696 25696 1.1
.bss 112164 118460 6296 5.6
.text 1319264 1344960 25696 1.9
light-app default (read/write) 2301600 2327288 25688 1.1
.bss 101080 107376 6296 6.2
.text 1259864 1285552 25688 2.0
lock-app default (read/write) 2277672 2303352 25680 1.1
.bss 99960 106256 6296 6.3
.data 2328 2336 8 0.3
.text 1235936 1261616 25680 2.1
qpg lighting-app qpg6100+debug (read only) 522184 533640 11456 2.2
.bss 82712 88112 5400 6.5
.text 516864 528320 11456 2.2
lock-app qpg6100+debug (read only) 496564 507992 11428 2.3
.bss 81848 87248 5400 6.6
.text 491244 502672 11428 2.3
telink lighting-app tlsr9518adk80d (read/write) 812282 831818 19536 2.4
bss 82864 88264 5400 6.5
text 567284 579950 12666 2.2
Decreases (7 builds for linux, mbed, p6)
platform target config section f85d6ed 157de4f change % change
linux chip-tool-ipv6only arm64 .rodata 364988 364924 -64 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 847240 840944 -6296 -0.7
lighting-app CY8CPROTO_062_4343W+release .heap 855088 848792 -6296 -0.7
lock-app CY8CPROTO_062_4343W+release .heap 856056 849760 -6296 -0.7
p6 all-clusters-app default .heap 918648 912352 -6296 -0.7
light-app default .heap 929896 923600 -6296 -0.7
lock-app default .heap 931056 924752 -6304 -0.7
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f85d6ed 157de4f change % change
efr32 lighting-app BRD4161A (read only) 815980 832952 16972 2.1
(read/write) 123152 128552 5400 4.4
.bss 121288 126688 5400 4.5
.data 1864 1864 0 0.0
.text 815972 832944 16972 2.1
BRD4161A+rpc (read only) 803612 820556 16944 2.1
(read/write) 139828 145228 5400 3.9
.bss 137864 143264 5400 3.9
.data 1964 1964 0 0.0
.text 803604 820548 16944 2.1
window-app BRD4161A (read only) 793056 810032 16976 2.1
(read/write) 122104 127504 5400 4.4
.bss 120272 125672 5400 4.5
.data 1828 1828 0 0.0
.text 793048 810024 16976 2.1
esp32 all-clusters-app c3devkit (read only) 857268 876682 19414 2.3
(read/write) 1304378 1312986 8608 0.7
.dram0.bss 64696 71008 6312 9.8
.dram0.data 14124 14188 64 0.5
.flash.rodata 172520 174760 2240 1.3
.flash.text 857268 876682 19414 2.3
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960819 964071 3252 0.3
(read/write) 450092 454092 4000 0.9
.dram0.bss 73976 77464 3488 4.7
.dram0.data 34048 34048 0 0.0
.flash.rodata 210280 210792 512 0.2
.flash.text 955435 958687 3252 0.3
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670436 687216 16780 2.5
.bss 73872 79272 5400 7.3
.data 1896 1896 0 0.0
.text 588868 600248 11380 1.9
lock-app k32w061+debug (read/write) 620372 637156 16784 2.7
.bss 72024 77424 5400 7.5
.data 1856 1856 0 0.0
.text 540692 552076 11384 2.1
shell k32w061+debug (read/write) 625740 642360 16620 2.7
.bss 74332 79732 5400 7.3
.data 1836 1836 0 0.0
.text 543772 554992 11220 2.1
linux chip-tool-ipv6only arm64 (read only) 6863180 6866396 3216 0.0
(read/write) 318737 323041 4304 1.4
.bss 51889 56017 4128 8.0
.data 1192 1192 0 0.0
.data.rel.ro 208416 208536 120 0.1
.dynamic 560 560 0 0.0
.got 53512 53568 56 0.1
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364988 364924 -64 -0.0
.text 5817828 5820676 2848 0.0
thermostat-no-ble arm64 (read only) 1954356 2000188 45832 2.3
(read/write) 137425 144833 7408 5.4
.bss 59537 65601 6064 10.2
.data 832 832 0 0.0
.data.rel.ro 70528 71696 1168 1.7
.dynamic 560 560 0 0.0
.got 3648 3816 168 4.6
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125780 127740 1960 1.6
.text 1620464 1661344 40880 2.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314104 2334296 20192 0.9
.bss 183964 190260 6296 3.4
.data 5240 5240 0 0.0
.heap 847240 840944 -6296 -0.7
.text 1276680 1296872 20192 1.6
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309960 2330152 20192 0.9
.bss 175824 182120 6296 3.6
.data 5536 5536 0 0.0
.heap 855088 848792 -6296 -0.7
.text 1272560 1292752 20192 1.6
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283072 2303264 20192 0.9
.bss 174864 181160 6296 3.6
.data 5528 5528 0 0.0
.heap 856056 849760 -6296 -0.7
.text 1245672 1265864 20192 1.6
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907735 922727 14992 1.7
bss 116300 119780 3480 3.0
rodata 102008 103304 1296 1.3
text 613828 624040 10212 1.7
nrf52840dk_nrf52840+rpc (read/write) 870803 885759 14956 1.7
bss 112648 116128 3480 3.1
rodata 93308 94600 1292 1.4
text 588572 598784 10212 1.7
nrf5340dk_nrf5340_cpuapp (read/write) 833738 848710 14972 1.8
bss 117672 121152 3480 3.0
rodata 97268 98560 1292 1.3
text 544256 554480 10224 1.9
lock-app nrf52840dk_nrf52840 (read/write) 880351 897483 17132 1.9
bss 113560 118956 5396 4.8
rodata 98128 99420 1292 1.3
text 593264 603684 10420 1.8
nrf5340dk_nrf5340_cpuapp (read/write) 806606 823742 17136 2.1
bss 114972 120368 5396 4.7
rodata 93416 94712 1296 1.4
text 523784 534212 10428 2.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885303 902423 17120 1.9
bss 113472 118868 5396 4.8
rodata 99480 100776 1296 1.3
text 596868 607284 10416 1.7
pump-controller-app nrf52840dk_nrf52840 (read/write) 878543 895631 17088 1.9
bss 113352 118748 5396 4.8
rodata 97616 98912 1296 1.3
text 592064 602484 10420 1.8
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2361000 2386696 25696 1.1
.bss 112164 118460 6296 5.6
.data 2528 2528 0 0.0
.heap 918648 912352 -6296 -0.7
.text 1319264 1344960 25696 1.9
light-app default (read/write) 2301600 2327288 25688 1.1
.bss 101080 107376 6296 6.2
.data 2368 2368 0 0.0
.heap 929896 923600 -6296 -0.7
.text 1259864 1285552 25688 2.0
lock-app default (read/write) 2277672 2303352 25680 1.1
.bss 99960 106256 6296 6.3
.data 2328 2336 8 0.3
.heap 931056 924752 -6304 -0.7
.text 1235936 1261616 25680 2.1
qpg lighting-app qpg6100+debug (read only) 522184 533640 11456 2.2
(read/write) 122332 122332 0 0.0
.bss 82712 88112 5400 6.5
.data 996 996 0 0.0
.text 516864 528320 11456 2.2
lock-app qpg6100+debug (read only) 496564 507992 11428 2.3
(read/write) 122336 122336 0 0.0
.bss 81848 87248 5400 6.6
.data 952 952 0 0.0
.text 491244 502672 11428 2.3
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812282 831818 19536 2.4
bss 82864 88264 5400 6.5
noinit 37160 37160 0 0.0
text 567284 579950 12666 2.2

@gjc13 gjc13 mentioned this pull request Dec 14, 2021
Merged
@andy31415
Copy link
Contributor

Generally seems ok - I have some concerns about not coupling things too much (we start having god objects for containing all 'managers'), however we should be able to decouple if we find it necessary.

@andy31415
Copy link
Contributor

fast track: PR up for a while now, change is reasonably small.

@andy31415 andy31415 merged commit 7ead62d into project-chip:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

Assignees
No one assigned
Labels
app examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjc13 @bzbarsky-apple @andy31415 @carol-apple