-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding -Wformat-nonliteral check #12763
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
woody-apple:Wformat-nonliteral
Jan 6, 2022
Merged
Adding -Wformat-nonliteral check #12763
bzbarsky-apple
merged 2 commits into
project-chip:master
from
woody-apple:Wformat-nonliteral
Jan 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
December 9, 2021 01:06
PR #12763: Size comparison from bf7feea to e202c8d Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
andy31415
approved these changes
Jan 5, 2022
msandstedt
approved these changes
Jan 5, 2022
bzbarsky-apple
force-pushed
the
Wformat-nonliteral
branch
from
January 6, 2022 16:31
e202c8d
to
5ee66b3
Compare
PR #12763: Size comparison from 48d299f to 5ee66b3 Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
/rebase |
The ENFORCE_FORMAT annotations help make it clear to the compiler which seemingly-nonliteral values are actually checked to be literals further up the callstack, because we disallow passing a non-literal as the format arg indicated by ENFORCE_FORMAT.
woody-apple
force-pushed
the
Wformat-nonliteral
branch
from
January 6, 2022 17:51
5ee66b3
to
92081f8
Compare
PR #12763: Size comparison from 89b87f1 to 92081f8 Full report (26 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
lmpprk
added a commit
to lmpprk/connectedhomeip
that referenced
this pull request
Jan 16, 2022
lmpprk
added a commit
to lmpprk/connectedhomeip
that referenced
this pull request
Jan 16, 2022
andy31415
pushed a commit
that referenced
this pull request
Jan 17, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Turn on -Wformat-security and -Wformat-nonliteral. The ENFORCE_FORMAT annotations help make it clear to the compiler which seemingly-nonliteral values are actually checked to be literals further up the callstack, because we disallow passing a non-literal as the format arg indicated by ENFORCE_FORMAT. * Address review comments Co-authored-by: Boris Zbarsky <[email protected]>
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This can be a security issue, adding this to the base warrnings
Change overview
Adding -Wformat-nonliteral for clang
Testing
CI