-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate CASE MRP parameters with controller and CASE server #12738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
December 8, 2021 17:28
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
December 8, 2021 17:28
billwatersiii
approved these changes
Dec 8, 2021
PR #12738: Size comparison from 1f4024a to 775fecc Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
pan-apple
force-pushed
the
integrate-case-mrp
branch
from
December 8, 2021 18:44
060753b
to
062b36c
Compare
rebased |
woody-apple
approved these changes
Dec 8, 2021
PR #12738: Size comparison from b1d7073 to 062b36c Increases (18 builds for efr32, linux, nrfconnect, p6, qpg, telink)
Full report (22 builds for efr32, linux, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Dec 8, 2021
msandstedt
approved these changes
Dec 8, 2021
PR #12738: Size comparison from b1d7073 to 3bd2df9 Increases (23 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (29 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
billwatersiii
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CASESession code was updated to use optional MRP parameters. The updated APIs need to be called from controller and CASE Server to enable the feature.
Change overview
Testing
Tested using chip-tool and all-cluster-app.
Also, update PairingSession unit test to match changed API.