-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LogEvent API #12711
Merged
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/improve_log_event
Dec 8, 2021
Merged
Improve LogEvent API #12711
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/improve_log_event
Dec 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
December 8, 2021 05:16
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 8, 2021 05:16
PR #12711: Size comparison from 8c04dce to 6b86167 Decreases (3 builds for esp32, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
robszewczyk
approved these changes
Dec 8, 2021
yufengwangca
reviewed
Dec 8, 2021
yufengwangca
approved these changes
Dec 8, 2021
Damian-Nordic
approved these changes
Dec 8, 2021
fast track: small change, several checkmarks, made by a domain owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Remove EventOptions parameter from LogEvent API and Add isUrgent parameter in LogEventAPI so that Cluster Event implementation would not be confused by things in EventOptions
Change overview
See above
Testing
Existing test covers