Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send/Extract optional MRP parameters in CASE messages #12705

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Send/Extract optional MRP parameters in CASE messages #12705

merged 3 commits into from
Dec 8, 2021

Conversation

billwatersiii
Copy link
Contributor

Problem

Change overview

Optional MRP parameters will be extracted from and/or provided in session messages when available.

Testing

Covered by existing tests.

@restyled-io restyled-io bot mentioned this pull request Dec 7, 2021
Closed
@billwatersiii billwatersiii changed the title Add mrp param to pase Send/Extract optional MRP parameters in CASE messages Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12705: Size comparison from 6f89b9b to d6e76cc

Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f89b9b d6e76cc change % change
efr32 lighting-app BRD4161A (read only) 794784 794940 156 0.0
(read/write) 122992 122996 4 0.0
.bss 121168 121176 8 0.0
.text 794776 794932 156 0.0
BRD4161A+rpc (read only) 822832 822988 156 0.0
(read/write) 141296 141304 8 0.0
.bss 139368 139376 8 0.0
.text 822824 822980 156 0.0
lock-app BRD4161A (read only) 769404 769560 156 0.0
(read/write) 120924 120936 12 0.0
.bss 119144 119152 8 0.0
.text 769396 769552 156 0.0
window-app BRD4161A (read only) 771672 771844 172 0.0
(read/write) 121128 121136 8 0.0
.bss 119344 119352 8 0.0
.text 771664 771836 172 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855784 208 0.0
(read/write) 1305994 1306034 40 0.0
.dram0.bss 67640 67648 8 0.0
.flash.rodata 171192 171232 40 0.0
.flash.text 855576 855784 208 0.0
m5stack (read only) 958323 958687 364 0.0
(read/write) 450236 450268 32 0.0
.dram0.bss 75000 75008 8 0.0
.flash.rodata 209400 209424 24 0.0
.flash.text 952939 953303 364 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731948 732084 136 0.0
.bss 81240 81248 8 0.0
.text 643056 643184 128 0.0
lock-app k32w061+debug (read/write) 622532 622668 136 0.0
.bss 71904 71912 8 0.0
.text 543008 543136 128 0.0
shell k32w061+debug (read/write) 685624 685776 152 0.0
.bss 81604 81612 8 0.0
.text 596428 596572 144 0.0
linux all-clusters-app debug (read only) 1904073 1905065 992 0.1
.rodata 155684 155812 128 0.1
.text 1602626 1603490 864 0.1
bridge-app debug+rpc (read only) 1447877 1448869 992 0.1
.rodata 123460 123588 128 0.1
.text 1219205 1220069 864 0.1
chip-tool debug (read only) 6690005 6691285 1280 0.0
.rodata 335657 335785 128 0.0
.text 5945253 5946405 1152 0.0
lighting-app debug+rpc (read only) 1735633 1736625 992 0.1
(read/write) 110776 110808 32 0.0
.bss 44816 44848 32 0.1
.rodata 144348 144476 128 0.1
.text 1448306 1449170 864 0.1
ota-provider-app debug (read only) 1412313 1413305 992 0.1
.rodata 124894 125022 128 0.1
.text 1182514 1183378 864 0.1
ota-requestor-app debug (read only) 1517033 1518313 1280 0.1
.rodata 137583 137711 128 0.1
.text 1270642 1271794 1152 0.1
tv-app debug (read only) 2044273 2045537 1264 0.1
.rodata 176444 176540 96 0.1
.text 1712802 1713970 1168 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2316128 2316424 296 0.0
.bss 186892 186900 8 0.0
.text 1278704 1279000 296 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2298776 2299072 296 0.0
.bss 175704 175712 8 0.0
.text 1261376 1261672 296 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2271688 2271984 296 0.0
.bss 174744 174752 8 0.0
.text 1234288 1234584 296 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896779 896979 200 0.0
bss 116176 116184 8 0.0
rodata 100132 100172 40 0.0
text 604904 605068 164 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 860003 200 0.0
bss 112524 112532 8 0.0
rodata 91428 91468 40 0.0
text 579632 579796 164 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822926 220 0.0
bss 117552 117560 8 0.0
rodata 95388 95432 44 0.0
text 535276 535448 172 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869215 869451 236 0.0
bss 113440 113448 8 0.0
rodata 96248 96292 44 0.0
text 584160 584324 164 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795402 795650 248 0.0
bss 114848 114856 8 0.0
rodata 91540 91580 40 0.0
text 514624 514800 176 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874299 200 0.0
bss 113352 113360 8 0.0
rodata 97604 97644 40 0.0
text 587676 587844 168 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867523 200 0.0
bss 113228 113236 8 0.0
rodata 95740 95780 40 0.0
text 582896 583060 164 0.0
p6 all-clusters-app default (read/write) 2349808 2350096 288 0.0
.bss 113124 113132 8 0.0
.text 1308072 1308360 288 0.0
light-app default (read/write) 2281112 2281416 304 0.0
.bss 100896 100904 8 0.0
.text 1239376 1239680 304 0.0
lock-app default (read/write) 2257200 2257504 304 0.0
.bss 99776 99784 8 0.0
.text 1215464 1215768 304 0.0
qpg lighting-app qpg6100+debug (read only) 511772 511908 136 0.0
.bss 82616 82624 8 0.0
.text 506452 506588 136 0.0
lock-app qpg6100+debug (read only) 485956 486092 136 0.0
.bss 81752 81760 8 0.0
.text 480636 480772 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 800102 800346 244 0.0
bss 82756 82764 8 0.0
text 557204 557408 204 0.0
Decreases (6 builds for mbed, p6)
platform target config section 6f89b9b d6e76cc change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 844320 844312 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855256 855248 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856216 856208 -8 -0.0
p6 all-clusters-app default .heap 917704 917696 -8 -0.0
light-app default .heap 930120 930112 -8 -0.0
lock-app default .heap 931280 931272 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f89b9b d6e76cc change % change
efr32 lighting-app BRD4161A (read only) 794784 794940 156 0.0
(read/write) 122992 122996 4 0.0
.bss 121168 121176 8 0.0
.data 1820 1820 0 0.0
.text 794776 794932 156 0.0
BRD4161A+rpc (read only) 822832 822988 156 0.0
(read/write) 141296 141304 8 0.0
.bss 139368 139376 8 0.0
.data 1928 1928 0 0.0
.text 822824 822980 156 0.0
lock-app BRD4161A (read only) 769404 769560 156 0.0
(read/write) 120924 120936 12 0.0
.bss 119144 119152 8 0.0
.data 1780 1780 0 0.0
.text 769396 769552 156 0.0
window-app BRD4161A (read only) 771672 771844 172 0.0
(read/write) 121128 121136 8 0.0
.bss 119344 119352 8 0.0
.data 1784 1784 0 0.0
.text 771664 771836 172 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855784 208 0.0
(read/write) 1305994 1306034 40 0.0
.dram0.bss 67640 67648 8 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171232 40 0.0
.flash.text 855576 855784 208 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958323 958687 364 0.0
(read/write) 450236 450268 32 0.0
.dram0.bss 75000 75008 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209424 24 0.0
.flash.text 952939 953303 364 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731948 732084 136 0.0
.bss 81240 81248 8 0.0
.data 1852 1852 0 0.0
.text 643056 643184 128 0.0
lock-app k32w061+debug (read/write) 622532 622668 136 0.0
.bss 71904 71912 8 0.0
.data 1820 1820 0 0.0
.text 543008 543136 128 0.0
shell k32w061+debug (read/write) 685624 685776 152 0.0
.bss 81604 81612 8 0.0
.data 1792 1792 0 0.0
.text 596428 596572 144 0.0
linux all-clusters-app debug (read only) 1904073 1905065 992 0.1
(read/write) 131584 131584 0 0.0
.bss 56688 56688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68240 68240 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155684 155812 128 0.1
.text 1602626 1603490 864 0.1
bridge-app debug+rpc (read only) 1447877 1448869 992 0.1
(read/write) 77712 77712 0 0.0
.bss 39120 39120 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31800 31800 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123460 123588 128 0.1
.text 1219205 1220069 864 0.1
chip-tool debug (read only) 6690005 6691285 1280 0.0
(read/write) 202336 202336 0 0.0
.bss 35272 35272 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160360 160360 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335657 335785 128 0.0
.text 5945253 5946405 1152 0.0
lighting-app debug+rpc (read only) 1735633 1736625 992 0.1
(read/write) 110776 110808 32 0.0
.bss 44816 44848 32 0.1
.data 1264 1264 0 0.0
.data.rel.ro 59312 59312 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144348 144476 128 0.1
.text 1448306 1449170 864 0.1
ota-provider-app debug (read only) 1412313 1413305 992 0.1
(read/write) 75688 75688 0 0.0
.bss 41600 41600 0 0.0
.data 896 896 0 0.0
.data.rel.ro 28008 28008 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124894 125022 128 0.1
.text 1182514 1183378 864 0.1
ota-requestor-app debug (read only) 1517033 1518313 1280 0.1
(read/write) 80704 80704 0 0.0
.bss 44768 44768 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29768 29768 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137583 137711 128 0.1
.text 1270642 1271794 1152 0.1
shell debug (read only) 828593 828593 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85970 85970 0 0.0
.text 635522 635522 0 0.0
tv-app debug (read only) 2044273 2045537 1264 0.1
(read/write) 324120 324120 0 0.0
.bss 251160 251160 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176444 176540 96 0.1
.text 1712802 1713970 1168 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316128 2316424 296 0.0
.bss 186892 186900 8 0.0
.data 5232 5232 0 0.0
.heap 844320 844312 -8 -0.0
.text 1278704 1279000 296 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298776 2299072 296 0.0
.bss 175704 175712 8 0.0
.data 5488 5488 0 0.0
.heap 855256 855248 -8 -0.0
.text 1261376 1261672 296 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271688 2271984 296 0.0
.bss 174744 174752 8 0.0
.data 5488 5488 0 0.0
.heap 856216 856208 -8 -0.0
.text 1234288 1234584 296 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047992 2047992 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010592 1010592 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896779 896979 200 0.0
bss 116176 116184 8 0.0
rodata 100132 100172 40 0.0
text 604904 605068 164 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 860003 200 0.0
bss 112524 112532 8 0.0
rodata 91428 91468 40 0.0
text 579632 579796 164 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822926 220 0.0
bss 117552 117560 8 0.0
rodata 95388 95432 44 0.0
text 535276 535448 172 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869215 869451 236 0.0
bss 113440 113448 8 0.0
rodata 96248 96292 44 0.0
text 584160 584324 164 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795402 795650 248 0.0
bss 114848 114856 8 0.0
rodata 91540 91580 40 0.0
text 514624 514800 176 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874299 200 0.0
bss 113352 113360 8 0.0
rodata 97604 97644 40 0.0
text 587676 587844 168 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867523 200 0.0
bss 113228 113236 8 0.0
rodata 95740 95780 40 0.0
text 582896 583060 164 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523268 523268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443908 443908 0 0.0
p6 all-clusters-app default (read/write) 2349808 2350096 288 0.0
.bss 113124 113132 8 0.0
.data 2512 2512 0 0.0
.heap 917704 917696 -8 -0.0
.text 1308072 1308360 288 0.0
light-app default (read/write) 2281112 2281416 304 0.0
.bss 100896 100904 8 0.0
.data 2328 2328 0 0.0
.heap 930120 930112 -8 -0.0
.text 1239376 1239680 304 0.0
lock-app default (read/write) 2257200 2257504 304 0.0
.bss 99776 99784 8 0.0
.data 2288 2288 0 0.0
.heap 931280 931272 -8 -0.0
.text 1215464 1215768 304 0.0
qpg lighting-app qpg6100+debug (read only) 511772 511908 136 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82624 8 0.0
.data 956 956 0 0.0
.text 506452 506588 136 0.0
lock-app qpg6100+debug (read only) 485956 486092 136 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81760 8 0.0
.data 912 912 0 0.0
.text 480636 480772 136 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800102 800346 244 0.0
bss 82756 82764 8 0.0
noinit 37160 37160 0 0.0
text 557204 557408 204 0.0

@andy31415
Copy link
Contributor

fast track: small delta, several checkmarks, change up for sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 1f4024a into project-chip:master Dec 8, 2021
@pan-apple pan-apple mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-apple pan-apple pan-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billwatersiii @andy31415 @woody-apple @pan-apple