Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CASE Authenticated Tags Support to Access Control Check. #12689

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Added CASE Authenticated Tags Support to Access Control Check. #12689

merged 2 commits into from
Dec 13, 2021
+504 −391

Conversation

emargolis
Copy link
Contributor

Change overview

-- Added CATValues field to the SubjectDescriptor struct
-- Moved declaration of CASEAuthTag and CATValues into separate file src/lib/core/CASEAuthTag.h
-- Added new CAT test cases to TestAccessControl.cpp
-- Minor test cleanups

Testing

Existing and new unit tests.

@chrisbeach59 chrisbeach59 mentioned this pull request Dec 8, 2021
Merged
@emargolis emargolis force-pushed the emargolis/feature/access-control-check-add-cats branch from 6aab918 to f289c0a Compare December 10, 2021 00:10
@todo
Copy link

todo bot commented Dec 10, 2021

Add the implicit admit for PASE after the spec is updated.

connectedhomeip/src/access/AccessControl.cpp

Lines 137 to 147 in f289c0a

// TODO: Add the implicit admit for PASE after the spec is updated.
else if (IsPAKEKeyId(subject))
{
VerifyOrReturnError(authMode == AuthMode::kPase, CHIP_ERROR_INVALID_ARGUMENT);
if (subject == subjectDescriptor.subject)
{
subjectMatched = true;
break;
}
}
else if (IsCASEAuthTag(subject))

This comment was generated by todo based on a TODO comment in f289c0a in #12689. cc @emargolis.

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12689: Size comparison from 0b60205 to f289c0a

Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 0b60205 f289c0a change % change
efr32 lighting-app BRD4161A (read only) 807484 807708 224 0.0
.text 807476 807700 224 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784684 224 0.0
.text 784452 784676 224 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668660 128 0.0
.text 587108 587236 128 0.0
lock-app k32w061+debug (read/write) 618492 618620 128 0.0
.text 538948 539076 128 0.0
shell k32w061+debug (read/write) 623584 623712 128 0.0
.text 541840 541968 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6793660 864 0.0
.text 5749972 5750836 864 0.0
thermostat-no-ble arm64 (read only) 1943364 1944228 864 0.0
.rodata 125300 125316 16 0.0
.text 1610912 1611760 848 0.1
p6 all-clusters-app default (read/write) 2360184 2360408 224 0.0
.text 1318448 1318672 224 0.0
light-app default (read/write) 2292984 2293192 208 0.0
.text 1251248 1251456 208 0.0
lock-app default (read/write) 2269048 2269272 224 0.0
.text 1227312 1227536 224 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520444 120 0.0
.text 515004 515124 120 0.0
lock-app qpg6100+debug (read only) 494700 494820 120 0.0
.text 489380 489500 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809906 136 0.0
text 565274 565410 136 0.0
Decreases (2 builds for linux)
platform target config section 0b60205 f289c0a change % change
linux chip-tool-ipv6only arm64 (read/write) 318273 318241 -32 -0.0
.bss 51713 51681 -32 -0.1
thermostat-no-ble arm64 (read/write) 136865 136833 -32 -0.0
.bss 59441 59409 -32 -0.1
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 0b60205 f289c0a change % change
efr32 lighting-app BRD4161A (read only) 807484 807708 224 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807476 807700 224 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784684 224 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784452 784676 224 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668660 128 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587236 128 0.0
lock-app k32w061+debug (read/write) 618492 618620 128 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 539076 128 0.0
shell k32w061+debug (read/write) 623584 623712 128 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541968 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6793660 864 0.0
(read/write) 318273 318241 -32 -0.0
.bss 51713 51681 -32 -0.1
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749972 5750836 864 0.0
thermostat-no-ble arm64 (read only) 1943364 1944228 864 0.0
(read/write) 136865 136833 -32 -0.0
.bss 59441 59409 -32 -0.1
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125316 16 0.0
.text 1610912 1611760 848 0.1
p6 all-clusters-app default (read/write) 2360184 2360408 224 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318672 224 0.0
light-app default (read/write) 2292984 2293192 208 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251456 208 0.0
lock-app default (read/write) 2269048 2269272 224 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227536 224 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520444 120 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515124 120 0.0
lock-app qpg6100+debug (read only) 494700 494820 120 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489500 120 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809906 136 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565410 136 0.0

@emargolis emargolis force-pushed the emargolis/feature/access-control-check-add-cats branch from f289c0a to 45dac8d Compare December 10, 2021 01:27
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12689: Size comparison from 077a822 to 45dac8d

Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 077a822 45dac8d change % change
efr32 lighting-app BRD4161A (read only) 807484 807708 224 0.0
.text 807476 807700 224 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784684 224 0.0
.text 784452 784676 224 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862214 154 0.0
.flash.text 862060 862214 154 0.0
m5stack (read only) 965247 965391 144 0.0
.flash.text 959863 960007 144 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668660 128 0.0
.text 587108 587236 128 0.0
lock-app k32w061+debug (read/write) 618492 618620 128 0.0
.text 538948 539076 128 0.0
shell k32w061+debug (read/write) 623584 623712 128 0.0
.text 541840 541968 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6793716 920 0.0
.text 5749972 5750900 928 0.0
thermostat-no-ble arm64 (read only) 1943364 1944292 928 0.0
.text 1610912 1611840 928 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2323376 2323504 128 0.0
.text 1285952 1286080 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308008 2308136 128 0.0
.text 1270608 1270736 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2281120 2281248 128 0.0
.text 1243720 1243848 128 0.0
p6 all-clusters-app default (read/write) 2360184 2360408 224 0.0
.text 1318448 1318672 224 0.0
light-app default (read/write) 2292984 2293192 208 0.0
.text 1251248 1251456 208 0.0
lock-app default (read/write) 2269048 2269272 224 0.0
.text 1227312 1227536 224 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520444 120 0.0
.text 515004 515124 120 0.0
lock-app qpg6100+debug (read only) 494700 494820 120 0.0
.text 489380 489500 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809906 136 0.0
text 565274 565410 136 0.0
Decreases (2 builds for linux)
platform target config section 077a822 45dac8d change % change
linux chip-tool-ipv6only arm64 (read/write) 318273 318241 -32 -0.0
.bss 51713 51681 -32 -0.1
.rodata 363884 363876 -8 -0.0
thermostat-no-ble arm64 (read/write) 136865 136833 -32 -0.0
.bss 59441 59409 -32 -0.1
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 077a822 45dac8d change % change
efr32 lighting-app BRD4161A (read only) 807484 807708 224 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807476 807700 224 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784684 224 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784452 784676 224 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862214 154 0.0
(read/write) 1305602 1305602 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172752 0 0.0
.flash.text 862060 862214 154 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965247 965391 144 0.0
(read/write) 451296 451296 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210468 0 0.0
.flash.text 959863 960007 144 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668660 128 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587236 128 0.0
lock-app k32w061+debug (read/write) 618492 618620 128 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 539076 128 0.0
shell k32w061+debug (read/write) 623584 623712 128 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541968 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6793716 920 0.0
(read/write) 318273 318241 -32 -0.0
.bss 51713 51681 -32 -0.1
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363876 -8 -0.0
.text 5749972 5750900 928 0.0
thermostat-no-ble arm64 (read only) 1943364 1944292 928 0.0
(read/write) 136865 136833 -32 -0.0
.bss 59441 59409 -32 -0.1
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610912 1611840 928 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323376 2323504 128 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285952 1286080 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308008 2308136 128 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270608 1270736 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281120 2281248 128 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243720 1243848 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360408 224 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318672 224 0.0
light-app default (read/write) 2292984 2293192 208 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251456 208 0.0
lock-app default (read/write) 2269048 2269272 224 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227536 224 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520444 120 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515124 120 0.0
lock-app qpg6100+debug (read only) 494700 494820 120 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489500 120 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809906 136 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565410 136 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the emargolis/feature/access-control-check-add-cats branch from 45dac8d to 1f3a2aa Compare December 10, 2021 05:58
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12689: Size comparison from 586aca7 to 1f3a2aa

Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 586aca7 1f3a2aa change % change
efr32 lighting-app BRD4161A (read only) 809204 809428 224 0.0
.text 809196 809420 224 0.0
BRD4161A+rpc (read only) 796824 797048 224 0.0
.text 796816 797040 224 0.0
window-app BRD4161A (read only) 786180 786404 224 0.0
.text 786172 786396 224 0.0
esp32 all-clusters-app c3devkit (read only) 862792 862942 150 0.0
.flash.text 862792 862942 150 0.0
m5stack (read only) 966015 966147 132 0.0
.flash.text 960631 960763 132 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669688 128 0.0
.text 587996 588124 128 0.0
lock-app k32w061+debug (read/write) 619508 619636 128 0.0
.text 539832 539960 128 0.0
shell k32w061+debug (read/write) 624608 624736 128 0.0
.text 542724 542852 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6864988 6865940 952 0.0
.text 5820564 5821524 960 0.0
thermostat-no-ble arm64 (read only) 1947444 1948404 960 0.0
.text 1614432 1615392 960 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2324456 128 0.0
.text 1286904 1287032 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2309072 128 0.0
.text 1271544 1271672 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2282192 128 0.0
.text 1244664 1244792 128 0.0
p6 all-clusters-app default (read/write) 2361904 2362128 224 0.0
.text 1320168 1320392 224 0.0
light-app default (read/write) 2294704 2294928 224 0.0
.text 1252968 1253192 224 0.0
lock-app default (read/write) 2270784 2270992 208 0.0
.text 1229048 1229256 208 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521440 120 0.0
.text 516000 516120 120 0.0
lock-app qpg6100+debug (read only) 495688 495808 120 0.0
.text 490368 490488 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 811090 136 0.0
text 566006 566138 132 0.0
Decreases (2 builds for linux)
platform target config section 586aca7 1f3a2aa change % change
linux chip-tool-ipv6only arm64 (read/write) 318785 318737 -48 -0.0
.bss 51985 51937 -48 -0.1
.rodata 364764 364756 -8 -0.0
thermostat-no-ble arm64 (read/write) 137201 137153 -48 -0.0
.bss 59601 59553 -48 -0.1
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 586aca7 1f3a2aa change % change
efr32 lighting-app BRD4161A (read only) 809204 809428 224 0.0
(read/write) 123148 123148 0 0.0
.bss 121288 121288 0 0.0
.data 1860 1860 0 0.0
.text 809196 809420 224 0.0
BRD4161A+rpc (read only) 796824 797048 224 0.0
(read/write) 139824 139824 0 0.0
.bss 137864 137864 0 0.0
.data 1960 1960 0 0.0
.text 796816 797040 224 0.0
window-app BRD4161A (read only) 786180 786404 224 0.0
(read/write) 121280 121280 0 0.0
.bss 119456 119456 0 0.0
.data 1824 1824 0 0.0
.text 786172 786396 224 0.0
esp32 all-clusters-app c3devkit (read only) 862792 862942 150 0.0
(read/write) 1306058 1306058 0 0.0
.dram0.bss 65832 65832 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 173064 0 0.0
.flash.text 862792 862942 150 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966015 966147 132 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75128 75128 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210772 0 0.0
.flash.text 960631 960763 132 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669688 128 0.0
.bss 73872 73872 0 0.0
.data 1892 1892 0 0.0
.text 587996 588124 128 0.0
lock-app k32w061+debug (read/write) 619508 619636 128 0.0
.bss 72024 72024 0 0.0
.data 1852 1852 0 0.0
.text 539832 539960 128 0.0
shell k32w061+debug (read/write) 624608 624736 128 0.0
.bss 74252 74252 0 0.0
.data 1832 1832 0 0.0
.text 542724 542852 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6864988 6865940 952 0.0
(read/write) 318785 318737 -48 -0.0
.bss 51985 51937 -48 -0.1
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364756 -8 -0.0
.text 5820564 5821524 960 0.0
thermostat-no-ble arm64 (read only) 1947444 1948404 960 0.0
(read/write) 137201 137153 -48 -0.0
.bss 59601 59553 -48 -0.1
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125508 0 0.0
.text 1614432 1615392 960 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324456 128 0.0
.bss 185108 185108 0 0.0
.data 5240 5240 0 0.0
.heap 846096 846096 0 0.0
.text 1286904 1287032 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2309072 128 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271672 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282192 128 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244792 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
p6 all-clusters-app default (read/write) 2361904 2362128 224 0.0
.bss 113244 113244 0 0.0
.data 2520 2520 0 0.0
.heap 917576 917576 0 0.0
.text 1320168 1320392 224 0.0
light-app default (read/write) 2294704 2294928 224 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252968 1253192 224 0.0
lock-app default (read/write) 2270784 2270992 208 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229256 208 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521440 120 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516000 516120 120 0.0
lock-app qpg6100+debug (read only) 495688 495808 120 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490368 490488 120 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 811090 136 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566006 566138 132 0.0

@emargolis
Added CASE Authenticated Tags Support to Access Control Check.
eea4f42 
  -- Added CATValues field to the SubjectDescriptor struct
  -- Moved declaration of CASEAuthTag and CATValues into separate file src/lib/core/CASEAuthTag.h
  -- Added new CAT test cases to TestAccessControl.cpp
  -- Minor test cleanups
@emargolis emargolis force-pushed the emargolis/feature/access-control-check-add-cats branch from 1f3a2aa to eea4f42 Compare December 13, 2021 14:55
@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12689: Size comparison from 228bd4b to eea4f42

Increases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 228bd4b eea4f42 change % change
efr32 lighting-app BRD4161A (read only) 815948 816172 224 0.0
.text 815940 816164 224 0.0
BRD4161A+rpc (read only) 803580 803804 224 0.0
.text 803572 803796 224 0.0
window-app BRD4161A (read only) 793008 793248 240 0.0
.text 793000 793240 240 0.0
esp32 all-clusters-app c3devkit (read only) 857182 857340 158 0.0
.flash.text 857182 857340 158 0.0
m5stack (read only) 960795 960923 128 0.0
.flash.text 955411 955539 128 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670536 128 0.0
.text 588840 588968 128 0.0
lock-app k32w061+debug (read/write) 620344 620456 112 0.0
.text 540664 540776 112 0.0
shell k32w061+debug (read/write) 625712 625840 128 0.0
.text 543744 543872 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6863300 6864244 944 0.0
.text 5817668 5818628 960 0.0
thermostat-no-ble arm64 (read only) 1954372 1955332 960 0.0
.text 1620272 1621232 960 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314024 2314216 192 0.0
.text 1276600 1276792 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309888 2310080 192 0.0
.text 1272488 1272680 192 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2283000 2283128 128 0.0
.text 1245600 1245728 128 0.0
p6 all-clusters-app default (read/write) 2360968 2361192 224 0.0
.text 1319232 1319456 224 0.0
light-app default (read/write) 2301568 2301792 224 0.0
.text 1259832 1260056 224 0.0
lock-app default (read/write) 2277640 2277864 224 0.0
.text 1235904 1236128 224 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522288 128 0.0
.text 516840 516968 128 0.0
lock-app qpg6100+debug (read only) 496532 496660 128 0.0
.text 491212 491340 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812414 152 0.0
text 567218 567366 148 0.0
Decreases (2 builds for linux)
platform target config section 228bd4b eea4f42 change % change
linux chip-tool-ipv6only arm64 (read/write) 318881 318833 -48 -0.0
.bss 51921 51873 -48 -0.1
.rodata 365028 365012 -16 -0.0
thermostat-no-ble arm64 (read/write) 137521 137473 -48 -0.0
.bss 59537 59489 -48 -0.1
Full report (22 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 228bd4b eea4f42 change % change
efr32 lighting-app BRD4161A (read only) 815948 816172 224 0.0
(read/write) 123152 123152 0 0.0
.bss 121288 121288 0 0.0
.data 1864 1864 0 0.0
.text 815940 816164 224 0.0
BRD4161A+rpc (read only) 803580 803804 224 0.0
(read/write) 139828 139828 0 0.0
.bss 137864 137864 0 0.0
.data 1964 1964 0 0.0
.text 803572 803796 224 0.0
window-app BRD4161A (read only) 793008 793248 240 0.0
(read/write) 122104 122104 0 0.0
.bss 120272 120272 0 0.0
.data 1828 1828 0 0.0
.text 793000 793240 240 0.0
esp32 all-clusters-app c3devkit (read only) 857182 857340 158 0.0
(read/write) 1304434 1304434 0 0.0
.dram0.bss 64696 64696 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 172544 172544 0 0.0
.flash.text 857182 857340 158 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960795 960923 128 0.0
(read/write) 450148 450148 0 0.0
.dram0.bss 73976 73976 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210336 210336 0 0.0
.flash.text 955411 955539 128 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670536 128 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588968 128 0.0
lock-app k32w061+debug (read/write) 620344 620456 112 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540776 112 0.0
shell k32w061+debug (read/write) 625712 625840 128 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543872 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6863300 6864244 944 0.0
(read/write) 318881 318833 -48 -0.0
.bss 51921 51873 -48 -0.1
.data 1192 1192 0 0.0
.data.rel.ro 208480 208480 0 0.0
.dynamic 560 560 0 0.0
.got 53560 53560 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365028 365012 -16 -0.0
.text 5817668 5818628 960 0.0
thermostat-no-ble arm64 (read only) 1954372 1955332 960 0.0
(read/write) 137521 137473 -48 -0.0
.bss 59537 59489 -48 -0.1
.data 832 832 0 0.0
.data.rel.ro 70592 70592 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620272 1621232 960 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314024 2314216 192 0.0
.bss 183964 183964 0 0.0
.data 5240 5240 0 0.0
.heap 847240 847240 0 0.0
.text 1276600 1276792 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2310080 192 0.0
.bss 175824 175824 0 0.0
.data 5536 5536 0 0.0
.heap 855088 855088 0 0.0
.text 1272488 1272680 192 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2283128 128 0.0
.bss 174864 174864 0 0.0
.data 5528 5528 0 0.0
.heap 856056 856056 0 0.0
.text 1245600 1245728 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
p6 all-clusters-app default (read/write) 2360968 2361192 224 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319232 1319456 224 0.0
light-app default (read/write) 2301568 2301792 224 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1260056 224 0.0
lock-app default (read/write) 2277640 2277864 224 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1236128 224 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522288 128 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516968 128 0.0
lock-app qpg6100+debug (read only) 496532 496660 128 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491340 128 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812414 152 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567366 148 0.0

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12689: Size comparison from 228bd4b to df937e4

Increases (11 builds for k32w, linux, p6, qpg, telink)
platform target config section 228bd4b df937e4 change % change
k32w lighting-app k32w061+se05x+release (read/write) 670408 670536 128 0.0
.text 588840 588968 128 0.0
lock-app k32w061+debug (read/write) 620344 620456 112 0.0
.text 540664 540776 112 0.0
shell k32w061+debug (read/write) 625712 625840 128 0.0
.text 543744 543872 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6863300 6874524 11224 0.2
(read/write) 318881 319153 272 0.1
.data.rel.ro 208480 208784 304 0.1
.got 53560 53576 16 0.0
.rodata 365028 365676 648 0.2
.text 5817668 5827764 10096 0.2
thermostat-no-ble arm64 (read only) 1954372 1955620 1248 0.1
.data.rel.ro 70592 70600 8 0.0
.text 1620272 1621472 1200 0.1
p6 all-clusters-app default (read/write) 2360968 2361200 232 0.0
.text 1319232 1319464 232 0.0
light-app default (read/write) 2301568 2301792 224 0.0
.text 1259832 1260056 224 0.0
lock-app default (read/write) 2277640 2277864 224 0.0
.text 1235904 1236128 224 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522288 128 0.0
.text 516840 516968 128 0.0
lock-app qpg6100+debug (read only) 496532 496660 128 0.0
.text 491212 491340 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812414 152 0.0
text 567218 567366 148 0.0
Decreases (2 builds for linux)
platform target config section 228bd4b df937e4 change % change
linux chip-tool-ipv6only arm64 .bss 51921 51873 -48 -0.1
thermostat-no-ble arm64 (read/write) 137521 137489 -32 -0.0
.bss 59537 59489 -48 -0.1
Full report (12 builds for k32w, linux, p6, qpg, telink)
platform target config section 228bd4b df937e4 change % change
k32w lighting-app k32w061+se05x+release (read/write) 670408 670536 128 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588968 128 0.0
lock-app k32w061+debug (read/write) 620344 620456 112 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540776 112 0.0
shell k32w061+debug (read/write) 625712 625840 128 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543872 128 0.0
linux chip-tool-ipv6only arm64 (read only) 6863300 6874524 11224 0.2
(read/write) 318881 319153 272 0.1
.bss 51921 51873 -48 -0.1
.data 1192 1192 0 0.0
.data.rel.ro 208480 208784 304 0.1
.dynamic 560 560 0 0.0
.got 53560 53576 16 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365028 365676 648 0.2
.text 5817668 5827764 10096 0.2
thermostat-no-ble arm64 (read only) 1954372 1955620 1248 0.1
(read/write) 137521 137489 -32 -0.0
.bss 59537 59489 -48 -0.1
.data 832 832 0 0.0
.data.rel.ro 70592 70600 8 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620272 1621472 1200 0.1
p6 all-clusters-app default (read/write) 2360968 2361200 232 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319232 1319464 232 0.0
light-app default (read/write) 2301568 2301792 224 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1260056 224 0.0
lock-app default (read/write) 2277640 2277864 224 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1236128 224 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522288 128 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516968 128 0.0
lock-app qpg6100+debug (read only) 496532 496660 128 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491340 128 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812414 152 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567366 148 0.0

@andy31415 andy31415 merged commit ed367ec into project-chip:master Dec 13, 2021
@emargolis emargolis mentioned this pull request Dec 13, 2021
Closed
@emargolis emargolis deleted the emargolis/feature/access-control-check-add-cats branch December 14, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux

@mlepage-google mlepage-google

@msandstedt msandstedt

@woody-apple woody-apple

@anush-apple anush-apple

@balducci-apple balducci-apple

@bzbarsky-apple bzbarsky-apple

@carol-apple carol-apple

@chrisdecenzo chrisdecenzo

@chulspro chulspro

@Damian-Nordic Damian-Nordic

@electrocucaracha electrocucaracha

@erjiaqing erjiaqing

@franck-apple franck-apple

@harimau-qirex harimau-qirex

@hawk248 hawk248

@jelderton jelderton

@jepenven-silabs jepenven-silabs

@jmartinez-silabs jmartinez-silabs

@kghost kghost

@kpschoedel kpschoedel

@LuDuda LuDuda

@mrjerryjohns mrjerryjohns

@mspang mspang

@pan-apple pan-apple

@sagar-apple sagar-apple

@saurabhst saurabhst

@selissia selissia

@tecimovic tecimovic

@turon turon

@vijs vijs

@vivien-apple vivien-apple

@wbschiller wbschiller

@yunhanw-google yunhanw-google

@Byungjoo-Lee Byungjoo-Lee

@chshu chshu

@dhrishi dhrishi

@gjc13 gjc13

@xylophone21 xylophone21

Assignees
No one assigned
Labels
lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emargolis @woody-apple @tcarmelveilleux @msandstedt @mlepage-google @andy31415