Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attribute-size.cpp. #12664

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Remove attribute-size.cpp. #12664

merged 1 commit into from
Dec 7, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This was being used only for the old list encoding, which we are not using anymore

Problem

Code we are not really using.

Change overview

Remove the code.

Testing

No intended behavior changes. Tree compiles.

@restyled-io restyled-io bot mentioned this pull request Dec 7, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12664: Size comparison from f647393 to c928db5

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f647393 c928db5 change % change
efr32 lighting-app BRD4161A (read only) 796540 791644 -4896 -0.6
.text 796532 791636 -4896 -0.6
BRD4161A+rpc (read only) 824508 819692 -4816 -0.6
.text 824500 819684 -4816 -0.6
lock-app BRD4161A (read only) 771224 766264 -4960 -0.6
.text 771216 766256 -4960 -0.6
window-app BRD4161A (read only) 773496 768536 -4960 -0.6
.text 773488 768528 -4960 -0.6
esp32 all-clusters-app c3devkit (read only) 856134 849770 -6364 -0.7
(read/write) 1298882 1233114 -65768 -5.1
.flash.rodata 170288 170056 -232 -0.1
.flash.text 856134 849770 -6364 -0.7
m5stack (read only) 959387 953187 -6200 -0.6
(read/write) 443208 442992 -216 -0.0
.flash.rodata 208588 208372 -216 -0.1
.flash.text 954003 947803 -6200 -0.6
k32w lighting-app k32w061+se05x+release (read/write) 731592 727988 -3604 -0.5
.text 644524 640920 -3604 -0.6
lock-app k32w061+debug (read/write) 622308 618624 -3684 -0.6
.text 544608 540924 -3684 -0.7
shell k32w061+debug (read/write) 688216 684536 -3680 -0.5
.text 598896 595216 -3680 -0.6
linux all-clusters-app debug (read only) 1902129 1874353 -27776 -1.5
.rodata 154933 153941 -992 -0.6
.text 1601666 1574882 -26784 -1.7
bridge-app debug+rpc (read only) 1450789 1436597 -14192 -1.0
.rodata 122692 121924 -768 -0.6
.text 1223029 1209605 -13424 -1.1
chip-tool debug (read only) 6680117 6678981 -1136 -0.0
.rodata 334449 334225 -224 -0.1
.text 5937173 5936261 -912 -0.0
lighting-app debug+rpc (read only) 1736569 1723177 -13392 -0.8
.rodata 143281 142641 -640 -0.4
.text 1450450 1437698 -12752 -0.9
ota-provider-app debug (read only) 1408089 1402937 -5152 -0.4
.rodata 124078 123598 -480 -0.4
.text 1179154 1174482 -4672 -0.4
ota-requestor-app debug (read only) 1512865 1507713 -5152 -0.3
.rodata 136823 136343 -480 -0.4
.text 1267282 1262610 -4672 -0.4
tv-app debug (read only) 2049985 2030801 -19184 -0.9
.rodata 175436 174636 -800 -0.5
.text 1719714 1701330 -18384 -1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2316272 2309384 -6888 -0.3
.text 1278848 1271960 -6888 -0.5
lighting-app CY8CPROTO_062_4343W+release (read/write) 2299968 2296360 -3608 -0.2
.text 1262568 1258960 -3608 -0.3
lock-app CY8CPROTO_062_4343W+release (read/write) 2273072 2269344 -3728 -0.2
.text 1235672 1231944 -3728 -0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 891103 -3596 -0.4
rodata 99676 99344 -332 -0.3
text 605624 602356 -3268 -0.5
nrf52840dk_nrf52840+rpc (read/write) 858075 854567 -3508 -0.4
rodata 91036 90808 -228 -0.3
text 580620 577340 -3280 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 820598 816998 -3600 -0.4
rodata 94936 94600 -336 -0.4
text 535952 532684 -3268 -0.6
lock-app nrf52840dk_nrf52840 (read/write) 867283 863587 -3696 -0.4
rodata 95796 95460 -336 -0.4
text 584996 581624 -3372 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 793434 789722 -3712 -0.5
rodata 91084 90748 -336 -0.4
text 515416 512048 -3368 -0.7
pump-app nrf52840dk_nrf52840 (read/write) 872019 868419 -3600 -0.4
rodata 97148 96812 -336 -0.3
text 588396 585128 -3268 -0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 861647 -3596 -0.4
rodata 95284 94952 -332 -0.3
text 583608 580344 -3264 -0.6
p6 all-clusters-app default (read/write) 2352208 2342392 -9816 -0.4
.text 1310472 1300656 -9816 -0.7
light-app default (read/write) 2283256 2278360 -4896 -0.2
.text 1241520 1236624 -4896 -0.4
lock-app default (read/write) 2259424 2254464 -4960 -0.2
.text 1217688 1212728 -4960 -0.4
qpg lighting-app qpg6100+debug (read only) 513300 509700 -3600 -0.7
.text 507980 504380 -3600 -0.7
lock-app qpg6100+debug (read only) 487604 483924 -3680 -0.8
.text 482284 478604 -3680 -0.8
telink lighting-app tlsr9518adk80d (read/write) 798086 794410 -3676 -0.5
text 557696 554476 -3220 -0.6
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f647393 c928db5 change % change
efr32 lighting-app BRD4161A (read only) 796540 791644 -4896 -0.6
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 796532 791636 -4896 -0.6
BRD4161A+rpc (read only) 824508 819692 -4816 -0.6
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 824500 819684 -4816 -0.6
lock-app BRD4161A (read only) 771224 766264 -4960 -0.6
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 771216 766256 -4960 -0.6
window-app BRD4161A (read only) 773496 768536 -4960 -0.6
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 773488 768528 -4960 -0.6
esp32 all-clusters-app c3devkit (read only) 856134 849770 -6364 -0.7
(read/write) 1298882 1233114 -65768 -5.1
.dram0.bss 61424 61424 0 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170288 170056 -232 -0.1
.flash.text 856134 849770 -6364 -0.7
.iram0.text 62076 62076 0 0.0
m5stack (read only) 959387 953187 -6200 -0.6
(read/write) 443208 442992 -216 -0.0
.dram0.bss 68776 68776 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208588 208372 -216 -0.1
.flash.text 954003 947803 -6200 -0.6
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731592 727988 -3604 -0.5
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644524 640920 -3604 -0.6
lock-app k32w061+debug (read/write) 622308 618624 -3684 -0.6
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544608 540924 -3684 -0.7
shell k32w061+debug (read/write) 688216 684536 -3680 -0.5
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598896 595216 -3680 -0.6
linux all-clusters-app debug (read only) 1902129 1874353 -27776 -1.5
(read/write) 128712 128712 0 0.0
.bss 54064 54064 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 67968 67968 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 154933 153941 -992 -0.6
.text 1601666 1574882 -26784 -1.7
bridge-app debug+rpc (read only) 1450789 1436597 -14192 -1.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 121924 -768 -0.6
.text 1223029 1209605 -13424 -1.1
chip-tool debug (read only) 6680117 6678981 -1136 -0.0
(read/write) 201512 201512 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160072 160072 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 334449 334225 -224 -0.1
.text 5937173 5936261 -912 -0.0
lighting-app debug+rpc (read only) 1736569 1723177 -13392 -0.8
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143281 142641 -640 -0.4
.text 1450450 1437698 -12752 -0.9
ota-provider-app debug (read only) 1408089 1402937 -5152 -0.4
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 123598 -480 -0.4
.text 1179154 1174482 -4672 -0.4
ota-requestor-app debug (read only) 1512865 1507713 -5152 -0.3
(read/write) 78120 78120 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29704 29704 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 136343 -480 -0.4
.text 1267282 1262610 -4672 -0.4
shell debug (read only) 823577 823577 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84754 0 0.0
.text 631986 631986 0 0.0
tv-app debug (read only) 2049985 2030801 -19184 -0.9
(read/write) 320288 320288 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64208 64208 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175436 174636 -800 -0.5
.text 1719714 1701330 -18384 -1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316272 2309384 -6888 -0.3
.bss 184596 184596 0 0.0
.data 5240 5240 0 0.0
.heap 846608 846608 0 0.0
.text 1278848 1271960 -6888 -0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299968 2296360 -3608 -0.2
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262568 1258960 -3608 -0.3
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2269344 -3728 -0.2
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1231944 -3728 -0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 891103 -3596 -0.4
bss 113852 113852 0 0.0
rodata 99676 99344 -332 -0.3
text 605624 602356 -3268 -0.5
nrf52840dk_nrf52840+rpc (read/write) 858075 854567 -3508 -0.4
bss 110200 110200 0 0.0
rodata 91036 90808 -228 -0.3
text 580620 577340 -3280 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 820598 816998 -3600 -0.4
bss 115224 115224 0 0.0
rodata 94936 94600 -336 -0.4
text 535952 532684 -3268 -0.6
lock-app nrf52840dk_nrf52840 (read/write) 867283 863587 -3696 -0.4
bss 111112 111112 0 0.0
rodata 95796 95460 -336 -0.4
text 584996 581624 -3372 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 793434 789722 -3712 -0.5
bss 112524 112524 0 0.0
rodata 91084 90748 -336 -0.4
text 515416 512048 -3368 -0.7
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 872019 868419 -3600 -0.4
bss 111024 111024 0 0.0
rodata 97148 96812 -336 -0.3
text 588396 585128 -3268 -0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 861647 -3596 -0.4
bss 110904 110904 0 0.0
rodata 95284 94952 -332 -0.3
text 583608 580344 -3264 -0.6
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2352208 2342392 -9816 -0.4
.bss 110868 110868 0 0.0
.data 2520 2520 0 0.0
.heap 919952 919952 0 0.0
.text 1310472 1300656 -9816 -0.7
light-app default (read/write) 2283256 2278360 -4896 -0.2
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1241520 1236624 -4896 -0.4
lock-app default (read/write) 2259424 2254464 -4960 -0.2
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1217688 1212728 -4960 -0.4
qpg lighting-app qpg6100+debug (read only) 513300 509700 -3600 -0.7
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507980 504380 -3600 -0.7
lock-app qpg6100+debug (read only) 487604 483924 -3680 -0.8
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482284 478604 -3680 -0.8
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798086 794410 -3676 -0.5
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557696 554476 -3220 -0.6

@vivien-apple
Copy link
Contributor

Looking at the removal I think attribute-list-byte-span.h and attribute-list-byte-span.cpp can also be removed. I did some quick searches using the GitHub UI and all the references of methods implemented by attribute-list-byte-span.cpp seems to be in attribute-size.cpp

@woody-apple
Copy link
Contributor

Fast tracking, given deleting dead code.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12664: Size comparison from 051685b to c8fa3cf

Decreases (3 builds for qpg, telink)
platform target config section 051685b c8fa3cf change % change
qpg lighting-app qpg6100+debug (read only) 514144 510560 -3584 -0.7
.text 508824 505240 -3584 -0.7
lock-app qpg6100+debug (read only) 488448 484752 -3696 -0.8
.text 483128 479432 -3696 -0.8
telink lighting-app tlsr9518adk80d (read/write) 799870 796186 -3684 -0.5
text 559130 555910 -3220 -0.6
Full report (4 builds for qpg, telink)
platform target config section 051685b c8fa3cf change % change
qpg lighting-app qpg6100+debug (read only) 514144 510560 -3584 -0.7
(read/write) 122332 122332 0 0.0
.bss 80168 80168 0 0.0
.data 964 964 0 0.0
.text 508824 505240 -3584 -0.7
lock-app qpg6100+debug (read only) 488448 484752 -3696 -0.8
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 479432 -3696 -0.8
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 796186 -3684 -0.5
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 555910 -3220 -0.6

@bzbarsky-apple
Remove attribute-size.cpp.
753156d 
This was being used only for the old list encoding, which we are not using anymore
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12664: Size comparison from 051685b to 753156d

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 753156d change % change
efr32 lighting-app BRD4161A (read only) 798156 793260 -4896 -0.6
.text 798148 793252 -4896 -0.6
BRD4161A+rpc (read only) 826116 821292 -4824 -0.6
.text 826108 821284 -4824 -0.6
lock-app BRD4161A (read only) 772832 767872 -4960 -0.6
.text 772824 767864 -4960 -0.6
window-app BRD4161A (read only) 775104 770144 -4960 -0.6
.text 775096 770136 -4960 -0.6
esp32 all-clusters-app c3devkit (read only) 856796 850432 -6364 -0.7
(read/write) 1298938 1233170 -65768 -5.1
.flash.rodata 170664 170432 -232 -0.1
.flash.text 856796 850432 -6364 -0.7
m5stack (read only) 960115 953859 -6256 -0.7
(read/write) 443244 443028 -216 -0.0
.flash.rodata 208952 208736 -216 -0.1
.flash.text 954731 948475 -6256 -0.7
k32w lighting-app k32w061+se05x+release (read/write) 732484 728880 -3604 -0.5
.text 645528 641924 -3604 -0.6
lock-app k32w061+debug (read/write) 623164 619464 -3700 -0.6
.text 545576 541876 -3700 -0.7
shell k32w061+debug (read/write) 689084 685388 -3696 -0.5
.text 599888 596192 -3696 -0.6
linux all-clusters-app debug (read only) 1907689 1879641 -28048 -1.5
.rodata 156277 155029 -1248 -0.8
.text 1605570 1578770 -26800 -1.7
bridge-app debug+rpc (read only) 1456485 1442101 -14384 -1.0
.rodata 123932 122972 -960 -0.8
.text 1227173 1213749 -13424 -1.1
chip-tool debug (read only) 6687597 6686221 -1376 -0.0
.rodata 335721 335273 -448 -0.1
.text 5942613 5941685 -928 -0.0
lighting-app debug+rpc (read only) 1742289 1728705 -13584 -0.8
.rodata 144529 143697 -832 -0.6
.text 1454610 1441858 -12752 -0.9
ota-provider-app debug (read only) 1411953 1406561 -5392 -0.4
.rodata 125086 124382 -704 -0.6
.text 1181794 1177106 -4688 -0.4
ota-requestor-app debug (read only) 1516705 1511313 -5392 -0.4
.rodata 137807 137103 -704 -0.5
.text 1269922 1265234 -4688 -0.4
tv-app debug (read only) 2056201 2036793 -19408 -0.9
.rodata 176828 175804 -1024 -0.6
.text 1724178 1705794 -18384 -1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2317160 2310336 -6824 -0.3
.text 1279736 1272912 -6824 -0.5
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300992 2297384 -3608 -0.2
.text 1263592 1259984 -3608 -0.3
lock-app CY8CPROTO_062_4343W+release (read/write) 2274032 2270368 -3664 -0.2
.text 1236632 1232968 -3664 -0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 893095 -3612 -0.4
rodata 100308 99976 -332 -0.3
text 607112 603840 -3272 -0.5
nrf52840dk_nrf52840+rpc (read/write) 859643 856135 -3508 -0.4
rodata 91500 91272 -228 -0.2
text 581848 578568 -3280 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 822638 819038 -3600 -0.4
rodata 95568 95232 -336 -0.4
text 537480 534212 -3268 -0.6
lock-app nrf52840dk_nrf52840 (read/write) 869275 865563 -3712 -0.4
rodata 96428 96092 -336 -0.3
text 586468 583096 -3372 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 795458 791746 -3712 -0.5
rodata 91716 91380 -336 -0.4
text 516932 513560 -3372 -0.7
pump-app nrf52840dk_nrf52840 (read/write) 874027 870411 -3616 -0.4
rodata 97780 97444 -336 -0.3
text 589884 586612 -3272 -0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 863655 -3580 -0.4
rodata 95916 95584 -332 -0.3
text 585092 581832 -3260 -0.6
p6 all-clusters-app default (read/write) 2353392 2343576 -9816 -0.4
.text 1311656 1301840 -9816 -0.7
light-app default (read/write) 2284536 2279640 -4896 -0.2
.text 1242800 1237904 -4896 -0.4
lock-app default (read/write) 2260688 2255728 -4960 -0.2
.text 1218952 1213992 -4960 -0.4
qpg lighting-app qpg6100+debug (read only) 514144 510560 -3584 -0.7
.text 508824 505240 -3584 -0.7
lock-app qpg6100+debug (read only) 488448 484752 -3696 -0.8
.text 483128 479432 -3696 -0.8
telink lighting-app tlsr9518adk80d (read/write) 799870 796186 -3684 -0.5
text 559130 555910 -3220 -0.6
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 753156d change % change
efr32 lighting-app BRD4161A (read only) 798156 793260 -4896 -0.6
(read/write) 120548 120548 0 0.0
.bss 118720 118720 0 0.0
.data 1828 1828 0 0.0
.text 798148 793252 -4896 -0.6
BRD4161A+rpc (read only) 826116 821292 -4824 -0.6
(read/write) 138856 138856 0 0.0
.bss 136920 136920 0 0.0
.data 1936 1936 0 0.0
.text 826108 821284 -4824 -0.6
lock-app BRD4161A (read only) 772832 767872 -4960 -0.6
(read/write) 118488 118488 0 0.0
.bss 116696 116696 0 0.0
.data 1788 1788 0 0.0
.text 772824 767864 -4960 -0.6
window-app BRD4161A (read only) 775104 770144 -4960 -0.6
(read/write) 118688 118688 0 0.0
.bss 116896 116896 0 0.0
.data 1792 1792 0 0.0
.text 775096 770136 -4960 -0.6
esp32 all-clusters-app c3devkit (read only) 856796 850432 -6364 -0.7
(read/write) 1298938 1233170 -65768 -5.1
.dram0.bss 61096 61096 0 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170664 170432 -232 -0.1
.flash.text 856796 850432 -6364 -0.7
.iram0.text 62028 62028 0 0.0
m5stack (read only) 960115 953859 -6256 -0.7
(read/write) 443244 443028 -216 -0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208952 208736 -216 -0.1
.flash.text 954731 948475 -6256 -0.7
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732484 728880 -3604 -0.5
.bss 79296 79296 0 0.0
.data 1860 1860 0 0.0
.text 645528 641924 -3604 -0.6
lock-app k32w061+debug (read/write) 623164 619464 -3700 -0.6
.bss 69960 69960 0 0.0
.data 1828 1828 0 0.0
.text 545576 541876 -3700 -0.7
shell k32w061+debug (read/write) 689084 685388 -3696 -0.5
.bss 81596 81596 0 0.0
.data 1800 1800 0 0.0
.text 599888 596192 -3696 -0.6
linux all-clusters-app debug (read only) 1907689 1879641 -28048 -1.5
(read/write) 128896 128896 0 0.0
.bss 54032 54032 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 68192 68192 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 155029 -1248 -0.8
.text 1605570 1578770 -26800 -1.7
bridge-app debug+rpc (read only) 1456485 1442101 -14384 -1.0
(read/write) 75088 75088 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31824 31824 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 122972 -960 -0.8
.text 1227173 1213749 -13424 -1.1
chip-tool debug (read only) 6687597 6686221 -1376 -0.0
(read/write) 201728 201728 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160376 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335273 -448 -0.1
.text 5942613 5941685 -928 -0.0
lighting-app debug+rpc (read only) 1742289 1728705 -13584 -0.8
(read/write) 108152 108152 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59344 59344 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 143697 -832 -0.6
.text 1454610 1441858 -12752 -0.9
ota-provider-app debug (read only) 1411953 1406561 -5392 -0.4
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 124382 -704 -0.6
.text 1181794 1177106 -4688 -0.4
ota-requestor-app debug (read only) 1516705 1511313 -5392 -0.4
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137103 -704 -0.5
.text 1269922 1265234 -4688 -0.4
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2056201 2036793 -19408 -0.9
(read/write) 320504 320504 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 175804 -1024 -0.6
.text 1724178 1705794 -18384 -1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317160 2310336 -6824 -0.3
.bss 184444 184444 0 0.0
.data 5240 5240 0 0.0
.heap 846760 846760 0 0.0
.text 1279736 1272912 -6824 -0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300992 2297384 -3608 -0.2
.bss 173248 173248 0 0.0
.data 5496 5496 0 0.0
.heap 857704 857704 0 0.0
.text 1263592 1259984 -3608 -0.3
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274032 2270368 -3664 -0.2
.bss 172296 172296 0 0.0
.data 5496 5496 0 0.0
.heap 858656 858656 0 0.0
.text 1236632 1232968 -3664 -0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048008 2048008 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010608 1010608 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 893095 -3612 -0.4
bss 113724 113724 0 0.0
rodata 100308 99976 -332 -0.3
text 607112 603840 -3272 -0.5
nrf52840dk_nrf52840+rpc (read/write) 859643 856135 -3508 -0.4
bss 110072 110072 0 0.0
rodata 91500 91272 -228 -0.2
text 581848 578568 -3280 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 822638 819038 -3600 -0.4
bss 115100 115100 0 0.0
rodata 95568 95232 -336 -0.4
text 537480 534212 -3268 -0.6
lock-app nrf52840dk_nrf52840 (read/write) 869275 865563 -3712 -0.4
bss 110988 110988 0 0.0
rodata 96428 96092 -336 -0.3
text 586468 583096 -3372 -0.6
nrf5340dk_nrf5340_cpuapp (read/write) 795458 791746 -3712 -0.5
bss 112396 112396 0 0.0
rodata 91716 91380 -336 -0.4
text 516932 513560 -3372 -0.7
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874027 870411 -3616 -0.4
bss 110900 110900 0 0.0
rodata 97780 97444 -336 -0.3
text 589884 586612 -3272 -0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 863655 -3580 -0.4
bss 110776 110776 0 0.0
rodata 95916 95584 -332 -0.3
text 585092 581832 -3260 -0.6
shell nrf52840dk_nrf52840 (read/write) 781643 781643 0 0.0
bss 109552 109552 0 0.0
rodata 74296 74296 0 0.0
text 523284 523284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696718 0 0.0
bss 110532 110532 0 0.0
rodata 68936 68936 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2353392 2343576 -9816 -0.4
.bss 110668 110668 0 0.0
.data 2520 2520 0 0.0
.heap 920152 920152 0 0.0
.text 1311656 1301840 -9816 -0.7
light-app default (read/write) 2284536 2279640 -4896 -0.2
.bss 98440 98440 0 0.0
.data 2336 2336 0 0.0
.heap 932568 932568 0 0.0
.text 1242800 1237904 -4896 -0.4
lock-app default (read/write) 2260688 2255728 -4960 -0.2
.bss 97320 97320 0 0.0
.data 2296 2296 0 0.0
.heap 933728 933728 0 0.0
.text 1218952 1213992 -4960 -0.4
qpg lighting-app qpg6100+debug (read only) 514144 510560 -3584 -0.7
(read/write) 122332 122332 0 0.0
.bss 80168 80168 0 0.0
.data 964 964 0 0.0
.text 508824 505240 -3584 -0.7
lock-app qpg6100+debug (read only) 488448 484752 -3696 -0.8
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 479432 -3696 -0.8
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 796186 -3684 -0.5
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 555910 -3220 -0.6

@bzbarsky-apple bzbarsky-apple merged commit 7ce81e5 into project-chip:master Dec 7, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-attribute-size branch December 7, 2021 20:39
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @vivien-apple @woody-apple