Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert array to linked list to support dynamic endpoints #12635

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Convert array to linked list to support dynamic endpoints #12635

merged 3 commits into from
Dec 9, 2021

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • Static array in onff cluster and identify cluster did not support dynamic endpoints

Change overview

  • Changed array to linked list

Testing

  • Automated tests to check for regressions and to verify changes
  • Manual testing to validate changes

@boring-cyborg boring-cyborg bot added the app label Dec 6, 2021
@mkardous-silabs mkardous-silabs mentioned this pull request Dec 6, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12635: Size comparison from d5e9b66 to a166451

Increases (10 builds for efr32, esp32, k32w, mbed, nrfconnect, telink)
platform target config section d5e9b66 a166451 change % change
efr32 lighting-app BRD4161A (read/write) 120740 120748 8 0.0
.bss 118912 118920 8 0.0
BRD4161A+rpc (read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
esp32 all-clusters-app c3devkit .dram0.bss 58232 58240 8 0.0
m5stack (read only) 956495 956503 8 0.0
.flash.text 951111 951119 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731592 16 0.0
.text 644508 644524 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 849840 849848 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894619 16 0.0
text 605532 605536 4 0.0
nrf52840dk_nrf52840+rpc text 580528 580532 4 0.0
nrf5340dk_nrf5340_cpuapp text 535856 535860 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798398 8 0.0
text 557996 558002 6 0.0
Decreases (9 builds for efr32, esp32, linux, mbed, p6)
platform target config section d5e9b66 a166451 change % change
efr32 lighting-app BRD4161A (read only) 797548 797516 -32 -0.0
.text 797540 797508 -32 -0.0
BRD4161A+rpc (read only) 825516 825500 -16 -0.0
.text 825508 825492 -16 -0.0
window-app BRD4161A (read only) 774504 774488 -16 -0.0
.text 774496 774480 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 852296 852266 -30 -0.0
.flash.text 852296 852266 -30 -0.0
linux all-clusters-app debug (read only) 1865497 1865369 -128 -0.0
.text 1569282 1569154 -128 -0.0
lighting-app debug+rpc (read only) 1730329 1730009 -320 -0.0
.text 1444978 1444658 -320 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 181412 181404 -8 -0.0
p6 all-clusters-app default (read/write) 2346600 2346584 -16 -0.0
.text 1304864 1304848 -16 -0.0
light-app default (read/write) 2283848 2283832 -16 -0.0
.text 1242112 1242096 -16 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5e9b66 a166451 change % change
efr32 lighting-app BRD4161A (read only) 797548 797516 -32 -0.0
(read/write) 120740 120748 8 0.0
.bss 118912 118920 8 0.0
.data 1828 1828 0 0.0
.text 797540 797508 -32 -0.0
BRD4161A+rpc (read only) 825516 825500 -16 -0.0
(read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
.data 1936 1936 0 0.0
.text 825508 825492 -16 -0.0
lock-app BRD4161A (read only) 772216 772216 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 772208 0 0.0
window-app BRD4161A (read only) 774504 774488 -16 -0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 774480 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 852296 852266 -30 -0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58240 8 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852296 852266 -30 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956495 956503 8 0.0
(read/write) 439528 439528 0 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208132 0 0.0
.flash.text 951111 951119 8 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731592 16 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644508 644524 16 0.0
lock-app k32w061+debug (read/write) 622292 622292 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544592 544592 0 0.0
shell k32w061+debug (read/write) 688184 688184 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598864 598864 0 0.0
linux all-clusters-app debug (read only) 1865497 1865369 -128 -0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 152917 0 0.0
.text 1569282 1569154 -128 -0.0
bridge-app debug+rpc (read only) 1444525 1444525 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 121916 0 0.0
.text 1217541 1217541 0 0.0
chip-tool debug (read only) 6646077 6646077 0 0.0
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313112 313112 0 0.0
.text 5928069 5928069 0 0.0
lighting-app debug+rpc (read only) 1730329 1730009 -320 -0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142513 0 0.0
.text 1444978 1444658 -320 -0.0
ota-provider-app debug (read only) 1402049 1402049 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123272 0 0.0
.text 1173922 1173922 0 0.0
ota-requestor-app debug (read only) 1511225 1511225 0 0.0
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136016 0 0.0
.text 1266402 1266402 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2046321 0 0.0
(read/write) 320320 320320 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174768 174768 0 0.0
.text 1716642 1716642 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312192 0 0.0
.bss 181412 181404 -8 -0.0
.data 5192 5192 0 0.0
.heap 849840 849848 8 0.0
.text 1274768 1274768 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894619 16 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605532 605536 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857979 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580528 580532 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820502 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535856 535860 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867203 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584904 584904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793338 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515324 515324 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871939 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588304 588304 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865147 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583512 583512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2346584 -16 -0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304864 1304848 -16 -0.0
light-app default (read/write) 2283848 2283832 -16 -0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1242096 -16 -0.0
lock-app default (read/write) 2259984 2259984 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1218248 0 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513276 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507956 0 0.0
lock-app qpg6100+debug (read only) 487580 487580 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482260 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798398 8 0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557996 558002 6 0.0

mkardous-silabs
mkardous-silabs commented Dec 6, 2021
View reviewed changes
Copy link
Contributor Author

@mkardous-silabs mkardous-silabs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

Damian-Nordic
Damian-Nordic approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some optional code style suggestions, but looking good overall.

@restyled-io restyled-io bot mentioned this pull request Dec 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12635: Size comparison from 1f4024a to 83777a1

Increases (8 builds for efr32, esp32, linux, nrfconnect, telink)
platform target config section 1f4024a 83777a1 change % change
efr32 lighting-app BRD4161A (read/write) 122996 123004 8 0.0
.bss 121176 121184 8 0.0
BRD4161A+rpc (read/write) 139680 139688 8 0.0
.bss 137752 137760 8 0.0
esp32 all-clusters-app m5stack (read only) 958923 958931 8 0.0
(read/write) 450252 450260 8 0.0
.dram0.bss 75000 75008 8 0.0
.flash.text 953539 953547 8 0.0
linux thermostat-no-ble arm64 (read/write) 135825 135841 16 0.0
.bss 59457 59473 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 605116 605120 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 860051 860067 16 0.0
text 579844 579848 4 0.0
nrf5340dk_nrf5340_cpuapp text 535496 535500 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 800386 800394 8 0.0
text 557446 557452 6 0.0
Decreases (6 builds for efr32, esp32, linux, p6)
platform target config section 1f4024a 83777a1 change % change
efr32 lighting-app BRD4161A (read only) 794956 794940 -16 -0.0
.text 794948 794932 -16 -0.0
BRD4161A+rpc (read only) 782552 782536 -16 -0.0
.text 782544 782528 -16 -0.0
window-app BRD4161A (read only) 771908 771892 -16 -0.0
.text 771900 771884 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 855952 855922 -30 -0.0
.flash.text 855952 855922 -30 -0.0
linux thermostat-no-ble arm64 (read only) 1906556 1906460 -96 -0.0
.text 1577744 1577648 -96 -0.0
p6 all-clusters-app default (read/write) 2350400 2350384 -16 -0.0
.text 1308664 1308648 -16 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1f4024a 83777a1 change % change
efr32 lighting-app BRD4161A (read only) 794956 794940 -16 -0.0
(read/write) 122996 123004 8 0.0
.bss 121176 121184 8 0.0
.data 1820 1820 0 0.0
.text 794948 794932 -16 -0.0
BRD4161A+rpc (read only) 782552 782536 -16 -0.0
(read/write) 139680 139688 8 0.0
.bss 137752 137760 8 0.0
.data 1928 1928 0 0.0
.text 782544 782528 -16 -0.0
window-app BRD4161A (read only) 771908 771892 -16 -0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 771900 771884 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 855952 855922 -30 -0.0
(read/write) 1306034 1306034 0 0.0
.dram0.bss 67648 67648 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171232 171232 0 0.0
.flash.text 855952 855922 -30 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958923 958931 8 0.0
(read/write) 450252 450260 8 0.0
.dram0.bss 75000 75008 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209416 209416 0 0.0
.flash.text 953539 953547 8 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732132 732132 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 643232 643232 0 0.0
lock-app k32w061+debug (read/write) 622716 622716 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 543184 543184 0 0.0
shell k32w061+debug (read/write) 685808 685808 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 596604 596604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6665652 6665652 0 0.0
(read/write) 305217 305217 0 0.0
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 201888 201888 0 0.0
.dynamic 560 560 0 0.0
.got 46984 46984 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 338548 338548 0 0.0
.text 5682820 5682820 0 0.0
thermostat-no-ble arm64 (read only) 1906556 1906460 -96 -0.0
(read/write) 135825 135841 16 0.0
.bss 59457 59473 16 0.0
.data 776 776 0 0.0
.data.rel.ro 69280 69280 0 0.0
.dynamic 560 560 0 0.0
.got 3456 3456 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 123964 123964 0 0.0
.text 1577744 1577648 -96 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316496 2316496 0 0.0
.bss 186900 186900 0 0.0
.data 5232 5232 0 0.0
.heap 844312 844312 0 0.0
.text 1279072 1279072 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299016 2299016 0 0.0
.bss 175712 175712 0 0.0
.data 5488 5488 0 0.0
.heap 855248 855248 0 0.0
.text 1261616 1261616 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271928 2271928 0 0.0
.bss 174752 174752 0 0.0
.data 5488 5488 0 0.0
.heap 856208 856208 0 0.0
.text 1234528 1234528 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 897027 897027 0 0.0
bss 116184 116184 0 0.0
rodata 100172 100172 0 0.0
text 605116 605120 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 860051 860067 16 0.0
bss 112532 112532 0 0.0
rodata 91468 91468 0 0.0
text 579844 579848 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822974 822974 0 0.0
bss 117560 117560 0 0.0
rodata 95432 95432 0 0.0
text 535496 535500 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869499 869499 0 0.0
bss 113448 113448 0 0.0
rodata 96292 96292 0 0.0
text 584376 584376 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795698 795698 0 0.0
bss 114856 114856 0 0.0
rodata 91580 91580 0 0.0
text 514848 514848 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874347 874347 0 0.0
bss 113360 113360 0 0.0
rodata 97644 97644 0 0.0
text 587892 587892 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867587 867587 0 0.0
bss 113236 113236 0 0.0
rodata 95780 95780 0 0.0
text 583112 583112 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2350400 2350384 -16 -0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1308664 1308648 -16 -0.0
light-app default (read/write) 2281464 2281464 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1239728 1239728 0 0.0
lock-app default (read/write) 2257568 2257568 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1215832 1215832 0 0.0
qpg lighting-app qpg6100+debug (read only) 511948 511948 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 506628 506628 0 0.0
lock-app qpg6100+debug (read only) 486140 486140 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 480820 480820 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800386 800394 8 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 557446 557452 6 0.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12635: Size comparison from 4584707 to 701c2b1

Increases (9 builds for efr32, esp32, linux, mbed, nrfconnect, telink)
platform target config section 4584707 701c2b1 change % change
efr32 lighting-app BRD4161A (read/write) 122980 122988 8 0.0
.bss 121160 121168 8 0.0
BRD4161A+rpc (read/write) 139664 139672 8 0.0
.bss 137736 137744 8 0.0
esp32 all-clusters-app m5stack (read only) 962527 962535 8 0.0
(read/write) 450860 450868 8 0.0
.dram0.bss 74984 74992 8 0.0
.flash.text 957143 957151 8 0.0
linux thermostat-no-ble arm64 (read/write) 136321 136337 16 0.0
.bss 59425 59441 16 0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2305928 2305992 64 0.0
.text 1268528 1268592 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 610376 610380 4 0.0
nrf52840dk_nrf52840+rpc text 585104 585108 4 0.0
nrf5340dk_nrf5340_cpuapp text 540804 540808 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 807462 807470 8 0.0
text 563528 563534 6 0.0
Decreases (6 builds for efr32, esp32, linux, p6)
platform target config section 4584707 701c2b1 change % change
efr32 lighting-app BRD4161A (read only) 803988 803972 -16 -0.0
.text 803980 803964 -16 -0.0
BRD4161A+rpc (read only) 791600 791584 -16 -0.0
.text 791592 791576 -16 -0.0
window-app BRD4161A (read only) 780716 780700 -16 -0.0
.text 780708 780692 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 859230 859200 -30 -0.0
.flash.text 859230 859200 -30 -0.0
linux thermostat-no-ble arm64 (read only) 1932068 1931972 -96 -0.0
.text 1601520 1601424 -96 -0.0
p6 all-clusters-app default (read/write) 2356128 2356112 -16 -0.0
.text 1314392 1314376 -16 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4584707 701c2b1 change % change
efr32 lighting-app BRD4161A (read only) 803988 803972 -16 -0.0
(read/write) 122980 122988 8 0.0
.bss 121160 121168 8 0.0
.data 1820 1820 0 0.0
.text 803980 803964 -16 -0.0
BRD4161A+rpc (read only) 791600 791584 -16 -0.0
(read/write) 139664 139672 8 0.0
.bss 137736 137744 8 0.0
.data 1928 1928 0 0.0
.text 791592 791576 -16 -0.0
window-app BRD4161A (read only) 780716 780700 -16 -0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780708 780692 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 859230 859200 -30 -0.0
(read/write) 1306602 1306602 0 0.0
.dram0.bss 67632 67632 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171816 171816 0 0.0
.flash.text 859230 859200 -30 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962527 962535 8 0.0
(read/write) 450860 450868 8 0.0
.dram0.bss 74984 74992 8 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210040 210040 0 0.0
.flash.text 957143 957151 8 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724636 0 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635752 635752 0 0.0
lock-app k32w061+debug (read/write) 615796 615796 0 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536280 536280 0 0.0
shell k32w061+debug (read/write) 679052 679052 0 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589864 589864 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6786028 6786028 0 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342380 342380 0 0.0
.text 5782004 5782004 0 0.0
thermostat-no-ble arm64 (read only) 1932068 1931972 -96 -0.0
(read/write) 136321 136337 16 0.0
.bss 59425 59441 16 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601520 1601424 -96 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320032 2320032 0 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1282608 1282608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305928 2305992 64 0.0
.bss 175696 175696 0 0.0
.data 5488 5488 0 0.0
.heap 855264 855264 0 0.0
.text 1268528 1268592 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174736 174736 0 0.0
.data 5488 5488 0 0.0
.heap 856224 856224 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 116168 116168 0 0.0
rodata 101164 101164 0 0.0
text 610376 610380 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 866307 866307 0 0.0
bss 112516 112516 0 0.0
rodata 92460 92460 0 0.0
text 585104 585108 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829274 829274 0 0.0
bss 117544 117544 0 0.0
rodata 96420 96420 0 0.0
text 540804 540808 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875527 0 0.0
bss 113432 113432 0 0.0
rodata 97280 97280 0 0.0
text 589440 589440 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801758 801758 0 0.0
bss 114840 114840 0 0.0
rodata 92568 92568 0 0.0
text 519964 519964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880455 0 0.0
bss 113344 113344 0 0.0
rodata 98632 98632 0 0.0
text 593032 593032 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873651 873651 0 0.0
bss 113220 113220 0 0.0
rodata 96772 96772 0 0.0
text 588192 588192 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356128 2356112 -16 -0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314392 1314376 -16 -0.0
light-app default (read/write) 2290512 2290512 0 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248776 1248776 0 0.0
lock-app default (read/write) 2266376 2266376 0 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224640 1224640 0 0.0
qpg lighting-app qpg6100+debug (read only) 517944 517944 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512624 512624 0 0.0
lock-app qpg6100+debug (read only) 491944 491944 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486624 486624 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807462 807470 8 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563528 563534 6 0.0

@jepenven-silabs jepenven-silabs merged commit 78ad213 into project-chip:master Dec 9, 2021
@mkardous-silabs mkardous-silabs deleted the fix/endpoint_array branch January 20, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkardous-silabs @andy31415 @woody-apple @Damian-Nordic @jmartinez-silabs @jepenven-silabs @restyled-commits