Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EventSchema and put ConcreteEventPath within Event Option #12633

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Remove EventSchema and put ConcreteEventPath within Event Option #12633

merged 1 commit into from
Dec 7, 2021

Conversation

yunhanw-google
Copy link
Contributor

Problem

Remove EventSchema and put ConcreteEventPath within Event Option

Change overview

See above

Testing

Existing test covers this

@boring-cyborg boring-cyborg bot added the app label Dec 6, 2021
@yunhanw-google yunhanw-google force-pushed the feature/improve_log_event_api branch from 6d92f45 to b5610a8 Compare December 6, 2021 20:11
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12633: Size comparison from d5e9b66 to b5610a8

Decreases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5e9b66 b5610a8 change % change
efr32 lighting-app BRD4161A (read only) 797548 797468 -80 -0.0
.text 797540 797460 -80 -0.0
BRD4161A+rpc (read only) 825516 825436 -80 -0.0
.text 825508 825428 -80 -0.0
lock-app BRD4161A (read only) 772216 772152 -64 -0.0
.text 772208 772144 -64 -0.0
window-app BRD4161A (read only) 774504 774424 -80 -0.0
.text 774496 774416 -80 -0.0
esp32 all-clusters-app c3devkit (read only) 852296 852210 -86 -0.0
.flash.text 852296 852210 -86 -0.0
m5stack (read only) 956495 956431 -64 -0.0
.flash.text 951111 951047 -64 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731512 -64 -0.0
.text 644508 644444 -64 -0.0
lock-app k32w061+debug (read/write) 622292 622212 -80 -0.0
.text 544592 544512 -80 -0.0
shell k32w061+debug (read/write) 688184 688120 -64 -0.0
.text 598864 598800 -64 -0.0
linux all-clusters-app debug (read only) 1865497 1865257 -240 -0.0
.text 1569282 1569042 -240 -0.0
bridge-app debug+rpc (read only) 1444525 1444285 -240 -0.0
.text 1217541 1217301 -240 -0.0
chip-tool debug (read only) 6646077 6645837 -240 -0.0
.text 5928069 5927829 -240 -0.0
lighting-app debug+rpc (read only) 1730329 1730089 -240 -0.0
.text 1444978 1444738 -240 -0.0
ota-provider-app debug (read only) 1402049 1401793 -256 -0.0
.text 1173922 1173666 -256 -0.0
ota-requestor-app debug (read only) 1511225 1510969 -256 -0.0
.text 1266402 1266146 -256 -0.0
tv-app debug (read only) 2046321 2046065 -256 -0.0
.text 1716642 1716386 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2312192 2312128 -64 -0.0
.text 1274768 1274704 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894539 -64 -0.0
text 605532 605460 -72 -0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857915 -64 -0.0
text 580528 580456 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820438 -64 -0.0
text 535856 535784 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867123 -80 -0.0
text 584904 584832 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793258 -80 -0.0
text 515324 515252 -72 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871859 -80 -0.0
text 588304 588232 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865083 -64 -0.0
text 583512 583440 -72 -0.0
p6 all-clusters-app default (read/write) 2346600 2346536 -64 -0.0
.text 1304864 1304800 -64 -0.0
light-app default (read/write) 2283848 2283768 -80 -0.0
.text 1242112 1242032 -80 -0.0
lock-app default (read/write) 2259984 2259920 -64 -0.0
.text 1218248 1218184 -64 -0.0
qpg lighting-app qpg6100+debug (read only) 513276 513204 -72 -0.0
.text 507956 507884 -72 -0.0
lock-app qpg6100+debug (read only) 487580 487508 -72 -0.0
.text 482260 482188 -72 -0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798310 -80 -0.0
text 557996 557916 -80 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5e9b66 b5610a8 change % change
efr32 lighting-app BRD4161A (read only) 797548 797468 -80 -0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797540 797460 -80 -0.0
BRD4161A+rpc (read only) 825516 825436 -80 -0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825508 825428 -80 -0.0
lock-app BRD4161A (read only) 772216 772152 -64 -0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 772144 -64 -0.0
window-app BRD4161A (read only) 774504 774424 -80 -0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 774416 -80 -0.0
esp32 all-clusters-app c3devkit (read only) 852296 852210 -86 -0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852296 852210 -86 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956495 956431 -64 -0.0
(read/write) 439528 439528 0 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208132 0 0.0
.flash.text 951111 951047 -64 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731512 -64 -0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644508 644444 -64 -0.0
lock-app k32w061+debug (read/write) 622292 622212 -80 -0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544592 544512 -80 -0.0
shell k32w061+debug (read/write) 688184 688120 -64 -0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598864 598800 -64 -0.0
linux all-clusters-app debug (read only) 1865497 1865257 -240 -0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 152917 0 0.0
.text 1569282 1569042 -240 -0.0
bridge-app debug+rpc (read only) 1444525 1444285 -240 -0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 121916 0 0.0
.text 1217541 1217301 -240 -0.0
chip-tool debug (read only) 6646077 6645837 -240 -0.0
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313112 313112 0 0.0
.text 5928069 5927829 -240 -0.0
lighting-app debug+rpc (read only) 1730329 1730089 -240 -0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142513 0 0.0
.text 1444978 1444738 -240 -0.0
ota-provider-app debug (read only) 1402049 1401793 -256 -0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123272 0 0.0
.text 1173922 1173666 -256 -0.0
ota-requestor-app debug (read only) 1511225 1510969 -256 -0.0
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136016 0 0.0
.text 1266402 1266146 -256 -0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2046065 -256 -0.0
(read/write) 320320 320320 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174768 174768 0 0.0
.text 1716642 1716386 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312128 -64 -0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274768 1274704 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894539 -64 -0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605532 605460 -72 -0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857915 -64 -0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580528 580456 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820438 -64 -0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535856 535784 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867123 -80 -0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584904 584832 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793258 -80 -0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515324 515252 -72 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871859 -80 -0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588304 588232 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865083 -64 -0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583512 583440 -72 -0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2346536 -64 -0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304864 1304800 -64 -0.0
light-app default (read/write) 2283848 2283768 -80 -0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1242032 -80 -0.0
lock-app default (read/write) 2259984 2259920 -64 -0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1218184 -64 -0.0
qpg lighting-app qpg6100+debug (read only) 513276 513204 -72 -0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507884 -72 -0.0
lock-app qpg6100+debug (read only) 487580 487508 -72 -0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482188 -72 -0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798310 -80 -0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557996 557916 -80 -0.0

@yunhanw-google yunhanw-google merged commit ee3df3f into project-chip:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robszewczyk robszewczyk robszewczyk approved these changes

@woody-apple woody-apple woody-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @robszewczyk @woody-apple @chrisdecenzo