Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created history tab to review most-recent-first commands #12622

Merged
merged 9 commits into from
Dec 11, 2021
Merged

Created history tab to review most-recent-first commands #12622

merged 9 commits into from
Dec 11, 2021

Conversation

JasonLiuZhuoCheng
Copy link
Contributor

Change overview

  • Created bottom navigation bar with History tab and Settings tab(empty)
  • Display history commands in History tab with Information such as ClusterName, CommandName, ParameterList, ResponseList and Status
  • Able to click on each history item and direct to ClusterDetail page, with autofilled ClusterName, CommandName and ParameterList
  • Improve UI on Endpoint item

Testing

Manually tested in the history tab

@todo
Copy link

todo bot commented Dec 6, 2021

Rename and change types of parameters

connectedhomeip/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionSettingsFragment.kt

Lines 16 to 26 in f8254c7

// TODO: Rename and change types of parameters
private var param1: String? = null
private var param2: String? = null
override fun onCreateView(
inflater: LayoutInflater, container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
// Inflate the layout for this fragment
return inflater.inflate(R.layout.cluster_interaction_settings_fragment, container, false)
}

This comment was generated by todo based on a TODO comment in f8254c7 in #12622. cc @JasonLiuZhuoCheng.

@boring-cyborg boring-cyborg bot added the android label Dec 6, 2021
@todo
Copy link

todo bot commented Dec 6, 2021

Rename and change types and number of parameters

connectedhomeip/src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionSettingsFragment.kt

Lines 35 to 43 in f8254c7

// TODO: Rename and change types and number of parameters
@JvmStatic
fun newInstance() =
ClusterInteractionSettingsFragment().apply {
arguments = Bundle().apply {
}
}
}
}

This comment was generated by todo based on a TODO comment in f8254c7 in #12622. cc @JasonLiuZhuoCheng.

austinh0
austinh0 suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@austinh0 austinh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title to be more descriptive

...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Show resolved Hide resolved
...m/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionHistoryFragment.kt Outdated Show resolved Hide resolved
...m/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionHistoryFragment.kt Outdated Show resolved Hide resolved
...m/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionHistoryFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
@JasonLiuZhuoCheng JasonLiuZhuoCheng changed the title Work around history tab Created history tab to review most-recent-first commands Dec 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12622: Size comparison from 5c70530 to cb406c3

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5c70530 cb406c3 change % change
efr32 lighting-app BRD4161A (read only) 797468 797468 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797460 797460 0 0.0
BRD4161A+rpc (read only) 825436 825436 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825428 825428 0 0.0
lock-app BRD4161A (read only) 772152 772152 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772144 772144 0 0.0
window-app BRD4161A (read only) 774424 774424 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774416 774416 0 0.0
esp32 all-clusters-app c3devkit (read only) 852210 852210 0 0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852210 852210 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956475 956475 0 0.0
(read/write) 439528 439528 0 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208132 0 0.0
.flash.text 951091 951091 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731512 731512 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644444 644444 0 0.0
lock-app k32w061+debug (read/write) 622212 622212 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544512 544512 0 0.0
shell k32w061+debug (read/write) 688120 688120 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598800 598800 0 0.0
linux all-clusters-app debug (read only) 1871081 1871081 0 0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 153717 153717 0 0.0
.text 1574066 1574066 0 0.0
bridge-app debug+rpc (read only) 1450101 1450101 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122692 0 0.0
.text 1222341 1222341 0 0.0
chip-tool debug (read only) 6651717 6651717 0 0.0
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313777 313777 0 0.0
.text 5933045 5933045 0 0.0
lighting-app debug+rpc (read only) 1735881 1735881 0 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143281 143281 0 0.0
.text 1449762 1449762 0 0.0
ota-provider-app debug (read only) 1407641 1407641 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124078 0 0.0
.text 1178706 1178706 0 0.0
ota-requestor-app debug (read only) 1516993 1516993 0 0.0
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 136823 0 0.0
.text 1271362 1271362 0 0.0
shell debug (read only) 823577 823577 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84754 0 0.0
.text 631986 631986 0 0.0
tv-app debug (read only) 2051945 2051945 0 0.0
(read/write) 320320 320320 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175436 175436 0 0.0
.text 1721602 1721602 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312128 2312128 0 0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274704 1274704 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894539 894539 0 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605460 605460 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857915 857915 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580456 580456 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820438 820438 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535784 535784 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867123 867123 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584832 584832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793258 793258 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515252 515252 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871859 871859 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588232 588232 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865083 865083 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583440 583440 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346536 2346536 0 0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304800 1304800 0 0.0
light-app default (read/write) 2283768 2283768 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242032 1242032 0 0.0
lock-app default (read/write) 2259920 2259920 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218184 1218184 0 0.0
qpg lighting-app qpg6100+debug (read only) 513204 513204 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507884 507884 0 0.0
lock-app qpg6100+debug (read only) 487508 487508 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482188 482188 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798310 798310 0 0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557916 557916 0 0.0

@github-actions
Copy link

PR #12622: Size comparison from 0b60205 to c198bd2

Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 0b60205 c198bd2 change % change
efr32 lighting-app BRD4161A (read only) 807484 807484 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807476 807476 0 0.0
window-app BRD4161A (read only) 784460 784460 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784452 784452 0 0.0
lighting-app BRD4161A+rpc (read only) 795120 795120 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795112 795112 0 0.0
k32w lock-app k32w061+debug (read/write) 618492 618492 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 538948 0 0.0
shell k32w061+debug (read/write) 623584 623584 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541840 0 0.0
lighting-app k32w061+se05x+release (read/write) 668532 668532 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587108 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6792796 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749972 5749972 0 0.0
thermostat-no-ble arm64 (read only) 1943364 1943364 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610912 1610912 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360184 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318448 0 0.0
light-app default (read/write) 2292984 2292984 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251248 0 0.0
lock-app default (read/write) 2269048 2269048 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227312 0 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520324 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515004 0 0.0
lock-app qpg6100+debug (read only) 494700 494700 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489380 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809770 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565274 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12622: Size comparison from 0b60205 to 3c0b68b

Full report (27 builds for k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0b60205 3c0b68b change % change
k32w lighting-app k32w061+se05x+release (read/write) 668532 668532 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587108 587108 0 0.0
lock-app k32w061+debug (read/write) 618492 618492 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538948 538948 0 0.0
shell k32w061+debug (read/write) 623584 623584 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541840 541840 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6792796 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749972 5749972 0 0.0
thermostat-no-ble arm64 (read only) 1943364 1943364 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610912 1610912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323376 2323376 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285952 1285952 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308008 2308008 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270608 1270608 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281120 2281120 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243720 1243720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905659 0 0.0
bss 116168 116168 0 0.0
rodata 101676 101676 0 0.0
text 612212 612212 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868683 0 0.0
bss 112516 112516 0 0.0
rodata 92972 92972 0 0.0
text 586940 586940 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831650 0 0.0
bss 117544 117544 0 0.0
rodata 96932 96932 0 0.0
text 542640 542640 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878271 0 0.0
bss 113432 113432 0 0.0
rodata 97792 97792 0 0.0
text 591656 591656 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804518 0 0.0
bss 114840 114840 0 0.0
rodata 93080 93080 0 0.0
text 522176 522176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883199 0 0.0
bss 113344 113344 0 0.0
rodata 99144 99144 0 0.0
text 595244 595244 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876443 0 0.0
bss 113220 113220 0 0.0
rodata 97284 97284 0 0.0
text 590444 590444 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360184 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318448 1318448 0 0.0
light-app default (read/write) 2292984 2292984 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251248 1251248 0 0.0
lock-app default (read/write) 2269048 2269048 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227312 1227312 0 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520324 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515004 515004 0 0.0
lock-app qpg6100+debug (read only) 494700 494700 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489380 489380 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 809770 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565274 565274 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the work-around-history-tab branch from 3c0b68b to c676219 Compare December 10, 2021 05:58
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12622: Size comparison from 586aca7 to c676219

Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 586aca7 c676219 change % change
esp32 all-clusters-app c3devkit (read only) 862792 862792 0 0.0
(read/write) 1306058 1306058 0 0.0
.dram0.bss 65832 65832 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 173064 0 0.0
.flash.text 862792 862792 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966015 966015 0 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75128 75128 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210772 0 0.0
.flash.text 960631 960631 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 669560 0 0.0
.bss 73872 73872 0 0.0
.data 1892 1892 0 0.0
.text 587996 587996 0 0.0
lock-app k32w061+debug (read/write) 619508 619508 0 0.0
.bss 72024 72024 0 0.0
.data 1852 1852 0 0.0
.text 539832 539832 0 0.0
shell k32w061+debug (read/write) 624608 624608 0 0.0
.bss 74252 74252 0 0.0
.data 1832 1832 0 0.0
.text 542724 542724 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6864988 6864988 0 0.0
(read/write) 318785 318785 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364764 0 0.0
.text 5820564 5820564 0 0.0
thermostat-no-ble arm64 (read only) 1947444 1947444 0 0.0
(read/write) 137201 137201 0 0.0
.bss 59601 59601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125508 0 0.0
.text 1614432 1614432 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324328 0 0.0
.bss 185108 185108 0 0.0
.data 5240 5240 0 0.0
.heap 846096 846096 0 0.0
.text 1286904 1286904 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308944 0 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282064 0 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244664 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906747 906747 0 0.0
bss 116296 116296 0 0.0
rodata 101980 101980 0 0.0
text 612876 612876 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 869795 869795 0 0.0
bss 112644 112644 0 0.0
rodata 93276 93276 0 0.0
text 587604 587604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832762 832762 0 0.0
bss 117672 117672 0 0.0
rodata 97236 97236 0 0.0
text 543304 543304 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879375 879375 0 0.0
bss 113560 113560 0 0.0
rodata 98096 98096 0 0.0
text 592320 592320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805634 805634 0 0.0
bss 114968 114968 0 0.0
rodata 93388 93388 0 0.0
text 522840 522840 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884315 884315 0 0.0
bss 113472 113472 0 0.0
rodata 99452 99452 0 0.0
text 595912 595912 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877555 877555 0 0.0
bss 113348 113348 0 0.0
rodata 97588 97588 0 0.0
text 591108 591108 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2361904 0 0.0
.bss 113244 113244 0 0.0
.data 2520 2520 0 0.0
.heap 917576 917576 0 0.0
.text 1320168 1320168 0 0.0
light-app default (read/write) 2294704 2294704 0 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252968 1252968 0 0.0
lock-app default (read/write) 2270784 2270784 0 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229048 0 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521320 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516000 516000 0 0.0
lock-app qpg6100+debug (read only) 495688 495688 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490368 490368 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 810954 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566006 566006 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12622: Size comparison from d27ac43 to 1ab13c8

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d27ac43 1ab13c8 change % change
efr32 lighting-app BRD4161A (read only) 815260 815260 0 0.0
(read/write) 123132 123132 0 0.0
.bss 121272 121272 0 0.0
.data 1860 1860 0 0.0
.text 815252 815252 0 0.0
BRD4161A+rpc (read only) 802908 802908 0 0.0
(read/write) 139808 139808 0 0.0
.bss 137848 137848 0 0.0
.data 1960 1960 0 0.0
.text 802900 802900 0 0.0
window-app BRD4161A (read only) 792224 792224 0 0.0
(read/write) 121264 121264 0 0.0
.bss 119440 119440 0 0.0
.data 1824 1824 0 0.0
.text 792216 792216 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669744 669744 0 0.0
.bss 73856 73856 0 0.0
.data 1892 1892 0 0.0
.text 588196 588196 0 0.0
lock-app k32w061+debug (read/write) 619696 619696 0 0.0
.bss 72008 72008 0 0.0
.data 1852 1852 0 0.0
.text 540036 540036 0 0.0
shell k32w061+debug (read/write) 625016 625016 0 0.0
.bss 74316 74316 0 0.0
.data 1832 1832 0 0.0
.text 543068 543068 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6846220 6846220 0 0.0
(read/write) 318849 318849 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208632 208632 0 0.0
.dynamic 560 560 0 0.0
.got 53408 53408 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364028 364028 0 0.0
.text 5801396 5801396 0 0.0
thermostat-no-ble arm64 (read only) 1947668 1947668 0 0.0
(read/write) 137185 137185 0 0.0
.bss 59505 59505 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70344 70344 0 0.0
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125476 125476 0 0.0
.text 1614416 1614416 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313680 2313680 0 0.0
.bss 184284 184284 0 0.0
.data 5232 5232 0 0.0
.heap 846928 846928 0 0.0
.text 1276256 1276256 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309168 2309168 0 0.0
.bss 175808 175808 0 0.0
.data 5528 5528 0 0.0
.heap 855112 855112 0 0.0
.text 1271768 1271768 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282288 2282288 0 0.0
.bss 174848 174848 0 0.0
.data 5520 5520 0 0.0
.heap 856080 856080 0 0.0
.text 1244888 1244888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907035 907035 0 0.0
bss 116280 116280 0 0.0
rodata 101932 101932 0 0.0
text 613240 613240 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870099 870099 0 0.0
bss 112628 112628 0 0.0
rodata 93228 93228 0 0.0
text 587984 587984 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833034 833034 0 0.0
bss 117656 117656 0 0.0
rodata 97188 97188 0 0.0
text 543668 543668 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879695 879695 0 0.0
bss 113544 113544 0 0.0
rodata 98048 98048 0 0.0
text 592684 592684 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805934 805934 0 0.0
bss 114952 114952 0 0.0
rodata 93336 93336 0 0.0
text 523204 523204 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884631 884631 0 0.0
bss 113456 113456 0 0.0
rodata 99400 99400 0 0.0
text 596276 596276 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877843 877843 0 0.0
bss 113332 113332 0 0.0
rodata 97540 97540 0 0.0
text 591472 591472 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782267 782267 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523840 523840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697346 697346 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444480 444480 0 0.0
p6 all-clusters-app default (read/write) 2360584 2360584 0 0.0
.bss 112484 112484 0 0.0
.data 2520 2520 0 0.0
.heap 918336 918336 0 0.0
.text 1318848 1318848 0 0.0
light-app default (read/write) 2300800 2300800 0 0.0
.bss 101064 101064 0 0.0
.data 2360 2360 0 0.0
.heap 929920 929920 0 0.0
.text 1259064 1259064 0 0.0
lock-app default (read/write) 2276872 2276872 0 0.0
.bss 99944 99944 0 0.0
.data 2328 2328 0 0.0
.heap 931072 931072 0 0.0
.text 1235136 1235136 0 0.0
qpg lighting-app qpg6100+debug (read only) 521532 521532 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82696 82696 0 0.0
.data 992 992 0 0.0
.text 516212 516212 0 0.0
lock-app qpg6100+debug (read only) 495896 495896 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81832 81832 0 0.0
.data 948 948 0 0.0
.text 490576 490576 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811522 811522 0 0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566628 566628 0 0.0

@github-actions
Copy link

PR #12622: Size comparison from d27ac43 to bb5aa00

Increases (1 build for mbed)
platform target config section d27ac43 bb5aa00 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846928 847264 336 0.0
Decreases (3 builds for mbed)
platform target config section d27ac43 bb5aa00 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313680 2313248 -432 -0.0
.bss 184284 183948 -336 -0.2
.text 1276256 1275824 -432 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309168 2309040 -128 -0.0
.text 1271768 1271640 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282288 2282160 -128 -0.0
.text 1244888 1244760 -128 -0.0
Full report (5 builds for mbed)
platform target config section d27ac43 bb5aa00 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313680 2313248 -432 -0.0
.bss 184284 183948 -336 -0.2
.data 5232 5232 0 0.0
.heap 846928 847264 336 0.0
.text 1276256 1275824 -432 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309168 2309040 -128 -0.0
.bss 175808 175808 0 0.0
.data 5528 5528 0 0.0
.heap 855112 855112 0 0.0
.text 1271768 1271640 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282288 2282160 -128 -0.0
.bss 174848 174848 0 0.0
.data 5520 5520 0 0.0
.heap 856080 856080 0 0.0
.text 1244888 1244760 -128 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0

@andy31415 andy31415 merged commit 03c6902 into project-chip:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@austinh0 austinh0 Awaiting requested review from austinh0

Assignees
No one assigned
Labels
android fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonLiuZhuoCheng @woody-apple @austinh0 @andy31415