Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix illuminance measurement cluster attributes #12614

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix illuminance measurement cluster attributes #12614

merged 2 commits into from
Dec 7, 2021

Conversation

fessehaeve
Copy link
Contributor

Problem

Min constraint for MaxMeasuredValue was wrong

Change overview

  • Corrected attribute constraint
  • updated all-clusters-app to use valid attribute default values

Testing

  • tested using chip-tool

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12614: Size comparison from bfdbd45 to ab5e19c

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 ab5e19c change % change
efr32 lighting-app BRD4161A (read only) 758896 758896 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758888 0 0.0
BRD4161A+rpc (read only) 787544 787544 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787536 0 0.0
lock-app BRD4161A (read only) 733952 733952 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733944 0 0.0
window-app BRD4161A (read only) 736224 736224 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 736216 0 0.0
esp32 all-clusters-app c3devkit (read only) 852538 852538 0 0.0
(read/write) 1290914 1290914 0 0.0
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169520 0 0.0
.flash.text 852538 852538 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 922399 0 0.0
(read/write) 424356 424356 0 0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 197324 0 0.0
.flash.text 917015 917015 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731908 731908 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644936 0 0.0
lock-app k32w061+debug (read/write) 622076 622076 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544472 0 0.0
shell k32w061+debug (read/write) 687968 687968 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598744 0 0.0
linux all-clusters-app debug (read only) 1872825 1872825 0 0.0
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152117 0 0.0
.text 1577602 1577602 0 0.0
bridge-app debug+rpc (read only) 1444277 1444277 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121500 0 0.0
.text 1217877 1217877 0 0.0
chip-tool debug (read only) 6628165 6628165 0 0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 310776 0 0.0
.text 5912661 5912661 0 0.0
lighting-app debug+rpc (read only) 1729441 1729441 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142161 0 0.0
.text 1444610 1444610 0 0.0
ota-provider-app debug (read only) 1400953 1400953 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122856 0 0.0
.text 1173410 1173410 0 0.0
ota-requestor-app debug (read only) 1510209 1510209 0 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135600 0 0.0
.text 1265970 1265970 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2046473 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174352 0 0.0
.text 1717378 1717378 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2313152 0 0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1275728 1275728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2299096 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2273088 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235688 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894879 0 0.0
bss 113756 113756 0 0.0
rodata 99680 99680 0 0.0
text 605896 605896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 858255 0 0.0
bss 110104 110104 0 0.0
rodata 91040 91040 0 0.0
text 580892 580892 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820790 0 0.0
bss 115128 115128 0 0.0
rodata 94936 94936 0 0.0
text 536232 536232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866899 0 0.0
bss 111016 111016 0 0.0
rodata 95796 95796 0 0.0
text 584708 584708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 793050 0 0.0
bss 112428 112428 0 0.0
rodata 91084 91084 0 0.0
text 515132 515132 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871683 0 0.0
bss 110928 110928 0 0.0
rodata 97148 97148 0 0.0
text 588156 588156 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864927 0 0.0
bss 110808 110808 0 0.0
rodata 95288 95288 0 0.0
text 583388 583388 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349448 2349448 0 0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1307712 0 0.0
light-app default (read/write) 2284072 2284072 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1242336 0 0.0
lock-app default (read/write) 2260624 2260624 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218888 0 0.0
qpg lighting-app qpg6100+debug (read only) 513724 513724 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508404 0 0.0
lock-app qpg6100+debug (read only) 487464 487464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 482144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 798382 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558088 0 0.0

@woody-apple
Copy link
Contributor

@fessehaeve Do we have to update the light app too?

@fessehaeve
Copy link
Contributor Author

@fessehaeve Do we have to update the light app too?

@woody-apple no, the light app doesn't contain the illuminance measurement cluster.

@andy31415
Copy link
Contributor

andy31415 commented Dec 7, 2021 •
edited
Loading

fast track: constant change only, PR up sufficiently for cross timezone review, change made by a domain owner.

@andy31415 andy31415 merged commit de09687 into project-chip:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@tecimovic tecimovic Awaiting requested review from tecimovic

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fessehaeve @woody-apple @andy31415