Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IM DataVersionFilter encoding support for read/subscribe request #12569

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Add IM DataVersionFilter encoding support for read/subscribe request #12569

merged 2 commits into from
Dec 6, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 3, 2021 •
edited
Loading

Problem

Per IM spec, Need to add IM DataVersionFilter and ClusterPath encoding support for read/subscribe request

Change overview

Add IM DataVersionFilter and ClusterPath encoding support for read/subscribe request
Remove deprecated AttributeVersionList.

Testing

Add unit test for DataVersionFilter and ClusterPath, update unit test for read/subscribe request message

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12569: Size comparison from 21757de to d9c12db

Increases above 0.2%:

platform target config section 21757de d9c12db change % change
linux all-clusters-app debug (read only) 1848137 1854009 5872 0.3
.rodata 149589 150421 832 0.6
.text 1555490 1560530 5040 0.3
bridge-app debug+rpc (read only) 1431021 1436837 5816 0.4
.rodata 121044 121820 776 0.6
.text 1205077 1210117 5040 0.4
lighting-app debug+rpc (read only) 1716161 1722017 5856 0.3
.rodata 141681 142513 832 0.6
.text 1431810 1436834 5024 0.4
ota-provider-app debug (read only) 1391625 1397473 5848 0.4
.rodata 121800 122606 806 0.7
.text 1165138 1170178 5040 0.4
ota-requestor-app debug (read only) 1498297 1504321 6024 0.4
.rodata 134288 135095 807 0.6
.text 1255314 1260530 5216 0.4
tv-app debug (read only) 2029745 2035721 5976 0.3
.rodata 174216 174980 764 0.4
.text 1700786 1706002 5216 0.3
Increases (8 builds for linux)
platform target config section 21757de d9c12db change % change
linux all-clusters-app debug (read only) 1848137 1854009 5872 0.3
.rodata 149589 150421 832 0.6
.text 1555490 1560530 5040 0.3
bridge-app debug+rpc (read only) 1431021 1436837 5816 0.4
.rodata 121044 121820 776 0.6
.text 1205077 1210117 5040 0.4
chip-tool debug (read only) 6593069 6599045 5976 0.1
.rodata 307512 308273 761 0.2
.text 5881573 5886789 5216 0.1
lighting-app debug+rpc (read only) 1716161 1722017 5856 0.3
.rodata 141681 142513 832 0.6
.text 1431810 1436834 5024 0.4
ota-provider-app debug (read only) 1391625 1397473 5848 0.4
.rodata 121800 122606 806 0.7
.text 1165138 1170178 5040 0.4
ota-requestor-app debug (read only) 1498297 1504321 6024 0.4
.rodata 134288 135095 807 0.6
.text 1255314 1260530 5216 0.4
shell debug (read only) 822041 822169 128 0.0
.rodata 83634 83730 96 0.1
.text 631570 631602 32 0.0
tv-app debug (read only) 2029745 2035721 5976 0.3
.rodata 174216 174980 764 0.4
.text 1700786 1706002 5216 0.3
Decreases (1 build for esp32)
platform target config section 21757de d9c12db change % change
esp32 all-clusters-app m5stack (read only) 918067 918063 -4 -0.0
.flash.text 912683 912679 -4 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 21757de d9c12db change % change
efr32 lighting-app BRD4161A (read only) 751784 751784 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751776 0 0.0
BRD4161A+rpc (read only) 780440 780440 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780432 0 0.0
lock-app BRD4161A (read only) 726592 726592 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726584 726584 0 0.0
window-app BRD4161A (read only) 729096 729096 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 729088 0 0.0
esp32 all-clusters-app c3devkit (read only) 847594 847594 0 0.0
(read/write) 1222714 1222714 0 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167848 167848 0 0.0
.flash.text 847594 847594 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918067 918063 -4 -0.0
(read/write) 421672 421672 0 0.0
.dram0.bss 60728 60728 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195648 195648 0 0.0
.flash.text 912683 912679 -4 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1848137 1854009 5872 0.3
(read/write) 123216 123216 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 66976 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 150421 832 0.6
.text 1555490 1560530 5040 0.3
bridge-app debug+rpc (read only) 1431021 1436837 5816 0.4
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121820 776 0.6
.text 1205077 1210117 5040 0.4
chip-tool debug (read only) 6593069 6599045 5976 0.1
(read/write) 199400 199400 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158168 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 308273 761 0.2
.text 5881573 5886789 5216 0.1
lighting-app debug+rpc (read only) 1716161 1722017 5856 0.3
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 142513 832 0.6
.text 1431810 1436834 5024 0.4
ota-provider-app debug (read only) 1391625 1397473 5848 0.4
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 122606 806 0.7
.text 1165138 1170178 5040 0.4
ota-requestor-app debug (read only) 1498297 1504321 6024 0.4
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 135095 807 0.6
.text 1255314 1260530 5216 0.4
shell debug (read only) 822041 822169 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83730 96 0.1
.text 631570 631602 32 0.0
tv-app debug (read only) 2029745 2035721 5976 0.3
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174980 764 0.4
.text 1700786 1706002 5216 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306704 2306704 0 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269280 1269280 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232824 1232824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817626 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863655 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581544 581544 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511972 511972 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339080 2339080 0 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1297344 0 0.0
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2256048 2256048 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214312 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 484124 484124 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478804 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/add_dataversionfilter branch from d9c12db to ed601a0 Compare December 5, 2021 08:01
@github-actions
Copy link

github-actions bot commented Dec 5, 2021 •
edited
Loading

PR #12569: Size comparison from b1e0023 to ed601a0

Increases above 0.2%:

platform target config section b1e0023 ed601a0 change % change
linux all-clusters-app debug (read only) 1851521 1857361 5840 0.3
.rodata 151285 152085 800 0.5
.text 1557154 1562194 5040 0.3
bridge-app debug+rpc (read only) 1432645 1438445 5800 0.4
.rodata 121948 122724 776 0.6
.text 1205797 1210821 5024 0.4
lighting-app debug+rpc (read only) 1717761 1723633 5872 0.3
.rodata 142577 143409 832 0.6
.text 1432514 1437554 5040 0.4
ota-provider-app debug (read only) 1393289 1399137 5848 0.4
.rodata 122792 123598 806 0.7
.text 1165810 1170850 5040 0.4
ota-requestor-app debug (read only) 1502561 1508585 6024 0.4
.rodata 135504 136311 807 0.6
.text 1258418 1263634 5216 0.4
tv-app debug (read only) 2031625 2037601 5976 0.3
.rodata 175344 176108 764 0.4
.text 1701538 1706754 5216 0.3
Increases (8 builds for linux)
platform target config section b1e0023 ed601a0 change % change
linux all-clusters-app debug (read only) 1851521 1857361 5840 0.3
.rodata 151285 152085 800 0.5
.text 1557154 1562194 5040 0.3
bridge-app debug+rpc (read only) 1432645 1438445 5800 0.4
.rodata 121948 122724 776 0.6
.text 1205797 1210821 5024 0.4
chip-tool debug (read only) 6619645 6625605 5960 0.1
.rodata 309912 310673 761 0.2
.text 5905173 5910373 5200 0.1
lighting-app debug+rpc (read only) 1717761 1723633 5872 0.3
.rodata 142577 143409 832 0.6
.text 1432514 1437554 5040 0.4
ota-provider-app debug (read only) 1393289 1399137 5848 0.4
.rodata 122792 123598 806 0.7
.text 1165810 1170850 5040 0.4
ota-requestor-app debug (read only) 1502561 1508585 6024 0.4
.rodata 135504 136311 807 0.6
.text 1258418 1263634 5216 0.4
shell debug (read only) 823129 823257 128 0.0
.rodata 84338 84434 96 0.1
.text 631954 631986 32 0.0
tv-app debug (read only) 2031625 2037601 5976 0.3
.rodata 175344 176108 764 0.4
.text 1701538 1706754 5216 0.3
Decreases (1 build for esp32)
platform target config section b1e0023 ed601a0 change % change
esp32 all-clusters-app m5stack (read only) 918319 918315 -4 -0.0
.flash.text 912935 912931 -4 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b1e0023 ed601a0 change % change
efr32 lighting-app BRD4161A (read only) 751672 751672 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 751664 0 0.0
BRD4161A+rpc (read only) 780344 780344 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 780336 0 0.0
lock-app BRD4161A (read only) 726496 726496 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 726488 0 0.0
window-app BRD4161A (read only) 729000 729000 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 728992 0 0.0
esp32 all-clusters-app c3devkit (read only) 847922 847922 0 0.0
(read/write) 1222786 1222786 0 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 167920 0 0.0
.flash.text 847922 847922 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 918315 -4 -0.0
(read/write) 421756 421756 0 0.0
.dram0.bss 60736 60736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 195724 0 0.0
.flash.text 912935 912931 -4 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1851521 1857361 5840 0.3
(read/write) 123344 123344 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 152085 800 0.5
.text 1557154 1562194 5040 0.3
bridge-app debug+rpc (read only) 1432645 1438445 5800 0.4
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 122724 776 0.6
.text 1205797 1210821 5024 0.4
chip-tool debug (read only) 6619645 6625605 5960 0.1
(read/write) 199688 199688 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158456 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 310673 761 0.2
.text 5905173 5910373 5200 0.1
lighting-app debug+rpc (read only) 1717761 1723633 5872 0.3
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 143409 832 0.6
.text 1432514 1437554 5040 0.4
ota-provider-app debug (read only) 1393289 1399137 5848 0.4
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 123598 806 0.7
.text 1165810 1170850 5040 0.4
ota-requestor-app debug (read only) 1502561 1508585 6024 0.4
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 136311 807 0.6
.text 1258418 1263634 5216 0.4
shell debug (read only) 823129 823257 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84434 96 0.1
.text 631954 631986 32 0.0
tv-app debug (read only) 2031625 2037601 5976 0.3
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 176108 764 0.4
.text 1701538 1706754 5216 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2307096 0 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269672 1269672 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2270288 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1232888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817610 817610 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533156 533156 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863639 863639 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581540 581540 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511964 511964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585080 585080 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580312 580312 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2340160 2340160 0 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1298424 1298424 0 0.0
light-app default (read/write) 2279680 2279680 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1237944 0 0.0
lock-app default (read/write) 2255984 2255984 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1214248 0 0.0
qpg lighting-app qpg6100+debug (read only) 510464 510464 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 505144 0 0.0
lock-app qpg6100+debug (read only) 484132 484132 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 478812 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 794746 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 554540 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12569: Size comparison from 299393b to 31be86b

Increases above 0.2%:

platform target config section 299393b 31be86b change % change
linux all-clusters-app debug (read only) 1868729 1874601 5872 0.3
.rodata 152245 153077 832 0.5
.text 1573378 1578418 5040 0.3
bridge-app debug+rpc (read only) 1440725 1446541 5816 0.4
.rodata 121628 122404 776 0.6
.text 1214197 1219237 5040 0.4
lighting-app debug+rpc (read only) 1725825 1731649 5824 0.3
.rodata 142257 143057 800 0.6
.text 1440898 1445922 5024 0.3
ota-provider-app debug (read only) 1398281 1404129 5848 0.4
.rodata 122984 123790 806 0.7
.text 1170610 1175650 5040 0.4
ota-requestor-app debug (read only) 1507521 1513545 6024 0.4
.rodata 135728 136535 807 0.6
.text 1263154 1268370 5216 0.4
tv-app debug (read only) 2042569 2048545 5976 0.3
.rodata 174480 175244 764 0.4
.text 1713346 1718562 5216 0.3
Increases (8 builds for linux)
platform target config section 299393b 31be86b change % change
linux all-clusters-app debug (read only) 1868729 1874601 5872 0.3
.rodata 152245 153077 832 0.5
.text 1573378 1578418 5040 0.3
bridge-app debug+rpc (read only) 1440725 1446541 5816 0.4
.rodata 121628 122404 776 0.6
.text 1214197 1219237 5040 0.4
chip-tool debug (read only) 6636133 6642077 5944 0.1
.rodata 311512 312241 729 0.2
.text 5919893 5925109 5216 0.1
lighting-app debug+rpc (read only) 1725825 1731649 5824 0.3
.rodata 142257 143057 800 0.6
.text 1440898 1445922 5024 0.3
ota-provider-app debug (read only) 1398281 1404129 5848 0.4
.rodata 122984 123790 806 0.7
.text 1170610 1175650 5040 0.4
ota-requestor-app debug (read only) 1507521 1513545 6024 0.4
.rodata 135728 136535 807 0.6
.text 1263154 1268370 5216 0.4
shell debug (read only) 823449 823577 128 0.0
.rodata 84658 84754 96 0.1
.text 631954 631986 32 0.0
tv-app debug (read only) 2042569 2048545 5976 0.3
.rodata 174480 175244 764 0.4
.text 1713346 1718562 5216 0.3
Decreases (1 build for esp32)
platform target config section 299393b 31be86b change % change
esp32 all-clusters-app m5stack (read only) 921367 921363 -4 -0.0
.flash.text 915983 915979 -4 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 299393b 31be86b change % change
efr32 lighting-app BRD4161A (read only) 795576 795576 0 0.0
(read/write) 120648 120648 0 0.0
.bss 118816 118816 0 0.0
.data 1828 1828 0 0.0
.text 795568 795568 0 0.0
BRD4161A+rpc (read only) 823552 823552 0 0.0
(read/write) 138952 138952 0 0.0
.bss 137016 137016 0 0.0
.data 1936 1936 0 0.0
.text 823544 823544 0 0.0
lock-app BRD4161A (read only) 770620 770620 0 0.0
(read/write) 118580 118580 0 0.0
.bss 116792 116792 0 0.0
.data 1788 1788 0 0.0
.text 770612 770612 0 0.0
window-app BRD4161A (read only) 772908 772908 0 0.0
(read/write) 118784 118784 0 0.0
.bss 116992 116992 0 0.0
.data 1792 1792 0 0.0
.text 772900 772900 0 0.0
esp32 all-clusters-app c3devkit (read only) 851636 851636 0 0.0
(read/write) 1225298 1225298 0 0.0
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169440 169440 0 0.0
.flash.text 851636 851636 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 921367 921363 -4 -0.0
(read/write) 424276 424276 0 0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197244 197244 0 0.0
.flash.text 915983 915979 -4 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731188 731188 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644216 644216 0 0.0
lock-app k32w061+debug (read/write) 621408 621408 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 543804 543804 0 0.0
shell k32w061+debug (read/write) 687300 687300 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598076 598076 0 0.0
linux all-clusters-app debug (read only) 1868729 1874601 5872 0.3
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152245 153077 832 0.5
.text 1573378 1578418 5040 0.3
bridge-app debug+rpc (read only) 1440725 1446541 5816 0.4
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121628 122404 776 0.6
.text 1214197 1219237 5040 0.4
chip-tool debug (read only) 6636133 6642077 5944 0.1
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 311512 312241 729 0.2
.text 5919893 5925109 5216 0.1
lighting-app debug+rpc (read only) 1725825 1731649 5824 0.3
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142257 143057 800 0.6
.text 1440898 1445922 5024 0.3
ota-provider-app debug (read only) 1398281 1404129 5848 0.4
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122984 123790 806 0.7
.text 1170610 1175650 5040 0.4
ota-requestor-app debug (read only) 1507521 1513545 6024 0.4
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135728 136535 807 0.6
.text 1263154 1268370 5216 0.4
shell debug (read only) 823449 823577 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84754 96 0.1
.text 631954 631986 32 0.0
tv-app debug (read only) 2042569 2048545 5976 0.3
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174480 175244 764 0.4
.text 1713346 1718562 5216 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312064 2312064 0 0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1274640 1274640 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298200 2298200 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1260800 1260800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272264 2272264 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1234864 1234864 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894175 894175 0 0.0
bss 113756 113756 0 0.0
rodata 99632 99632 0 0.0
text 605244 605244 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857551 857551 0 0.0
bss 110104 110104 0 0.0
rodata 90992 90992 0 0.0
text 580240 580240 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820090 820090 0 0.0
bss 115128 115128 0 0.0
rodata 94892 94892 0 0.0
text 535576 535576 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 866263 866263 0 0.0
bss 111016 111016 0 0.0
rodata 95752 95752 0 0.0
text 584116 584116 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 792414 792414 0 0.0
bss 112428 112428 0 0.0
rodata 91040 91040 0 0.0
text 514540 514540 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 870999 870999 0 0.0
bss 110928 110928 0 0.0
rodata 97104 97104 0 0.0
text 587512 587512 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864239 864239 0 0.0
bss 110808 110808 0 0.0
rodata 95240 95240 0 0.0
text 582744 582744 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346696 2346696 0 0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1304960 1304960 0 0.0
light-app default (read/write) 2281872 2281872 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1240136 1240136 0 0.0
lock-app default (read/write) 2258392 2258392 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1216656 1216656 0 0.0
qpg lighting-app qpg6100+debug (read only) 513000 513000 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 507680 507680 0 0.0
lock-app qpg6100+debug (read only) 486808 486808 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 481488 481488 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 797638 797638 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 557380 557380 0 0.0

@woody-apple woody-apple merged commit a1cb341 into project-chip:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @yufengwangca @woody-apple @jmartinez-silabs