-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BDXDownloader for new OTA Requestor API #12560
Implement BDXDownloader for new OTA Requestor API #12560
Conversation
if file already exists and is not empty, erase previous contentsconnectedhomeip/examples/ota-requestor-app/linux/LinuxOTAImageProcessor.cpp Lines 100 to 105 in a537444
This comment was generated by todo based on a
|
instatiate and initialize these values when QueryImageResponse tells us an image is availableconnectedhomeip/examples/ota-requestor-app/linux/main.cpp Lines 213 to 223 in a537444
This comment was generated by todo based on a
|
add API for OTARequestor to pass QueryImageResponse info to the application to use for OTADownloader initconnectedhomeip/examples/ota-requestor-app/linux/main.cpp Lines 214 to 224 in a537444
This comment was generated by todo based on a
|
PR #12560: Size comparison from fc07dcf to ea9f33a Increases above 0.2%:
Increases (11 builds for k32w, linux, p6, qpg)
Decreases (10 builds for k32w, linux, p6, qpg, telink)
Full report (18 builds for k32w, linux, p6, qpg, telink)
|
PR #12560: Size comparison from fc07dcf to 8cdc8fb Increases above 0.2%:
Increases (18 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (23 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Need flexible API for users to implement/support OTA Requestor cluster. This includes an API for downloading OTA images, especially using BDX.
Change overview
BDXDownloader
for downloading via BDX protocolBDXDownloader
that was more rigid and not unit-testable and did not fit into the new API designOTADownloader
interfaceLinuxOTAImageProcessor
to accommodateOTADownloader
API changesQueryImageResponse
indicates that an image is not availableNote: this change does not switch other platforms to the new API, only the Linux example.
Testing
Manual testing on Linux only:
Confirmed download is successful for a local file between two local Linux nodes.