Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable featuremap for the Thread Network Diagnostics cluster #12527

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Enable featuremap for the Thread Network Diagnostics cluster #12527

merged 2 commits into from
Dec 3, 2021

Conversation

jmartinez-silabs
Copy link
Member

Problem

Featuremap isn't enable in the thread network diagnostic cluster

Change overview

Add the ThreadNetworkDiagnosticsFeature bitmap in the cluster xml for the code generation.
Enable FeatureMap attribute on all app that have the cluster enabled.
Set default value to 0x0F

Bit | Code   | Feature
0   | PKTCNT | PacketCounts
1   | ERRCNT | ErrorCounts
2   | MLECNT | MLECounts
3   | MACCNT | MACCounts

Testing

read the attribute with chip-tool

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12527: Size comparison from 1ad526b to 5813d22

Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1ad526b 5813d22 change % change
efr32 lighting-app BRD4161A (read only) 751584 751600 16 0.0
.text 751576 751592 16 0.0
BRD4161A+rpc (read only) 780256 780280 24 0.0
.text 780248 780272 24 0.0
lock-app BRD4161A (read only) 725440 725456 16 0.0
.text 725432 725448 16 0.0
window-app BRD4161A (read only) 728752 728768 16 0.0
(read/write) 118160 118168 8 0.0
.bss 116368 116376 8 0.0
.text 728744 728760 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1223826 1223842 16 0.0
.flash.rodata 167744 167760 16 0.0
m5stack (read/write) 422804 422820 16 0.0
.flash.rodata 195548 195564 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728752 728780 28 0.0
.bss 79304 79312 8 0.0
.text 641788 641808 20 0.0
lock-app k32w061+debug (read/write) 617736 617764 28 0.0
.bss 69744 69752 8 0.0
.text 540368 540388 20 0.0
shell k32w061+debug (read/write) 683636 683656 20 0.0
.text 594640 594660 20 0.0
linux all-clusters-app debug (read only) 1843857 1843881 24 0.0
bridge-app debug+rpc (read only) 1424181 1424205 24 0.0
(read/write) 74416 74448 32 0.0
.data.rel.ro 31528 31560 32 0.1
chip-tool debug (read only) 6619357 6620493 1136 0.0
(read/write) 202128 202224 96 0.0
.data.rel.ro 161112 161208 96 0.1
.text 5901765 5902709 944 0.0
lighting-app debug+rpc (read only) 1708281 1708305 24 0.0
(read/write) 107408 107440 32 0.0
.data.rel.ro 59024 59056 32 0.1
tv-app debug (read only) 2001625 2001649 24 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2309264 2309288 24 0.0
.bss 179628 179636 8 0.0
.text 1271840 1271864 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2295656 2295680 24 0.0
.text 1258256 1258280 24 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2268688 2268712 24 0.0
.text 1231288 1231312 24 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891503 891523 20 0.0
bss 113752 113756 4 0.0
rodata 99408 99428 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 854879 854899 20 0.0
bss 110100 110104 4 0.0
rodata 90768 90788 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817414 817434 20 0.0
bss 115124 115128 4 0.0
rodata 94664 94684 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862359 862379 20 0.0
bss 110788 110792 4 0.0
rodata 95144 95164 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788514 788534 20 0.0
bss 112200 112204 4 0.0
rodata 90436 90456 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868375 868395 20 0.0
bss 110924 110928 4 0.0
rodata 96880 96900 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861439 861459 20 0.0
bss 110804 110808 4 0.0
rodata 95016 95036 20 0.0
p6 all-clusters-app default (read/write) 2339544 2339568 24 0.0
.text 1297808 1297832 24 0.0
light-app default (read/write) 2278920 2278936 16 0.0
.text 1237184 1237200 16 0.0
lock-app default (read/write) 2254256 2254272 16 0.0
.text 1212520 1212536 16 0.0
qpg lighting-app qpg6100+debug (read only) 510544 510564 20 0.0
.bss 80264 80272 8 0.0
.text 505224 505244 20 0.0
lock-app qpg6100+debug (read only) 483352 483372 20 0.0
.bss 79176 79184 8 0.0
.text 478032 478052 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 794594 794614 20 0.0
bss 80328 80332 4 0.0
Decreases (1 build for mbed)
platform target config section 1ad526b 5813d22 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851632 851624 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1ad526b 5813d22 change % change
efr32 lighting-app BRD4161A (read only) 751584 751600 16 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751576 751592 16 0.0
BRD4161A+rpc (read only) 780256 780280 24 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780248 780272 24 0.0
lock-app BRD4161A (read only) 725440 725456 16 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725432 725448 16 0.0
window-app BRD4161A (read only) 728752 728768 16 0.0
(read/write) 118160 118168 8 0.0
.bss 116368 116376 8 0.0
.data 1792 1792 0 0.0
.text 728744 728760 16 0.0
esp32 all-clusters-app c3devkit (read only) 847862 847862 0 0.0
(read/write) 1223826 1223842 16 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167744 167760 16 0.0
.flash.text 847862 847862 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918439 918439 0 0.0
(read/write) 422804 422820 16 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195548 195564 16 0.0
.flash.text 913055 913055 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728752 728780 28 0.0
.bss 79304 79312 8 0.0
.data 1860 1860 0 0.0
.text 641788 641808 20 0.0
lock-app k32w061+debug (read/write) 617736 617764 28 0.0
.bss 69744 69752 8 0.0
.data 1824 1824 0 0.0
.text 540368 540388 20 0.0
shell k32w061+debug (read/write) 683636 683656 20 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594640 594660 20 0.0
linux all-clusters-app debug (read only) 1843857 1843881 24 0.0
(read/write) 124256 124256 0 0.0
.bss 50768 50768 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146517 146517 0 0.0
.text 1554882 1554882 0 0.0
bridge-app debug+rpc (read only) 1424181 1424205 24 0.0
(read/write) 74416 74448 32 0.0
.bss 36144 36144 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31528 31560 32 0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119564 119564 0 0.0
.text 1199957 1199957 0 0.0
chip-tool debug (read only) 6619357 6620493 1136 0.0
(read/write) 202128 202224 96 0.0
.bss 34440 34440 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161112 161208 96 0.1
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 307288 307288 0 0.0
.text 5901765 5902709 944 0.0
lighting-app debug+rpc (read only) 1708281 1708305 24 0.0
(read/write) 107408 107440 32 0.0
.bss 41808 41808 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59024 59056 32 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139345 139345 0 0.0
.text 1426530 1426530 0 0.0
ota-provider-app debug (read only) 1384897 1384897 0 0.0
(read/write) 72648 72648 0 0.0
.bss 38720 38720 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120808 120808 0 0.0
.text 1159618 1159618 0 0.0
ota-requestor-app debug (read only) 1488721 1488721 0 0.0
(read/write) 76584 76584 0 0.0
.bss 40832 40832 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 133136 133136 0 0.0
.text 1247106 1247106 0 0.0
shell debug (read only) 819625 819625 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3512 3512 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83570 83570 0 0.0
.text 629314 629314 0 0.0
tv-app debug (read only) 2001625 2001649 24 0.0
(read/write) 317648 317648 0 0.0
.bss 246712 246712 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 63720 63720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169384 169384 0 0.0
.text 1679250 1679250 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309264 2309288 24 0.0
.bss 179628 179636 8 0.0
.data 5184 5184 0 0.0
.heap 851632 851624 -8 -0.0
.text 1271840 1271864 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295656 2295680 24 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258256 1258280 24 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268688 2268712 24 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231288 1231312 24 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891503 891523 20 0.0
bss 113752 113756 4 0.0
rodata 99408 99428 20 0.0
text 602792 602792 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854879 854899 20 0.0
bss 110100 110104 4 0.0
rodata 90768 90788 20 0.0
text 577788 577788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817414 817434 20 0.0
bss 115124 115128 4 0.0
rodata 94664 94684 20 0.0
text 533128 533128 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862359 862379 20 0.0
bss 110788 110792 4 0.0
rodata 95144 95164 20 0.0
text 581044 581044 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788514 788534 20 0.0
bss 112200 112204 4 0.0
rodata 90436 90456 20 0.0
text 511472 511472 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868375 868395 20 0.0
bss 110924 110928 4 0.0
rodata 96880 96900 20 0.0
text 585108 585108 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861439 861459 20 0.0
bss 110804 110808 4 0.0
rodata 95016 95036 20 0.0
text 580168 580168 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779891 779891 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339544 2339568 24 0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297808 1297832 24 0.0
light-app default (read/write) 2278920 2278936 16 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237184 1237200 16 0.0
lock-app default (read/write) 2254256 2254272 16 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212520 1212536 16 0.0
qpg lighting-app qpg6100+debug (read only) 510544 510564 20 0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80272 8 0.0
.data 964 964 0 0.0
.text 505224 505244 20 0.0
lock-app qpg6100+debug (read only) 483352 483372 20 0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79184 8 0.0
.data 916 916 0 0.0
.text 478032 478052 20 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794594 794614 20 0.0
bss 80328 80332 4 0.0
noinit 37160 37160 0 0.0
text 554576 554576 0 0.0

@jepenven-silabs jepenven-silabs merged commit dbda129 into project-chip:master Dec 3, 2021
billwatersiii pushed a commit to billwatersiii/connectedhomeip that referenced this pull request Dec 3, 2021
@jmartinez-silabs @billwatersiii
Enable featuremap for the Thread Network Diagnostics cluster (project…
55e975e 
…-chip#12527)

* Enable featuremap with value 15 (support all features) for thread network diagnostic cluster

* regen
@jmartinez-silabs jmartinez-silabs deleted the thread_featuremap branch February 11, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmartinez-silabs @saurabhst @woody-apple @jepenven-silabs