Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant 0x from before %p in log formats. #12519

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Remove redundant 0x from before %p in log formats. #12519

merged 1 commit into from
Dec 3, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Tried of seeing 0x0xabcdef01 in the logs.

Problem

See above.

Change overview

Remove the extra "0x".

Testing

Looked at resulting logs.

@bzbarsky-apple
Remove redundant 0x from before %p in log formats.
f99e518 
Tried of seeing 0x0xabcdef01 in the logs.
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12519: Size comparison from 7cba51d to f99e518

Decreases (15 builds for efr32, linux, mbed, nrfconnect, p6, telink)
platform target config section 7cba51d f99e518 change % change
efr32 lighting-app BRD4161A+rpc (read only) 780216 780208 -8 -0.0
.text 780208 780200 -8 -0.0
linux bridge-app debug+rpc (read only) 1423037 1423005 -32 -0.0
.rodata 119500 119468 -32 -0.0
ota-provider-app debug (read only) 1383857 1383825 -32 -0.0
.rodata 120776 120744 -32 -0.0
mbed shell CY8CPROTO_062_4343W+release (read/write) 2046968 2046960 -8 -0.0
.text 1009568 1009560 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891475 891471 -4 -0.0
rodata 99412 99408 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 854835 854831 -4 -0.0
rodata 90772 90768 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817370 817366 -4 -0.0
rodata 94668 94664 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 862331 862327 -4 -0.0
rodata 95148 95144 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788470 788466 -4 -0.0
rodata 90440 90436 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 868331 868327 -4 -0.0
rodata 96884 96880 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861411 861407 -4 -0.0
rodata 95020 95016 -4 -0.0
shell nrf52840dk_nrf52840 (read/write) 779895 779891 -4 -0.0
rodata 73796 73792 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694934 -4 -0.0
rodata 68436 68432 -4 -0.0
p6 all-clusters-app default (read/write) 2339520 2339512 -8 -0.0
.text 1297784 1297776 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 794550 794546 -4 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7cba51d f99e518 change % change
efr32 lighting-app BRD4161A (read only) 751552 751552 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751544 751544 0 0.0
BRD4161A+rpc (read only) 780216 780208 -8 -0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780208 780200 -8 -0.0
lock-app BRD4161A (read only) 725392 725392 0 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725384 725384 0 0.0
window-app BRD4161A (read only) 728720 728720 0 0.0
(read/write) 118160 118160 0 0.0
.bss 116368 116368 0 0.0
.data 1792 1792 0 0.0
.text 728712 728712 0 0.0
esp32 all-clusters-app c3devkit (read only) 847808 847808 0 0.0
(read/write) 1223826 1223826 0 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167744 167744 0 0.0
.flash.text 847808 847808 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918399 918399 0 0.0
(read/write) 422804 422804 0 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195548 195548 0 0.0
.flash.text 913015 913015 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728720 728720 0 0.0
.bss 79304 79304 0 0.0
.data 1860 1860 0 0.0
.text 641756 641756 0 0.0
lock-app k32w061+debug (read/write) 617704 617704 0 0.0
.bss 69744 69744 0 0.0
.data 1824 1824 0 0.0
.text 540336 540336 0 0.0
shell k32w061+debug (read/write) 683604 683604 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594608 594608 0 0.0
linux all-clusters-app debug (read only) 1842697 1842697 0 0.0
(read/write) 124256 124256 0 0.0
.bss 50768 50768 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146453 146453 0 0.0
.text 1553890 1553890 0 0.0
bridge-app debug+rpc (read only) 1423037 1423005 -32 -0.0
(read/write) 74416 74416 0 0.0
.bss 36144 36144 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31528 31528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119500 119468 -32 -0.0
.text 1198981 1198981 0 0.0
chip-tool debug (read only) 6618837 6618837 0 0.0
(read/write) 202128 202128 0 0.0
.bss 34440 34440 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161112 161112 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 307224 307224 0 0.0
.text 5901429 5901429 0 0.0
lighting-app debug+rpc (read only) 1707121 1707121 0 0.0
(read/write) 107408 107408 0 0.0
.bss 41808 41808 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59024 59024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139281 139281 0 0.0
.text 1425538 1425538 0 0.0
ota-provider-app debug (read only) 1383857 1383825 -32 -0.0
(read/write) 72648 72648 0 0.0
.bss 38720 38720 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120776 120744 -32 -0.0
.text 1158722 1158722 0 0.0
ota-requestor-app debug (read only) 1483945 1483945 0 0.0
(read/write) 76512 76512 0 0.0
.bss 40832 40832 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29576 29576 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132688 132688 0 0.0
.text 1243458 1243458 0 0.0
shell debug (read only) 818561 818561 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 628418 628418 0 0.0
tv-app debug (read only) 2000921 2000921 0 0.0
(read/write) 317616 317616 0 0.0
.bss 246712 246712 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 63720 63720 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169320 169320 0 0.0
.text 1678722 1678722 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309264 2309264 0 0.0
.bss 179628 179628 0 0.0
.data 5184 5184 0 0.0
.heap 851632 851632 0 0.0
.text 1271840 1271840 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295592 2295592 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258192 1258192 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268688 2268688 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231288 1231288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046968 2046960 -8 -0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009568 1009560 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891475 891471 -4 -0.0
bss 113752 113752 0 0.0
rodata 99412 99408 -4 -0.0
text 602752 602752 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854835 854831 -4 -0.0
bss 110100 110100 0 0.0
rodata 90772 90768 -4 -0.0
text 577748 577748 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817370 817366 -4 -0.0
bss 115124 115124 0 0.0
rodata 94668 94664 -4 -0.0
text 533088 533088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862331 862327 -4 -0.0
bss 110788 110788 0 0.0
rodata 95148 95144 -4 -0.0
text 581004 581004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788470 788466 -4 -0.0
bss 112200 112200 0 0.0
rodata 90440 90436 -4 -0.0
text 511432 511432 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868331 868327 -4 -0.0
bss 110924 110924 0 0.0
rodata 96884 96880 -4 -0.0
text 585068 585068 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861411 861407 -4 -0.0
bss 110804 110804 0 0.0
rodata 95020 95016 -4 -0.0
text 580128 580128 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779895 779891 -4 -0.0
bss 109696 109696 0 0.0
rodata 73796 73792 -4 -0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694934 -4 -0.0
bss 110680 110680 0 0.0
rodata 68436 68432 -4 -0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339520 2339512 -8 -0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297784 1297776 -8 -0.0
light-app default (read/write) 2278872 2278872 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237136 1237136 0 0.0
lock-app default (read/write) 2254224 2254224 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212488 1212488 0 0.0
qpg lighting-app qpg6100+debug (read only) 510496 510496 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80264 0 0.0
.data 964 964 0 0.0
.text 505176 505176 0 0.0
lock-app qpg6100+debug (read only) 483320 483320 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79176 0 0.0
.data 916 916 0 0.0
.text 478000 478000 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794550 794546 -4 -0.0
bss 80328 80328 0 0.0
noinit 37160 37160 0 0.0
text 554522 554522 0 0.0

woody-apple
woody-apple approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking given this is fixing logging.

@woody-apple woody-apple merged commit 1ad526b into project-chip:master Dec 3, 2021
@bzbarsky-apple bzbarsky-apple deleted the logging-pointers branch December 3, 2021 01:04
billwatersiii pushed a commit to billwatersiii/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple @billwatersiii
Remove redundant 0x from before %p in log formats. (project-chip#12519)
0be5df5 
Tried of seeing 0x0xabcdef01 in the logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha approved these changes

@msandstedt msandstedt msandstedt approved these changes

@emargolis emargolis emargolis approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @electrocucaracha @msandstedt @emargolis @yunhanw-google @woody-apple