-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pump-examples] Set default value for CHIP_CONFIG_MAX_DEVICE_ADMINS #12473
Merged
woody-apple
merged 3 commits into
project-chip:master
from
Grundfos:feature/TIPlatformSetMaxAdmins
Dec 3, 2021
Merged
[pump-examples] Set default value for CHIP_CONFIG_MAX_DEVICE_ADMINS #12473
woody-apple
merged 3 commits into
project-chip:master
from
Grundfos:feature/TIPlatformSetMaxAdmins
Dec 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_STACK size on TI platform. Increased heap size in pump apps.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst and
selissia
December 2, 2021 11:28
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
December 2, 2021 11:28
andersbangGF
changed the title
[TI cc13xx_26xx] Set default value for CHIP_CONFIG_MAX_DEVICE_ADMINS
[pump-examples] Set default value for CHIP_CONFIG_MAX_DEVICE_ADMINS
Dec 2, 2021
PR #12473: Size comparison from 7b214c9 to 4aadc6b Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Dec 2, 2021
PR #12473: Size comparison from dc10c82 to b38ce68 Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this is a platform manufacturer updating their platform.
billwatersiii
pushed a commit
to billwatersiii/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…_STACK size on TI platform. Increased heap size in pump apps. (project-chip#12473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing