Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QName compression in minmdns #12445

Merged
merged 23 commits into from
Dec 3, 2021
Merged

Implement QName compression in minmdns #12445

merged 23 commits into from
Dec 3, 2021

Conversation

andy31415
Copy link
Contributor

Problem

Our MDNS packets begin to be quite large given advertising of vid/ping and multiple IP addresses.

Change overview

Adds support for qname compression when building mdns packets. Expect to make packets somewhat smaller.

Testing

E2E unit tests on linux exercise minmdns a lot
Unit tests updated & added new unit test for the compressed writer
Manual validation with minmdns example that query works

@boring-cyborg boring-cyborg bot added the lib label Dec 1, 2021
@boring-cyborg boring-cyborg bot added the vscode label Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12445: Size comparison from dc10c82 to 9a98ea1

Increases above 0.2%:

platform target config section dc10c823 9a98ea1 change % change
linux bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
.text 1147589 1150341 2752 0.2
lighting-app debug+rpc .text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
.text 1106514 1109330 2816 0.3
ota-requestor-app debug .text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
.got 3504 3512 8 0.2
.text 623250 625026 1776 0.3
Increases (11 builds for linux, p6)
platform target config section dc10c823 9a98ea1 change % change
linux all-clusters-app debug (read only) 1797065 1799865 2800 0.2
(read/write) 125992 126024 32 0.0
.bss 53456 53488 32 0.1
.text 1510818 1513618 2800 0.2
bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
(read/write) 71920 71952 32 0.0
.bss 35440 35472 32 0.1
.text 1147589 1150341 2752 0.2
chip-tool debug (read only) 6528285 6531117 2832 0.0
(read/write) 199760 199792 32 0.0
.bss 33736 33768 32 0.1
.text 5816693 5819525 2832 0.0
lighting-app debug+rpc (read only) 1651097 1653897 2800 0.2
(read/write) 105008 105040 32 0.0
.bss 41136 41168 32 0.1
.text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
(read/write) 70376 70408 32 0.0
.bss 38016 38048 32 0.1
.text 1106514 1109330 2816 0.3
ota-requestor-app debug (read only) 1427937 1430753 2816 0.2
(read/write) 74272 74304 32 0.0
.bss 40128 40160 32 0.1
.text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
(read/write) 60264 60296 32 0.1
.got 3504 3512 8 0.2
.text 623250 625026 1776 0.3
tv-app debug (read only) 1944817 1947617 2800 0.1
(read/write) 314640 314672 32 0.0
.bss 245496 245528 32 0.0
.text 1626946 1629746 2800 0.2
p6 all-clusters-app default (read/write) 2320840 2321432 592 0.0
.bss 110072 110104 32 0.0
.text 1279104 1279696 592 0.0
light-app default (read/write) 2256624 2257216 592 0.0
.bss 98112 98144 32 0.0
.text 1214888 1215480 592 0.0
lock-app default (read/write) 2231984 2232576 592 0.0
.bss 96768 96800 32 0.0
.text 1190248 1190840 592 0.0
Decreases (3 builds for p6)
platform target config section dc10c823 9a98ea1 change % change
p6 all-clusters-app default .heap 920808 920776 -32 -0.0
light-app default .heap 932904 932872 -32 -0.0
lock-app default .heap 934288 934256 -32 -0.0
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section dc10c823 9a98ea1 change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1799865 2800 0.2
(read/write) 125992 126024 32 0.0
.bss 53456 53488 32 0.1
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1513618 2800 0.2
bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
(read/write) 71920 71952 32 0.0
.bss 35440 35472 32 0.1
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1150341 2752 0.2
chip-tool debug (read only) 6528285 6531117 2832 0.0
(read/write) 199760 199792 32 0.0
.bss 33736 33768 32 0.1
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816693 5819525 2832 0.0
lighting-app debug+rpc (read only) 1651097 1653897 2800 0.2
(read/write) 105008 105040 32 0.0
.bss 41136 41168 32 0.1
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
(read/write) 70376 70408 32 0.0
.bss 38016 38048 32 0.1
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1109330 2816 0.3
ota-requestor-app debug (read only) 1427937 1430753 2816 0.2
(read/write) 74272 74304 32 0.0
.bss 40128 40160 32 0.1
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
(read/write) 60264 60296 32 0.1
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3512 8 0.2
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 625026 1776 0.3
tv-app debug (read only) 1944817 1947617 2800 0.1
(read/write) 314640 314672 32 0.0
.bss 245496 245528 32 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1629746 2800 0.2
p6 all-clusters-app default (read/write) 2320840 2321432 592 0.0
.bss 110072 110104 32 0.0
.data 2464 2464 0 0.0
.heap 920808 920776 -32 -0.0
.text 1279104 1279696 592 0.0
light-app default (read/write) 2256624 2257216 592 0.0
.bss 98112 98144 32 0.0
.data 2328 2328 0 0.0
.heap 932904 932872 -32 -0.0
.text 1214888 1215480 592 0.0
lock-app default (read/write) 2231984 2232576 592 0.0
.bss 96768 96800 32 0.0
.data 2288 2288 0 0.0
.heap 934288 934256 -32 -0.0
.text 1190248 1190840 592 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@andy31415 andy31415 marked this pull request as ready for review December 2, 2021 16:10
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12445: Size comparison from dc10c82 to 623b5e3

Increases above 0.2%:

platform target config section dc10c823 623b5e3 change % change
linux bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
.text 1147589 1150341 2752 0.2
lighting-app debug+rpc .text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
.text 1106514 1109330 2816 0.3
ota-requestor-app debug .text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
.got 3504 3512 8 0.2
.text 623250 625026 1776 0.3
Increases (11 builds for linux, p6)
platform target config section dc10c823 623b5e3 change % change
linux all-clusters-app debug (read only) 1797065 1799865 2800 0.2
(read/write) 125992 126024 32 0.0
.bss 53456 53488 32 0.1
.text 1510818 1513618 2800 0.2
bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
(read/write) 71920 71952 32 0.0
.bss 35440 35472 32 0.1
.text 1147589 1150341 2752 0.2
chip-tool debug (read only) 6528285 6531117 2832 0.0
(read/write) 199760 199792 32 0.0
.bss 33736 33768 32 0.1
.text 5816693 5819525 2832 0.0
lighting-app debug+rpc (read only) 1651097 1653897 2800 0.2
(read/write) 105008 105040 32 0.0
.bss 41136 41168 32 0.1
.text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
(read/write) 70376 70408 32 0.0
.bss 38016 38048 32 0.1
.text 1106514 1109330 2816 0.3
ota-requestor-app debug (read only) 1427937 1430753 2816 0.2
(read/write) 74272 74304 32 0.0
.bss 40128 40160 32 0.1
.text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
(read/write) 60264 60296 32 0.1
.got 3504 3512 8 0.2
.text 623250 625026 1776 0.3
tv-app debug (read only) 1944817 1947617 2800 0.1
(read/write) 314640 314672 32 0.0
.bss 245496 245528 32 0.0
.text 1626946 1629746 2800 0.2
p6 all-clusters-app default (read/write) 2320840 2321432 592 0.0
.bss 110072 110104 32 0.0
.text 1279104 1279696 592 0.0
light-app default (read/write) 2256624 2257216 592 0.0
.bss 98112 98144 32 0.0
.text 1214888 1215480 592 0.0
lock-app default (read/write) 2231984 2232576 592 0.0
.bss 96768 96800 32 0.0
.text 1190248 1190840 592 0.0
Decreases (3 builds for p6)
platform target config section dc10c823 623b5e3 change % change
p6 all-clusters-app default .heap 920808 920776 -32 -0.0
light-app default .heap 932904 932872 -32 -0.0
lock-app default .heap 934288 934256 -32 -0.0
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section dc10c823 623b5e3 change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1799865 2800 0.2
(read/write) 125992 126024 32 0.0
.bss 53456 53488 32 0.1
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1513618 2800 0.2
bridge-app debug+rpc (read only) 1367285 1370037 2752 0.2
(read/write) 71920 71952 32 0.0
.bss 35440 35472 32 0.1
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1150341 2752 0.2
chip-tool debug (read only) 6528285 6531117 2832 0.0
(read/write) 199760 199792 32 0.0
.bss 33736 33768 32 0.1
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816693 5819525 2832 0.0
lighting-app debug+rpc (read only) 1651097 1653897 2800 0.2
(read/write) 105008 105040 32 0.0
.bss 41136 41168 32 0.1
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1376706 2800 0.2
ota-provider-app debug (read only) 1327881 1330697 2816 0.2
(read/write) 70376 70408 32 0.0
.bss 38016 38048 32 0.1
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1109330 2816 0.3
ota-requestor-app debug (read only) 1427937 1430753 2816 0.2
(read/write) 74272 74304 32 0.0
.bss 40128 40160 32 0.1
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1194002 2816 0.2
shell debug (read only) 812841 814705 1864 0.2
(read/write) 60264 60296 32 0.1
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3512 8 0.2
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 625026 1776 0.3
tv-app debug (read only) 1944817 1947617 2800 0.1
(read/write) 314640 314672 32 0.0
.bss 245496 245528 32 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1629746 2800 0.2
p6 all-clusters-app default (read/write) 2320840 2321432 592 0.0
.bss 110072 110104 32 0.0
.data 2464 2464 0 0.0
.heap 920808 920776 -32 -0.0
.text 1279104 1279696 592 0.0
light-app default (read/write) 2256624 2257216 592 0.0
.bss 98112 98144 32 0.0
.data 2328 2328 0 0.0
.heap 932904 932872 -32 -0.0
.text 1214888 1215480 592 0.0
lock-app default (read/write) 2231984 2232576 592 0.0
.bss 96768 96800 32 0.0
.data 2288 2288 0 0.0
.heap 934288 934256 -32 -0.0
.text 1190248 1190840 592 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12445: Size comparison from 803f3b8 to cb73e42

Increases above 0.2%:

platform target config section 803f3b8 cb73e42 change % change
linux bridge-app debug+rpc .text 1194261 1197477 3216 0.3
ota-provider-app debug .text 1153714 1156962 3248 0.3
ota-requestor-app debug .text 1238386 1241634 3248 0.3
shell debug .text 623538 625410 1872 0.3
Increases (17 builds for esp32, linux, mbed, p6)
platform target config section 803f3b8 cb73e42 change % change
esp32 all-clusters-app c3devkit (read only) 847268 847824 556 0.1
(read/write) 1223618 1223650 32 0.0
.dram0.bss 56472 56504 32 0.1
.flash.text 847268 847824 556 0.1
m5stack (read only) 917827 918275 448 0.0
(read/write) 422596 422628 32 0.0
.dram0.bss 61864 61896 32 0.1
.flash.text 912443 912891 448 0.0
linux all-clusters-app debug (read only) 1835665 1839041 3376 0.2
(read/write) 123840 123872 32 0.0
.bss 50640 50672 32 0.1
.rodata 146357 146517 160 0.1
.text 1547506 1550722 3216 0.2
bridge-app debug+rpc (read only) 1417669 1421021 3352 0.2
(read/write) 74032 74064 32 0.0
.bss 36048 36080 32 0.1
.rodata 119404 119540 136 0.1
.text 1194261 1197477 3216 0.3
chip-tool debug (read only) 6613133 6616509 3376 0.1
(read/write) 201744 201776 32 0.0
.bss 34344 34376 32 0.1
.rodata 307128 307256 128 0.0
.text 5896373 5899621 3248 0.1
lighting-app debug+rpc (read only) 1701465 1704809 3344 0.2
(read/write) 107088 107120 32 0.0
.bss 41744 41776 32 0.1
.rodata 139185 139313 128 0.1
.text 1420530 1423746 3216 0.2
ota-provider-app debug (read only) 1378201 1381577 3376 0.2
(read/write) 72264 72296 32 0.0
.bss 38624 38656 32 0.1
.rodata 120680 120808 128 0.1
.text 1153714 1156962 3248 0.3
ota-requestor-app debug (read only) 1478225 1481601 3376 0.2
(read/write) 76160 76192 32 0.0
.bss 40736 40768 32 0.1
.rodata 132592 132720 128 0.1
.text 1238386 1241634 3248 0.3
shell debug (read only) 813129 815089 1960 0.2
(read/write) 60264 60296 32 0.1
.got 3504 3512 8 0.2
.text 623538 625410 1872 0.3
tv-app debug (read only) 1995169 1998529 3360 0.2
(read/write) 316760 316792 32 0.0
.bss 246112 246144 32 0.0
.rodata 169224 169352 128 0.1
.text 1673618 1676850 3232 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2308576 2309088 512 0.0
.bss 179532 179564 32 0.0
.text 1271152 1271664 512 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2295096 2295544 448 0.0
.bss 173224 173256 32 0.0
.text 1257696 1258144 448 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2268128 2268640 512 0.0
.bss 172040 172072 32 0.0
.text 1230728 1231240 512 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2046576 2046960 384 0.0
.text 1009176 1009560 384 0.0
p6 all-clusters-app default (read/write) 2338416 2339040 624 0.0
.bss 107720 107752 32 0.0
.text 1296680 1297304 624 0.0
light-app default (read/write) 2278016 2278640 624 0.0
.bss 98452 98484 32 0.0
.text 1236280 1236904 624 0.1
lock-app default (read/write) 2253368 2253992 624 0.0
.bss 97108 97140 32 0.0
.text 1211632 1212256 624 0.1
Decreases (6 builds for mbed, p6)
platform target config section 803f3b8 cb73e42 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851728 851696 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857728 857696 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858912 858880 -32 -0.0
p6 all-clusters-app default .heap 923168 923136 -32 -0.0
light-app default .heap 932552 932520 -32 -0.0
lock-app default .heap 933936 933904 -32 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 803f3b8 cb73e42 change % change
efr32 lighting-app BRD4161A (read only) 751432 751432 0 0.0
(read/write) 120008 120008 0 0.0
.bss 118176 118176 0 0.0
.data 1828 1828 0 0.0
.text 751424 751424 0 0.0
BRD4161A+rpc (read only) 780080 780080 0 0.0
(read/write) 138312 138312 0 0.0
.bss 136376 136376 0 0.0
.data 1936 1936 0 0.0
.text 780072 780072 0 0.0
lock-app BRD4161A (read only) 725272 725272 0 0.0
(read/write) 117712 117712 0 0.0
.bss 115928 115928 0 0.0
.data 1784 1784 0 0.0
.text 725264 725264 0 0.0
window-app BRD4161A (read only) 728600 728600 0 0.0
(read/write) 118136 118136 0 0.0
.bss 116344 116344 0 0.0
.data 1792 1792 0 0.0
.text 728592 728592 0 0.0
esp32 all-clusters-app c3devkit (read only) 847268 847824 556 0.1
(read/write) 1223618 1223650 32 0.0
.dram0.bss 56472 56504 32 0.1
.dram0.data 14052 14052 0 0.0
.flash.rodata 167632 167632 0 0.0
.flash.text 847268 847824 556 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 917827 918275 448 0.0
(read/write) 422596 422628 32 0.0
.dram0.bss 61864 61896 32 0.1
.dram0.data 34016 34016 0 0.0
.flash.rodata 195436 195436 0 0.0
.flash.text 912443 912891 448 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728608 728608 0 0.0
.bss 79280 79280 0 0.0
.data 1860 1860 0 0.0
.text 641668 641668 0 0.0
lock-app k32w061+debug (read/write) 617592 617592 0 0.0
.bss 69720 69720 0 0.0
.data 1824 1824 0 0.0
.text 540248 540248 0 0.0
shell k32w061+debug (read/write) 683460 683460 0 0.0
.bss 81376 81376 0 0.0
.data 1796 1796 0 0.0
.text 594488 594488 0 0.0
linux all-clusters-app debug (read only) 1835665 1839041 3376 0.2
(read/write) 123840 123872 32 0.0
.bss 50640 50672 32 0.1
.data 1120 1120 0 0.0
.data.rel.ro 66816 66816 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146357 146517 160 0.1
.text 1547506 1550722 3216 0.2
bridge-app debug+rpc (read only) 1417669 1421021 3352 0.2
(read/write) 74032 74064 32 0.0
.bss 36048 36080 32 0.1
.data 1728 1728 0 0.0
.data.rel.ro 31248 31248 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119404 119540 136 0.1
.text 1194261 1197477 3216 0.3
chip-tool debug (read only) 6613133 6616509 3376 0.1
(read/write) 201744 201776 32 0.0
.bss 34344 34376 32 0.1
.data 1024 1024 0 0.0
.data.rel.ro 160824 160824 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 307128 307256 128 0.0
.text 5896373 5899621 3248 0.1
lighting-app debug+rpc (read only) 1701465 1704809 3344 0.2
(read/write) 107088 107120 32 0.0
.bss 41744 41776 32 0.1
.data 1280 1280 0 0.0
.data.rel.ro 58752 58752 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139185 139313 128 0.1
.text 1420530 1423746 3216 0.2
ota-provider-app debug (read only) 1378201 1381577 3376 0.2
(read/write) 72264 72296 32 0.0
.bss 38624 38656 32 0.1
.data 928 928 0 0.0
.data.rel.ro 27592 27592 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120680 120808 128 0.1
.text 1153714 1156962 3248 0.3
ota-requestor-app debug (read only) 1478225 1481601 3376 0.2
(read/write) 76160 76192 32 0.0
.bss 40736 40768 32 0.1
.data 992 992 0 0.0
.data.rel.ro 29304 29304 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132592 132720 128 0.1
.text 1238386 1241634 3248 0.3
shell debug (read only) 813129 815089 1960 0.2
(read/write) 60264 60296 32 0.1
.bss 16904 16904 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3512 8 0.2
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623538 625410 1872 0.3
tv-app debug (read only) 1995169 1998529 3360 0.2
(read/write) 316760 316792 32 0.0
.bss 246112 246144 32 0.0
.data 1520 1520 0 0.0
.data.rel.ro 63440 63440 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169224 169352 128 0.1
.text 1673618 1676850 3232 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308576 2309088 512 0.0
.bss 179532 179564 32 0.0
.data 5184 5184 0 0.0
.heap 851728 851696 -32 -0.0
.text 1271152 1271664 512 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295096 2295544 448 0.0
.bss 173224 173256 32 0.0
.data 5496 5496 0 0.0
.heap 857728 857696 -32 -0.0
.text 1257696 1258144 448 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268128 2268640 512 0.0
.bss 172040 172072 32 0.0
.data 5496 5496 0 0.0
.heap 858912 858880 -32 -0.0
.text 1230728 1231240 512 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046960 384 0.0
.bss 156704 156704 0 0.0
.data 4872 4872 0 0.0
.heap 874872 874872 0 0.0
.text 1009176 1009560 384 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891323 891323 0 0.0
bss 113728 113728 0 0.0
rodata 99372 99372 0 0.0
text 602684 602684 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854699 854699 0 0.0
bss 110076 110076 0 0.0
rodata 90732 90732 0 0.0
text 577680 577680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817234 817234 0 0.0
bss 115100 115100 0 0.0
rodata 94628 94628 0 0.0
text 533024 533024 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862179 862179 0 0.0
bss 110764 110764 0 0.0
rodata 95108 95108 0 0.0
text 580936 580936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788334 788334 0 0.0
bss 112176 112176 0 0.0
rodata 90400 90400 0 0.0
text 511368 511368 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868195 868195 0 0.0
bss 110900 110900 0 0.0
rodata 96844 96844 0 0.0
text 585004 585004 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861275 861275 0 0.0
bss 110780 110780 0 0.0
rodata 94980 94980 0 0.0
text 580064 580064 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779911 779911 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521916 521916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694938 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442520 442520 0 0.0
p6 all-clusters-app default (read/write) 2338416 2339040 624 0.0
.bss 107720 107752 32 0.0
.data 2456 2456 0 0.0
.heap 923168 923136 -32 -0.0
.text 1296680 1297304 624 0.0
light-app default (read/write) 2278016 2278640 624 0.0
.bss 98452 98484 32 0.0
.data 2336 2336 0 0.0
.heap 932552 932520 -32 -0.0
.text 1236280 1236904 624 0.1
lock-app default (read/write) 2253368 2253992 624 0.0
.bss 97108 97140 32 0.0
.data 2296 2296 0 0.0
.heap 933936 933904 -32 -0.0
.text 1211632 1212256 624 0.1
qpg lighting-app qpg6100+debug (read only) 510408 510408 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80240 80240 0 0.0
.data 964 964 0 0.0
.text 505088 505088 0 0.0
lock-app qpg6100+debug (read only) 483232 483232 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79152 79152 0 0.0
.data 916 916 0 0.0
.text 477912 477912 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794430 794430 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 554474 554474 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12445: Size comparison from f847731 to bc38e47

Increases above 0.2%:

platform target config section f847731 bc38e47 change % change
linux bridge-app debug+rpc .text 1198949 1202149 3200 0.3
ota-provider-app debug .text 1158706 1161938 3232 0.3
ota-requestor-app debug .text 1243378 1246610 3232 0.3
shell debug .text 628386 630242 1856 0.3
Increases (17 builds for esp32, linux, mbed, p6)
platform target config section f847731 bc38e47 change % change
esp32 all-clusters-app c3devkit (read only) 847754 848310 556 0.1
(read/write) 1223810 1223842 32 0.0
.dram0.bss 56552 56584 32 0.1
.flash.text 847754 848310 556 0.1
m5stack (read only) 918375 918843 468 0.1
(read/write) 422780 422812 32 0.0
.dram0.bss 61936 61968 32 0.1
.flash.text 912991 913459 468 0.1
linux all-clusters-app debug (read only) 1842681 1846041 3360 0.2
(read/write) 124224 124256 32 0.0
.bss 50736 50768 32 0.1
.rodata 146453 146613 160 0.1
.text 1553874 1557074 3200 0.2
bridge-app debug+rpc (read only) 1423005 1426341 3336 0.2
(read/write) 74384 74416 32 0.0
.bss 36112 36144 32 0.1
.rodata 119500 119636 136 0.1
.text 1198949 1202149 3200 0.3
chip-tool debug (read only) 6618757 6622149 3392 0.1
(read/write) 202096 202128 32 0.0
.bss 34408 34440 32 0.1
.rodata 307224 307352 128 0.0
.text 5901349 5904613 3264 0.1
lighting-app debug+rpc (read only) 1707105 1710449 3344 0.2
(read/write) 107376 107408 32 0.0
.bss 41776 41808 32 0.1
.rodata 139281 139409 128 0.1
.text 1425522 1428738 3216 0.2
ota-provider-app debug (read only) 1383841 1387201 3360 0.2
(read/write) 72616 72648 32 0.0
.bss 38688 38720 32 0.1
.rodata 120776 120904 128 0.1
.text 1158706 1161938 3232 0.3
ota-requestor-app debug (read only) 1483865 1487225 3360 0.2
(read/write) 76480 76512 32 0.0
.bss 40800 40832 32 0.1
.rodata 132688 132816 128 0.1
.text 1243378 1246610 3232 0.3
shell debug (read only) 818529 820473 1944 0.2
.got 3504 3512 8 0.2
.text 628386 630242 1856 0.3
tv-app debug (read only) 2000841 2004185 3344 0.2
(read/write) 317072 317104 32 0.0
.bss 246168 246200 32 0.0
.rodata 169320 169448 128 0.1
.text 1678642 1681858 3216 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2309200 2309648 448 0.0
.bss 179604 179636 32 0.0
.text 1271776 1272224 448 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2295528 2296040 512 0.0
.bss 173248 173280 32 0.0
.text 1258128 1258640 512 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2268624 2269072 448 0.0
.bss 172064 172096 32 0.0
.text 1231224 1231672 448 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2046968 2047416 448 0.0
.text 1009568 1010016 448 0.0
p6 all-clusters-app default (read/write) 2339520 2340160 640 0.0
.bss 107796 107828 32 0.0
.text 1297784 1298424 640 0.0
light-app default (read/write) 2278872 2279512 640 0.0
.bss 98480 98512 32 0.0
.text 1237136 1237776 640 0.1
lock-app default (read/write) 2254224 2254864 640 0.0
.bss 97136 97168 32 0.0
.text 1212488 1213128 640 0.1
Decreases (6 builds for mbed, p6)
platform target config section f847731 bc38e47 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851656 851624 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857704 857672 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858888 858856 -32 -0.0
p6 all-clusters-app default .heap 923088 923056 -32 -0.0
light-app default .heap 932528 932496 -32 -0.0
lock-app default .heap 933912 933880 -32 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f847731 bc38e47 change % change
efr32 lighting-app BRD4161A (read only) 751440 751440 0 0.0
(read/write) 120008 120008 0 0.0
.bss 118176 118176 0 0.0
.data 1828 1828 0 0.0
.text 751432 751432 0 0.0
BRD4161A+rpc (read only) 780088 780088 0 0.0
(read/write) 138312 138312 0 0.0
.bss 136376 136376 0 0.0
.data 1936 1936 0 0.0
.text 780080 780080 0 0.0
lock-app BRD4161A (read only) 725280 725280 0 0.0
(read/write) 117712 117712 0 0.0
.bss 115928 115928 0 0.0
.data 1784 1784 0 0.0
.text 725272 725272 0 0.0
window-app BRD4161A (read only) 728608 728608 0 0.0
(read/write) 118136 118136 0 0.0
.bss 116344 116344 0 0.0
.data 1792 1792 0 0.0
.text 728600 728600 0 0.0
esp32 all-clusters-app c3devkit (read only) 847754 848310 556 0.1
(read/write) 1223810 1223842 32 0.0
.dram0.bss 56552 56584 32 0.1
.dram0.data 14052 14052 0 0.0
.flash.rodata 167744 167744 0 0.0
.flash.text 847754 848310 556 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918375 918843 468 0.1
(read/write) 422780 422812 32 0.0
.dram0.bss 61936 61968 32 0.1
.dram0.data 34016 34016 0 0.0
.flash.rodata 195548 195548 0 0.0
.flash.text 912991 913459 468 0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728648 728648 0 0.0
.bss 79280 79280 0 0.0
.data 1860 1860 0 0.0
.text 641708 641708 0 0.0
lock-app k32w061+debug (read/write) 617616 617616 0 0.0
.bss 69720 69720 0 0.0
.data 1824 1824 0 0.0
.text 540272 540272 0 0.0
shell k32w061+debug (read/write) 683500 683500 0 0.0
.bss 81376 81376 0 0.0
.data 1796 1796 0 0.0
.text 594528 594528 0 0.0
linux all-clusters-app debug (read only) 1842681 1846041 3360 0.2
(read/write) 124224 124256 32 0.0
.bss 50736 50768 32 0.1
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146453 146613 160 0.1
.text 1553874 1557074 3200 0.2
bridge-app debug+rpc (read only) 1423005 1426341 3336 0.2
(read/write) 74384 74416 32 0.0
.bss 36112 36144 32 0.1
.data 1728 1728 0 0.0
.data.rel.ro 31528 31528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119500 119636 136 0.1
.text 1198949 1202149 3200 0.3
chip-tool debug (read only) 6618757 6622149 3392 0.1
(read/write) 202096 202128 32 0.0
.bss 34408 34440 32 0.1
.data 1024 1024 0 0.0
.data.rel.ro 161112 161112 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 307224 307352 128 0.0
.text 5901349 5904613 3264 0.1
lighting-app debug+rpc (read only) 1707105 1710449 3344 0.2
(read/write) 107376 107408 32 0.0
.bss 41776 41808 32 0.1
.data 1280 1280 0 0.0
.data.rel.ro 59024 59024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139281 139409 128 0.1
.text 1425522 1428738 3216 0.2
ota-provider-app debug (read only) 1383841 1387201 3360 0.2
(read/write) 72616 72648 32 0.0
.bss 38688 38720 32 0.1
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120776 120904 128 0.1
.text 1158706 1161938 3232 0.3
ota-requestor-app debug (read only) 1483865 1487225 3360 0.2
(read/write) 76480 76512 32 0.0
.bss 40800 40832 32 0.1
.data 992 992 0 0.0
.data.rel.ro 29576 29576 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132688 132816 128 0.1
.text 1243378 1246610 3232 0.3
shell debug (read only) 818529 820473 1944 0.2
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3512 8 0.2
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 628386 630242 1856 0.3
tv-app debug (read only) 2000841 2004185 3344 0.2
(read/write) 317072 317104 32 0.0
.bss 246168 246200 32 0.0
.data 1520 1520 0 0.0
.data.rel.ro 63720 63720 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169320 169448 128 0.1
.text 1678642 1681858 3216 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309200 2309648 448 0.0
.bss 179604 179636 32 0.0
.data 5184 5184 0 0.0
.heap 851656 851624 -32 -0.0
.text 1271776 1272224 448 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295528 2296040 512 0.0
.bss 173248 173280 32 0.0
.data 5496 5496 0 0.0
.heap 857704 857672 -32 -0.0
.text 1258128 1258640 512 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268624 2269072 448 0.0
.bss 172064 172096 32 0.0
.data 5496 5496 0 0.0
.heap 858888 858856 -32 -0.0
.text 1231224 1231672 448 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046968 2047416 448 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009568 1010016 448 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891363 891363 0 0.0
bss 113728 113728 0 0.0
rodata 99412 99412 0 0.0
text 602680 602680 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854739 854739 0 0.0
bss 110076 110076 0 0.0
rodata 90772 90772 0 0.0
text 577676 577676 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817274 817274 0 0.0
bss 115100 115100 0 0.0
rodata 94668 94668 0 0.0
text 533016 533016 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862219 862219 0 0.0
bss 110764 110764 0 0.0
rodata 95148 95148 0 0.0
text 580932 580932 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788374 788374 0 0.0
bss 112176 112176 0 0.0
rodata 90440 90440 0 0.0
text 511360 511360 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868235 868235 0 0.0
bss 110900 110900 0 0.0
rodata 96884 96884 0 0.0
text 584996 584996 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861299 861299 0 0.0
bss 110780 110780 0 0.0
rodata 95020 95020 0 0.0
text 580056 580056 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779911 779911 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521916 521916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694938 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442520 442520 0 0.0
p6 all-clusters-app default (read/write) 2339520 2340160 640 0.0
.bss 107796 107828 32 0.0
.data 2456 2456 0 0.0
.heap 923088 923056 -32 -0.0
.text 1297784 1298424 640 0.0
light-app default (read/write) 2278872 2279512 640 0.0
.bss 98480 98512 32 0.0
.data 2336 2336 0 0.0
.heap 932528 932496 -32 -0.0
.text 1237136 1237776 640 0.1
lock-app default (read/write) 2254224 2254864 640 0.0
.bss 97136 97168 32 0.0
.data 2296 2296 0 0.0
.heap 933912 933880 -32 -0.0
.text 1212488 1213128 640 0.1
qpg lighting-app qpg6100+debug (read only) 510440 510440 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80240 80240 0 0.0
.data 964 964 0 0.0
.text 505120 505120 0 0.0
lock-app qpg6100+debug (read only) 483264 483264 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79152 79152 0 0.0
.data 916 916 0 0.0
.text 477944 477944 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794470 794470 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 554474 554474 0 0.0

@andy31415
Copy link
Contributor Author

Moved to fast track: PR up for quite some time, several checkmarks, significant test coverage.

@andy31415 andy31415 merged commit 1662309 into project-chip:master Dec 3, 2021
billwatersiii pushed a commit to billwatersiii/connectedhomeip that referenced this pull request Dec 3, 2021
@andy31415 @billwatersiii
Implement QName compression in minmdns (project-chip#12445)
0804560 
* Revamp constants: qname length constant is NOT used

* First pass on an indirection  to use a dedicated writer. No test updates yet nor functionality

* Updates to use the record writer, more tests pass now

* Compressed writer with unit tests

* Fix memory leak in UDP responders when a multicast join fails

* Add a harder unit test

* Make the complex reuse also validate that we can write things other than qnames

* Compression applied on all answers (no queries yet)

* Prepare to make query writing do compression as well, add more unit tests to qname writing

* Record compression for writing serialized qnames as well. Tested that query compression on replies is done

* Fix unit tests for resource records for writing QName compression

* Code review comments, fix android compile

* Fix test advertiser to consider the entire valid packet range when validating (for qname compression support)

* Only remember non-fully compressed  qnames

* Address some  code review comments

* Add a fit validation for response building

* update the code to have RecordWriter be more transparent/easier to use in put statements
@andy31415 andy31415 deleted the qname_compression branch June 14, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
fast track lib review - pending vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @woody-apple @bzbarsky-apple