-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the "Set up environment for size reports" step in "act". #12419
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-act-local-run
Dec 1, 2021
Merged
Skip the "Set up environment for size reports" step in "act". #12419
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-act-local-run
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This step doesn't work in the "act" environment (which makes the whole CI job fail), and it's not needed anyway since we don't upload size reports in that environment.
kpschoedel
approved these changes
Dec 1, 2021
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 1, 2021 17:37
woody-apple
approved these changes
Dec 1, 2021
Fast tracking given this is a tooling update. |
PR #12419: Size comparison from 31156c4 to 68b7d93 Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step doesn't work in the "act" environment (which makes the whole
CI job fail), and it's not needed anyway since we don't upload size
reports in that environment.
Problem
Using "act" to run various jobs fails because the size report preparation step fails.
Change overview
Skip this step when doing "act".
Testing
Managed to run the nrfconnect CI job locally with this change.