Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make all gn example builds export the compile commands #12416

Merged
merged 1 commit into from
Dec 1, 2021
Merged

make all gn example builds export the compile commands #12416

merged 1 commit into from
Dec 1, 2021

Conversation

andy31415
Copy link
Contributor

Problem

compile_commands.json is really helpful for IDEs/autocomplete.

Change overview

Make build_examples.py generate this file automatically, since there seems to be little downside (some extra storage and time, but likely minimal) and great benefit (ide autocomplete).

Testing

Unit tests validate this
Ran a build and found compile_commands.json exists in the output directory.

@boring-cyborg boring-cyborg bot added the scripts label Dec 1, 2021
@andy31415
Copy link
Contributor Author

fast track: trivial change that does not affect functionality

@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #12416: Size comparison from a7b18b8 to 27c9ca4

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a7b18b8 27c9ca4 change % change
efr32 lighting-app BRD4161A (read only) 763296 763296 0 0.0
(read/write) 119972 119972 0 0.0
.bss 118164 118164 0 0.0
.data 1808 1808 0 0.0
.text 763288 763288 0 0.0
BRD4161A+rpc (read only) 791784 791784 0 0.0
(read/write) 138276 138276 0 0.0
.bss 136364 136364 0 0.0
.data 1908 1908 0 0.0
.text 791776 791776 0 0.0
lock-app BRD4161A (read only) 737176 737176 0 0.0
(read/write) 117684 117684 0 0.0
.bss 115916 115916 0 0.0
.data 1764 1764 0 0.0
.text 737168 737168 0 0.0
window-app BRD4161A (read only) 740264 740264 0 0.0
(read/write) 118116 118116 0 0.0
.bss 116340 116340 0 0.0
.data 1772 1772 0 0.0
.text 740256 740256 0 0.0
esp32 all-clusters-app c3devkit (read only) 837356 837356 0 0.0
(read/write) 1224050 1224050 0 0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166248 166248 0 0.0
.flash.text 837356 837356 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908839 908839 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194100 194100 0 0.0
.flash.text 903455 903455 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724524 724524 0 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638112 638112 0 0.0
lock-app k32w061+debug (read/write) 613524 613524 0 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536708 536708 0 0.0
shell k32w061+debug (read/write) 679304 679304 0 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590932 590932 0 0.0
linux all-clusters-app debug (read only) 1781513 1781513 0 0.0
(read/write) 125192 125192 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65728 65728 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139797 139797 0 0.0
.text 1502098 1502098 0 0.0
bridge-app debug+rpc (read only) 1352565 1352565 0 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113820 113820 0 0.0
.text 1138533 1138533 0 0.0
chip-tool debug (read only) 6272725 6272725 0 0.0
(read/write) 197904 197904 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157880 157880 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 295624 295624 0 0.0
.text 5574133 5574133 0 0.0
lighting-app debug+rpc (read only) 1632633 1632633 0 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 57072 57072 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132273 132273 0 0.0
.text 1362450 1362450 0 0.0
ota-provider-app debug (read only) 1313009 1313009 0 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115024 115024 0 0.0
.text 1097538 1097538 0 0.0
ota-requestor-app debug (read only) 1412993 1412993 0 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 126848 126848 0 0.0
.text 1182258 1182258 0 0.0
shell debug (read only) 808969 808969 0 0.0
(read/write) 60104 60104 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38528 38528 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79794 79794 0 0.0
.text 623474 623474 0 0.0
tv-app debug (read only) 1927281 1927281 0 0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161448 161448 0 0.0
.text 1617298 1617298 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296632 2296632 0 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259232 1259232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281312 2281312 0 0.0
.bss 172636 172636 0 0.0
.data 5480 5480 0 0.0
.heap 858328 858328 0 0.0
.text 1243912 1243912 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254344 2254344 0 0.0
.bss 171452 171452 0 0.0
.data 5464 5464 0 0.0
.heap 859528 859528 0 0.0
.text 1216944 1216944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2045928 2045928 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008528 1008528 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876807 876807 0 0.0
bss 113136 113136 0 0.0
rodata 97368 97368 0 0.0
text 590764 590764 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 839255 839255 0 0.0
bss 109488 109488 0 0.0
rodata 88632 88632 0 0.0
text 564932 564932 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801842 0 0.0
bss 114512 114512 0 0.0
rodata 92628 92628 0 0.0
text 520220 520220 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847635 847635 0 0.0
bss 110176 110176 0 0.0
rodata 93108 93108 0 0.0
text 569012 569012 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772906 0 0.0
bss 111584 111584 0 0.0
rodata 88396 88396 0 0.0
text 498560 498560 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853679 853679 0 0.0
bss 110312 110312 0 0.0
rodata 94840 94840 0 0.0
text 573080 573080 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846743 846743 0 0.0
bss 110188 110188 0 0.0
rodata 92976 92976 0 0.0
text 568140 568140 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779227 779227 0 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521888 521888 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694274 694274 0 0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442496 442496 0 0.0
p6 all-clusters-app default (read/write) 2318024 2318024 0 0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276288 1276288 0 0.0
lock-app default (read/write) 2229112 2229112 0 0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187376 1187376 0 0.0
qpg lighting-app qpg6100+debug (read only) 496884 496884 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491564 491564 0 0.0
lock-app qpg6100+debug (read only) 469480 469480 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464160 464160 0 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778686 0 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541466 541466 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, as this is updating our tools

@andy31415 andy31415 merged commit 35cff83 into project-chip:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @woody-apple @jmartinez-silabs