-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Fix BRD4170A builds #12411
Merged
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_brd4170a
Dec 1, 2021
Merged
[EFR32] Fix BRD4170A builds #12411
jmartinez-silabs
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix_brd4170a
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
December 1, 2021 15:01
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
December 1, 2021 15:01
fast tracked. It only affect our EFR32 platform |
jepenven-silabs
approved these changes
Dec 1, 2021
PR #12411: Size comparison from 18f959b to 894c82d Decreases (4 builds for efr32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 1, 2021
yufengwangca
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EFR32 examples would not build for BRD4170A.
Change overview
Bump ot-efr32 submodule
Disable RADIO_CONFIG_915MHZ_OQPSK_SUPPORT for brd4170A also. Code now validates that only one band is used at a time. We currently run all on 2.4ghz on all supported boards
Testing
No behaviour change, Validated that BRD4170a builds and can join the thread network.