[docker] Enable all docker images in build CI #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tecimovic
|
The build docker task is failing given the ubuntu sysroot file is not present. |
electrocucaracha
force-pushed
the
enable_imgs
branch
from
e13ea8c to
832aa6d
Compare
msandstedt
reviewed
Dec 1, 2021
electrocucaracha
force-pushed
the
enable_imgs
branch
from
832aa6d to
3b253ed
Compare
msandstedt
approved these changes
Dec 1, 2021
|
PR #12367: Size comparison from 7b7374a to 3b253ed Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
electrocucaracha
force-pushed
the
enable_imgs
branch
from
3b253ed to
8d02937
Compare
|
PR #12367: Size comparison from 6f3b5a0 to 8d02937 Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
electrocucaracha
force-pushed
the
enable_imgs
branch
from
8d02937 to
ab35380
Compare
|
PR #12367: Size comparison from a5513c2 to ab35380 Full report (33 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
|
|
/rebase |
|
PR #12367: Size comparison from 7cba51d to 25810dc Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Dec 6, 2021
|
How does this patch decrease the size of the crosscompile image? |
I see this updated from chip-build image to base alipine. Could you add this to the description? Was it validated that cross compile can still be performed? |
|
/rebase |
@andy31415 just to be sure, do you mean PR description or the description into the |
|
PR #12367: Size comparison from 5c70530 to 959009d Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR description since this seems a significant change. I don't think people actually read |
Signed-off-by: Victor Morales <[email protected]>
Signed-off-by: Victor Morales <[email protected]>
Signed-off-by: Victor Morales <[email protected]>
Signed-off-by: Victor Morales <[email protected]>
electrocucaracha
force-pushed
the
enable_imgs
branch
from
959009d to
1aee8de
Compare
Remove experimental solution to create the sysroot file in cross-compile imageThis comment was generated by todo based on a
|
|
PR #12367: Size comparison from 051685b to 1aee8de Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
This change includes all the existing Dockerfiles into the Docker build CI workflow as well as the right Docker tag in the Vulnerability Scanner.
It also reduces the size of the crosscompile docker image from 5.22GB to 1.79GB (given that now it uses the alpine as base image instead of chip-base image) as well as includes the instructions to generate Sysroot tarball file.
Testing
This was tested locally