-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] [ESP32] Add discriminator, rendezvousInformation and setupPINC… #1234
Merged
BroderickCarlin
merged 1 commit into
project-chip:master
from
vivien-apple:Demo_RendezVous_QRCodeInformations
Jun 24, 2020
Merged
[Demo] [ESP32] Add discriminator, rendezvousInformation and setupPINC… #1234
BroderickCarlin
merged 1 commit into
project-chip:master
from
vivien-apple:Demo_RendezVous_QRCodeInformations
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
June 24, 2020 10:21
kedars
approved these changes
Jun 24, 2020
andy31415
approved these changes
Jun 24, 2020
gerickson
suggested changes
Jun 24, 2020
vivien-apple
force-pushed
the
Demo_RendezVous_QRCodeInformations
branch
from
June 24, 2020 15:51
cde6b61
to
19e0ba7
Compare
gerickson
approved these changes
Jun 24, 2020
jelderton
approved these changes
Jun 24, 2020
saurabhst
approved these changes
Jun 24, 2020
@vivien-apple can we fix this merge conflict? |
…ode to the QRCode payload
vivien-apple
force-pushed
the
Demo_RendezVous_QRCodeInformations
branch
from
June 24, 2020 18:34
19e0ba7
to
5419a9d
Compare
Pushed an update to resolve the merge conflict. |
Size increase report for "Build Examples [nRF]"
Full report output
|
Size increase report for "Build Examples [ESP32]"
Full report output
|
Size increase report for "Build Examples [main-build]"
Full report output
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs Squashed commit of the following: commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91 Author: Shadi Makdissi <[email protected]> Date: Tue Oct 10 11:05:46 2023 -0400 remove 917ncp sqa run
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jan 29, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs Squashed commit of the following: commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91 Author: Shadi Makdissi <[email protected]> Date: Tue Oct 10 11:05:46 2023 -0400 remove 917ncp sqa run
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs Squashed commit of the following: commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91 Author: Shadi Makdissi <[email protected]> Date: Tue Oct 10 11:05:46 2023 -0400 remove 917ncp sqa run
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs Squashed commit of the following: commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91 Author: Shadi Makdissi <[email protected]> Date: Tue Oct 10 11:05:46 2023 -0400 remove 917ncp sqa run
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs Squashed commit of the following: commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91 Author: Shadi Makdissi <[email protected]> Date: Tue Oct 10 11:05:46 2023 -0400 remove 917ncp sqa run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode to the QRCode payload
Problem
The ESP32 demo should generate a random discriminator and encode it into the QRCode displayed on the screen of the M5Stack.
It will helps to discriminate if multiple devices are up at the same time.
Summary of Changes
fixes #1233