Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] [ESP32] Add discriminator, rendezvousInformation and setupPINC… #1234

Conversation

vivien-apple
Copy link
Contributor

…ode to the QRCode payload

Problem

The ESP32 demo should generate a random discriminator and encode it into the QRCode displayed on the screen of the M5Stack.
It will helps to discriminate if multiple devices are up at the same time.

Summary of Changes

  • Add discriminator, rendezvousInformation and setupPINCode to the QRCode

fixes #1233

@vivien-apple vivien-apple force-pushed the Demo_RendezVous_QRCodeInformations branch from cde6b61 to 19e0ba7 Compare June 24, 2020 15:51
@vivien-apple vivien-apple requested a review from gerickson June 24, 2020 15:52
@woody-apple
Copy link
Contributor

@vivien-apple can we fix this merge conflict?

@vivien-apple vivien-apple force-pushed the Demo_RendezVous_QRCodeInformations branch from 19e0ba7 to 5419a9d Compare June 24, 2020 18:34
@vivien-apple
Copy link
Contributor Author

Pushed an update to resolve the merge conflict.

@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .dram0.bss 0 -8
chip-wifi-echo.elf .flash.rodata -8 -8
Full report output
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,8
.dram0.bss,-8,0
.flash.rodata,-8,-8


@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize


@BroderickCarlin BroderickCarlin merged commit f01110e into project-chip:master Jun 24, 2020
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs

Squashed commit of the following:

commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91
Author: Shadi Makdissi <[email protected]>
Date:   Tue Oct 10 11:05:46 2023 -0400

    remove 917ncp sqa run
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs

Squashed commit of the following:

commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91
Author: Shadi Makdissi <[email protected]>
Date:   Tue Oct 10 11:05:46 2023 -0400

    remove 917ncp sqa run
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs

Squashed commit of the following:

commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91
Author: Shadi Makdissi <[email protected]>
Date:   Tue Oct 10 11:05:46 2023 -0400

    remove 917ncp sqa run
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs

Squashed commit of the following:

commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91
Author: Shadi Makdissi <[email protected]>
Date:   Tue Oct 10 11:05:46 2023 -0400

    remove 917ncp sqa run
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
Merge in WMN_TOOLS/matter from remove/917ncp_sqa to silabs

Squashed commit of the following:

commit 8b01e53bfb6c7e5f254ce51c0c56332fdc797f91
Author: Shadi Makdissi <[email protected]>
Date:   Tue Oct 10 11:05:46 2023 -0400

    remove 917ncp sqa run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo] ESP32 should generate a discriminator, and encode it into QR code
9 participants