Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless OpcredsIssuer dependency #12338

Merged
merged 7 commits into from
Dec 3, 2021
Merged

Remove needless OpcredsIssuer dependency #12338

merged 7 commits into from
Dec 3, 2021

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • Dependency on ExampleOperationalCredentialsIssuer was in
    many files where not needed, making other refactors more
    difficult.

Change overview

Remove this dependency and make CHIPCommand own its ephemeral
operational credentials issuer.

Testing

  • Unit tests and integration tests still pass

tcarmelveilleux and others added 2 commits November 29, 2021 17:04
@tcarmelveilleux
Remove needless OpcredsIssuer dependency
cf81575 
- Dependency on ExampleOperationalCredentialsIssuer was in
  many files where not needed, making other refactors more
  difficult.

Remove this dependency and make CHIPCommand own its ephemeral
operational credentials issuer.
@restyled-commits
Restyled by clang-format
9d5506d
@restyled-io restyled-io bot mentioned this pull request Nov 29, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #12338: Size comparison from 489de97 to 9d5506d

Decreases (1 build for linux)
platform target config section 489de97 9d5506d change % change
linux chip-tool debug (read only) 6095509 6095477 -32 -0.0
.text 5412981 5412949 -32 -0.0
Full report (36 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 489de97 9d5506d change % change
efr32 lighting-app BRD4161A (read only) 762200 762200 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762192 762192 0 0.0
BRD4161A+rpc (read only) 790648 790648 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790640 790640 0 0.0
lock-app BRD4161A (read only) 736144 736144 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736136 736136 0 0.0
window-app BRD4161A (read only) 739208 739208 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739200 739200 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723316 723316 0 0.0
.bss 78292 78292 0 0.0
.data 1844 1844 0 0.0
.text 637380 637380 0 0.0
lock-app k32w061+debug (read/write) 612388 612388 0 0.0
.bss 68740 68740 0 0.0
.data 1808 1808 0 0.0
.text 536040 536040 0 0.0
shell k32w061+debug (read/write) 677712 677712 0 0.0
.bss 79892 79892 0 0.0
.data 1780 1780 0 0.0
.text 590240 590240 0 0.0
linux all-clusters-app debug (read only) 1775225 1775225 0 0.0
(read/write) 131416 131416 0 0.0
.bss 60144 60144 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139093 139093 0 0.0
.text 1497762 1497762 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6095509 6095477 -32 -0.0
(read/write) 198744 198744 0 0.0
.bss 40096 40096 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152048 152048 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 293096 293096 0 0.0
.text 5412981 5412949 -32 -0.0
lighting-app debug+rpc (read only) 1629209 1629209 0 0.0
(read/write) 110976 110976 0 0.0
.bss 47440 47440 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132017 132017 0 0.0
.text 1359474 1359474 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406889 1406889 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177346 1177346 0 0.0
shell debug (read only) 820449 820449 0 0.0
(read/write) 66808 66808 0 0.0
.bss 23496 23496 0 0.0
.data 224 224 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79154 79154 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921361 1921361 0 0.0
(read/write) 318944 318944 0 0.0
.bss 250264 250264 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161032 161032 0 0.0
.text 1611986 1611986 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295088 2295088 0 0.0
.bss 181884 181884 0 0.0
.data 5128 5128 0 0.0
.heap 849432 849432 0 0.0
.text 1257688 1257688 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280368 2280368 0 0.0
.bss 172492 172492 0 0.0
.data 5488 5488 0 0.0
.heap 858464 858464 0 0.0
.text 1242968 1242968 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253448 2253448 0 0.0
.bss 171308 171308 0 0.0
.data 5472 5472 0 0.0
.heap 859664 859664 0 0.0
.text 1216048 1216048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051040 2051040 0 0.0
.bss 156496 156496 0 0.0
.data 4872 4872 0 0.0
.heap 875080 875080 0 0.0
.text 1013640 1013640 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875615 875615 0 0.0
bss 112660 112660 0 0.0
rodata 97296 97296 0 0.0
text 590116 590116 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838191 838191 0 0.0
bss 109012 109012 0 0.0
rodata 88544 88544 0 0.0
text 564432 564432 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800650 800650 0 0.0
bss 114036 114036 0 0.0
rodata 92556 92556 0 0.0
text 519580 519580 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846539 846539 0 0.0
bss 109700 109700 0 0.0
rodata 93084 93084 0 0.0
text 568388 568388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771810 771810 0 0.0
bss 111108 111108 0 0.0
rodata 88372 88372 0 0.0
text 497940 497940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852511 852511 0 0.0
bss 109836 109836 0 0.0
rodata 94792 94792 0 0.0
text 572432 572432 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845615 845615 0 0.0
bss 109712 109712 0 0.0
rodata 92952 92952 0 0.0
text 567512 567512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778451 778451 0 0.0
bss 109180 109180 0 0.0
rodata 73192 73192 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67836 67836 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311416 2311416 0 0.0
.bss 114688 114688 0 0.0
.data 2432 2432 0 0.0
.heap 916224 916224 0 0.0
.text 1269680 1269680 0 0.0
lock-app default (read/write) 2223232 2223232 0 0.0
.bss 100976 100976 0 0.0
.data 2304 2304 0 0.0
.heap 930064 930064 0 0.0
.text 1181496 1181496 0 0.0
qpg lighting-app qpg6100+debug (read only) 493652 493652 0 0.0
(read/write) 114144 114144 0 0.0
.bss 77464 77464 0 0.0
.data 920 920 0 0.0
.text 488332 488332 0 0.0
lock-app qpg6100+debug (read only) 466328 466328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 76376 76376 0 0.0
.data 872 872 0 0.0
.text 461008 461008 0 0.0
persistent-storage-app qpg6100+debug (read only) 105612 105612 0 0.0
(read/write) 114138 114138 0 0.0
.bss 35218 35218 0 0.0
.data 276 276 0 0.0
.text 100292 100292 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777398 777398 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540724 540724 0 0.0

@pullapprove pullapprove bot requested a review from vijs November 30, 2021 15:44
@restyled-io restyled-io bot mentioned this pull request Nov 30, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #12338: Size comparison from 46fbb06 to bdf30ee

Increases above 0.2%:

platform target config section 46fbb06 bdf30ee change % change
esp32 all-clusters-app c3devkit .dram0.data 13988 14028 40 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5128 5168 40 0.8
p6 all-clusters-app default .data 2424 2456 32 1.3
.heap 915664 921176 5512 0.6
lock-app default .heap 929504 934656 5152 0.6
Increases (27 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 46fbb06 bdf30ee change % change
efr32 lighting-app BRD4161A (read only) 763016 763096 80 0.0
.text 763008 763088 80 0.0
BRD4161A+rpc (read only) 791512 791608 96 0.0
.text 791504 791600 96 0.0
lock-app BRD4161A (read only) 736896 736976 80 0.0
.text 736888 736968 80 0.0
window-app BRD4161A (read only) 739984 740080 96 0.0
.text 739976 740072 96 0.0
esp32 all-clusters-app c3devkit (read only) 836580 837376 796 0.1
.dram0.data 13988 14028 40 0.3
.flash.rodata 166400 166616 216 0.1
.flash.text 836580 837376 796 0.1
.iram0.text 61390 61394 4 0.0
m5stack (read only) 908587 908883 296 0.0
.dram0.data 33960 34000 40 0.1
.flash.rodata 194244 194452 208 0.1
.flash.text 903203 903499 296 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724356 724508 152 0.0
.bss 78756 78772 16 0.0
.text 637956 638096 140 0.0
lock-app k32w061+debug (read/write) 613348 613492 144 0.0
.bss 69204 69212 8 0.0
.text 536536 536676 140 0.0
shell k32w061+debug (read/write) 679128 679288 160 0.0
.bss 80780 80796 16 0.0
.text 590768 590916 148 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2296160 2296640 480 0.0
.data 5128 5168 40 0.8
.heap 848968 849640 672 0.1
.text 1258760 1259240 480 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2281096 2281312 216 0.0
.heap 858000 858328 328 0.0
.text 1243696 1243912 216 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2254192 2254344 152 0.0
.heap 859200 859528 328 0.0
.text 1216792 1216944 152 0.0
shell CY8CPROTO_062_4343W+release .heap 874656 874992 336 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876791 152 0.0
bss 113124 113136 12 0.0
rodata 97344 97368 24 0.0
text 590620 590740 120 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839239 152 0.0
bss 109476 109488 12 0.0
rodata 88608 88632 24 0.0
text 564788 564908 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801810 136 0.0
bss 114500 114512 12 0.0
rodata 92604 92628 24 0.0
text 520076 520196 120 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847603 136 0.0
bss 110164 110176 12 0.0
rodata 93084 93108 24 0.0
text 568872 568988 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772874 136 0.0
bss 111572 111584 12 0.0
rodata 88372 88396 24 0.0
text 498420 498536 116 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853647 168 0.0
bss 110300 110312 12 0.0
rodata 94816 94840 24 0.0
text 572940 573052 112 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846711 152 0.0
bss 110176 110188 12 0.0
rodata 92952 92976 24 0.0
text 568000 568112 112 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779163 120 0.0
bss 109604 109616 12 0.0
rodata 73192 73216 24 0.0
text 521724 521832 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694210 152 0.0
bss 110588 110600 12 0.0
rodata 67836 67860 24 0.0
text 442332 442444 112 0.0
p6 all-clusters-app default (read/write) 2317928 2318376 448 0.0
.data 2424 2456 32 1.3
.heap 915664 921176 5512 0.6
.text 1276192 1276640 448 0.0
lock-app default (read/write) 2229400 2229528 128 0.0
.heap 929504 934656 5152 0.6
.text 1187664 1187792 128 0.0
qpg lighting-app qpg6100+debug (read only) 496712 496860 148 0.0
.bss 79640 79656 16 0.0
.text 491392 491540 148 0.0
lock-app qpg6100+debug (read only) 469316 469448 132 0.0
.bss 78552 78568 16 0.0
.text 463996 464128 132 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778614 160 0.0
bss 79700 79716 16 0.0
text 541270 541394 124 0.0
Decreases (18 builds for efr32, esp32, k32w, mbed, p6, qpg)
platform target config section 46fbb06 bdf30ee change % change
efr32 lighting-app BRD4161A (read/write) 120300 119956 -344 -0.3
.bss 118476 118140 -336 -0.3
.data 1820 1812 -8 -0.4
BRD4161A+rpc (read/write) 138596 138252 -344 -0.2
.bss 136676 136340 -336 -0.2
.data 1920 1912 -8 -0.4
lock-app BRD4161A (read/write) 118004 117660 -344 -0.3
.bss 116228 115892 -336 -0.3
.data 1776 1768 -8 -0.5
window-app BRD4161A (read/write) 118436 118092 -344 -0.3
.bss 116652 116316 -336 -0.3
.data 1784 1776 -8 -0.4
esp32 all-clusters-app c3devkit (read/write) 1225258 1224450 -808 -0.1
.dram0.bss 59608 58552 -1056 -1.8
m5stack (read/write) 424484 423684 -800 -0.2
.dram0.bss 65000 63952 -1048 -1.6
k32w lighting-app k32w061+se05x+release .data 1844 1840 -4 -0.2
lock-app k32w061+debug .data 1808 1804 -4 -0.2
shell k32w061+debug .data 1780 1776 -4 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 182348 181636 -712 -0.4
lighting-app CY8CPROTO_062_4343W+release .bss 172956 172636 -320 -0.2
.data 5488 5480 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .bss 171772 171452 -320 -0.2
.data 5472 5464 -8 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2051232 2046096 -5136 -0.3
.bss 156920 156592 -328 -0.2
.data 4872 4864 -8 -0.2
.text 1013832 1008696 -5136 -0.5
p6 all-clusters-app default .bss 115256 109712 -5544 -4.8
lock-app default .bss 101552 96408 -5144 -5.1
.data 2288 2280 -8 -0.3
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
.data 944 940 -4 -0.4
lock-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
.data 896 892 -4 -0.4
persistent-storage-app qpg6100+debug (read only) 108076 108020 -56 -0.1
(read/write) 114144 114140 -4 -0.0
.bss 36864 36688 -176 -0.5
.data 296 292 -4 -1.4
.text 102756 102700 -56 -0.1
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 46fbb06 bdf30ee change % change
efr32 lighting-app BRD4161A (read only) 763016 763096 80 0.0
(read/write) 120300 119956 -344 -0.3
.bss 118476 118140 -336 -0.3
.data 1820 1812 -8 -0.4
.text 763008 763088 80 0.0
BRD4161A+rpc (read only) 791512 791608 96 0.0
(read/write) 138596 138252 -344 -0.2
.bss 136676 136340 -336 -0.2
.data 1920 1912 -8 -0.4
.text 791504 791600 96 0.0
lock-app BRD4161A (read only) 736896 736976 80 0.0
(read/write) 118004 117660 -344 -0.3
.bss 116228 115892 -336 -0.3
.data 1776 1768 -8 -0.5
.text 736888 736968 80 0.0
window-app BRD4161A (read only) 739984 740080 96 0.0
(read/write) 118436 118092 -344 -0.3
.bss 116652 116316 -336 -0.3
.data 1784 1776 -8 -0.4
.text 739976 740072 96 0.0
esp32 all-clusters-app c3devkit (read only) 836580 837376 796 0.1
(read/write) 1225258 1224450 -808 -0.1
.dram0.bss 59608 58552 -1056 -1.8
.dram0.data 13988 14028 40 0.3
.flash.rodata 166400 166616 216 0.1
.flash.text 836580 837376 796 0.1
.iram0.text 61390 61394 4 0.0
m5stack (read only) 908587 908883 296 0.0
(read/write) 424484 423684 -800 -0.2
.dram0.bss 65000 63952 -1048 -1.6
.dram0.data 33960 34000 40 0.1
.flash.rodata 194244 194452 208 0.1
.flash.text 903203 903499 296 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724356 724508 152 0.0
.bss 78756 78772 16 0.0
.data 1844 1840 -4 -0.2
.text 637956 638096 140 0.0
lock-app k32w061+debug (read/write) 613348 613492 144 0.0
.bss 69204 69212 8 0.0
.data 1808 1804 -4 -0.2
.text 536536 536676 140 0.0
shell k32w061+debug (read/write) 679128 679288 160 0.0
.bss 80780 80796 16 0.0
.data 1780 1776 -4 -0.2
.text 590768 590916 148 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296160 2296640 480 0.0
.bss 182348 181636 -712 -0.4
.data 5128 5168 40 0.8
.heap 848968 849640 672 0.1
.text 1258760 1259240 480 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281096 2281312 216 0.0
.bss 172956 172636 -320 -0.2
.data 5488 5480 -8 -0.1
.heap 858000 858328 328 0.0
.text 1243696 1243912 216 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254192 2254344 152 0.0
.bss 171772 171452 -320 -0.2
.data 5472 5464 -8 -0.1
.heap 859200 859528 328 0.0
.text 1216792 1216944 152 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051232 2046096 -5136 -0.3
.bss 156920 156592 -328 -0.2
.data 4872 4864 -8 -0.2
.heap 874656 874992 336 0.0
.text 1013832 1008696 -5136 -0.5
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876791 152 0.0
bss 113124 113136 12 0.0
rodata 97344 97368 24 0.0
text 590620 590740 120 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839239 152 0.0
bss 109476 109488 12 0.0
rodata 88608 88632 24 0.0
text 564788 564908 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801810 136 0.0
bss 114500 114512 12 0.0
rodata 92604 92628 24 0.0
text 520076 520196 120 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847603 136 0.0
bss 110164 110176 12 0.0
rodata 93084 93108 24 0.0
text 568872 568988 116 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772874 136 0.0
bss 111572 111584 12 0.0
rodata 88372 88396 24 0.0
text 498420 498536 116 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853647 168 0.0
bss 110300 110312 12 0.0
rodata 94816 94840 24 0.0
text 572940 573052 112 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846711 152 0.0
bss 110176 110188 12 0.0
rodata 92952 92976 24 0.0
text 568000 568112 112 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779163 120 0.0
bss 109604 109616 12 0.0
rodata 73192 73216 24 0.0
text 521724 521832 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694210 152 0.0
bss 110588 110600 12 0.0
rodata 67836 67860 24 0.0
text 442332 442444 112 0.0
p6 all-clusters-app default (read/write) 2317928 2318376 448 0.0
.bss 115256 109712 -5544 -4.8
.data 2424 2456 32 1.3
.heap 915664 921176 5512 0.6
.text 1276192 1276640 448 0.0
lock-app default (read/write) 2229400 2229528 128 0.0
.bss 101552 96408 -5144 -5.1
.data 2288 2280 -8 -0.3
.heap 929504 934656 5152 0.6
.text 1187664 1187792 128 0.0
qpg lighting-app qpg6100+debug (read only) 496712 496860 148 0.0
(read/write) 114144 114140 -4 -0.0
.bss 79640 79656 16 0.0
.data 944 940 -4 -0.4
.text 491392 491540 148 0.0
lock-app qpg6100+debug (read only) 469316 469448 132 0.0
(read/write) 114144 114140 -4 -0.0
.bss 78552 78568 16 0.0
.data 896 892 -4 -0.4
.text 463996 464128 132 0.0
persistent-storage-app qpg6100+debug (read only) 108076 108020 -56 -0.1
(read/write) 114144 114140 -4 -0.0
.bss 36864 36688 -176 -0.5
.data 296 292 -4 -1.4
.text 102756 102700 -56 -0.1
telink lighting-app tlsr9518adk80d (read/write) 778454 778614 160 0.0
bss 79700 79716 16 0.0
noinit 37160 37160 0 0.0
text 541270 541394 124 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the member needs to move from private to protected.

@tcarmelveilleux
Copy link
Contributor Author

Not sure why the member needs to move from private to protected.

To match other similarly scoped items just as storage

@andy31415
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12338: Size comparison from 3a339bc to e21562d

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a339bc e21562d change % change
efr32 lighting-app BRD4161A (read only) 751784 751784 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751776 0 0.0
BRD4161A+rpc (read only) 780440 780440 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780432 0 0.0
lock-app BRD4161A (read only) 726592 726592 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726584 726584 0 0.0
window-app BRD4161A (read only) 729096 729096 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 729088 0 0.0
esp32 all-clusters-app c3devkit (read only) 847594 847594 0 0.0
(read/write) 1222714 1222714 0 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167848 167848 0 0.0
.flash.text 847594 847594 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918067 918067 0 0.0
(read/write) 421672 421672 0 0.0
.dram0.bss 60728 60728 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195648 195648 0 0.0
.flash.text 912683 912683 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1848137 1848137 0 0.0
(read/write) 123216 123216 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 66976 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 149589 0 0.0
.text 1555490 1555490 0 0.0
bridge-app debug+rpc (read only) 1431021 1431021 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205077 0 0.0
chip-tool debug (read only) 6593069 6593069 0 0.0
(read/write) 199400 199400 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158168 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 307512 0 0.0
.text 5881573 5881573 0 0.0
lighting-app debug+rpc (read only) 1716161 1716161 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431810 0 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029745 2029745 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700786 1700786 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306704 2306704 0 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269280 1269280 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232824 1232824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817626 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863655 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581544 581544 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511972 511972 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339080 2339080 0 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1297344 0 0.0
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2256048 2256048 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214312 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 484124 484124 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478804 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@andy31415 andy31415 merged commit 21757de into project-chip:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@emargolis emargolis emargolis approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@vijs vijs Awaiting requested review from vijs

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tcarmelveilleux @andy31415 @msandstedt @emargolis @bzbarsky-apple @jmeg-sfy @restyled-commits