-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using TLV::EstimateStructOverhead() to Estimate Encoded CD TLV Struct Size #12329
Merged
andy31415
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/estimate-tlv-struct-overhead
Nov 30, 2021
Merged
Using TLV::EstimateStructOverhead() to Estimate Encoded CD TLV Struct Size #12329
andy31415
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/estimate-tlv-struct-overhead
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
turon
November 29, 2021 19:26
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 29, 2021 19:26
PR #12329: Size comparison from 2bd6bd6 to acaf4f3 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 29, 2021
woody-apple
approved these changes
Nov 29, 2021
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
PR #12329: Size comparison from 2bd6bd6 to 575a7ee Increases above 0.2%:
Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (19 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: code has been up for a while, small delta, has several checkmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#11017
Change overview
Using TLV::EstimateStructOverhead() to Estimate Encoded CD TLV Struct Size
Testing
All current unit testing