Update ZAP to version that generates min/max information. #12325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XML updates are based on examining the all-clusters app codegen and removing spurious min-max constraints that just restate the value range of the type (e.g. setting max to 0xFFFF for an int16u). A few attributes were made nullable in the process to remove an unnecessary constraint like max="0xFFFE" when the spec says range is all but the attribute is nullable.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tecimovic
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #12325: Size comparison from 2bd6bd6 to 16db7cd Increases above 0.2%:
Increases (20 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (19 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
@bzbarsky-apple The |
Yep, I am working on fixing that right now. ;) |
bzbarsky-apple
force-pushed
the
pull-min-max-bits
branch
from
6eccb06 to
29b79a2
Compare
andy31415
approved these changes
Nov 29, 2021
bzbarsky-apple
force-pushed
the
pull-min-max-bits
branch
from
29b79a2 to
c3ab4d9
Compare
|
PR #12325: Size comparison from ef9c86c to c3ab4d9 Increases above 0.2%:
Increases (12 builds for efr32, k32w, linux, p6, qpg, telink)
Decreases (3 builds for k32w, linux, qpg)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
…texpr. This should ensure that it does not accidentally end up in .data instead of .rodata. The main fix here is adding the constexpr constructor for EmberAfDefaultOrMinMaxAttributeValue that takes a EmberAfAttributeMinMaxValue*, which lets us remove the non-constexpr reinterpret_cast (coming from the C-style cast) to uint8_t* in ZAP_MIN_MAX_DEFAULTS_INDEX. The other fixes are just fixing long-standing const-correctness issues; this allows us to remove the implicit const_cast from ZAP_LONG_DEFAULTS_INDEX.
bzbarsky-apple
force-pushed
the
pull-min-max-bits
branch
from
c3ab4d9 to
45566eb
Compare
|
PR #12325: Size comparison from 489de97 to 45566eb Increases above 0.2%:
Increases (20 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for k32w, linux, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
@saurabhst @msandstedt @Damian-Nordic @LuDuda @vivien-apple @woody-apple @jmartinez-silabs @jepenven-silabs could you please take a look? |
woody-apple
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML updates are based on examining the all-clusters app codegen
and removing spurious min-max constraints that just restate the value
range of the type (e.g. setting max to 0xFFFF for an int16u). A few
attributes were made nullable in the process to remove an unnecessary
constraint like max="0xFFFE" when the spec says range is all but the
attribute is nullable.
Problem
min/max in XML are ignored in our codegen.
Change overview
Output min/max information in the generated endpoint_config.
Testing
Code inspection. yaml tests are forthcoming, in followup PRs.