SetUpCodePairer: don't use DeviceDiscoveryDelegate #12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
vivien-apple
pullapprove
bot
requested review from
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #12320: Size comparison from 7d55d2e to 0304275 Full report (14 builds for efr32, esp32, k32w, p6, qpg)
|
vivien-apple
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
fwiw I'm trying to get the dns-sd dispatch mechanism to support multiple delegates in #12261
woody-apple
approved these changes
Nov 30, 2021
andy31415
approved these changes
Dec 3, 2021
|
/rebase |
This class replaces the device discovery delegate that gets passed in in the commissioning parameters which will cause the original delegate to stop receiving callbacks if this class is used. Instead, just have the commissioner notify this class directly. The commissioner owns this part, so it doesn't need to use a derived delegate because we know what we're talking to. Also adding a discovery filter. This wasn't as necessary before because the class would stop receiving notifications by setting the delegate to null. However, that is still a race because it is possible to get spurious mdns responses.
woody-apple
force-pushed
the
setupcodepairer
branch
from
f111af7 to
c5571a0
Compare
|
PR #12320: Size comparison from fc07dcf to c5571a0 Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SetUpCodePairer replaces the delegate that was set up during commissioner initialization and doesn't put it back. There is also a chance of a race from spurious dns-sd responses.
Change overview
This class replaces the device discovery delegate that gets passed
in in the commissioning parameters which will cause the original
delegate to stop receiving callbacks if this class is used.
Instead, just have the commissioner notify this class directly.
The commissioner owns this part, so it doesn't need to use a derived
delegate because we know what we're talking to.
Also adding a discovery filter. This wasn't as necessary before
because the class would stop receiving notifications by setting the
delegate to null. However, that is still a race because it is
possible to get spurious mdns responses.
Testing
With #12319, tested manual and qr code pairing.