-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ACL attribute read/write #12305
Merged
mlepage-google
merged 46 commits into
project-chip:master
from
mlepage-google:access-control-server-implementation
Dec 7, 2021
Merged
Changes from 40 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
d5eb767
Add access control server skeleton
mlepage-google 2748396
Regen code.
mlepage-google dd3d079
Restyle code
mlepage-google 2e5b927
Update from upstream changes
mlepage-google e4af168
Merge branch 'master' into access-control-server-skeleton
mlepage-google dcc1381
Restyle
mlepage-google c593e2a
Merge branch 'master' into access-control-server-skeleton
mlepage-google d3df60c
Add access-control-server to CMakeLists.txt
mlepage-google bf1709f
Remove nullable from list attribute
mlepage-google b8bc6ec
Merge branch 'master' into access-control-server-skeleton
mlepage-google 2fb788a
Merge branch 'master' into access-control-server-skeleton
mlepage-google 89a5974
Regen and restyle
mlepage-google 71b5fa7
Merge branch 'master' into access-control-server-skeleton
mlepage-google c68c025
Regen and restyle
mlepage-google 21466e7
Merge branch 'master' into access-control-server-skeleton
mlepage-google 80dc54b
Fix test
mlepage-google 53baaf3
Regen and restyle
mlepage-google 63a0ce0
Regen and restyle
mlepage-google 08c41e9
Merge branch 'master' into access-control-server-skeleton
mlepage-google 466a548
Merge branch 'master' into access-control-server-skeleton
mlepage-google 6a5b6f8
Regen and restyle
mlepage-google a2208c6
Merge branch 'master' into access-control-server-skeleton
mlepage-google 1655019
Regen and restyle
mlepage-google c710106
Merge branch 'master' into access-control-server-skeleton
mlepage-google 49cbd62
Regen and restyle
mlepage-google 5ac7f6a
Regen and restyle
mlepage-google ea2d4df
Add AccessControl cluster to Darwin test helper
mlepage-google c8a905a
Remove AccessControl cluster from some tests
mlepage-google 6eec4e3
Fix unless in test file
mlepage-google 4334838
Merge branch 'master' into access-control-server-skeleton
mlepage-google fb1e25f
Restyle and regen
mlepage-google e9a2499
Implement ACL attribute
mlepage-google 04d074d
Merge branch 'master' into access-control-server-skeleton
mlepage-google ccad3d2
Regen and restyle
mlepage-google cd3a461
Merge branch 'access-control-server-skeleton' into access-control-ser…
mlepage-google ff1b272
Merge branch 'master' into access-control-server-implementation
mlepage-google 406a6f9
Regen and restyle
mlepage-google 9fa4b97
Change extension attribute storage to RAM
mlepage-google 8435fdd
Re-enable access control cluster tests
mlepage-google 884341b
Fix extension attribute
mlepage-google 31853e4
Merge branch 'master' into access-control-server-implementation
mlepage-google 53926dd
Restyle and regen
mlepage-google 12b0651
Change lambda arg to auto in access control server
mlepage-google e19c1ad
Add missing variable definitions
mlepage-google 0a62238
Merge branch 'master' into access-control-server-implementation
mlepage-google b7e997e
Regen and restyle
mlepage-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? This is going to take up space in the attr store that is completely unused...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the easiest way to get the tests running for now, because the attribute exists. Otherwise I have to go through and ensure all the "not yet implemented" parts have "some kind of implementation" sufficient to keep the tests happy. I made the length 4 just in case any test tried to write more than one, but I could change the length to 1 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see PR #12690